From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (unknown [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 579D5460A4; Thu, 16 Jan 2025 18:46:15 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 90F3A40DD3; Thu, 16 Jan 2025 18:45:58 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.20]) by mails.dpdk.org (Postfix) with ESMTP id C6D29402D6 for ; Thu, 16 Jan 2025 18:45:56 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1737049557; x=1768585557; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=WNCI2bRbGPoPLdN4Zknns9TemX4Rcid4MZXyKbiJJOs=; b=ZasMJxNG/Ljv1J3nWhG9x9L3Ci3zDjRaaQVz/xreMbUQmCZTEM2HVCDD MCTYLDI27WX7NruAQY096PKgq2Qyp+xg1y2lknzSBEglyQmlpkSESusFF 06tFGj6pJp4b0eT2aXBjHayYFA8TPjsZk+14CsyTWMPE82pb1Ur37QOoh H5ayqqKVjhM6Ga+0ffckPe/APCG1QDwEerIzqbBaU2fhWU6mxFz5qPefx HIKOeqrs7vZV6WmKtRtlAHaDvAKdS2h+dxF8LDDb5SJ9rCs7QHaIUww79 moBPak5wojcm2F4l5rQRue5e99vME0Zc1FIZ2zDakEixYVasIpgcvlBS6 w==; X-CSE-ConnectionGUID: oUaLkuhSTBy0meg72EkCVg== X-CSE-MsgGUID: NnfnWeBwSJSvtT2wy6WB8w== X-IronPort-AV: E=McAfee;i="6700,10204,11317"; a="37147422" X-IronPort-AV: E=Sophos;i="6.13,210,1732608000"; d="scan'208";a="37147422" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by orvoesa112.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Jan 2025 09:45:56 -0800 X-CSE-ConnectionGUID: ksmF3TDKRziBy//KelJ8yQ== X-CSE-MsgGUID: OPZ1gzpQRpuT799V5Z97Kg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,224,1728975600"; d="scan'208";a="136440340" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmviesa001.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 16 Jan 2025 09:45:56 -0800 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.44; Thu, 16 Jan 2025 09:45:54 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.44 via Frontend Transport; Thu, 16 Jan 2025 09:45:54 -0800 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.171) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.44; Thu, 16 Jan 2025 09:45:54 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=CQRtiAMbUbrJfcEaW61qfRWOlNta6ampRzYGBr7FxkQVo8n199pDdQVhfAN3aRyClgLqOmY3Av5yO95Ib/tvFoHzmTn99Nltw4592stzdshFbMMhn+hFBW0L7Lj2C0vlOdTHNcZgxfO/s3/b4GxZZcp/U5xX8O22UCiQwh+6xtFEJni7vgxmtgT81jUWAIoF+t7QTjjF10K7jd6cQv676E51ZhYkVx43A3TJBvBScR/MK4sHMRIze15ofmvPsc9qQagyd7SadaCBB4wxh5ed0VGFEmD/YsUC0whssAbndjEHLqt3pAxHlnTH/xPHd2W+rfpgdzVzQG2TsQZvBx0Cjw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IcdVS8JJ2EoBt3/YhX0vt2kfjRbiJFPdC//ncjq325o=; b=lAvqgaJAuUUI65lO2mdTLujqmJdY1Akts0+YqeJnvdweYAYpTy+iK/9+Mx3aGCbCpPPW3744gy8SK0ZWg4ZI5vmwY3UZEWjLFaWqPyjpcnuqqBt8vb4OeXTt3TOSh4Z9W3v2TvK8heBuNWHTXnEgB/x+bkzfk8fXnhiavbmfI8AhrQ33iwcNfscIi49BGBUJyaLD3qP7cd6GtkgRu64+98PEZ9jracPgiKvDy5N7mcVVh7TrtPvBA5mFEThY2IwoXzD7YeH9YvH5ebMglgspnvVMUSiOKcchFMAxLRDR62vJiaqV4Cx3b3Z98evXA6O4lXYgn9igpi1dKK8A3oy+Wg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by LV3PR11MB8553.namprd11.prod.outlook.com (2603:10b6:408:1b8::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8356.13; Thu, 16 Jan 2025 17:45:52 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%5]) with mapi id 15.20.8356.014; Thu, 16 Jan 2025 17:45:52 +0000 Date: Thu, 16 Jan 2025 17:45:47 +0000 From: Bruce Richardson To: Jerin Jacob CC: Subject: Re: [PATCH v4 00/24] Reduce code duplication across Intel NIC drivers Message-ID: References: <20241122125418.2857301-1-bruce.richardson@intel.com> <20241220143925.609044-1-bruce.richardson@intel.com> Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: DU7P191CA0020.EURP191.PROD.OUTLOOK.COM (2603:10a6:10:54e::30) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|LV3PR11MB8553:EE_ X-MS-Office365-Filtering-Correlation-Id: 9a11439b-81c3-48cf-1c1a-08dd36559f21 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|366016; X-Microsoft-Antispam-Message-Info: =?utf-8?B?Y3dKNW9FcVZEcjZBZFFkZ0lqVzdNUWl3b0Rlb0NWd2xqLzB4LzJrbEl0SCtG?= =?utf-8?B?cmp4cFFJMmttL2IxVUxPUmRmK1E3em51bkwrYjZNbWM1UTR4UlptOHZRTmdv?= =?utf-8?B?V2ltZlB4b3kvQ21wVUxMZjArajJvczJxdXhZWmppSGR2Rmh6dnpCSlphZnN0?= =?utf-8?B?RUlqQTU0Q3BiYVM0ZXAwdVR1K2FiRVJab3Bmd1V2bkpwMnQvZVVQMjNsMEo3?= =?utf-8?B?VFR1T2t4QjQyUjZvL002c2E3TkV1d2k5akE0NVAwWm4wNUpQK211VGpmdTZv?= =?utf-8?B?Q29Xd0ErV1hUc2VUWjRzdzFnRVluVHBaTkpGaXZZMzNYcjhIZTZzdzFDR2E4?= =?utf-8?B?WVhXTEFaMk02Y0JCRWZteE1KUG9lenhLS3YwbHZkdFlFeW5pSVBBU1hIMUlh?= =?utf-8?B?MkZYTFl2NUR4WExFQzJ0TFI5KzZ0K3N4RGF0b21JUUhGSWFuNGl4cUlDL3Vw?= =?utf-8?B?cVdRdHJmaU1lZ2RzRFJaY3RtUkFtRzZ4a2hvUXoyRWhBaVFYam1OclRDU2Vm?= =?utf-8?B?LzkvaW5EWFJvRGhlOE1ncTBDZE9ObUtNVXBMbGpCTzcxWHdRNTNndTFUUWVX?= =?utf-8?B?Zm5BMDJXbGswMDd5cXIyNGZMS2k4UDlHdjI5NU1aNWxxcWh0eERpLzU1U0pO?= =?utf-8?B?OWt3b1MxNDhyakxjOEtVWXBERkNpcFNoYVJIZ210Z2ZaaHRTQngvUnZpdzVR?= =?utf-8?B?Q3plb0thektVTTU4WUMwb3R0VjlMdEJTbmNMeUgxVEoyUXN0SEJaMkFJQmJI?= =?utf-8?B?MDZmeUtuSHJ2dXZIdHdtR0MwbnNKTUtpVjBYdFU4WjVrUENLUHZtUzJ0S1NC?= =?utf-8?B?ekMzYy90WWplM0RzczZ1Wm9MenRGeXFXQUVReGp5M055ZHNQdVdZWFBWMmV2?= =?utf-8?B?NVJNK1VuelBkQ1dpWXJybExqam8vVTdHdCtMNjVacG1iQ20rTkFEdzNwUmNX?= =?utf-8?B?MGJTZlJ1RWdUSzRITThTOU13dUthVVg3c3RGbThhUXR2R2JVdzBsdzlKR284?= =?utf-8?B?Qk5USXBneFpUL0xPMTRRbE5FQ2hJa0g4OUErMFZwZXkrN2ZKV0hDb1JrcW5j?= =?utf-8?B?S201TGVIKzdvVnBGeG1CMys3QkxlcnMzelhVa1BSZTRaOWRYQ1JRWjhjOHhZ?= =?utf-8?B?WjZZelA1M1hhaGFXczREZVZIS2FOZmJkZ2ptU3liVTNpWGVsY3FFZHFhWHRp?= =?utf-8?B?TXo0QzNYOWUrS3NlVk9JSGtRZCt0eDFGZisyc3l0OHF0SWpQWDI3UTdFNzNM?= =?utf-8?B?SkpoN05kQXVsdk1UZXAyenFCajZoZE5YMWUrTVQxSXJvWExJQ00zd2YzWnVm?= =?utf-8?B?UWZlUDROWDlTT1NXSmk3WDVXTGtkV1YzaU1iZUxyVzBlN01xYmxRcUVUWVNm?= =?utf-8?B?cDRvVjF6dUZ5bUtVZ3VJV25LRUdKWDlmUzVISDlvV1R6dnVsTEx5SXlPK09h?= =?utf-8?B?RERGSjRXYnhwdjRtZlp2OE8rSGFEdzZMdzVEdG1IdlFlSnk1ZTVvMC9GSGEr?= =?utf-8?B?N1VsdC9GQ0tWaXUwK1E0OHJUUzBnM2tURWc1OCt1Nmg3NldQNWRCdEJ6TmhL?= =?utf-8?B?NVY2OUNTdFhTWDRJRU1wSjhSTE82THdGL0RSL2pFdGFEcmJCQWVib0J5Um1h?= =?utf-8?B?aHE4VUVWenFLQWFQTHJZSzF6YUREeWlZWjN2Y1l6ZWpXY2Z5cHN6ZndiM1d5?= =?utf-8?B?ZkxFRkRlZ3VzelptcmlMK3padUJiclZGVlJFYTk3QWkwbXhjS1V1M2dVbjAv?= =?utf-8?B?U3huZXlDUHNMWmdqZFM4MEdNNXY3WUl5dlBPdzl2N2lOZWlIdFJXY3NFMm9C?= =?utf-8?B?TU1uOFVXS0lyd2ZpeTVvck1oWDdrcXRXOEdnbGxwT2t3TWhzRU5mUjM5dUQ1?= =?utf-8?Q?udww1Z82U9IZR?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(376014)(366016); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TTN6RGlIMXRCZ3VCUVNzeUFseWhPeEd0ZWh0cU1NWlcxSlRLT0NFbnBGL3Ja?= =?utf-8?B?blZ4SjB2ZFZyWmlpU1R6U2xhd3lBVXdTdVk3VnUyc280QTFNdDlZRU4rUlVv?= =?utf-8?B?TU1CUHR3dVhMT3VFSG5EZFVRUS94YmxCUGFFejZQZzZGejZIOHhnVnlpZU1X?= =?utf-8?B?STR6MVhOQ3hLMExZZGFzeW1PcDlCZVpvdXphdjJPV1FldUphSmFEelFFT1Nn?= =?utf-8?B?TkYzY1dEZk1xcVJWR1Vja1lsUmM3STB3OGdoMjk2T0JrSnRNVEMrbml5dnV6?= =?utf-8?B?RitEemlWYUpVK1pZNCtjN215Z3BMWEpVa2lrMlE0ZTV0QW5WeVFYdmJBMXNx?= =?utf-8?B?V2pPZ096clFTUDE5dkhiczdWdm9LTkFORTZ3d1VzQWdKREI3aFhwZEora25i?= =?utf-8?B?SEhmZVp1amlrMmp1TDFWMWxiS05Zd3M3RTFPSDVJVmhnTlZMNVUyT2lpbFht?= =?utf-8?B?bGFVcWYwY0I0QzMvQ2xGQ0FHeitncDlOekRaWXV4L0NXbWN4V1Y3SWZYUUh0?= =?utf-8?B?dUhMM1ZVQklLYW4xa1NUQUxucTg1Qjh1ak1abnpRZGJaTXpoME9EVFBPK2Ev?= =?utf-8?B?QzhQblE0VWtnOWc3RHdIT0JBNG9wS0RzeGt5MFFCYVptOXlGb0R0MUQwNFpj?= =?utf-8?B?Y1NYRysvQW5JeGo0UGNyL2Y5VGhCblU4V0cxWllDMkp5bkJYS1ZaL2hpQ2Y4?= =?utf-8?B?clR4VzFYTEFVUlJNYi9tT290a09ORzNwd2RlaWJyVkVLL0c0Y2Npa0wxNUVP?= =?utf-8?B?S2xWRkRxZFcxQzFiWnFWalo0NEhBNkZpTnNuZnZpL0RIelh0YzU1a2JMdG1G?= =?utf-8?B?WmFrKzlnaHhmRlM2NEorL3g3OFV2c2tiblBOVDQ3cVA2cHhxN0NDdFFoOEpZ?= =?utf-8?B?MjA4MWRDOWNVOWZFKzAzSEpsM3JRNGQ2b0ZiNVM2YTV1WnlROUYraEJSd01z?= =?utf-8?B?RkMxd3hRbG90WS94bEhuekF6MDg1NXpZamtPSldpVVZNMVFJM0dkZlVMdnQy?= =?utf-8?B?dXZaWEM4ektyWGdLbGVGUUM1TFRnRUhOUG5nU3NGeDFQS1NtOW1WL1VWbTUw?= =?utf-8?B?bHptQUVjeVlsYVFGd3pobkJNOHR5eGZNa1kwVHl2NmFHdjBUQkRPMCthelE4?= =?utf-8?B?MTV0MkNQYWlmajJVOElVMU5jcFFQOWVWSkxVckVmNW9vckpLRmhFSzNuQXgx?= =?utf-8?B?TnBHZGZDRDYvVld3UkVGUE1HRUZGOUY0Q1ErUFRib096cmRvQmVnVXJ4NlV4?= =?utf-8?B?dk5rNGM5Z1c4UUxRbVFlMEN6ajlCUjI1KzdMTGVEMStBTkZvS3FEekwyc2dw?= =?utf-8?B?YTYzS0l2S2lxZGc0b3EwMEdQQm9IZXQxcmpKblBFRnZjNkFobHNWd0ErVmJk?= =?utf-8?B?Q3h3ZlROdFFnOFR4VnFKK2VXMm1xNFp1Mk85dnJvSXFaQ21tYXJicFRCdWEz?= =?utf-8?B?TU4yYW1KQXVDbnNzQlZKdnVJc1VTaDBkVEdrcm12djN4RGYvMDNuc01IbTNs?= =?utf-8?B?UmtNSGt1a21WZ0NVclVjcm9ia0cyekZWUXIvdDM3L2Y4K25mT3pvUHVKWG9W?= =?utf-8?B?YklSd2htbWZDMk12UGhMdzVTQlR5MWQ1WkRvL2pISnY5NnFqSGVBbWFkMUQx?= =?utf-8?B?TXJYM0ZsN0Nac0xhcmhwcTV3NUhXclpwVEZNQkllU3RuVXZ1V0NEUDNUWUZO?= =?utf-8?B?djZjS0plSXgrUUZ4Wm8rM1JvU3lTcmRkYVhOWWtCeGtCYThjbG0zaFIrejRq?= =?utf-8?B?dlU0MTFrS3RFRHNzTVlEWUVZQlYxaWVNcDV2SjBnWjRqSkhjbU5ITGtjMzRu?= =?utf-8?B?Sm9MYW1WdnJ6bUtxeHAvb1NVNHViZnRlUmI4UW5DNXpjaXlRcDFndzRGZGoz?= =?utf-8?B?S2xZL2dNWE9CNVphMWRxUk1FMlNmMldTQnlaaG5Cejg4dE9uUW9hdWVVbnRK?= =?utf-8?B?U2pPbXVjYmNtMFJMOXNNTHBSYnZlMko0VFdqaVRMbzhCMys3YVIvOGFHVjdu?= =?utf-8?B?RlRWWkFvdUZsLytMSjVOQTZIT0h0V3lwcnlrM2l4eGlFNzY5cWRnQXZaV0RP?= =?utf-8?B?WjJ5Und6NjF1SnRzUzFVKzJFcW1VQUtGUjVDbmFDM0JJc0JiWnpKeUN0ZUUr?= =?utf-8?B?RkIyNDVaYWR0eDF4SHZ5NjFtcW9CanZRVmovUWp2UUFHR2NKbmcyUzhPU25J?= =?utf-8?B?V3c9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 9a11439b-81c3-48cf-1c1a-08dd36559f21 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jan 2025 17:45:52.7264 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: bhqibb34YKzuv9lUUrGWKV66Gz/fOhWkzccQSDpvvQ8SZwJC3osTNfvJ5ACg+d3tnpsd9cO0s8Mc6YuSxr7GgUqZOtZOfY3Nw7R5cMHS8kw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV3PR11MB8553 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Jan 16, 2025 at 11:10:47PM +0530, Jerin Jacob wrote: > On Thu, Jan 16, 2025 at 10:50 PM Bruce Richardson > wrote: > > > > On Fri, Dec 20, 2024 at 02:38:57PM +0000, Bruce Richardson wrote: > > > This RFC attempts to reduce the amount of code duplication across a > > > number of Intel NIC drivers, specifically: ixgbe, i40e, iavf, and ice. > > > > > > The first patch extract a function from the Rx side, otherwise the > > > majority of the changes are on the Tx side, leading to a converged Tx > > > queue structure across the 4 drivers, and a large number of common > > > functions. > > > > > > > When considering the changes in this patchset, I'm still not entirely > > satisfied with where to place the common code in the repo. Using the > > "drivers/common" seems wrong to me, as it's for code common across devices, > > and having a "_common_intel" (or common_intel) folder inside drivers/net > > driver/common/intel is OK. I think. > > > seems a bit ugly to me. > > > > What would people think of me taking a leaf out of the kernel directory > > structure playbook, and moving the intel drivers into a separate > > subdirectory "drivers/net/intel"? I've done up a prototype RFC patch for > > I thought the reason for not keeping the company name was to - not > change the directory structure > if NIC block is bought by another company (driver/net/bnxk was with > Boradcom then moved to Marvell) or acquired by another company. > (Cavium->Marvell) > > I hadn't thought of that. However, in our case I believe the reason we don't use this scheme is that we a) never needed to and AFAIK b) it has never been proposed. In practice, if we do this for the intel drivers, it does not need to be done by other vendors unless they want to do so, or have a lot of drivers in DPDK. Also, renaming vendor directories is not going to be a serious problem, so long as the underlying device directory name remains the same. For compatibility of output, my RFC patch strips off all paths but the last, so intel/i40e remains just "i40e" in terms of all generated objects. /Bruce