From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (unknown [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6C518460A1; Fri, 17 Jan 2025 09:53:50 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3520A42790; Fri, 17 Jan 2025 09:53:32 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.17]) by mails.dpdk.org (Postfix) with ESMTP id 926D94029C for ; Fri, 17 Jan 2025 09:53:30 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1737104011; x=1768640011; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=9VB3l5kk/4AfLTv0TrI2U2UOaLZKLUNGVuBa5IQmzEU=; b=H1cxX6x38RAJeSJGEg03j8WTce3LfT8MP3mfYgPymKRSxVFcOXKDRyUx GLykLGH1ubRDlfQW59RT/lniCV5FtIaGPucMzW8WkpFJylsJwvvid7ydi ai0NxDy1aFTzgy9IPqyx3tQ4H/IZLVD18eA44/A0lN/a2UFBkIOmg4wOv 5Wn7n0UMFxvx5YFYzEgMAOuzLXqP+2oj76Xl2vhBehrtGPU/9yOQbG0v6 AHKyevIjL4fF2OUF1KZI7KSnlsrI6XjumNKHW5zpZOAk2HDcZuAmyPuTn 6fk+WHd4DKz0i2mSJxaUzEec66y92o3pvokKMD5Z9Ng6Q+Ql0+q7IZHIH Q==; X-CSE-ConnectionGUID: q/+AJJQXTHSJFtrBaC59iw== X-CSE-MsgGUID: u7kh21GKSQmfPV3QOvVJag== X-IronPort-AV: E=McAfee;i="6700,10204,11317"; a="37554534" X-IronPort-AV: E=Sophos;i="6.13,211,1732608000"; d="scan'208";a="37554534" Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by orvoesa109.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Jan 2025 00:53:30 -0800 X-CSE-ConnectionGUID: nmmOeFN5R86VSI7L9Lsv2g== X-CSE-MsgGUID: uvt0tG7rQZeGe+lLl0DLiQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,224,1728975600"; d="scan'208";a="109814288" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmviesa003.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 17 Jan 2025 00:53:29 -0800 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.44; Fri, 17 Jan 2025 00:53:28 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.44 via Frontend Transport; Fri, 17 Jan 2025 00:53:28 -0800 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.170) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.44; Fri, 17 Jan 2025 00:53:28 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Y2m1nKyrQGToFYPz6NVfjKzM2Rz2D0W/MrUGubG4+wFtpLydaC3g4m3KdqvW2cferPMRpVxHbQHvEnxGDh301Q2uJ7aGd5s5EQgoYT33HDFmMiLvb6aIfuA+nHEJThpq8vCstlX1bretj62ls9MI7PAV8f3QBkNEkkR2YiGsHCWYESp7iDh5Lvt8DTpxza28lmScTwPG0ciK3Ys1QWge7NoMw+NB9nOQQgwes0b0jf2CBnoR9U0Pc9aFNGXAjEful5sv8g7cjllPnm5bh9JQzdfwQmX2i4p4sKxNRsMYw+05qSoZ8+ISgsecvscX12Hu6DdjDk2wa3/Iuoc4ZXILMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fb2wQbC0i2GEeuZKYouKh3MMjCb24kxKh17tW4ZffWQ=; b=lVUsfCPwk4zbVPh7wNB/iJnx5NdlD4YPauDVCOrfc6XV/1nCeossIwet79iHEtzeOjH/VbIO+m9W3R+M+DHGd3R6urIjIeWrSjaF1irSjFySvgdcFe+Q1705qXTHWIKmoCw9ttChd+ltWkdlBdhzPursrVmCLuq0NbUd/zhLzTCdpDtoCAK+mpu/n7RHUTIdDD/cIJc+0u0gH+/AoGVp10gyh4Svknpr1z31NHfWtD2/n6x7JTTr/ymYE8ZCLtU18JWR1QrQkpbVK40lJqLzXRcZr3ZcwuKyYlW4hdHfq0CxOgfi3JUNJUWqSGnOWlmFNySzzP+X/RCW5jGyrdSMCg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by SJ2PR11MB8472.namprd11.prod.outlook.com (2603:10b6:a03:574::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8356.14; Fri, 17 Jan 2025 08:53:05 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%5]) with mapi id 15.20.8356.014; Fri, 17 Jan 2025 08:53:04 +0000 Date: Fri, 17 Jan 2025 08:53:01 +0000 From: Bruce Richardson To: Morten =?iso-8859-1?Q?Br=F8rup?= CC: Jerin Jacob , Subject: Re: [PATCH v4 00/24] Reduce code duplication across Intel NIC drivers Message-ID: References: <20241122125418.2857301-1-bruce.richardson@intel.com> <20241220143925.609044-1-bruce.richardson@intel.com> <98CBD80474FA8B44BF855DF32C47DC35E9F9C4@smartserver.smartshare.dk> Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35E9F9C4@smartserver.smartshare.dk> X-ClientProxiedBy: DB9PR06CA0020.eurprd06.prod.outlook.com (2603:10a6:10:1db::25) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|SJ2PR11MB8472:EE_ X-MS-Office365-Filtering-Correlation-Id: 8516dce6-def6-4067-157d-08dd36d45b2e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?c0UzcHplNmtkNVRzamsyMEhGdlZsSHVRSk9YQzBKcHZ6N25BdnlRRWFCMmJI?= =?utf-8?B?R0R0UVdyc1h6eDFYdks5U25LYTFiK2JKdmNPOXpLbjZXLzgwUEJQMThrVFBy?= =?utf-8?B?L2I4VW9NZWRVZmx6bVdDMWd1VUxFb01uRXpBQzh0dVZiVWR1Y3VObTBVajJM?= =?utf-8?B?a2VtemNkQlhrNkJ3TTI1OFY1N2owTmVvT1VENWFCcnhwTVdPYkM5MW9QcENv?= =?utf-8?B?YVEyRmtvd2dCc201VWgyaXo5RERkRWtDN3ZDcFQ2WjRudzZPRGNHNVhRUlkz?= =?utf-8?B?OWdJdzByaVUyZXB5NEZnNkkycEppZHlXRUpPdG55N0VaUDY1UnVIeWFmM3lK?= =?utf-8?B?ZDV0bkxTelpRcmFuZXJsUXlaMEk0eHNTb2p6bVlaQ2EvdExFTk9XcE5KU2pE?= =?utf-8?B?L1dEVWJYY3AvWm5SeTYxeWNGVGRXM2JDVlNFcVpKK1Y1bTJMcFQvRGI5VUh2?= =?utf-8?B?eG5FWHpGYmpiWVU1VEkrVkhRMklXZ2FnSUYwOFl0dkhOZHNDd2hyTSt4SXpN?= =?utf-8?B?QUZYMElGTVUzQ3pBZllPbThWaW9kTGQ2UlBrYU5wZ1pmME9zWWpKS0d2UGZW?= =?utf-8?B?cjByZis4ekNKV0VMTWdSb2dDbStuOFZaM09md0FZOUtaTlNQMFU3MUVUaDRQ?= =?utf-8?B?Y3ZuTFhsU1ZQU05uTjVNNVdrYkQ5RmJ3TUhHOEUzUFZoUEFobWhZUDZVMFBt?= =?utf-8?B?TXhUbDh4cmE0ZndsWUxMdnVaZTZ6TXJiL1N2WlJmeXRvWXFVUlpmS05vVHpB?= =?utf-8?B?ek1GNEtlMUNFdWdlbzNsaDhLNlZyRXUyaHZuVUZHdkJLenJBMUpPbkxhdTdQ?= =?utf-8?B?U1poajR5YmRMbi94bmpwY2hIcitxL1luMElwNTRNN3hnUDlKM0kzZExtWmxP?= =?utf-8?B?WjQzSm5Fa0tVNTJ6clZZQUVlVFZ3OEF2M1pQL2R1RXI4MmEwdWdBNEtsWDI0?= =?utf-8?B?dFpnNEFWZlUzN2Y5L3MrK0xrd25sLzA4ZS9VZndvekFhenBPLzFTU1o5RkQw?= =?utf-8?B?Qk1pM29MUXJybkt2Q01pTDRJUXBGbkFWZ1FZRlV2WlFzajFSaDErRDhRMTht?= =?utf-8?B?ZkdBWHFpSDBKMmFTV1dPcVVvaXArZ1kzd2N6eS9xeVFKeHE2YzU0eTg0RmJa?= =?utf-8?B?V1JLMnN2RXVUSThLL0xocFo5bUJTTDd2Q0EwN3ZaT3dzOGIrbEtnM0NoNmF2?= =?utf-8?B?bWxXME9ORnpNajN4VXM3YUdmck1HUmE5UExXL0M3c2pVOWJpOEtqanRUWXNG?= =?utf-8?B?bHdqdEluN3hkV2ZlbWd4d01pZ2JSVHd2ZW55N1RsNk5VS2dJeUU3cmVZRjZW?= =?utf-8?B?c1hxb0NvYnl2cU5nOWFROTduV2hWSUZjUytDT0VJMzdGUUZ4OSs2YklUc2VP?= =?utf-8?B?VkJZY2NRRjNWWjhvQ1RFWkdPOE92bG9oMkF2M0U1YVYwQ1pZNVFOYXNIKzZv?= =?utf-8?B?NDhEandzVWJjSTJvK3llSlFidFdVL3hwT0gzV3JkeVFZbSs2NGFURjhZcCtG?= =?utf-8?B?UTJ1T2xjWWl0Ly9QNmtSUDRQYzEvNis1MHBSNE1QTFZoTkphdS9VeUI3UFhi?= =?utf-8?B?V1JuaExKaElaaXpFOWxYVXUvbVdCRTRMVFhiQzNQRDdpU3BPd0QxbEIzTXdI?= =?utf-8?B?dnZZcXdZK3VJU09hYkxENDd3Mkp4TjJNcHQrWlBYcmt5QkNkUUl0aitkZ2Ra?= =?utf-8?B?NzFiVzVUbm02T0NRemhBTUNjWk9CSU5NS2N3WHVkUVFJU3JFSy9Jak15eTY4?= =?utf-8?B?MXYrSG5KY0pEVXZpZm8ybXFTUCs3eWxpS3JmSFpZVVZqeHN3YThzZFdjaklM?= =?utf-8?B?MGlNTWJ1N3RFeks5TTBWNGwzSjBidnNJcFc5b2h2dXBYQUtrS2Q1MTRDL1dt?= =?utf-8?Q?HoijjJZWbROY9?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(376014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TUdTUU5DZXdhK2tBa1pNVVpBWlVFR2c0RmRnTzJxdWRLeVRKVDBhdnJlRFVw?= =?utf-8?B?U2dRVXpXRGJPT05hZkxjbHgxTmFjd2M3VkxLM1oxVEIzYXk5N2craWlIRVBR?= =?utf-8?B?eVdJYWVWbm91a1RWVmcvaGJsaG9UNnFIMGFQUnA1ZDlqRWxZZCtvRlA3S0lC?= =?utf-8?B?bnJTYzZkMVpMbXl6VVFJV0tHQkdsaUJKWEFOcUZSSHBDejZHZkxxV2VIaEM2?= =?utf-8?B?R0hYR3BjelFrVVlQejdiNm1lVkxiUmF4d0h0dmtPWSs4elQxV0tUSjNneGdr?= =?utf-8?B?V0U1TWY4MDM0N1Z6QTdBNmFNdklWVjhjSWZpaGxQMVZqQmpIMHRIQlk2TjA5?= =?utf-8?B?aGgwNWNWd2VaWGtzZFlncHQ2RTVIUjZYNDRxQlhhM1lLZDlYM3UwUy9CVndT?= =?utf-8?B?YjJNanAycUpBY3hma3ZLWjk4S0VlM0VKcWVLTjYzTVR1OGJzRzFEdmFIeWg4?= =?utf-8?B?OTMyM3ppNFdrdHVEMUFBN2xKT0J1b0NyTHJObTNneG5CajgzVE1Fclp1b0dJ?= =?utf-8?B?T3oxeXZNYnAwRk5XNE1yTGRLbUZ1K1dBRCtYMS9tN2FDOFltb0V3VFFORjVv?= =?utf-8?B?M0ZXRXl3eGxabDFpL2xBT3hqdWpGeGVIQ3dncjhydnErY2RIR2RkL3dKeTF1?= =?utf-8?B?b2I2bHIvN21DNURjVVBxcE16Q0M1MTUrTlYwMVJNeVFoUThEVmVOTkJpREVB?= =?utf-8?B?YlgvaUYvdjNhS05yRUduVnRER1ZVTktzZUZTQUJVSjZCRysyTEpqaVhlMnBX?= =?utf-8?B?TGZkRGtVQ2p5Yk90WkxmUVlBd1h1NFp1MmdqTEFnZHp3TkJtUEZXbEdVc2cz?= =?utf-8?B?Y0t3Ui9oV0NvK3RTQzJzN1VXT2czbUpCRXV2WjBUNG9JTGxPdTUxZ3BpSUg2?= =?utf-8?B?eE0wSjdIQmtOZGxQSXJYc1k5T0dacWdEU2xQSXBOcnJhMk9XRlFHSjhiWHo1?= =?utf-8?B?dXFGUldpSjVjTFRraDNaMlJLdlhpK1Y1L0U0YlJnazZ4RG1vUi8zdmdMbThU?= =?utf-8?B?UlNuMENmenoyZiswbHBQd2dtMkxTZkVsM0I4UmtlbG9sNnc5TW81WExTeHcy?= =?utf-8?B?UGVFVzZUV0ZvTTE3Y3ZhZjBEMll1TFVYRllyckJTaUYzakFISGlmU0NoUWFp?= =?utf-8?B?SlYraTZUYU9YSURnWG5takh5TjBrbXBpelY3NTVDQU1PYmRqaG5lWHB0d0c1?= =?utf-8?B?VWM2UWlyRnA3anRWN09UMWlTYWc4bUdRWDVaWE5SMVZrMEtEQ005UFh1MjVo?= =?utf-8?B?cU00cjYwQ2FKMzNqbmNxRzR2OUR5TGQ2NEU0VjBaUXN1eWZzVjBzeXBjZW1o?= =?utf-8?B?bXZxdU4yNDg5cHVBakZDNG1iZUFnR0cwcXZMelhueFpSWGRtb1JLb3ZhRDBy?= =?utf-8?B?OWpvWGowMVd1K0doZHhKSCsreGYyUjBYR0luNlVYcDF0TWRYNGNjRkUyVk1M?= =?utf-8?B?TXVXRzNoRlZieWxOWDFZZjB6b29oclg5Tm0xRUpqN01FZGFSVmdoeGFjTTNB?= =?utf-8?B?bmZHVmhZVEFlY2FjR09taVRSRzhXdzJkREhyMC9pM0tKYVM0UHJWdE5keGY4?= =?utf-8?B?dklqeHJFc2szbDRNN3RyTXIzbzhBM2EyUERLNFdVeFRzaG5kSlpDcUtPUm00?= =?utf-8?B?cU1EdDVtU1JjbG1EK3k0c2VZM2RmWTZiM2ppb1FmY1JrazF2clRGc1JRbzBI?= =?utf-8?B?ZFJxOC8vVXljYTg0OFRlQ3V4QzV5SzJ0ZS9oTkRzTlQwSEsyKzF4Wm00R243?= =?utf-8?B?MngzZjUzL0ZsYmM3OThSNm9MZGFKUk5FWmkwaU1GQXdkYkNPc01VL0pEY1Zp?= =?utf-8?B?UFZ6eEQ4aCsxTHQ2NllsTFZ5bHg4aFRtcGJ1dWxya3VyWmtWcklHR1JIVXhy?= =?utf-8?B?VFNWVmYyVnlib0VncklGT28vN1A3c1U3QWZRZ1BEWWpOTVZuN05JRjRJb2Na?= =?utf-8?B?QXFkOEJnanp0SUhFZ0xOdGRoUEpVNkFRSWNqL2FsR0JxSkd3ZmlkWi9XMGpW?= =?utf-8?B?UW9zYzNjSWZPdHN6S3QwelFzZ0ZwR0hGL1hwSXowZ29Jbk5oQTlFL3RRRjBQ?= =?utf-8?B?cjlNa0U0SVpJcy9ZUlJaaldJYXdYSnJKNW05YzhLZE0rWkZDUE04US90UHRU?= =?utf-8?B?UUFRYnVFajZhRmNVU2RDS3o4N0JHeHB4WXlpV1BQVW0rWDZjRDR1N1dDU1VB?= =?utf-8?B?MWc9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 8516dce6-def6-4067-157d-08dd36d45b2e X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jan 2025 08:53:04.9314 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /lR1liXL19uj8X5SIitON2BdicPP2htZAy6OQxTpV6cTSfcAVuMrj0wizQUYApSROmtMaAgxYyNKUjtrr0KEXmFuU3A2+peudB05qBdVwS4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR11MB8472 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Jan 16, 2025 at 09:36:30PM +0100, Morten Brørup wrote: > > From: Bruce Richardson [mailto:bruce.richardson@intel.com] > > Sent: Thursday, 16 January 2025 18.46 > > > > On Thu, Jan 16, 2025 at 11:10:47PM +0530, Jerin Jacob wrote: > > > On Thu, Jan 16, 2025 at 10:50 PM Bruce Richardson > > > wrote: > > > > > > > > On Fri, Dec 20, 2024 at 02:38:57PM +0000, Bruce Richardson wrote: > > > > > This RFC attempts to reduce the amount of code duplication across > > a > > > > > number of Intel NIC drivers, specifically: ixgbe, i40e, iavf, and > > ice. > > > > > > > > > > The first patch extract a function from the Rx side, otherwise > > the > > > > > majority of the changes are on the Tx side, leading to a > > converged Tx > > > > > queue structure across the 4 drivers, and a large number of > > common > > > > > functions. > > > > > > > > > > > > > When considering the changes in this patchset, I'm still not > > entirely > > > > satisfied with where to place the common code in the repo. Using > > the > > > > "drivers/common" seems wrong to me, as it's for code common across > > devices, > > > > and having a "_common_intel" (or common_intel) folder inside > > drivers/net > > > > > > driver/common/intel is OK. I think. > > > > > > > seems a bit ugly to me. > > > > > > > > What would people think of me taking a leaf out of the kernel > > directory > > > > structure playbook, and moving the intel drivers into a separate > > > > subdirectory "drivers/net/intel"? I've done up a prototype RFC > > patch for > > > > > > I thought the reason for not keeping the company name was to - not > > > change the directory structure > > > if NIC block is bought by another company (driver/net/bnxk was with > > > Boradcom then moved to Marvell) or acquired by another company. > > > (Cavium->Marvell) > > > > > > > > I hadn't thought of that. > > > > However, in our case I believe the reason we don't use this scheme is > > that > > we a) never needed to and AFAIK b) it has never been proposed. > > > > In practice, if we do this for the intel drivers, it does not need to > > be > > done by other vendors unless they want to do so, or have a lot of > > drivers > > in DPDK. Also, renaming vendor directories is not going to be a serious > > problem, so long as the underlying device directory name remains the > > same. > > For compatibility of output, my RFC patch strips off all paths but the > > last, so intel/i40e remains just "i40e" in terms of all generated > > objects. > > > > /Bruce > > If we proceed with drivers/net/intel/i40e, will new patches be titled "net/intel/i40e: new feature", or still just "net/i40e: ..."? > > The key is getting rid of code duplication, so either directory structure is fine with me, drivers/net/intel/common, or drivers/common/intel. > > Considering Jerin's input about NICs getting new owner companies, I have a slight preference for Jerin's suggestion. > For the second suggestion, drivers/common/intel wouldn't work as a name on it's own since it's too generic, and doesn't specify that this is common net driver code. So the resulting name would be "drivers/common/intel_net" or "intel_eth". My preference is definitely against using drivers/common, but I am ok to continue to use the "_common_intel" folder name in "net" as in the v4 patchset, or (my slight preference) to have "drivers/net/intel/common" folder with the other drivers moved to that "drivers/net/intel" folder too. /Bruce