From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7C07B460FB; Thu, 23 Jan 2025 13:43:20 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1628340269; Thu, 23 Jan 2025 13:43:20 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) by mails.dpdk.org (Postfix) with ESMTP id A544740263 for ; Thu, 23 Jan 2025 13:43:18 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1737636199; x=1769172199; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=y4nCKnD//atRTMbNZmsJ0xYhu1nZb9NGNg5R//GiZQw=; b=a/JEZeT/oAEoWq8h2DBMRZM4RV9T8gjEwAa3hmZbaTgb3fzbMS4944tR 6aSiv57NfzjhhMHGHn7C6vUQFQbsUz5lLy94A5erW6NrOjX753sBjMM72 +H8oqgI1aT+DE+wOEC4U9F9VkOhKUus6pAAvO/sDWCnVsIhRchV/885pC PPUjVeY6bpLvgD16TUOeR6eOCoH8BQiPEbVWGZkskN/3wpP6Ru4RRKEY6 M40ZNGVAn8IJjfzFkSyJVN7SkDGqVCAZpNO6TP3lOisDti+RwKHZY0DJt 7nP9TCltoGzXhAOMCHWMCV8WXx6Fl5eLhFR9GHxn3jCBwcHZuHTAlU39/ A==; X-CSE-ConnectionGUID: 9jtO2xvsQK6HT+/plX3Gvg== X-CSE-MsgGUID: 3VFblDJPQUiD7ncX5wLkYw== X-IronPort-AV: E=McAfee;i="6700,10204,11324"; a="55545741" X-IronPort-AV: E=Sophos;i="6.13,228,1732608000"; d="scan'208";a="55545741" Received: from orviesa004.jf.intel.com ([10.64.159.144]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jan 2025 04:43:17 -0800 X-CSE-ConnectionGUID: ZZNXlz8sTgSPUW39jLQ8Ug== X-CSE-MsgGUID: FS6Jm9qUQOiuPnl7rKDcmA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.13,228,1732608000"; d="scan'208";a="112474537" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orviesa004.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 23 Jan 2025 04:43:17 -0800 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.44; Thu, 23 Jan 2025 04:43:17 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.44 via Frontend Transport; Thu, 23 Jan 2025 04:43:17 -0800 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (104.47.56.42) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.44; Thu, 23 Jan 2025 04:43:16 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=nb5fCQ17RYI6MbgVSDueqwdA0arp7cQGdapAlvlybqUfVHO1RGPViswHouB9AuQzPBpSbZWsq1wnkwUkvguOR+AEWIFvZ8VKv6Zt9GprObUH+3vM8W5a3ePKAs7oYv4dF3lcjTQtRZxLLl4I2Qii2gPONu4tMLZN5CHyhpofyO2D1HhNZaRAMDykp7h5mm1cGWXtoQghK6R3sB+hf4YbLWu0bJO5q/d3Z3ZTmd60GE3H/dThSBV96ouzyaSHndaP+wty/3EmBT3r5UqUtWyXtBXfi06IbTUUfGa2uMHPlPGiY11O+CaQDysFj4rjQxahR8kHkP4LQCmg7GQX1s4beg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Z2VTEbIRQFdsGRPHJZR6U26LvfoRDMZU5AeBBGnkfHs=; b=e+xJsbCPX0/PGkVsDfiVYNVRHTbtJu4G8u8wgt15XSZdklnujEA/9R40g+TcRJGOnVDT9/KM8Lm/HiGWsBahX6Hm3462gh5QgPl1GIxpaq9a1L6ub7SmWKSGi8Eg+YIrTgHHXWIZj9X+oYR6qzEtTrMq6uuoCImVcFyaJzaSFwSXfMaVfXhpC5BavDCT3HzfH7HGqMhjiNF7DjkXep21robJyOR9LhUNL4kmsEE6i3uMOIPi7pd/QXEYcCDwTlepM43/UyYyHK8x5BRsHWHd4zxff1/1j0+XLCM9kPXIqAfhZHxEVsSSUmKijnVo1OGv+v2bdsnODKaVFOy2/ArQYw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by PH7PR11MB6793.namprd11.prod.outlook.com (2603:10b6:510:1b7::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8377.17; Thu, 23 Jan 2025 12:43:09 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%5]) with mapi id 15.20.8377.009; Thu, 23 Jan 2025 12:43:09 +0000 Date: Thu, 23 Jan 2025 12:43:04 +0000 From: Bruce Richardson To: David Marchand CC: Andre Muezerie , , , Subject: Re: [PATCH v16 00/60] remove use of VLAs for Windows Message-ID: References: <1713397319-26135-1-git-send-email-roretzla@linux.microsoft.com> <1736821958-3295-1-git-send-email-andremue@linux.microsoft.com> Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: DU2PR04CA0235.eurprd04.prod.outlook.com (2603:10a6:10:2b1::30) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|PH7PR11MB6793:EE_ X-MS-Office365-Filtering-Correlation-Id: edc85087-13c7-4be5-0b7d-08dd3bab7dad X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|366016; X-Microsoft-Antispam-Message-Info: =?utf-8?B?em4vdi80SURQSFlPaXBnZXkyRzNlT0kyWWhNVWdyMWRGMmc3clU3MCtkeHhH?= =?utf-8?B?dWdoZ0RaNDRYckJyd1hlN3hrM25haWVkSXBGNHRxUDhCMFNocDhkQ0ZUaXND?= =?utf-8?B?b2JVeno4bkVyb1VKMzQzSnJjY3VUVDdqTlprN0crUFAwSm9BVm9LNEE2V0Fj?= =?utf-8?B?emNOWWRKTCtHV0FkbU9FNW5HMlZQWjdVNVJkL0Izam5WZnM2bkh1UldodFJw?= =?utf-8?B?UXQzOFJ2eXA2RXFOSk8wWUk4OFpwcjRzZjQ2SlQrVUJTZTEvWFZLcmVVSFlG?= =?utf-8?B?enVDN1ROMjk3aFVqRFkvK1pNajRHbFZycDRXVzcxTWpDcUx0dVczOUJIc3V3?= =?utf-8?B?ZmlHa3lXYVVmc0JJQW1lMUkxRFlscVN2djlUK3hxZnFLUldTRnpQMFp1Umpn?= =?utf-8?B?VDgyaTFJOE1iSm5sMnBOYjRzMW5nNDRITHdPSWZvWUxBSGZHWnViN3NLQzNS?= =?utf-8?B?SENNT0lKZnQxQ1o2MGRSdjc3VVNLcmNHWTBSekxhNlRZTlB0QnlPZE9UUXdz?= =?utf-8?B?ejhiZUxpRU45Y2tuL2NqN2ZybmRaR3RpVnQvcVA1aGdHd280QitNandRbloz?= =?utf-8?B?R2RGU2tFSU5OeFNYVzNhcEdLMVdBcW0wOFJmTDJrSVVwVmF6cEE1WjhKVndE?= =?utf-8?B?YUM3MSttMFFOcjc1Q3d4djN0akJKMS9xaTRaKyt0UnZzdzU3UmdsejM2Mmc0?= =?utf-8?B?N0hEd0N5VHFqcWhNNTV5c1VyZ0NNRC9YMVRaYWF0TmV4bDN0a3BZRitNV083?= =?utf-8?B?V3JBTVhRbWQ0VlB0cmYrK0J1MHU5Y29NVkRrUWtxd3UxZjFQM3hFRDFTZlN0?= =?utf-8?B?V0NqTjFNVExqMEdjOG5YVkNMZWRtZnZVU3RiWFdtUXlMWGorSGpZUlF3Y2dz?= =?utf-8?B?SnNJU3VyWnlGZVcydHo2ZTVRTStWUlV5ZW10YVZUdFdiYmY3bklyT0VWZXBk?= =?utf-8?B?eVYzVW1hK3JmUDJnVGtJYTVSWld0RHpiV3pUUHpkY3BJVTNxMmRzdENGQkdL?= =?utf-8?B?bTFtdC9tdkpOUVV6RTVCNzVTVXZ5S3haSHNqWkVFdFpHNHIydFVJVmN4dnJ3?= =?utf-8?B?eXJQekVmTVF5TGU4ZVJrUE5iZi9wZGREN1NOazZ5ZVJvSUZkVDI5T296ZGxY?= =?utf-8?B?QXlhc3A5U2lJdEpwOEszVjBYb05PcEdQMTZ4TDJaTzVua2trb3F6U1dCM1V1?= =?utf-8?B?M0o0cjZydFFaQ3d0QmFFeGRiVTBKclFoRzJ2RGFOQnZWSFFPL1daR1M0MmpY?= =?utf-8?B?WGxUNE9adEo1V0ozRUdibEV0VVliRzZGREtjaE9abHB2NXFDd0ZxaTYwRVlG?= =?utf-8?B?bnVoQzlKdzZmOElZN0Q2ZjhvZ2x1YVJmZG5ST29BeDA4TVpNck1vSEdPTGQ0?= =?utf-8?B?YXlBN3Vwa2lsSlNYMkpHQS82Yk41TGh4Y1kwTS9TeDJqQ3FQUFVXTzFuamp6?= =?utf-8?B?dWJ5MERSd1BnRWpHVDV2Zjk5eXBFTFZFSUYyMWVGTzJENDBMeHd1eU1DdVRS?= =?utf-8?B?aWFFcWlkd0pqbkVCU1ZaVDBsMndHdWdRTEJJWkRkUE5BbXdBOTJXUVlrMHh6?= =?utf-8?B?RlFzSEdCK0srcUQ3WFhwUG9UaThqU0JIdkpNYmlWc3lWMVkyemdBWlNLR1B1?= =?utf-8?B?a2MycVFiNDV0MkJkdWErbUtURTRCVHl5ZnNtaVIvcENIbWNkNklrZ2liUHV6?= =?utf-8?B?aEhyNGNNV3NydGhTSVNkYURsbEZ4VTlkRmtvZTlkSGpVdzdKT3NXNEY5aURL?= =?utf-8?B?cUkvajNERDVOTSttdjBqUkhwbG1icDdibDVTMENGbXZqcDdES0VwN3A4dVJF?= =?utf-8?B?dTNHakNORDA3dmtNK2txMU5oOCtmalBiU0FMUUdjdVJPZG54N1hoK25TTlFs?= =?utf-8?Q?/NI7lWBcwol9M?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(1800799024)(366016); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WW5SVlpKWmp3ZFE4bWFBSkl2bWhYSGQ0aTZ5WW5BNndIMXQxdEtzVjhrdFZ6?= =?utf-8?B?cklzdXQ0eTdneGlibkZ5WVZUVStSYzB2OEo4WUNrVTZiZDhxZVl2eSswWXdO?= =?utf-8?B?Mkwza09ZNUFaU0xmdmJ5QXhKTWs3YmNGOFM2dGxuOUg2bG51VmxtOFRvNGpr?= =?utf-8?B?REVxakFFSElnYloxekEzZ2d0ZWRRNy91aDdQRkZRdFU3RVNFYnA4MituQTgw?= =?utf-8?B?Q0FiankrRkNlWFo4Wmk1bmFTK0JReFkwcUNEdHUvTVpHSWx4UElycWhOdE9p?= =?utf-8?B?TWpwcE85TDZXL1VJZ0k4OUYzckFlY1paS2ZBV2FHOFRDTlB0cUFWblJjL0Za?= =?utf-8?B?OTQwcW9naVJ1eEdWV0JVRTk1U0UycDc1Ynp3L1ZpTnZzSnZZWENXYXQ3QWdH?= =?utf-8?B?bEZxSW16UE9rYmhmMUZsWHZZUG1uRW1TYTdGdFpwYzlsWEhTcE52M0NvVDA2?= =?utf-8?B?S1ZVL2RNeW9sRzJCRUxWVzRqVTZ1Nk9FNkovVDZTTnc4Rk4raWNoa0ZNTVBz?= =?utf-8?B?d1VXb1BvSVhZV25LWjlmb3d3M3RhcEJLVm1TRmY4c3RLcHZ6elhpbStBZS9o?= =?utf-8?B?M3VmSG9pdFVZRWlkYWZ5cy9sc281SGpBSjRGL2dtclVvUVptVHNuSFp4OUNi?= =?utf-8?B?M2NrLytHR0JkeDRrbHFlVEd2b1JLVzZ0RU5Jcjl6T2dJYlVoZGVKOTlId1VW?= =?utf-8?B?ZjRQM3pTR0NlK0RjMTVINmlHTHI4TWNSai84SC9CRU5iQkRjNUZJczFJNktU?= =?utf-8?B?VFcyY1cvUnJLL1RGNXp3NFVmMWR6N0NtZEI5YWVubGFTNUJzUXhRNjM0Y2xJ?= =?utf-8?B?SkMzdkFVczBocW5FOGVxVXpiTks5aXFmaDB6bzJRRGJIbU0zaCt2V1dWMjI5?= =?utf-8?B?bEYydjhweTdoOUdSR3FPV3hoK0x5amRnNjlFeE8rblQ2bTdjZ002eko2M3VG?= =?utf-8?B?QWs2aGRhNFBOdERUWTAydmVNbXZwalEyMUxQcndJeWdsNzdOc2JFN0c0Znpj?= =?utf-8?B?NUczMDNpNFdEbUdvbkh6THpJc2xiN2ZobEhYT1NPSTVKSXp5T3RPWm1jeVZk?= =?utf-8?B?Y1FzMGE2M1NmeStYRUJtc0tGcnBnS0FnNU1jMm5ZUXdCYmxaR1NiZVZXblZV?= =?utf-8?B?Q1JKa1BlODFNOGFza1RLMnJRaXJ5akdxNFMzclhqUUhybitLL3NyV2J3NTV1?= =?utf-8?B?ZWVYUjdyd3pJdEZubWhCT25VWGp5V0NiOW1xWnZtcTZidmxBSno4VnRPelM3?= =?utf-8?B?bzNLYXNUSUhUQVJ6bnVrSVNTZStSaDVmN1B4dDh1am1RdHpkdktLcmorKzRq?= =?utf-8?B?TDVtMVFjNGJYM1M5SUYwU2xLS3p1TmlsejV0aDdTQklmdVpRRm5lRnlKS1Ev?= =?utf-8?B?OStjdjRkK05KVTFjNEFsUkNPdmVPdGhsbEJYTi9UcHpzaUJ0aWh0QjNnSnQx?= =?utf-8?B?VGtrTmlRc0hpMVJCa01sVDhyREptb0R1aXJLYnZqdm9RKzQ4aEo2N0huSXhX?= =?utf-8?B?emY3aTNKSzhLbWR2dnZBS2RaUmxLQXZ3bW1wbWNnd3lJbVkzYVRGNTVBaWYw?= =?utf-8?B?T0ZsSGFhZXdMT3NYVUo4L2Z4NVk2aXFyd3pySmN6NU5pa2RTOFlrb0dudjJu?= =?utf-8?B?bDEvOExuamVRdlE4THJDVEV5OXlnSjYxWWtEbnVldzl3QnZHQzl2cnhGN2Rw?= =?utf-8?B?SzMvR0J1d0R6RVVKSEtBaS9TYlFGSVlETkFTQytONlZoM3BvM0trN0k0UmVO?= =?utf-8?B?UDIwanhrdEk0aUNzSnVPSm91MHZxRXlwd0dDSjQ4cGU3ZytEUTM2RU1OVTRB?= =?utf-8?B?TElCWkVaTzI3UERUYnJFTHhnaXVka0orVUMxdUhxem9sMVJCaGw5OUhWaGVm?= =?utf-8?B?WE12K0ZlWnlCM2ROSWVrTEJKenBtYnVtc000Z2pZUnovREp4YVJCT0RlSHVO?= =?utf-8?B?aU54eHQwdmtyRm9uSUVnSjNNUUN2eTM2b2txQ01wc1RjUGk0M2tZVDhJbUtF?= =?utf-8?B?T1QyS0VsQ0JlVXlBelVZdHFzcjRFZmEwOFJJOUNXZU9xSmFpcGZiemdXYy8w?= =?utf-8?B?aFVPVjdUV2FYVnl3Z3I1dFZMTEFJUm5OU0Rmbm91V2V0eGRMVE1xS3ZDcnFq?= =?utf-8?B?VVNPand1bGxXZ1F3ZnRXWXI2QlcrQnVWc2Jta1NrTU56WG5rSHJ6d1E3ZDNM?= =?utf-8?B?WEE9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: edc85087-13c7-4be5-0b7d-08dd3bab7dad X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jan 2025 12:43:09.1748 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: eim4KUBt0+D7CQ9GcIElQp/TC7g+I0zy2yNc4wpsMOvpqdwCsmQlvhO/iYthMU0id/q9LDXb8DShuLLcF2+p7/rsTTxubmkdIdtvTWgkuqk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB6793 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Jan 23, 2025 at 12:58:49PM +0100, David Marchand wrote: > On Tue, Jan 14, 2025 at 3:32 AM Andre Muezerie > wrote: > > > > As per guidance technical board meeting 2024/04/17. This series > > removes the use of VLAs from code built for Windows for all 3 > > toolchains. If there are additional opportunities to convert VLAs > > to regular C arrays please provide the details for incorporation > > into the series. > > > > MSVC does not support VLAs, replace VLAs with standard C arrays > > or alloca(). alloca() is available for all toolchain/platform > > combinations officially supported by DPDK. > > > > v16: > > * remove -Wvla from drivers/common/mlx5/meson.build and > > drivers/common/qat/meson.build > > > > v15: > > * inverted some of the logic added during v14: > > add -Wvla to meson build files in app and lib directories, adding > > -Wno-vla to the few subdirectories which are not yet VLA free > > > > v14: > > * add -Wvla to meson build for directories that are VLA free > > under app, lib, drivers. This is to ensure that new VLAs are > > not added to these directories in the future. > > Thanks for working on this topic. > > I see there is some back and forth on the topic of passing -Wvla. > It would be less fragile to put a -Wla in a upper level meson.build > (like config/meson.build for example), then disable explicitly in the > parts that are not ready. > > Something like: > diff --git a/config/meson.build b/config/meson.build > index 6aaad6d8a4..be603bd45b 100644 > --- a/config/meson.build > +++ b/config/meson.build > @@ -348,6 +348,17 @@ foreach arg: warning_flags > endif > endforeach > > +if cc.has_argument('-Wvla') > + add_project_arguments('-Wvla', language: 'c') > + if not is_windows > + no_vla_cflag = '-Wno-vla' > + else > + no_vla_cflag = [] > + endif > +else > + no_vla_cflag = [] > +endif > + Minor simplification suggestion, put "no_vla_cflag = []" outside the conditionals at the start, as the default value. Save having multiple copies of that assignment, and having to do "else" legs. /Bruce