DPDK patches and discussions
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: David Marchand <david.marchand@redhat.com>
Cc: <anatoly.burakov@intel.com>,
	Andre Muezerie <andremue@linux.microsoft.com>, <dev@dpdk.org>,
	<thomas@monjalon.net>
Subject: Re: [PATCH v2 0/2] fix void function returning a value
Date: Thu, 23 Jan 2025 12:46:20 +0000	[thread overview]
Message-ID: <Z5I6HGfVC0qZqRqX@bricha3-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <CAJFAV8yNg8jtpubkRfLwCtG1pKY+mzztg-AsvRpNVT2w8CB7fA@mail.gmail.com>

On Thu, Jan 23, 2025 at 01:23:15PM +0100, David Marchand wrote:
> Hello Bruce,
> 
> On Wed, Jan 22, 2025 at 4:21 PM Andre Muezerie
> <andremue@linux.microsoft.com> wrote:
> >
> > v2:
> >  * Updated commit messages to follow standard format.
> >
> > This patch avoids warnings like the one below emitted by MSVC, and is
> > needed to get the code to compile cleanly with MSVC.
> >
> > ../drivers/common/idpf/idpf_common_rxtx_avx512.c(139):
> >     warning C4098: 'idpf_singleq_rearm':
> >     'void' function returning a value
> >
> > Andre Muezerie (2):
> >   drivers/common: fix void function returning a value
> >   drivers/net: fix void function returning a value
> >
> >  drivers/common/idpf/idpf_common_rxtx_avx512.c | 12 ++++++++----
> >  drivers/net/i40e/i40e_rxtx_vec_avx2.c         |  2 +-
> >  drivers/net/i40e/i40e_rxtx_vec_avx512.c       |  2 +-
> >  drivers/net/iavf/iavf_rxtx_vec_avx2.c         |  2 +-
> >  drivers/net/ice/ice_rxtx_vec_avx2.c           |  2 +-
> >  5 files changed, 12 insertions(+), 8 deletions(-)
> 
> I see the series is delegated to the main repo (Thomas).
> 
> This touches only Intel drivers and the code deduplication effort you
> started may conflict (though trivially) with such changes depending on
> when it lands.
> 
> Would you mind merging this fixes from Andre through the
> next-net-intel tree, right now?
> If so, please mark it as delegated to you in patchwork.
> 
> 
> Thanks!
> 
Hi David,

the code deduplication effort patchsets are similarly delegated to the main
repo. I was assuming this was deliberate, but perhaps it isn't? I'm ok to
take these patches in next-net-intel, but just would like to confirm that
neither you, Thomas or Stephen (as net maintainer) want to review the dedup
work ahead of that initial merge?

/Bruce

  reply	other threads:[~2025-01-23 12:46 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-26 23:14 [PATCH " Andre Muezerie
2024-12-26 23:14 ` [PATCH 1/2] drivers_common: " Andre Muezerie
2024-12-26 23:14 ` [PATCH 2/2] drivers_net: " Andre Muezerie
2025-01-22 15:20   ` [PATCH v2 0/2] " Andre Muezerie
2025-01-22 15:20     ` [PATCH v2 1/2] drivers/common: " Andre Muezerie
2025-01-22 15:47       ` Bruce Richardson
2025-01-22 15:20     ` [PATCH v2 2/2] drivers/net: " Andre Muezerie
2025-01-22 15:48       ` Bruce Richardson
2025-01-23 12:23     ` [PATCH v2 0/2] " David Marchand
2025-01-23 12:46       ` Bruce Richardson [this message]
2025-01-23 13:03         ` David Marchand
2025-01-23 14:08           ` Bruce Richardson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z5I6HGfVC0qZqRqX@bricha3-mobl1.ger.corp.intel.com \
    --to=bruce.richardson@intel.com \
    --cc=anatoly.burakov@intel.com \
    --cc=andremue@linux.microsoft.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).