From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DE6F7460FB; Thu, 23 Jan 2025 13:46:33 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8128E40269; Thu, 23 Jan 2025 13:46:33 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.13]) by mails.dpdk.org (Postfix) with ESMTP id DE43140263 for ; Thu, 23 Jan 2025 13:46:30 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1737636391; x=1769172391; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=E/mPjjs67KITRct1EUTakd2xsn7iZzin+n3p3pSbST0=; b=HxSgENNoYZJq7F39Rc8MeBCTgOF37XoB1Dyn3BoRTqahm2LpSExzaWFs mYet6Jr+NqJRIgNooOfJRXcerGPkJqekvqlzXeWFyaJ8mfy7ikudewcaB tbkEkIv839CdwjgPINDzV6mBorPL2mttd8E5+PyxXkXJbOlh8T7VELCuR GLAE6pRLtaL5DuxJo9l539rVEBT+Wk4N1vHDsjUtI7KR1qtfyNYW+5RME pvDlFSZt31N7o6ZckuI4juFsYFLs6iYVi5Ha+VhNGr//AgNkMhqo1aU2G 8ih/GELJQhqP2WovI9GEKE1pT5Fdn0tNk71qBVL2y9o8DDk3jluuVR9mC Q==; X-CSE-ConnectionGUID: a5fpwpVSSGWXTrX+wTRp4A== X-CSE-MsgGUID: i09vkjPpTX2UJYqYFn8aFg== X-IronPort-AV: E=McAfee;i="6700,10204,11324"; a="40956151" X-IronPort-AV: E=Sophos;i="6.13,228,1732608000"; d="scan'208";a="40956151" Received: from orviesa008.jf.intel.com ([10.64.159.148]) by fmvoesa107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jan 2025 04:46:30 -0800 X-CSE-ConnectionGUID: SJwYmdkSTsCk2rPTyGUoew== X-CSE-MsgGUID: 2dvzz3xvSpGUqCIPyYyGOA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,224,1728975600"; d="scan'208";a="108317153" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orviesa008.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 23 Jan 2025 04:46:29 -0800 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.44; Thu, 23 Jan 2025 04:46:29 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.44 via Frontend Transport; Thu, 23 Jan 2025 04:46:29 -0800 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.42) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.44; Thu, 23 Jan 2025 04:46:29 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=xYUCA/nhA2znmW7jMRbjkFt8bno+qG9AedTS7qV8Cvr1gTZqH1th1W0MuRhbx6ymFL5sKrnG76GUwHhEyreuMA1wCS8f9MxJKaNND76fs7ogESw/69QSrJAs5v60+2ddDhYx3B9wJg7q3v5YPKiS8d0wxKywK92rJ/Nrz6TklEh6rrZSnr5ocieyWcW8ZMiVrwGcsDc3tvMvFBgMy3dCw0QzyA4jOoDw40e7mPy5BRgVwmXI/SbaJgpS0usB/sk87bNuul0/Mrk4cPa02G5asqF5OnE9dig6a86cFbdl5cFauz5SANhJLIN+pcRYoVsVu+wo1bLB9fGLoRei34jLFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JGGxG7V/2Xd20Xv7E7HNW2d5wWa9nlwwzuiX6DpPHxI=; b=f9iCoAk9GOAI/kJqE8xJasnFcjbbAvt46o312ZWTDduJ6AFcQ96UpdAGerufFkxUw1Wss37hSg66eBG6Y3An8Nb/jV6s9gwsxIzK8KUbGI9mRCCVdzMs9sqgP3WXIEp2kg2qCiqpHUBR3/m5uFIxMB3TpALQyC/3l4EcFC+CnJY4DXZ0Kybtve8VF6j7nGl2S6SbEl31vtbfzJilONethpX5awgGyOTt9JoAXYPLLXPn4//ji3Y37ASZSDGvcJ7bmpZbW1t2IoEB3e7qAv30yaUfsnYMFuPCa7Hf2LimOVnw5dLt0vhJp2Kj/xoiiTPXGvHp0fJ74ckz/EKCfAOcXg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by PH7PR11MB6553.namprd11.prod.outlook.com (2603:10b6:510:1a7::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8356.19; Thu, 23 Jan 2025 12:46:25 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%5]) with mapi id 15.20.8377.009; Thu, 23 Jan 2025 12:46:25 +0000 Date: Thu, 23 Jan 2025 12:46:20 +0000 From: Bruce Richardson To: David Marchand CC: , Andre Muezerie , , Subject: Re: [PATCH v2 0/2] fix void function returning a value Message-ID: References: <1735254890-18457-3-git-send-email-andremue@linux.microsoft.com> <1737559244-9107-1-git-send-email-andremue@linux.microsoft.com> Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: DUZPR01CA0016.eurprd01.prod.exchangelabs.com (2603:10a6:10:46b::9) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|PH7PR11MB6553:EE_ X-MS-Office365-Filtering-Correlation-Id: ed13638e-1516-4d5a-30d0-08dd3babf2dd X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|366016; X-Microsoft-Antispam-Message-Info: =?utf-8?B?YmtlRGYrZ0Y4NEg0ejhDK2NHZGltTnhuS2hPek5CeEFTeVVTdUl6bU1tSFZF?= =?utf-8?B?bWk4U0dyMDkvTmYxSmFmZHRaSi94NzBoeTdlbisrSWhDZS9LVG1BcGlrcXUx?= =?utf-8?B?R0dQWTE1UTZHUG1HR2VZZjAvTCtVWGtQQ3pDaE5ITHZ2YWlDckdWejdXYjhB?= =?utf-8?B?QnJhNmFmQ3VJVlU4R2luVUVEMVJYMms2amR4S0JjU0hLZElYOXRSOENqV0ZX?= =?utf-8?B?UWU4cUZsMzFHQisxZUhzUmphSnM0a3R5NVowNG9xTmVxOWlYODV2SUVYWXdL?= =?utf-8?B?VjI2L2lueXJ1QUp1ejd6cExOeHhjQ3BIcWZheElEeVhGMEVRQzNFMlRZc004?= =?utf-8?B?UDQ1RS9kRjlheUdzUjVUY2VOcEtBNElSSzRsNllIMklUSmsxNFNIV013ekt5?= =?utf-8?B?R1dvUW1nem5YRFdjSlpWMVo3Z3psNWpHQjZVR01VNGlHZ1BlL01CeEk5ZXM5?= =?utf-8?B?Mk11WElDWm54WDh5Y1RRSStpWGtYb3dVdlpxenovTldOaHVEcUxVVmZlOEhq?= =?utf-8?B?VVdIeTQ2aTJWMFRieTRBQ2tHSWkvZmxoSVVleGpRc3Y4K1NzanBRVDZaZWg5?= =?utf-8?B?c05yWktBWEpKL2RsSDJGekJFSG1CeFh2OUhQeUVHSzBjUWlrVlZTN1ZSZGth?= =?utf-8?B?V0d4K3BxL0FuWmRmWDVKM2hFT2ZGM3lzdi81OXBoRWMzMDdxYVg0SEthaVU5?= =?utf-8?B?NU1RRU1XNnNjeXAwU1JPOE5iN0lXM0NXenpqa3RGN1NQcFJyTjYwVXk3Y0U5?= =?utf-8?B?QTZWMkVVUmp1NGJkY0VLSTkxTHVqNi90RjJlWnp6UEhNNkhTQkxyTTNTYjBX?= =?utf-8?B?VUxmb3ljVlNFeGRBWVByb1FvSlVzenVkNjVabzJMNWhwWFFuOXM5Umc4NkFq?= =?utf-8?B?em52UG1EOG1kZW9ZQ3E3ZENsRThLUEdqRTRLNFJoTGdxdnFEdDVZMXh2VmpY?= =?utf-8?B?MHNWaEhXRlZpNis4YmdBTHBya01XclNGZDNNUGlsbWxUZXRPdHloVHJuUHhC?= =?utf-8?B?djJrZ3ZmUkpuOW9zTkp6aFN3QUM4ajFJUllpVDlqUURySUtjaVJMeVcyTzN1?= =?utf-8?B?SXAwcVJMdDBuUFRDVTdWcXNqYjlYWm9TMFFDMEJWdjFEOVZIdUZ3Q0UwVFE5?= =?utf-8?B?b1VXRGFrYitpVFlxRU9rV2pSTlV6K3R3dE5aT1FEMGxEcjUxc1M0TFV0TWhK?= =?utf-8?B?R0Y1L0pHcUphcHVSQ0Z2aFgrSWJHc0lRMVlrRkprcDlhSDdGYWJiVVNBT3Rh?= =?utf-8?B?bmZiV2NSbFhIc1Z2a3UxeVhvZFRpZWRvWHJ0a1oyelgwR2syeHhIVCtwY3A0?= =?utf-8?B?cnBRNTlVeUtqZVEyWkF6eU5OSkNUM0oyZlJQcDBjdHNrSzgrRzNGRXY3SUhZ?= =?utf-8?B?VjNselpvUUdGR1c5dFE2WmRGTi9PQ2Y1Z2pra3UxaisyZGN3YTE4Yk1DWWJ5?= =?utf-8?B?blFPa1R4MG1YRllEbDdRYVVXZ0x2bVppWnBTTndzcVRwd1hVS3dGR0ZnSE9t?= =?utf-8?B?QThnOXozVittMFNCY0VhQTJCcTlZLzRKSHpGN3N6UWdScGRYRnZwQkpONnBk?= =?utf-8?B?UndSQ0JiMUl5OWdSbnhZVzl6Zk56dmQzN1A1SjBrSElBdUxHMU0wTFllMnhq?= =?utf-8?B?TzhuSDhIUTdxajJ1ZVZ1d1kwNzRRK0lBR2pEaG5KaUhxUCsvU3lZbW5JMUEz?= =?utf-8?B?YW0xczVBSmdKcHZkdEUxUWtYZFU5V2I3K095WHZBTzhFejdmQm43WEdzN0l1?= =?utf-8?B?VkVxVlhuZHRYYVhlSnk3YWg3SFkwZEl6bFoweHdJMWwrankrV1BhMEJiWGdW?= =?utf-8?B?cU54WkswZTRqeGs5YlhGUjBUeFVWRUwrZFl1M280WnhMeGIxODBQK2NOR2hk?= =?utf-8?Q?t6EPhn/d8K3Gw?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(1800799024)(366016); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RExtb051dU1nVzRiNjN0Slg1NWZ2RDRwUkQxc1JydEJVNDZYcWcrNHZBbnVP?= =?utf-8?B?UmhGaXZmZW5ZcENobGtjbWpOZU80RVU5S281YUpGVU1TZ1kwVnhaYzYyN3RQ?= =?utf-8?B?MGtKZlJsMFRkc1EvSmFLcEV5RXZ1ZGdZNXFOa29NRUt2bXZCMUJzTHlweExU?= =?utf-8?B?eTRPVnNKQ2psVzJZazhNRFNEZ0kyb045T3NEeWxBV0xYZllJa0FwaEhxbWVZ?= =?utf-8?B?enpuWjFTc3dId1lGY1lvVmpmcyt2dENPYjBUOGRRMWhBamlNZGpnU3AzbVM1?= =?utf-8?B?RXQ5aG80OU9CbHNLYm83TDZ3R25ZZHlidGU3bjJSUDV6UzRhQVkvQ1ZyUllv?= =?utf-8?B?VmpOWHV2dVE2NGVDNU9uWXdWWmFKT1QyRVVadTBwTytvdnA3K2tnWXRZVjli?= =?utf-8?B?MUtaTWR2d0VNeU93VnhKV3ZtZFl2cEwzUzhrU2V5bGl2K2VZVFZpanNLcFpO?= =?utf-8?B?K2hNOVVFUUxwcUZRZEEzUnkwbTZIU3BvNWFDbWJZRjErQytaRFdjbExEaGdV?= =?utf-8?B?OEVmWEUyeFV3bVN5eXJQYi80YW1UckVEVGJ1WElDYzBPK0FFdlpjTDZ4QjNR?= =?utf-8?B?VEJ1N216WmMzNmlwQ0RwcDFmdVZQQ0w3Z2tTNE5oRlNWUE12bnVtd1c0YVk2?= =?utf-8?B?enpWcjNLVWxwUXZEQ1hTQ2dhWWRWVW1icEs3SkhRaDdVWGUxSDEvbDlLazJQ?= =?utf-8?B?OXh2NkJyNnJUSmlnMUZNdVE5YVBURml0aURsN0krWWtVdm5DN1ZyelQxZ0ZT?= =?utf-8?B?VmxWeXBvMTJGNHFpbjJGeUxBLzVOd1V3SjYyTnlwVzlqZ3psNHkreGZSdUpy?= =?utf-8?B?ZThNbEp2L0FTUkhyUk93YXpLaEc5SW9oOVNkZ1hpMmZvZXlVMnZPTEc0S3ds?= =?utf-8?B?VjR6Vk5XWTR3WmJLeHR1UTQ1WVZkYUZnOW92YzRpb3UxU3RVNEZuSDF5NjZn?= =?utf-8?B?K3gyUzUxY1BzRXprYlN5WlIwSlNJQkZVdmltZEExTVVjdGJndEpkNjVJcFBR?= =?utf-8?B?VWxSVnp6MittMlZZQnd5Ym50aEFzYm1vZ0xXeGd4b1dZRlYyUXFpTXN2TzBZ?= =?utf-8?B?a1RhZGV5d1FYem9Md1JZWml5dVcrZFhFdmRJbzFPaHc1WTVoTlpzMnhkOWVv?= =?utf-8?B?amdUZkR6S0VWeXllaU9zanh0a3dWNHRaSUpUaTB5dzMvK2pYQUtweTV5Ynps?= =?utf-8?B?T3UwdUtBZHFjdWcvQTY3SjVnQ2pNRzBhQnE5SmJBS2VNT3JQc3A0eTBRaDBY?= =?utf-8?B?S1hkNytSVG9hanFOQ2x6NURZdGh6VWwzbEVRN0lEaDl6OVRobWJiQ0t6Z040?= =?utf-8?B?ZnJkeURFZnZwWGRDMTFpNm5ueVE3bzJKelRvUS9UVVFXN0NxUjhFQ2NXVTZa?= =?utf-8?B?ZDR1dXFQSFF5SFdDeXBXcnVXSW5XamRtV2RJRml5TTNqdmtGQkh0eStLbnEv?= =?utf-8?B?RXo4UndQeC84Mmh1ekJ3S3R0akpoeHc5c3VSTWloMlFSSk5Gc3BZVC9TMzJX?= =?utf-8?B?cDhyTWNyeHhocUJBZlhheHRJcDhURmtyMEtsQjQxZEJEY3J1WDZTWUdubUtK?= =?utf-8?B?V2hEOW94Ly9zYVROQzhNdHJKRXU1MDJWZTZMSS9YVkpiTzRqQldBZEplbmFN?= =?utf-8?B?dktBNjdGbUJEbGRVSkNuZkJFb2FnSzdTOFFic0drTUw0NnovRW9vUWVpME5F?= =?utf-8?B?VzZ2ZmVhMUhobjdpT0Q4ZzZqWnBRQ0lQMGRPQ29LbXhpN1o0cExQZkI5R1U0?= =?utf-8?B?UWpwQW8vcGRvTVFzNlF6cUtYSHVVWXpKMFdRL2Y0WG1YbTFHdEpNdFd5WVVP?= =?utf-8?B?Q1A2ZzBoKy9mSCt3eUh3eDNjeDk0WkZEUlBCeXIra1FuWm1WUC9UQVczaGkw?= =?utf-8?B?MStOSHZ2OGpDTk1LSmQxMkQ2U2k2cVdQNmpvdmt2ZXR3OXlKRGxWTWhvQksx?= =?utf-8?B?UmhMMjdzR2tUVGlaY0xBT3IrVDJ3Ulk5ZThqU25qY3NFRENRQU1IdTUvMURY?= =?utf-8?B?cE9uNklSa29iQi9qRis1QU9FNWlTV1VZT0QwMXZOWVpiT1BZdUVqbEs3RzAy?= =?utf-8?B?c2hzWTFSeUJXbmJzWFd1MkplUjJGZHl0S2pnV1Y5R2lIcU1BZEdqYXkvbzJ2?= =?utf-8?B?Q25PTTByWEZjUHVQVEZTZVJIWWhxamVTd3N2OE5oZVpxaldCOHE4ajNuaG1B?= =?utf-8?B?ZFE9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: ed13638e-1516-4d5a-30d0-08dd3babf2dd X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jan 2025 12:46:25.7678 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: kqwOB2KCHTg6jQRXBRyGoqOuBXWj7VZSkt95eXVMXw7t29fk998H/fagpFb4rDYOpUtv+AMNKyd+OAgCH7yHUOU9r7r5sI5VThIkZytuDkg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB6553 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Jan 23, 2025 at 01:23:15PM +0100, David Marchand wrote: > Hello Bruce, > > On Wed, Jan 22, 2025 at 4:21 PM Andre Muezerie > wrote: > > > > v2: > > * Updated commit messages to follow standard format. > > > > This patch avoids warnings like the one below emitted by MSVC, and is > > needed to get the code to compile cleanly with MSVC. > > > > ../drivers/common/idpf/idpf_common_rxtx_avx512.c(139): > > warning C4098: 'idpf_singleq_rearm': > > 'void' function returning a value > > > > Andre Muezerie (2): > > drivers/common: fix void function returning a value > > drivers/net: fix void function returning a value > > > > drivers/common/idpf/idpf_common_rxtx_avx512.c | 12 ++++++++---- > > drivers/net/i40e/i40e_rxtx_vec_avx2.c | 2 +- > > drivers/net/i40e/i40e_rxtx_vec_avx512.c | 2 +- > > drivers/net/iavf/iavf_rxtx_vec_avx2.c | 2 +- > > drivers/net/ice/ice_rxtx_vec_avx2.c | 2 +- > > 5 files changed, 12 insertions(+), 8 deletions(-) > > I see the series is delegated to the main repo (Thomas). > > This touches only Intel drivers and the code deduplication effort you > started may conflict (though trivially) with such changes depending on > when it lands. > > Would you mind merging this fixes from Andre through the > next-net-intel tree, right now? > If so, please mark it as delegated to you in patchwork. > > > Thanks! > Hi David, the code deduplication effort patchsets are similarly delegated to the main repo. I was assuming this was deliberate, but perhaps it isn't? I'm ok to take these patches in next-net-intel, but just would like to confirm that neither you, Thomas or Stephen (as net maintainer) want to review the dedup work ahead of that initial merge? /Bruce