From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6157C45F7C; Thu, 23 Jan 2025 15:09:28 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3040D402E6; Thu, 23 Jan 2025 15:09:28 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.18]) by mails.dpdk.org (Postfix) with ESMTP id 3D15C40261 for ; Thu, 23 Jan 2025 15:09:24 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1737641366; x=1769177366; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=DLmLGJab2jc+icXuip5HxpkaAbObP2pJowLKvy5b9HM=; b=iKef9NfBtNV+Ukmy1SqYPT4a9RwSYs0oWaDSUNmT27kGD9Tp7W0sPPAC lghueqe/lGn0r7JB8N8kQlx3KItCf1/8z1IEliHjflR7nudGfyW+CWTgK qNOV6yrQ5JSyh/+lOvdVTPu9c67bZpXDcID32tvqneYa34dw1nd+If09o 4KVRt/nhsuGAcOASv46irq17RVFDykntECQqKdOUjCH34A8aB342Ok62l x1++E5arZKGfQhKvV9ieUwl1pDbAW6qF1UGILAPFG0OzteWEfxb9tNxJe uHGZBJw5XqmRfmgFLHgJKT0TOdUT0cF4/ZOhIFdO4QMjGFrY/gQyY7fC7 Q==; X-CSE-ConnectionGUID: E+nAP1vTQXWL0kAHEuY4IA== X-CSE-MsgGUID: NYI9TZQSTxyeGTV94VVyLA== X-IronPort-AV: E=McAfee;i="6700,10204,11314"; a="38240077" X-IronPort-AV: E=Sophos;i="6.12,310,1728975600"; d="scan'208";a="38240077" Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by orvoesa110.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jan 2025 06:09:24 -0800 X-CSE-ConnectionGUID: fMjfcVQ+Tp66jcdLzU2paw== X-CSE-MsgGUID: TY3zkJT7S1utyQGl5c8EpQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.13,228,1732608000"; d="scan'208";a="107386989" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmviesa007.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 23 Jan 2025 06:09:23 -0800 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.44; Thu, 23 Jan 2025 06:09:22 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.44 via Frontend Transport; Thu, 23 Jan 2025 06:09:22 -0800 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.48) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.44; Thu, 23 Jan 2025 06:09:22 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=dGGEVm0/jgqhYWoemE9GKUFRjbg/61lB7VKwt+MHcIruiAsk0kd/F9iPNnVwUUMPbHdUD+ECOStedgjzZpuafHx0eiXQpVvaB6Hu4nd02QanguYCZEEgeVANXQKf0HpvkasRozzmT4tA6oZS4PZqQpQVj84Iw7ccryPU8jiT1o+7Ce7e3mxk0ofXBvTAWRUsJRG/RGB0dxx5d6WCHyfgKQCJMua94rjppvcuq7mc0xApVjioOoI0o7iJhM1nLOMlnsu11+jKjGqim6MLKGGPdX8iNVyhAEow6LkdsWZLBUmAiYcmOkrJ5plZSTy4CmxnZZC4Esn9xc8Row4ZCLPrNQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=756K59TsJnl2TMEst4aecerJY46oMcTKifKMdeQSHjY=; b=kkdjVpkkr3wCBT4gqvQkfaa285aUm2AZB9vuJ7WlrHfz2UiNUpUauQ2jgI/fbu7AdPigLxAi0TLp+b5sUkuYO/o1RiLoi67QeY5ckUUS/IL8NVnaKF9PPRUdaO2GTulrS66Kwr7Sckt2rjRiGAzU1pTMz6iw//su5Ll8WGxCCdd9neHpuRj3uHWu1OLANZmkHHXR4d1jYR/mlUVkFJ7TJw2wImoH6HMxn4itc+v6vBvPmpUn/z3cCcU3wK6mqgOl+qKqaVZr/YmNnviltRLA4EqwZFXPXu1sPrLCLiw7JdNfqSnUlhrqn7eBxgLGt32vGVCwskGegur6WN5WLP2/Eg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by SA2PR11MB5146.namprd11.prod.outlook.com (2603:10b6:806:116::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8356.17; Thu, 23 Jan 2025 14:09:20 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%5]) with mapi id 15.20.8377.009; Thu, 23 Jan 2025 14:09:00 +0000 Date: Thu, 23 Jan 2025 14:08:37 +0000 From: Bruce Richardson To: David Marchand CC: , Andre Muezerie , , , Stephen Hemminger Subject: Re: [PATCH v2 0/2] fix void function returning a value Message-ID: References: <1735254890-18457-3-git-send-email-andremue@linux.microsoft.com> <1737559244-9107-1-git-send-email-andremue@linux.microsoft.com> Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: DU2PR04CA0194.eurprd04.prod.outlook.com (2603:10a6:10:28d::19) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|SA2PR11MB5146:EE_ X-MS-Office365-Filtering-Correlation-Id: d2085839-193f-439d-467d-08dd3bb770c7 X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|366016; X-Microsoft-Antispam-Message-Info: =?utf-8?B?dFNpSi9hc0xnQW40UkpQUGlxWDBLT1NzRnJRK3RVNjJaVWtERHFXM3hReGJ3?= =?utf-8?B?WTJCeEc4amFLVURUYzBaMExtendkZWdmTzlEeGNLTlF4RlplTFNMNzY4RUx0?= =?utf-8?B?cEhmcmRtRVJjZkRpYkM4NytuSC81R1oxaERFNloxOVFoUEhJRWV5bmR3Tmw4?= =?utf-8?B?R0xxVklTZ0V2RHUyS1NiRmI0R0Ixa2FmMHVRSzZRYit3SFVJMUdqSmlONDlp?= =?utf-8?B?S2Rsc0drVkEvN3JpUnZFTXh6TzBnTGJxTEMvcytKNGZBb2xidWVSYzRSV25s?= =?utf-8?B?L3VPSVJBZmpvZE1HWWlRcm80K2o5UExpOVVrZDVnWEpPN3h6MW51eGRLcUxm?= =?utf-8?B?R3hkOWJvVk5XYXl3RCtJMlZvN3Exajh3TnZKSVFvNU4rbWg5dDV3VnhKTFhD?= =?utf-8?B?OHlqSFdEWUxWWjB0d1ZyOFhaSE5sWGdHdTJ2NnIzQTVsa0s3cDVITUxzR3Zy?= =?utf-8?B?WlpwRzg2cU1mdWF2TVVhUmJzUjVlRjJZT29sUHJkYWJ6OVZmaUZzQ1pKZ3pK?= =?utf-8?B?OVFnSWJ5aWhRc2FSOTc4QXNsU2xEU29QKzVZcWRqWUU4TUM3VXoza1pkSEtR?= =?utf-8?B?K25HME1tMCtkZ2wxM2RJMStZR2V1UHp3U09MY1dVem5YdXBlUGxrNGFLQmo2?= =?utf-8?B?akZmQ09KQ2lueVR2WnNWMm52eWNudDhTbmRUNTZjZGVPRGx1cVFZUkZPNHh4?= =?utf-8?B?bDEwUTZuc1lUQmNweHhqS1BDbXN2VzVOL0cvTVRkOTFSVE5vRWJIVncyRUdZ?= =?utf-8?B?Q0RRaXpRYjhDa0hhQkN4U3VMa29rTkNZRGNpc05kWUk0dTVNTkNhRmo5MW1h?= =?utf-8?B?dkJTSGc5TWk0QjFFeEQ1dnU2VWNlcmVhUU52OXFhejVxempTd25yZnNnZjFq?= =?utf-8?B?Ukc1STJxNFN2V2xNL3I1MUc2cjcrdXZJUVY4c3N2c0FtK0V3UXB1UC9uRkxv?= =?utf-8?B?dUxVN0NyeWhiM2VvR1FYQk8wQ25kdFNrUU9WTkt6dkRkZ2Fid2pkZDZNSVV5?= =?utf-8?B?bEFzRWRqMHN1WS9RUGlKdjlNR3dUanhsbjY4cmFLQXdhc3BkNnFIVkhGOHlV?= =?utf-8?B?cXNqSjFCOG9CYmdpVXVldm5xTkdod3ZVc2plYnZBTEZnTnpPSEFEc25hbTAr?= =?utf-8?B?WmtZeXYrVmcxVWJMWHFuTmNkbFdmdmNCcFE4K0dwSUwvUGhqaTFYZFIyWm9W?= =?utf-8?B?emVlcndqTE5MLzVEcE41ZkQ1M0tkVFJpbzQxQzh6UldtNEJRRm0zT2dYRVVL?= =?utf-8?B?aXBIU0VVQnRNbGdRemZEdHBHb3dMZWdROXZMUEtwS0ZRUzJVS3l3R2JCanUz?= =?utf-8?B?WncxdlVRN2tyV2UxVzZwVG1aZjBsT3pFcXNUc3RkclZ0a2tvaUp1YXVHeHZy?= =?utf-8?B?OWM2RDVEM2VKR0FxcGlqeWhkY0ZRSGhMUUVITDdOQk9zaTlSaFF2V2FsOHlR?= =?utf-8?B?MnpDMTBCSmp3NWVNNkVaanRSSGZDSU5lZUdpVWVJSHpLOGZsaGtaT2tCVXFZ?= =?utf-8?B?L1g2VUFKYkxwT1JmNG1QUEhZaEZXL1c0Nm5ocTZJNS9MejVpangrZmJVZHlX?= =?utf-8?B?elpOaTUydERPMngxeTFNWlNkZ3NoMmRYamVzTVAxUjh1aStMOGsxdjFNZGlE?= =?utf-8?B?cTBDMVQxRXNxU3V2R3B3SVB0L0xOaENjSDd5YTZWMGxQLzlmSFFPL0YzdWh0?= =?utf-8?B?QmFoeS9BUEhrWHMvUWhxYWMxdE03emdncU5YYVBWRkZMYzZmYjNzcTV6a2N5?= =?utf-8?B?eGhqK01PZG9zL01XRFJsd1N1S0ExMmgvY3FObGVwbEUxZ2ZiRlh0dUliMkM4?= =?utf-8?B?c0luckhHdlZhZnk3dlJiUT09?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(1800799024)(366016); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?R1R2cjdzc2dKMWUyRXVLZmRMYjVkNVlrWHdmTU1BK1RUbHA5SVZDcGNPNG0r?= =?utf-8?B?Uy9URFV5aUVQM0hPT0MyR1owVXpJRWtzSmd0dGlQV2ZqcmxhZ1RwVlVaS0Fs?= =?utf-8?B?MTNBd0xaRVNJZG1CdGd2TFF0MGovOG4rbVhJZmhsV29IenNmZ3MvM0U2Q01S?= =?utf-8?B?dlJ3RVU2Wkw4c3FxR3B5cU9JL3RGTzkxZmhKZVNoUnZaTStFWXEwYnkya1Rz?= =?utf-8?B?VmxEZHc2ZHlucXZJSFBCSjRDaG9ud3MyYytWbVVIWmFqZnZwdXFZYTBwOEgv?= =?utf-8?B?UlNOSmVNS2diYjNvQWpPVWkwUFgwSDZqa0l2VURVZXlVWVhldW1CT1oxbFor?= =?utf-8?B?dVNNSU5LVjFqN0Z3UW9FTzZSMTdyWm5hWjdXM2JaZXViNEJUcGVUaEpTZ09a?= =?utf-8?B?VkI2U1RXb3Iva0o0bkE4dlFNbGJCUnp3WkU3aUtPOWZqYTZRSEdWMlBjMjBi?= =?utf-8?B?WWV2VlBoZWgveU92Q1dCUXlEVVlWTlZaaGlCMmNZbFlNeWNnbDltZzk2bDJD?= =?utf-8?B?QWhkZ1craGszUUtrbjV1cHhLUnVJTlV5U3Zmc2hCWDEvem8wbll3Q3hFdEpG?= =?utf-8?B?QmltU3RGUlh2dFJzWlh3RXFXc1ZTaDdzTy9FaXdKSTlrZ2dFNUt4Q2VwUkJq?= =?utf-8?B?a0hlSUNrM2duWkUzQSs2emNCK2tYSDhmY0VzQ1hITWx0WUc5VWFsVWJ3aGJ4?= =?utf-8?B?V21ScHZ6VmJnMThMdjczZk14RlVNLzBTeTV6VTgzOXd3TTc4Z0o4N3hNOW9i?= =?utf-8?B?MHJjSkFCQmtRMDVuc2xHU1E2NDJYYkw1akl4cExFNklGODlTdllTeDFNWEww?= =?utf-8?B?bXRsVkY2UEs4dzJFTkxsYkQ1Yy82Ry9RNkxFbDFDcEVONXpGU2xDTHh2SWdi?= =?utf-8?B?V0Q2Q2RLdlFoOGlZTEEwNkZzdFJHTWxRN1Rub2dRdEFkai9Ybm52L253OHhQ?= =?utf-8?B?bWJwY0RHNUFQU0xmTVRoOHNoWHJqeUNFYnpkMWVWUjliSWxmTEQxSEtoRTls?= =?utf-8?B?bHdNazYrbHhUdmZrWThFc1FoYWlobVFycDkrYk10MmdmZWpjN0xhQjU2cnlH?= =?utf-8?B?M1E0dzJBUnpOMVMvU0FKaDhmTFpUVE1RM1p6Y05kclJETE02alRCUWErQ01P?= =?utf-8?B?RmpvNG44T2pINU15S1VOSG43ZlZuNEk5Y2IvR1dWckJGeERNd1JOQjdaZEM5?= =?utf-8?B?OURzeHlLWS9HQm5qdkFCUTE3aFA3NVlyRkhRTnVHR1R6V2tqQ3B0S1QvRDlv?= =?utf-8?B?NnR0YzJTNTM4cUFZWEV0TGlSMjhYTVVRZ240VGpMMi9OWWVGMjQvakdDN0xH?= =?utf-8?B?WHFieUhhQWx2UDd3MnJJVHNoa0pPc1NYd1lHNFJLOXhTcFZWcjFueEw3VEwr?= =?utf-8?B?Q2JPL1dGT29MVjFjcXRFTU5id3FvOTV0bE1jSzgra09MVEtyNjNaWWlzM1ZJ?= =?utf-8?B?eFVZU2E1YmpCWDE0QnIwQjVxb2tqdUdlN0NVSUFqV3ZrRC82UHFVUzUxTGJr?= =?utf-8?B?Y2FUZEIwQmZqRnMyU1RsVVB5T25kWnFQNHp1ZndYMWNkWDFzdWJCaHEveFRs?= =?utf-8?B?dDYwYTdRdlpETGhpSmZiWXF0VUIyb1lBQmxhaENwU0NRR3Z0cGxtNXZ1M0ZR?= =?utf-8?B?bzJMT2NqNkdzQUp5WUs0YlBqVDZBeDNuSXpxVTVvNWpmWTEwVnBRT1YybWpj?= =?utf-8?B?TGtzTTlFUHdCajNVcUtvb2VjNjhzY3JCS0N6bnZnbHN4MVJXblpGU1RCV1NV?= =?utf-8?B?NkZoWjd6VzRmQUVhdkxsT3AwM3JmaGhBNERBc0UwV2xLR2RZY0dDVlZrRGxI?= =?utf-8?B?RUQ5NHpkNytmK3dvcElVMFcramJEcDJlNWVPcG1uNGZFZUxUazVLOGMwWmIv?= =?utf-8?B?MW1nTFJXdkFZaG5WVUxoa3RrQXM3d2NSR2hCcGlSWDlVMTlicitJWFdtSGZD?= =?utf-8?B?R3NmVmcySFZtY1lndGlodzk2Q0VIN3oxeW1RTS9vY3lzdkRmcktKVmJQellG?= =?utf-8?B?UFN6TWZHU0hFaU81cXdyb1VmV1NsODBTY1BlL0F2ZmNxaEo3SUM5RkdxSVp2?= =?utf-8?B?R2N2R09MNjNtWlVicC96RWVsdTB0MGsrd05UTWpiSHhwYVJOejlRL0FZWERj?= =?utf-8?B?SjRQejVGTkttOUdJL2F6d2dpUUxHZ0VQOEdWSWhScjg2aVQvWFUyaTA2T1dS?= =?utf-8?B?R1E9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: d2085839-193f-439d-467d-08dd3bb770c7 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jan 2025 14:09:00.6901 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: W6FjD+9s3PRJVYPfOjylU+3iDGyOH1Ojerq5XxEFCBC6tmxUsa5gZaWdAnSXEZfeZv+wVD5h6SAToaG4rO34V3G/U8Y+5WtITqSdcH5IEj4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB5146 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Jan 23, 2025 at 02:03:29PM +0100, David Marchand wrote: > On Thu, Jan 23, 2025 at 1:46 PM Bruce Richardson > wrote: > > > > On Thu, Jan 23, 2025 at 01:23:15PM +0100, David Marchand wrote: > > > Hello Bruce, > > > > > > On Wed, Jan 22, 2025 at 4:21 PM Andre Muezerie > > > wrote: > > > > > > > > v2: > > > > * Updated commit messages to follow standard format. > > > > > > > > This patch avoids warnings like the one below emitted by MSVC, and is > > > > needed to get the code to compile cleanly with MSVC. > > > > > > > > ../drivers/common/idpf/idpf_common_rxtx_avx512.c(139): > > > > warning C4098: 'idpf_singleq_rearm': > > > > 'void' function returning a value > > > > > > > > Andre Muezerie (2): > > > > drivers/common: fix void function returning a value > > > > drivers/net: fix void function returning a value > > > > > > > > drivers/common/idpf/idpf_common_rxtx_avx512.c | 12 ++++++++---- > > > > drivers/net/i40e/i40e_rxtx_vec_avx2.c | 2 +- > > > > drivers/net/i40e/i40e_rxtx_vec_avx512.c | 2 +- > > > > drivers/net/iavf/iavf_rxtx_vec_avx2.c | 2 +- > > > > drivers/net/ice/ice_rxtx_vec_avx2.c | 2 +- > > > > 5 files changed, 12 insertions(+), 8 deletions(-) > > > > > > I see the series is delegated to the main repo (Thomas). > > > > > > This touches only Intel drivers and the code deduplication effort you > > > started may conflict (though trivially) with such changes depending on > > > when it lands. > > > > > > Would you mind merging this fixes from Andre through the > > > next-net-intel tree, right now? > > > If so, please mark it as delegated to you in patchwork. > > > > > > > > > Thanks! > > > > > Hi David, > > > > the code deduplication effort patchsets are similarly delegated to the main > > repo. I was assuming this was deliberate, but perhaps it isn't? I'm ok to > > I suspect it was delegated to main because of the change on > devtools/check-git-log.sh. > But it is really only about net driver changes, so it should go either > through your or Stephen tree. > (we have enough patches waiting in main ;-)) > I'm ok to take it in my tree, unless Stephen would rather in his tree. > > > take these patches in next-net-intel, but just would like to confirm that > > neither you, Thomas or Stephen (as net maintainer) want to review the dedup > > work ahead of that initial merge? > > I don't have an objection on this series (on the contrary, I am quite > happy to see such effort). > I'll have a deeper look at it, this afternoon. > Thanks. I'm having it[1] reviewed internally, but I'd appreciate even a cursory review, especially at the new directory layout and build implications, from the higher-level directory maintainers. /Bruce [1] https://patches.dpdk.org/project/dpdk/list/?series=34398