From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C0279460CA; Thu, 23 Jan 2025 15:36:33 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 51A3E4028A; Thu, 23 Jan 2025 15:36:33 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.9]) by mails.dpdk.org (Postfix) with ESMTP id A4C1840261 for ; Thu, 23 Jan 2025 15:36:30 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1737642991; x=1769178991; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=jI0uYQ6KB9jhK+Is+Hp35MdKDRer1rgd1zEozFdIuqs=; b=aCVbLGE5i0sg5141Bm2NtUfAgdMz/9dbpOr7Jno0H4ybFJEmY2/LzRyy pDNokBRsDhfReCHyeBTPTclg4H2fbYpWcpzKjK2arr3RAI8mT83B4M04q sKOdYJu1x4/4u6ZlDK9IxkkErxTu+8FsDSnZSG4rfuMpzK9NB6CLyMhMC xtSd7qxx0h1wu6UuU/Kc8d0C8Bbw0cbpoYfKZNhbM1WaSLV+HYn/PYEEu +yRtKQvqeHiN8KkGjejzAB/rBdceuVVjsdB5JrqbRAV9TytvDTo7EoxHc bB5lo6azwzKsge7w4hZhuIwRGAf472SpYi+3Bi/o0zYV3oXjkC9tfAo8k A==; X-CSE-ConnectionGUID: nmQ+BCS9QUCPth30WJNPcw== X-CSE-MsgGUID: zZFk2zY7TSiizf44eSJ31Q== X-IronPort-AV: E=McAfee;i="6700,10204,11324"; a="48809081" X-IronPort-AV: E=Sophos;i="6.13,228,1732608000"; d="scan'208";a="48809081" Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by fmvoesa103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jan 2025 06:36:29 -0800 X-CSE-ConnectionGUID: WiuEnxfXTriVo6Kz2KO1KA== X-CSE-MsgGUID: DRklwWBLQFyou4eHSSakXQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,224,1728975600"; d="scan'208";a="130765725" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmviesa002.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 23 Jan 2025 06:36:29 -0800 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.44; Thu, 23 Jan 2025 06:36:28 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.44 via Frontend Transport; Thu, 23 Jan 2025 06:36:28 -0800 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.40) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.44; Thu, 23 Jan 2025 06:36:27 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=XZwEMn4SCgLJgX6G7Q9AtZ305W4DOIcK4nP/9WLRKTtln+AScdF/WvOrjR8xrlWKZmrqhK4cST/pbK++vzjT5EJ7ZGNfTZle9IsHAeHo9zNYs4NVZ6h2BXZiXgVB4xVcuy9vR3QTnFqZZYCVU5fzPjFNzHK0HcE5Lm8CPFEqbFFrVqx5p/RUCQ3gHttApFOWQoOpzDgQN3m1Miyt4VvKAx5OgeKxioGDmPpN/VdB1/KZQmzhCQ/B9GBaXzj9MhSTDDzGwzQMjJJvOGjfKWW8tbHd6jOdCS8xlTyBKJd0N536UB+3X737O74OaY42obyY8j9uJKhdVEjlzAgVfPtFtA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uoXn5XgZKQhYhwckjuQHQYvxPGHP8eWQCRGIJ51rum8=; b=g+Zh3s+c+Jr386OanwPRPqxHo+TAyZZYD7SnTsUOsDtpyQFLlxpId97itXltwDEu1Kk73dQO8NDCpbvFcDeQMnug9ZZphh7LKgFBghkPI7fMFl2wXvZUsWxmr39piO1m54+hl2v5v6HD+1V0b+jx80OhE/++EbI3GnurcCI1JeyfhrntLHgOFkMwRcQA1lN5PtFeUdANHNFu8VrqxmBbNg/76Na3NJBHaF2HVAn67CG/u0M98e2mTJCHtKYPgf+AlTeGUzUy2z+bvU94NSx/Xil5Ify6wWoMZzU0nYoJVBx3ibZR86VNPjpIMKmWmjLEnV4zieyqHdRFIjRazMQ26Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by CH3PR11MB8434.namprd11.prod.outlook.com (2603:10b6:610:176::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8377.17; Thu, 23 Jan 2025 14:36:04 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%5]) with mapi id 15.20.8377.009; Thu, 23 Jan 2025 14:36:04 +0000 Date: Thu, 23 Jan 2025 14:35:58 +0000 From: Bruce Richardson To: David Marchand CC: Thomas Monjalon , , Konstantin Ananyev , David Christensen , Wathsala Vithanage , Praveen Shetty , Ian Stokes , "Vladimir Medvedkin" , Anatoly Burakov , Jingjing Wu , Rosen Xu , Robin Jarry Subject: Re: [PATCH v5 01/25] net: move intel drivers to intel subdirectory Message-ID: References: <20241122125418.2857301-1-bruce.richardson@intel.com> <20250120120016.1530274-1-bruce.richardson@intel.com> <20250120120016.1530274-2-bruce.richardson@intel.com> Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: DU2PR04CA0319.eurprd04.prod.outlook.com (2603:10a6:10:2b5::24) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|CH3PR11MB8434:EE_ X-MS-Office365-Filtering-Correlation-Id: 13ccb466-3499-4809-a7b9-08dd3bbb43ee X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?VGlpMTdpSU1sSHBpVXBGY3BWWnljUlpwU0FJeWdEbE16ZERNOTJlbUZWNmV6?= =?utf-8?B?SmphZTF5YlozVFFtakt4UkFyMExpOXZhUFlHVzR5dlVhRHB3eDQyMS9nYjdZ?= =?utf-8?B?c01abkQ4SUZrTGRrMlNmem1jbW5WYmlDMHowdE5ESmgrRVpoSGFwczl1cEtV?= =?utf-8?B?QmV2WjBuSmc5dnJmQTNIWGhMQkZFd2tVTUpxUllkMitML2t5cGtGenpVUEk4?= =?utf-8?B?cG1PR3ZtcDQyZ3gxTHZ5RVA2dnp4UytIbjJheUxVcUg4eTNLa25QcEZqOUM5?= =?utf-8?B?aWxtUUppSXVPU2IweEs2TTZNMWtPdlp6czcwTnJsK1pSKzdGYlU5R1pURlRR?= =?utf-8?B?a3BOV3FCTGtTeFlEcTVBRmlaTkw5ZW9DbXcyQXY4MHZvUnQxNHBBOEdXcmxE?= =?utf-8?B?NmZROVlUQlp4cGlqc2hQVDFyZ0pUOGRDelhFYjJMdVNmWDl6OU1FeklwQndF?= =?utf-8?B?b0NGRmdpaGNDRlFMemIrMy9MY0dzS2IyczJDZHhwUkFuYXQ4U05PSU9ROUph?= =?utf-8?B?SmtMU1ZIMVRWc0M4RmxjR0hHeXdiZCthZGc2TXZJVlVFbnBacVhMYlJ4ZDY5?= =?utf-8?B?WFc5TUpheElSUjMzQjYwM0tKUzJ2T3pEWGU2LzRKMjhtWnBjcGIzRzl0bzhD?= =?utf-8?B?MlJhQVlQYnR5ZVhmMU1EU2NvbG4rNTkvejFyMU82c0I5Q3BGMVdIc1NBbCs1?= =?utf-8?B?Y1QrRU5CcEI5TlNEb2NIS1RKcGpjaTlzNmdXLzZ4N1Q5NkFBemMxeWlDd0Jw?= =?utf-8?B?TVhIQTc5WmxCQkpSSzBUZFRBR2tmMnp6R1ZCWFZRc1pNREdYWXAwUm92cWN4?= =?utf-8?B?VVpPTXcrak54amoxRWp1ajZmdktGajVNRHR0S0s3cENDOUZrVWpvMVNqVUZu?= =?utf-8?B?cnlUSFU0MGNpdko1MkNjdW1GeWhxZmkvT1dZZ1JSK0s4ekNjNVluWG1laGNM?= =?utf-8?B?dzh5UFQ1UXdydjVNUE5mQzBSbUlwdHVaMXVsRkRQMW5NRk0rYisrUDJ3Q1gw?= =?utf-8?B?bmV6TUc0VW0yMTlwRk9rTVRDYVNRUllLQ3FQbHgvMW5yQUkxVXFoYms5NjdV?= =?utf-8?B?KzJHbWFpZEdpVnE1djFaWlZDWGFFT3B0U3g1Zkl6eFR3ank5NmEwL2t3YllL?= =?utf-8?B?Mzg3WEJPUGFQaCszRGVLdk1BYTBnN0FxVU9VT1NyUDdjNmI0TWw4THpQWGJv?= =?utf-8?B?TkViWk1BZ0k2YkVPR0I2RXRralVLbEIrdzA1cThFQUtQODVEUlF4S1NBZEhD?= =?utf-8?B?ZHkvekJJL2JJU0xOMFgvTlhYRWhLYVYya09QU1ZGK3FQaGdCRGVqc242WG5t?= =?utf-8?B?UjFJK280aHArS3pCLzlDYUFONGNSYXcvVGtZVlJqbkZnNFNPMDljMXpBMTYw?= =?utf-8?B?QVN1cmdaNzREeHFZWXB2YUhkbGJ0NXQvd0x6Z1VXTjBBSHR3TXdac2dpdjdq?= =?utf-8?B?R0p2a25mVXNucTAyMnhaa05LNmFrbjh5SGdVVUk0UENHM0draGdEbW5RMjZ2?= =?utf-8?B?TTNaM1Y4Uy8rTXZ2YzBNVHpiaDdGZ0NMaVAySU5tdWl1OS85SnF2bE9hT0c2?= =?utf-8?B?bG5VZFhxbDVvZ3dPRTlkNWlQaFYvUDZyNzNCQnJGQVdkaEN3bVV0c2s2c1c4?= =?utf-8?B?azJZOGJNd3Y1bUpFbzJaMzdkSytWMjFqaXNHNnBtOGNnQnZpemtITzMvZE05?= =?utf-8?B?bWRnWmFGWWt3ck5FMHhzaXhuV2svSGw1YndiVnd6emd0Ti9iR1RvUERUdzZ2?= =?utf-8?B?QUtiWHhZNW45aXIvbUp1VGIxZDk5SjlCOFQ1Q2V0cFJycERRQis2TlRocVJl?= =?utf-8?B?TVYreXRKWVY3ME05TFNSQXNLcVZSK0lCZUgwMlNFZ2FOWEU2NTBScVVjN0o4?= =?utf-8?Q?5P53TAzP7XozC?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(376014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ckJ3azdOQVcxUnZsb0pjSlNYMEVoVkhaa2FmekJjcTBPVExjb2IvcmxYZDNu?= =?utf-8?B?MXBxazEzZUsramlkT3hqREJLMEFyZWd0SmliQjZ6V0hmNWt1T2ZDZmVXRnJT?= =?utf-8?B?by9lQTN5SlpFcnN6dnZ6SFZwOUJkWThUYWFWREtIbzdtOFp1bksyRzZ6N29B?= =?utf-8?B?WGxMNnoxY1hCZTMzZlRkRnJHYWUvK1RqTEZ4Szlna1FUckZDeXNLSXBWZU9S?= =?utf-8?B?aWxrMURxOGs2VE1BUWpkYjRrT241M2FsSCtnNVlNdEZnWTduS2NNS09KcGVI?= =?utf-8?B?UzhFa1BEUUFSNGhpQTBwS0hRVDhXY3JRWTd1TWdzMVp5TkJLZGVhamsvcFFG?= =?utf-8?B?ZFhUQjFrT2Y4TWZjeTJFNWl2K3pUYlJoLy82UjFJY2NLT3d3Z29seUJyWCtV?= =?utf-8?B?c3pDU2RHSnhVY0lSUmF2ZlZtbDRFa0QybWNkZGkxTnUvSVRiNTVkWlpwRFV1?= =?utf-8?B?QmV2SW8yVDZvekJzbG9HbEEyd1UzRVJGR2N5aDVGSkR3SXlsRDF1RHd4MUJP?= =?utf-8?B?VG9QMWZFcDdGTVZERlROMy8wTEFxd1AvcGRGUE1FR3AwOUFJYjE3YU1ycURu?= =?utf-8?B?cGcxOGQwblYvVkkzYVRaUmNVdHRLK0NET3BqNUtUN3ZrOEdhY1dtL2tRZTJk?= =?utf-8?B?SUpZRktaZFBrQXVSaWh1LzRocGlYa2w2SHNaMFRiQ1VJQ3lCOG5KV1lyN1J5?= =?utf-8?B?Q0gyaGUrUGxpVzBLb2VwQnBnelhKMjBNSWdTR21hS3RXdEI3N04rRUQ2ejN4?= =?utf-8?B?alJMZmhaeTVKcVZ3eDg5NEJXMmFOSVBmNkdSOHBUdkVUaG52MWkrR3U3dERk?= =?utf-8?B?ZDM4R2MxYkZtaHArazBCdXBOck1VTm5WQXVzdHVSdVM5YWdRTFZHelRrM0Vo?= =?utf-8?B?SVZ1TW5BOE9Md0Q5WUsyZGFub2Q1VVV5YU9QODZEYUM0VTlVMDlHMys1ekJy?= =?utf-8?B?aHJiUFpBeHhLUlo5cmhlUCtFb0l0eHZOUlVMSkxuQ1NNajh5VjdlWjJ4akZN?= =?utf-8?B?R0pQcFd2cHMyZm5iaHkyMFd2cVZuaVVOWGowS1E4dllFQmZaSU5SSmx1KzYr?= =?utf-8?B?ei9Mazc5bVc3c25CZ2J0cUVBcjk2dEwxWTMrQmpZYTNPNVA0TzBBZjVrMHJr?= =?utf-8?B?SktKOWowSzJoMWtoZmRtSEZZOHhRZEppejU4QkM2bktwN1VWZVFDOHhxd1pn?= =?utf-8?B?NE0vTnlxMC9Qanh5Mm1zL3cyREUrMTI4d1RGbGJQSURWYWFQME9TREU0YzVR?= =?utf-8?B?S0ZIeXRtNVVYVU1sMzdtSG0wR2V1cHVHdmp5aUZhblVURjFyTDgvZDNKQ05m?= =?utf-8?B?SnJRQzZUYVl1MUl6VytUQzZMNytXVnhuRkF5alBzWVh6Z0srdUNDajFselhi?= =?utf-8?B?enpvMjVsdlBsa2ZJcDErY3lZRWJWblQrWUxITUluVHRwZXdBQ003azdmdGVx?= =?utf-8?B?Mi9rUUJMTU9DK2RuRzcyUWhLamhqR1g2VGllQ1lJS0o1anZ1UWpZUnlIU3p3?= =?utf-8?B?WFh2K3ZQRkdmb1BEOUg5YzdST3YybTg3SUtUczNjV092RzRFRkloaGdrcWpX?= =?utf-8?B?NnJjOWIvaEJjcEtvYmpsL0FvQzdkTHlxRTZBUWFVRURqU0RUTUJhQ3dZN2Nz?= =?utf-8?B?eHhuSVlORVA2cFZ4M3FreUFrZ1c0WjYrOXFzWVN3bFlEbnQvZEtvT05vNnhp?= =?utf-8?B?SUN5dURLRkdEWTdJNXdoMVg4Rmw0TDZhODJERWhJWFlwaDJ5NXdlWmFoWUpT?= =?utf-8?B?dmRORzRHUTYxRnVkOEtTTjlOclpBcnJBS1lIVTRIWVd1NXF3R21CTTg1bDdm?= =?utf-8?B?cGh2eEpLMUZUWU9PR0xwa0xyTnNEaEJ2T2dZSkp5UXBLSUtFRURKUCtvQ3Ix?= =?utf-8?B?b0R5L1pMd2FWYmRDYWlJQ29KVDlmL1phLzBLa0NWT0F2UmdBTlZnZlg1UnJy?= =?utf-8?B?MHJHaGQ3SzlrU1FNcU9RT1o0UmMyVXIwNStqUG40VzlYbDgxUWtHTGoxdVg3?= =?utf-8?B?empDc2NSd0pGeHUyNHE4Nm43a0JxT0ZTQkVEZTU5RjJHV2Fldk9jVXFJdVVX?= =?utf-8?B?SzBnaGR4RStaUDFSQVJJSDBSZFFqdTFWcGRLazFGYktwQXEvVkprVnNiMnhY?= =?utf-8?B?TmZoa041VDFUYkhjZ2gzOGFQZDBadHhjZ1gzSklhUmRNUGRiWFpGMDFiU0ov?= =?utf-8?B?Vnc9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 13ccb466-3499-4809-a7b9-08dd3bbb43ee X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jan 2025 14:36:04.3440 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: PWgl0EUwt9n+CiSr9b8TRkmROckyu+VSz5DpFyDsSBrRlfYHzDZuAhnjYSaQWt8k3sktpVOLa/hggygIvqNHxifKaVZHrRqTHFUgiXcB/Hw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB8434 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Jan 23, 2025 at 03:16:40PM +0100, David Marchand wrote: > Hello Bruce, Thomas, > > On Mon, Jan 20, 2025 at 1:00 PM Bruce Richardson > wrote: > > > > Consolidate all Intel HW NIC drivers into a driver/net/intel This > > matches the layout used for drivers in the kernel, and potentially > > enabling easier sharing among drivers. > > > > Signed-off-by: Bruce Richardson > > - This deserves a RN entry has it impacts how users select compiled drivers. > > > - Trying to select net/intel/* triggers a meson error: > > $ meson configure build -Denable_drivers=net/intel/* > $ ninja -C build > ... > Message: drivers/net/intel/i40e: Defining dependency "net_i40e" > > ../drivers/net/intel/iavf/meson.build:33:46: ERROR: Unknown variable > "static_rte_common_iavf". > Thanks for catching that. I suspect in my testing with intel/* I also added common/iavf out of habit! Will fix in v6. > A full log can be found at > /home/dmarchan/git/pub/dpdk.org/dedup/build/meson-logs/meson-log.txt > FAILED: build.ninja > /usr/bin/meson --internal regenerate /home/dmarchan/git/pub/dpdk.org/dedup . > > > - I see some remaining references to the old path. One is to be fixed: > doc/guides/nics/ice.rst: These ICE_DBG_XXX are defined in > ``drivers/net/ice/base/ice_type.h``. > Ack, will fix. > > - Thomas, please have a look at this part. > > On the check-git-log.sh update, we will have many warnings with current update. > > Wrong headline prefix: > net/intel/common: add pkt reassembly fn for intel drivers > net/intel/common: provide common Tx entry structures > net/intel/common: add Tx mbuf ring replenish fn > net/intel: align Tx queue struct field names > net/intel: add prefix for driver-specific structs > net/intel/common: merge ice and i40e Tx queue struct > net/iavf: use common Tx queue structure > net/ixgbe: use common Tx queue structure > net/intel/common: pack Tx queue structure > net/intel/common: add post-Tx buffer free function > net/intel/common: add Tx buffer free fn for AVX-512 > net/iavf: use common Tx free fn for AVX-512 > net/ice: move Tx queue mbuf cleanup fn to common > net/iavf: use common Tx queue mbuf cleanup fn > net/ice: use vector SW ring for all vector paths > net/intel/common: remove unneeded code > net/intel/common: create common mbuf initializer fn > net/intel/common: extract common Rx vector criteria > > Invalid patch(es) found - checked 25 patches > > I tried to tweak this a bit, with the following heuristic: > * if touching only net/intel/common, accept net/intel/common: > * if touching multiple drivers under net/intel, then accept net/intel: > as prefix, > * if touching some net/intel/$drv (and optionnally net/intel/common), > accept net/$drv, > > diff --git a/devtools/check-git-log.sh b/devtools/check-git-log.sh > index b2da013f6c..41c290f0ca 100755 > --- a/devtools/check-git-log.sh > +++ b/devtools/check-git-log.sh > @@ -79,11 +79,18 @@ bad=$(for commit in $commits ; do > [ -z "$(echo "$files" | grep -v '^\(drivers\|doc\|config\)/')" ] || > continue > drv=$(echo "$files" | grep '^drivers/' | cut -d "/" -f 2,3 | sort -u) > - # for drivers/net/intel/* use 2nd and 4th fields not 2nd and 3rd > if [ "$drv" = "net/intel" ] ; then > - drv=$(echo "$files" | grep '^drivers/' | cut -d "/" -f > 2,4 | sort -u) > + drvgrp="net/intel" > + drv=$(echo "$files" | grep '^drivers/' | grep -v > '^drivers/net/intel/common' | > + cut -d "/" -f 2,4 | sort -u) > + if [ $(echo "$drv" | wc -l) -eq 0 ] ; then > + drv='net/intel/common:' > + elif [ $(echo "$drv" | wc -l) -gt 1 ] ; then > + drv='net/intel:' > + fi > + else > + drvgrp=$(echo "$drv" | cut -d "/" -f 1 | uniq) > fi > - drvgrp=$(echo "$drv" | cut -d "/" -f 1 | uniq) > if [ $(echo "$drvgrp" | wc -l) -gt 1 ] ; then > echo "$headline" | grep -v '^drivers:' > elif [ $(echo "$drv" | wc -l) -gt 1 ] ; then > > Which then complains on patches in this series that touch many drivers > (but have net/intel/common: as prefix where I would suggest net/intel: > instead). > I tend to disagree with this suggestion. I think that a prefix can be valid so long as the prefix matches at least one component in the patch. For example, for the first patch in the set, I think net/intel/common is a better prefix than just "net/intel". I don't massively object to your suggestion, I just prefer patches identify the most relevant component, if possible, rather than generalities. > Wrong headline prefix: > net/intel/common: add pkt reassembly fn for intel drivers > net/intel/common: provide common Tx entry structures > net/intel/common: add Tx mbuf ring replenish fn > net/intel/common: merge ice and i40e Tx queue struct > net/intel/common: pack Tx queue structure > net/intel/common: add post-Tx buffer free function > net/intel/common: add Tx buffer free fn for AVX-512 > net/iavf: use common Tx free fn for AVX-512 > net/iavf: use common Tx queue mbuf cleanup fn > net/intel/common: remove unneeded code > net/intel/common: create common mbuf initializer fn > net/intel/common: extract common Rx vector criteria > > > > -- > David Marchand >