From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 717B94611C; Fri, 24 Jan 2025 10:25:04 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 40D7D40E11; Fri, 24 Jan 2025 10:25:04 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) by mails.dpdk.org (Postfix) with ESMTP id ECBE6402E9 for ; Fri, 24 Jan 2025 10:25:01 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1737710703; x=1769246703; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=BgdvcZxNnWNCo8LKo9IlldLLksVzp1ZbrpBzBYEUWRo=; b=FE30HBZcmzT+LpJC67CxrFZdWHsqL7UQ2lTsMc2Tj4Jwi2q8Mv4fHef4 Gq+XhrcLrtJXV/jX5DEwMYm58/3Eoluh70MoQqRdEjDqkMt6G3pDnqv28 eTFonLyyNHmDgFLKSQDWSd0bXOngKRHKyGr2SOWAE150zQ4HfAZW1XORD x54iTBgjNfXKynB6b4wfwK2iSkS5LEJmnpwPEddAW0OVhfJAHHHY/icxB V4ktZY1ehawFFwMQXcjW6DYajqf5TFTXAhaGUtvU/d/V5W8+J/gk7Yqlo 3IPRO2aU12iNg7rz2GEBATR1mbhXzC9RdEM7+q1uCcJfHU/rKZZKqpPPE A==; X-CSE-ConnectionGUID: /3ulbE4vRz6GsouiE/zVAg== X-CSE-MsgGUID: zy4rD2a1S6u6Jt1Wu2BHTA== X-IronPort-AV: E=McAfee;i="6700,10204,11324"; a="60705153" X-IronPort-AV: E=Sophos;i="6.13,230,1732608000"; d="scan'208";a="60705153" Received: from orviesa009.jf.intel.com ([10.64.159.149]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Jan 2025 01:25:01 -0800 X-CSE-ConnectionGUID: AGTACRgSSnu03jl8+fvdGQ== X-CSE-MsgGUID: Frvrcm1ZR8OBeeFB1JWSkA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.13,230,1732608000"; d="scan'208";a="107528063" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orviesa009.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 24 Jan 2025 01:25:01 -0800 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.44; Fri, 24 Jan 2025 01:25:00 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.44 via Frontend Transport; Fri, 24 Jan 2025 01:25:00 -0800 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.177) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.44; Fri, 24 Jan 2025 01:25:00 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=mxdQ6i5rD/XMatQsIE/qGLn9RFPQGjgiVxytL6nb08Y4srtQNdPRQnoDjDqCvZuq78aw9CyqWpmGNRdix4a9ophdUMs4NAPdAKCu9XFJImwYM8ua0konMQ7zlFyNK+QxJ3dnQ6TzND682uN1ILmOZk7/whv9odS1g9OuB+ROPKTjwFGt+rTVK8Bmbx4Cxv7U8hRsozhQr7J4JE1PL0sGLsWfE4fvLMAakoGW0XiKklKqSzX1vxQyEhIScwSInDaK7lpqb52f/CVi2rxEN+UQyptGDsaRKas6P0UpNwW8EGuKA4GO8PNebGipBGXsEFZB74AYJbXdUrAv+dcMW36P4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lZMmx9lEzlPMeIyzco36Zv2qCkFyZc5mhO92XanUS6A=; b=pnQHpnVfk8e4/LlOT8WGOIj/jreEo0iB7YoXI8DkY8rHrV/iwrpw298h6JTJ65LQSgMCZXRfwA5CTO6CinaDE6LiTdj2sP+0nRtucNWwA2a0hz4y2uBo1kaW1Ot5tzM/F+jxCQmSPboGJOnOdGGPQwYFT+dbXMl1qpQZ14OsUwl/C/jols5PhQZNTkVkLT0UifWdh5kZiFffr8oOLTNLIdlx0WA/AC1aA3l9PSP0+p5k0a9In3qcNviEp95SWTdyIia6iS1g4koUe3r1aTUTS59NZ7Y6fX4BddkUDOym4TayikvG8kZeETH88+4XmZO3+S0kTZgzcUTQJA6EqOmC1g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by DM4PR11MB5993.namprd11.prod.outlook.com (2603:10b6:8:5c::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8377.16; Fri, 24 Jan 2025 09:24:58 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%5]) with mapi id 15.20.8377.009; Fri, 24 Jan 2025 09:24:58 +0000 Date: Fri, 24 Jan 2025 09:24:54 +0000 From: Bruce Richardson To: David Marchand CC: , Ian Stokes , Anatoly Burakov Subject: Re: [PATCH v5 07/25] net/intel/common: merge ice and i40e Tx queue struct Message-ID: References: <20241122125418.2857301-1-bruce.richardson@intel.com> <20250120120016.1530274-1-bruce.richardson@intel.com> <20250120120016.1530274-8-bruce.richardson@intel.com> Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: DUZPR01CA0287.eurprd01.prod.exchangelabs.com (2603:10a6:10:4b7::29) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|DM4PR11MB5993:EE_ X-MS-Office365-Filtering-Correlation-Id: 962c58d5-2a1e-463a-5006-08dd3c58f874 X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|366016|1800799024; X-Microsoft-Antispam-Message-Info: =?utf-8?B?U0EzVFNkTDdXbXphaC9ZdnpkYTJ6RW1tSGpHNklxMVVOMDV6Y2V5N1Z5MDdQ?= =?utf-8?B?TjgzOTh2ZFBFQ1ExZUJnN3ptbmJLdEsrQ2Q2R2JqQnYvUTNTaFVxek9BVTlr?= =?utf-8?B?aUJIYnJSYkJjZFA4cXM4bzR1Y1pYTGZrM0FCYnRVMTByZXBneXd0QlI2aVpW?= =?utf-8?B?N3RWZzZiVzBQYzJnSkFETG45Wi9Ha2s2MTJNUlRsUFlCdk9meStNOUhxZ2d3?= =?utf-8?B?MURPQ1ltaFBLMzZkMXlLTXRmODhUN2ZqNmt4VU1xbmZqbEJsVkY0SEsxSmgy?= =?utf-8?B?S3h1d1NwSTRGUG4xUWVCUzkvYnkvQ1JhNDNiUHF0UHdrdk9hM2JQZHYrMTk1?= =?utf-8?B?K0NuV0FsNW1oS0YrTTh1NVRWM1F6Y1M0VUx0NjlvM3N6K0V6d0VZWG04bDV5?= =?utf-8?B?SWlUVjhiYVVyNVNPNWJBaU1JSjR6U1NnYUlaYkFDNitvZjJjdkZLZWIrcFk3?= =?utf-8?B?WW0rT1RvRWJwSGJtdHErQVEzUzF6SDU4eFR2UFJzMHRoejVodjFUMkEza3Fj?= =?utf-8?B?eEc4bTVsa2RyY0JaVEppYXc5bG9wd3l2NzhJZjl0aVFGK25GVitPMm9rUUpE?= =?utf-8?B?R0VzK0dtdUtCSFVsaStjbUtJeUh1SnNRQlhVMW9TTlhNaWkwLzAvbEZLbEhy?= =?utf-8?B?eVVWcldzUjNtN3lhYm5tM2dpNVFlUHVkd3ErUHdpRmZCdjJRUW9hT3dvMmR6?= =?utf-8?B?ZkF1ZkJLamRKL0oyTmV3L29PWUNKSk9uMkJ3cWtuT2k2Wjhyd25BcVpxeHc4?= =?utf-8?B?WTM5dW02aVg1MUN1ZG1IZXFwbkgrb1VpRkVHY0Ntc0ZhTGRWa2NHalZZYlRs?= =?utf-8?B?VkRkb29LMGtka1RDSk9UUU1uVHI3WXRzTmxCZFpCM1RrUk1qUTRVcXhUZHhU?= =?utf-8?B?OUdZTGlXR2xCYmNPWU9NcFFsRzlSRmZmSVNnalRCQm9iMkdSNURxZ2Nmc29P?= =?utf-8?B?STNhaXVFREg4Q0pWZHZNdDFyMzZYaXdVNWZlZHhjSnhNM1k0em1iT1R2T2hk?= =?utf-8?B?azNLRHdxRFg5azFNa25jZ0xRQUI2b0ZYVFI2WjlRYzdjWlNGVVIvMXlaQUxZ?= =?utf-8?B?MFpTQUt6TjVxaHVoWWRjRDJEY0hyblJiUS9FcUtNL0gvYUJVQ2RMa0ZPNEtY?= =?utf-8?B?MDB6ald0RHBrdTBUNGtTcFlRTS9xY2Erd0lSWFNoajVlbWkxdklkM0VFTDhZ?= =?utf-8?B?eUFySDNjZUJ6QldBNmJ4M0E1OWd4Vm5IcndFeW5TR2d3UXdTaExINUZPcnhh?= =?utf-8?B?VkZncm1HSTZUVG5yYy8wOFV3a25OTGZaTHVoRHQ2Y0pIOWc4MDByTHBDZXFk?= =?utf-8?B?dEVNbFIwR2h2YStIZUFkb1FicUNxYXN5ZmxCcGJUUkpwYy9GalNKanBveldh?= =?utf-8?B?aFZBclN3ZWZwNGNZLzd3UElkenlaT2NPemQzTVlQSTZZWnVwc2o4eldRK1hj?= =?utf-8?B?UEdNbXVmMFNCUkpUZjNONUV3Uzh2OUpkc0tGWWFkRkNhTEpKRGZVNExWN2FN?= =?utf-8?B?K1EvWElUZFo0UVFVM1Z6U3Y5VU9kQzdOeWVoS3ZZUGFUNjRyWXNQV2IybGg4?= =?utf-8?B?SVJ2K3VoSmc0U3ZGZ3YzUXFOT2hSTXpVT2pTWFhSVlNhbnBhc2MwNHJPbWh0?= =?utf-8?B?eDgva2tYSU1rL01vTSt4amhKUDlVREZVWThXNE81blF4QnY2Y2g3blI4Zllq?= =?utf-8?B?UjdxTC8vcE9UMlB5c1RqajBKa25oSndPVHY5eUxKRHhGcDAyd0Y2ZWFDWktM?= =?utf-8?B?OTlQZEVnUGFOWlFnS1ROSk9qQlFlRFNsc3QxWXc1YVNiQjJqRzlDT0pxa2kz?= =?utf-8?B?SXBZMXpvVkdQUU5acXQvNjFabXIrUEZCUnFiY3BlL243Z1NENThsbUNCelRL?= =?utf-8?Q?vD7V+gAbmwHTW?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(366016)(1800799024); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Ym1OK3JaK05SNnF6L2IzdW9mdEZZWW5yRERhdGhNK3pHNkw5RkFDSmpiK3Fn?= =?utf-8?B?S2lnZ3JtTTFtRlJRNndyTUZjd0tOV21zbk4zdEtiZ3dlUC8yWVZpM1VQeFUr?= =?utf-8?B?SVd6VXBsUmdoeGY1WGhmNWxXcERXTGNBVlhHWnlsK0R4ajJtaGJDMnZ1L3dz?= =?utf-8?B?bUd2a3BOaWFvbnpObytJaU5PR2h0U0dPOC9TOGJCZ2pBVEM0MXBGN0Z3ZGFL?= =?utf-8?B?OUZ0WFRLMmpDZ0ZBbHJTQk9IUUd2QzIzTWJoak9JeGdWRUxXaGlrVUc2enBm?= =?utf-8?B?dHVLTWR3akZJU2xFT2lwQlZCaFlLekozek9UNEFKcUQ3ZW1uVjBweGg2N1V0?= =?utf-8?B?SFJtcEN4TEd4TlczVzJHdTZpc3N6c1R0RHBhUDJhTXZ5OGEyeHdjb0xFQlhs?= =?utf-8?B?NE4wejlwSmhKa2xkNVMrOUVDVzRjV0JLZTMwTHlkTEljVDc2SElvTDdUR3E5?= =?utf-8?B?YzdnVy84SGZYMlltMk5JcS9YWXVjZG8vR0FpenJDVjhaZlZCTWUrcjU0SmVm?= =?utf-8?B?bGRJdGQzWG90bGVYSllnWEtZc3RlcDVvVjdpdXFvZDhySjF4NEFuQzhQcGVP?= =?utf-8?B?Mm1qUXZWbW5YMWRuUThvaXk5cGJOcldrMERlMVlDRFlKemdoclBNbStkMUJV?= =?utf-8?B?MnQvUzdaMnhIKytiYm9uUG1KNUJJQUppejROMmIvR1VpQzZtU2JVL1hoNmt4?= =?utf-8?B?OGNDcStjemtqRStieHRSMit0OXptM250MS9DbGNibmpYZ0dXUXRGM3d1Z0FV?= =?utf-8?B?OG1qaTVONWlTa0k1ZlkxYm1aamhLWUVsSnU3dWdBMVJTOGI5dW9wRFZZVkQx?= =?utf-8?B?Qy9FNHNvcXdQTkxLTG53c0hidlZoZ3ZuVnZDYkRpaUlKRy9MRGc2QmxJWWJV?= =?utf-8?B?T24rbzBlU1VlMzhjcVlsaTEyNmF5dDNOcFAwTTVuaDZJbEZNaDEzWTd4b2xt?= =?utf-8?B?MUJXZkVGM2xDVlh2WmxqNnBQVnRlYlYycHZLek1PcVRYSTVCaEhreng5RWUz?= =?utf-8?B?UTFxbzUxS2dWcVh6UjNvRkJvLzVVcGQ0ODBmVURiYXhvMmFIU2pHdHd1aGp1?= =?utf-8?B?STBncXVGZ0haS1dwVFZSUXJJaWpYT3hVbmxQMjFNdTZuVjhaRmhjUTNONXhD?= =?utf-8?B?ckxDMjBucFlHMVMwTVQwT2JwMXJ2MEJDZlFNUjJzd21vT1JkUDB5cFVIbC9z?= =?utf-8?B?eU5pYWRXc0ZvZkxieElSeGxwUERPMzF0eGJMMVl0RTEwd2F6QlBuS2pYSVR1?= =?utf-8?B?NE53dVREbWJUZ3g1TjNpYVVXVDh2dnEyWXhXYkxNWjJicy9BNlFPWTJ4eUwv?= =?utf-8?B?MHhTLzNpWnhST1J0Q3ovM3RwYitKK0Q5WkQwNnp5ZjZ2ZE1KbjFUaVRTZUJl?= =?utf-8?B?WFUySFNmejZLVW9wWXM0amg3K0hJUWNTaGVOdURBSVYxYVFia1c0T1JSMyt1?= =?utf-8?B?TEhJYTJ4NXRZc1VNczBGa1VxbnhQOHZhUVZCZFhtQVcwdzVXR1RpeUZtUXJt?= =?utf-8?B?VWd0ZWlGbkRVRG9naFBKYjEvQkJwb1NGcityQWcwV2JFRjNpNVBxdEdmRnFr?= =?utf-8?B?ZXpvcEFLQ2JSeDZlMHlDcDFYWmVQOEpIUHBvaUVHZCs3TVM2SW5pMkRSVzdT?= =?utf-8?B?dUExQlVSWHZ4RkVuaFhPbnBqRzBsbHlqd0UvZUZuazJJM2E5K0RkbnhpUzdD?= =?utf-8?B?V3l3VUE3Rms2enlVRXFIZkZ4d29WMml4czMwSlBwMU1OY2w1dmR3aWpKTGo4?= =?utf-8?B?Y1ZzU2RYTXBzUHdCdmpRT01OaDdXS3g2amlvUEZtcTR5VlFkN014QmRPbCta?= =?utf-8?B?REsrZnhvcUU1Zm43SHd1MUtKZ1ErczNtbGdQbmhLREdrRVNudlVJQ3J5MUta?= =?utf-8?B?K3k1WkV5M096VnFHVm1rbk42SXh6WGp4OEE0N3R1NVBjbElWSXg2c2VqK2V5?= =?utf-8?B?Vkt4MHk4cEEzcHRRbUowR0plMnl4MG9PWDhsKzNwUjJyb2JjWU5CZWxwdmdX?= =?utf-8?B?OGtqL3J3cmhRYXdWR242U2RXQXQvMktUSFYyUHdrMUI3UnVRQnRiRnFvWmRQ?= =?utf-8?B?U0R6K1VIaUY5UmpraVFwSWN1S0s3SnVmSG1oNXBrRjRZOTJyZXhrR0ZwY0RZ?= =?utf-8?B?MjJrUFVQMnlEVWZpdERGYVNsamQyK2JxWWcreUVENWd6MWh2bU9oU21kcUhC?= =?utf-8?B?NkE9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 962c58d5-2a1e-463a-5006-08dd3c58f874 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jan 2025 09:24:58.0869 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Wbax3SbpV8/pG+uMfRBTK01LTgaVSGaNgcEB8viFy/zbJRM3oyBTm40sWGiUBAlMtXZ5bUdchNrIB8dwxM6/M25all7TEMMQbRPFG01H4qA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5993 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Jan 24, 2025 at 09:39:13AM +0100, David Marchand wrote: > On Mon, Jan 20, 2025 at 1:00 PM Bruce Richardson > wrote: > > > > The queue structures of i40e and ice drivers are virtually identical, so > > merge them into a common struct. This should allow easier function > > merging in future using that common struct. > > > > Signed-off-by: Bruce Richardson > > --- > > drivers/net/intel/common/tx.h | 55 +++++++++++++++++ > > drivers/net/intel/i40e/i40e_ethdev.c | 4 +- > > drivers/net/intel/i40e/i40e_ethdev.h | 4 +- > > drivers/net/intel/i40e/i40e_fdir.c | 4 +- > > .../i40e/i40e_recycle_mbufs_vec_common.c | 2 +- > > drivers/net/intel/i40e/i40e_rxtx.c | 58 +++++++++--------- > > drivers/net/intel/i40e/i40e_rxtx.h | 50 ++-------------- > > .../net/intel/i40e/i40e_rxtx_vec_altivec.c | 4 +- > > drivers/net/intel/i40e/i40e_rxtx_vec_avx2.c | 4 +- > > drivers/net/intel/i40e/i40e_rxtx_vec_avx512.c | 6 +- > > drivers/net/intel/i40e/i40e_rxtx_vec_common.h | 2 +- > > drivers/net/intel/i40e/i40e_rxtx_vec_neon.c | 4 +- > > drivers/net/intel/i40e/i40e_rxtx_vec_sse.c | 4 +- > > drivers/net/intel/ice/ice_dcf.c | 4 +- > > drivers/net/intel/ice/ice_dcf_ethdev.c | 10 ++-- > > drivers/net/intel/ice/ice_diagnose.c | 2 +- > > drivers/net/intel/ice/ice_ethdev.c | 2 +- > > drivers/net/intel/ice/ice_ethdev.h | 4 +- > > drivers/net/intel/ice/ice_rxtx.c | 60 +++++++++---------- > > drivers/net/intel/ice/ice_rxtx.h | 41 +------------ > > drivers/net/intel/ice/ice_rxtx_vec_avx2.c | 4 +- > > drivers/net/intel/ice/ice_rxtx_vec_avx512.c | 8 +-- > > drivers/net/intel/ice/ice_rxtx_vec_common.h | 8 +-- > > drivers/net/intel/ice/ice_rxtx_vec_sse.c | 6 +- > > 24 files changed, 165 insertions(+), 185 deletions(-) > > > > diff --git a/drivers/net/intel/common/tx.h b/drivers/net/intel/common/tx.h > > index 5397007411..c965f5ee6c 100644 > > --- a/drivers/net/intel/common/tx.h > > +++ b/drivers/net/intel/common/tx.h > > @@ -8,6 +8,9 @@ > > #include > > #include > > > > +/* forward declaration of the common intel (ci) queue structure */ > > +struct ci_tx_queue; > > + > > /** > > * Structure associated with each descriptor of the TX ring of a TX queue. > > */ > > @@ -24,6 +27,58 @@ struct ci_tx_entry_vec { > > struct rte_mbuf *mbuf; /* mbuf associated with TX desc, if any. */ > > }; > > > > +typedef void (*ice_tx_release_mbufs_t)(struct ci_tx_queue *txq); > > + > > +struct ci_tx_queue { > > + union { /* TX ring virtual address */ > > + volatile struct ice_tx_desc *ice_tx_ring; > > + volatile struct i40e_tx_desc *i40e_tx_ring; > > + }; > > Minor nit.. this gets alphabetically sorted in a later patch. > Right. I'll get that sorted (pun very much intended!) in v6. :-) /Bruce