From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BC6274611C; Fri, 24 Jan 2025 10:30:31 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4596040E11; Fri, 24 Jan 2025 10:30:31 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) by mails.dpdk.org (Postfix) with ESMTP id 2105F402E9 for ; Fri, 24 Jan 2025 10:30:29 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1737711030; x=1769247030; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=Nw/5L5CQ51NJVzB6B9sMrmDa+m7w69NJouenrZSTSR0=; b=nQpcTKWUeNm6ryp7UEo77Mwc3cPmNbxtSQRbZjzecGnh1h2Hlu/D6rIK 6xzjWFZOHe4tOLhjNcDccqmM8R9MPNivYP3WgERjzWJxfI7/ul+IGqSV7 c2yZPoUAhyiXeqgFhXYre+qgQs4hYjYrA3N7XUBCyx8C6K+OIb1wbGQTn aQGCuPs2muHelzNZ0iarQQwjEWv7tMSHyru69L0t3/2JV4dCX9IONGbVf nJBemDrnVZiEBXLwn5BBgXVkIMKAuUznzZY2PR32Ez+U4o7sWZxEZnfBE BDkViE7dMjzGwjGbXysrRkgVSDaY5Fa6M4K2g5BLHwwScGv0E39Utcg75 Q==; X-CSE-ConnectionGUID: zFhdiZLgQYizDgr0Ctn01w== X-CSE-MsgGUID: lTR7h9V0RjC+KuT+E24PqQ== X-IronPort-AV: E=McAfee;i="6700,10204,11324"; a="60705973" X-IronPort-AV: E=Sophos;i="6.13,230,1732608000"; d="scan'208";a="60705973" Received: from fmviesa010.fm.intel.com ([10.60.135.150]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Jan 2025 01:30:29 -0800 X-CSE-ConnectionGUID: BxsBEVQKRVqWrDE79RJKKA== X-CSE-MsgGUID: b+cCZ01NTOmc5LZ54Z5MtA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.13,230,1732608000"; d="scan'208";a="108265427" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmviesa010.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 24 Jan 2025 01:30:29 -0800 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.44; Fri, 24 Jan 2025 01:30:28 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.44 via Frontend Transport; Fri, 24 Jan 2025 01:30:28 -0800 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.174) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.44; Fri, 24 Jan 2025 01:30:28 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=RKaBbcZWdPRDqwRRyjMmizCTo2mb8uJcYFUFr9113Gjk/3qcc7EuO4Um0jr2XB3xpaoFC+/30s7NdWDVqVDPZ+wdybYFTCSxXeHvqF5pPB/9n1Lvv2cYKO1qH+bppS5mkzKxNdHoG+gFu8d+HWz1LbLoqYNxbLh57QE1kjreWgeIOaDowuD8OI1cEvYQ6WfFYxZsdEmKTBb2AHmiADOss0jcPMmxHSaPvbohAPH6dDWhL2FvEjUuxyaRclVK8X4Q3wHzreU86nHem3SPKbYBd3SDDT8BbE5OwtMghQSPh7Qs97q3M0fPyVoX/MsH0nQa6OV+WyPo0RdSu2smePo2ug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dQP8izTlTQj1k1rESAEFC+h1cDp6kmXPfxFl0r1mTH8=; b=SpEXw+hB9oJkM/guFTTx3e3bcjiGaEDTdr7jqoFD6/CdVhC9LZjKQmqEpH2SYd15ugn5d0HURDQrcbcPCfhAXVvWAZotQeKpw6Q1ac2viCnjMAA6HZv//QMurU/Mu2awnADsvNKlPB98y1UlHsYpoQBiMOpkuRYVDj9IJVYcGXfunPuejkq9xwGKhBkMnB8YksiVhEI8xzseqlgneJUPIMIVB+79gowf1BK30mAsD7VWzRz00ijDx79GfKzMdMv08H+UUs6eynrXLYzxn/u1tbWSH1pZhU0dD4uDCIXERlm8WGbgVl4ETnkMdwAGFjbZp9otjEmm6XHMDggX+LI0JA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by DM4PR11MB5993.namprd11.prod.outlook.com (2603:10b6:8:5c::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8377.16; Fri, 24 Jan 2025 09:29:54 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%5]) with mapi id 15.20.8377.009; Fri, 24 Jan 2025 09:29:54 +0000 Date: Fri, 24 Jan 2025 09:29:50 +0000 From: Bruce Richardson To: David Marchand CC: , Thomas Monjalon , Stephen Hemminger Subject: Re: [PATCH v5 00/25] Reduce code duplication across Intel NIC drivers Message-ID: References: <20241122125418.2857301-1-bruce.richardson@intel.com> <20250120120016.1530274-1-bruce.richardson@intel.com> Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: DUZPR01CA0241.eurprd01.prod.exchangelabs.com (2603:10a6:10:4b5::24) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|DM4PR11MB5993:EE_ X-MS-Office365-Filtering-Correlation-Id: 92292596-d1bd-4fa3-ba50-08dd3c59a8fd X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|366016|1800799024; X-Microsoft-Antispam-Message-Info: =?utf-8?B?Ym1PUElhWjU0azdQSVRGbHcrbU1pWHVRTjBsUDBLc3JKa3V6Rm93bWpkVzBC?= =?utf-8?B?eHVaZ0hGQ2hJSHYrR0RkZXAyQlNoTlV5QkJ0R1I2YUtFbndLNTBhekdXTE1m?= =?utf-8?B?djdpOGhWNTMrdVk0bXFRVGJiWFFyb2pOMFB6aUpaOXRVMGFjVlJKTXI1RGpN?= =?utf-8?B?UVh4WW1tcWxrdDdUZ1NWaVhkVEtWOXpJVnJpT1FwMEFqMlp5WHJtOFlzSDhu?= =?utf-8?B?cU83Qjg3WjNMVlNZajBUekRMSTRTZDV5K2FzcUZUaDNLOTJ1bmkwVEtqK0V1?= =?utf-8?B?cEZRNStsdHl2aXdZQzhyNHplZmNwMkxuaEt2bURKd0ZrNjhheTZHeWxqV2Er?= =?utf-8?B?WWNnSnBqVWhlODBBWjhIK09ZRkNoZnZzL0VQbExDTEJWR3hPSWkrclZmc0xZ?= =?utf-8?B?N1ZmVU9RNEZkSFZWUU5HTkIwN1ZzZHU5dDZsZjJuRkh1L3I0WHVhQW81NFd3?= =?utf-8?B?RDFYTjlKVWFveVo2dWlrNi9xVzNDc3I3OFYvR1RuUTNzWDYycDVwZlFDOWY5?= =?utf-8?B?ckFMa0JpYldlbFNXVTA5LzNzMDlPdUpSSmVIR3Mwa0V5K1YvMnExWFRUQk1E?= =?utf-8?B?VU5yc1JXdGwrYlZWaCtwcFl0QjZXRG5YSFREVmQ1RmJpcmpzc0g4Mnc4UG1W?= =?utf-8?B?dUdjNHFLVWlzUXFYd2lLRlo2MkFjZUJiWnpYM0hWZUZRMC90YmQrUXZ4RVNO?= =?utf-8?B?TzYxT3RXdmx4UUhnVWhmTHFEdTNXN0hEbGZXZ01iVkdBMlNKTUVGMG5lanJR?= =?utf-8?B?ZzhydFZ6d2tUK283ekpBWWlTWXZNaE54dnFxc3BlbXhIQUZSbnhSNUVDUnRp?= =?utf-8?B?RzJFMDR0Z1pnV3ZjMEEyQms0NFdTcUxwc1dpMnRjOE1KeWI4b0dxakl1NkYx?= =?utf-8?B?cFpZc1p2d1BDK3o4R05KZXlpQXdGcnBwbUJwU2pFeUErNmovd2EvQjdHSmpi?= =?utf-8?B?YUlLaEtQR2RualJsZGlWWnludGJUQlIraXZDUWpFMTNRenJnVHNZMEFyWHlH?= =?utf-8?B?MnkzZXRsdXZwbmYwZDRLaStvUHNSVXpKQWdQNjBtaHhZSFd2ZFFsankyT20v?= =?utf-8?B?QWJMMUtYQlpFSFhTYTd6a0hKNC83QkthaFNJa2U3bmhXbW1abGNGYytKMFp0?= =?utf-8?B?ckMxbXN3MzJPTFNQQURsV2h3RDYzb2grTEplTnVGUHBwUmQ4dGlLSGYwMDVM?= =?utf-8?B?bTYzR0FXeisySXEvSTFLbS9tRm5YMW9ZSTV6d0RHTUc1RVBVRFhuTW5RdVNu?= =?utf-8?B?bDB3N29nVW9ueStpdThCdzFaR1dmM0VPUFVYWEkrYzZ0NlBYZVdaZUJqWlAx?= =?utf-8?B?b21LdGZTdWowMm5TdGF1SGVJYjJSdGxNai80MTRpM2MzbytwMEtzR040a1JM?= =?utf-8?B?OXc3L2F0K1ZndFIrOVRRMko5d29DWXNZY3ZobWFnVWEzZmpJajhTRE5aVUEr?= =?utf-8?B?OUdVMXpvejVLUHdYYVo0U1dNbmJyc2FueFpmY3VLM3hoZG1sWCtrS25yY0Ew?= =?utf-8?B?V0s5L0JrLzl6VmFoMyt2T0dIOWREVFpRN2NNUjNkVWhZanduamNHWllaaHM0?= =?utf-8?B?eVU4TFdaUmxJY013L2NvNmRvT1ZMRnBZazFEL2hSR1MwYW9zZmExQnYwY2tU?= =?utf-8?B?QVozMnp3ZHRMTXZtanRFM0lHZFFiQjJSeVYwQkh5c3hRQzZTTHlWWVhsUmxT?= =?utf-8?B?c2tuUm1kNnRVQmMxTDduZ3kzYnA5N3BIYXJYNVlDRGpkUUtrMyt0MVlENWlx?= =?utf-8?B?RDJKZFpLZCtSZGgzcS82OHhSKzBQWGtBa1kveGpMQWo1TUdneXd4UjZhS1lr?= =?utf-8?B?S3ZaQWtOWFNhS1JDMDV6ODZEQlQvbitReVg0MEN1U0VmOUpvelhJN21QOTZY?= =?utf-8?Q?nyW2N6enod75f?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(366016)(1800799024); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VGdqS0wzQU1VQjdVK2RCamdpSXZnS1V4WkdsNmFiaG9TbENaSUQwWStpRk9p?= =?utf-8?B?K2J3dTNXZnZrSm95SWRicmlPdktLYTlJLy80alB4RnZBcWh6c3kvOE5PQnZG?= =?utf-8?B?RzFEZnR5MHpLYTZDWFV1cy9VK2hjTWxzcFFTNHBoYUNhbWdxZ0tXMG5oOHlp?= =?utf-8?B?SlhRWWNvc2crTTFwb29SWlVjSWRQUHZ4c0tmaktKaUYyMEQyRllhZEZpNHNW?= =?utf-8?B?VjhMU0RZYWtTcUNUeWZFdXdjdUhJUDdjTkRwd3d3eFZ1eENhdGR6T0RDTlBi?= =?utf-8?B?bldPbWRSYmVORXZ4SVlmSmVlSWVrWTZEaXlOQk5obzJJSUFhVzZhRk5qQW4x?= =?utf-8?B?eHAra2Y0SGhoQm9HbitFYnI3SzE0ZGpGNWc2QjltWjR6R3haWmhPaUlJc2Ns?= =?utf-8?B?OGxBVjFkczBXZXBmbzFIVkUyYys4VSt6c0dnUWEwU2dyN3kvUlBSK2w3dGpB?= =?utf-8?B?ZHd6OVNxQ1lITTFMUlhCY1d0UFFVL1R4Sy8zYTlhNC9CWENwelVVeEs0ME1R?= =?utf-8?B?VHBEaXdBYXFkVUt4OWc4SzZ5QWppRnN0TXNzaG1nNlJwakRSVjU5bC9wWEUv?= =?utf-8?B?V21ERnJMUXBCSGp3UmVuRkhJWGcrWWNmc1MvdFFGa0c2dVNPMTdjeWZSaXBZ?= =?utf-8?B?Ylgwcm9vd3RhQXIrQXZFS2gyMnYxOS84dmx6UHAzYkR2QWVkVWZ0SmNkUlpZ?= =?utf-8?B?ZGQzbVdRT1BsMW0rbDFmM2lKMXQ1QVZJdHZCSHF3QzNSdkVleFp0M1hGLzBR?= =?utf-8?B?RzFZaWpsUlgvM1l0ZzcvbnNBRVEyNWJvWm84NXdNeGk2alVUY2pSZXliSmEy?= =?utf-8?B?Ym8yY05xVWpRMmJqWEk5SE5wN2FpOHNzS0tXM3dWZUc1Mzk2aWF1amk4V0hF?= =?utf-8?B?VE9helRia2J0bEwzemRmamd1VEtvVGpSOVBVbENCdlk1T2JFWmROVXhPWTc2?= =?utf-8?B?aHdWY1ZOU2lacFozUGQxRmU5SGYxeVRQbVpydzRTbStMaVRPZ3luaTI0bXlC?= =?utf-8?B?eWN4bVpZNTVZSDExZlRwakdESjNMbGlBZGJzM1ZtSWhuVm5ydGk4VFhxUzVy?= =?utf-8?B?MVlRUlJWQklHckZnb2N0SktqOHROOS95eEl5MUIyV2FyZXl3Y04yREtESjQ4?= =?utf-8?B?VkticFVZSzRJSStpWm9GNU4xMS9VODI1WEwwZ2NWUmQvVXNabWtnWVAvR05q?= =?utf-8?B?YndSN1NxaTJWVk03M2JaeFcrcEJqVG9XTFRNdTB2WG5iQ2pzMC8rZU9KeU5p?= =?utf-8?B?a3JHT1RjZ3JtQjRRYnQveXEwTTdNUXdSTnN0djRDbitubVVYblJqSGRlWjdI?= =?utf-8?B?VStxdW43Wk96RGk4NXFUeC9sZi9sUGtJVG4xbTR3aGlDSUQ0dDFMOUZWTG5N?= =?utf-8?B?WExlclZxbDRQLy9yZnlBVHZnS0U0RUxUK1dldlR2VmtrSU1HQ3Z0eWtUVUU5?= =?utf-8?B?Q0xOS3VpVnN2c28wU1JGSHAyakFPbVhmUGZLeEVWZ2NBZ09vTlZRd2k3QkpY?= =?utf-8?B?QU52L2FTa3RJbmpUbGVaZWFZRDc2OVdGZlNoRTFjNUxGaW1MWWRwbDFQaFBT?= =?utf-8?B?UThyTGVRb0F3TjUxV1ZUQzUxN2J4WW9YM3BVcnd2STNLd1B4Yk0zNG13NzNC?= =?utf-8?B?aXg1S3pxQ25OeXpXblJKYjNPc1pPY3U3TGw4bTRWekJJSzMvcFB6ZzMxSlg5?= =?utf-8?B?RTF0M29tYmxGMmlPTFIwYm1hMGowT0VqY2ZXcU5IZmMya1lFcEpRY0doNU1a?= =?utf-8?B?alFwajJtdzc1VmlzQmFOUmRXWTBEWDFBVUNZSUlvU04wUmx0K1ZOb0tRaHFT?= =?utf-8?B?cnJ1SzlJc0JKQ3RLMHZqZ2E3YXkxQzJtSWZWbmo0K2s4Nzh0TSsxdmRvc3ho?= =?utf-8?B?SlU4SzBMeHM5YzVFVHNnRXl5TFVOTmUrSUpDY0M0ZEp5Q1JLakVSN2JuV0cy?= =?utf-8?B?YXAwM2lGY0x1UUpySHhHbTFOeDFLd21mUDRVYVQwa3NsM3IrUWVVTXlKSFF4?= =?utf-8?B?ZGllcU8vN3c2YnovUGVDbnFiQnBkLzVydWJEQUo2bzkzbjcrWE5oYW9DOGM2?= =?utf-8?B?WVBpcE94ZWRMZVRtV05QMWdCKzlHNTVjbXhjdTRNelAxTUtIdWtCUm1WWDNk?= =?utf-8?B?NHg5WWxLSDZybEdobENKK1pFTG82cTlqY1U5QVAxVHhhQnNRcXdROWpnbkNR?= =?utf-8?B?QkE9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 92292596-d1bd-4fa3-ba50-08dd3c59a8fd X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jan 2025 09:29:54.3463 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: mnSk/6HMBFJUBGjuPcO4KY1y+rsVBRuxxGCpUW8D30IelzIqerQ1n2VGjJ2arwBps701pWeY3c/fmqYnuAOps6Rb4AwgtQ77NT1keV5P4aA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5993 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Jan 24, 2025 at 09:43:03AM +0100, David Marchand wrote: > On Mon, Jan 20, 2025 at 1:00 PM Bruce Richardson > wrote: > > > > This patchset attempts to reduce the amount of code duplication across a > > number of Intel NIC drivers, specifically: ixgbe, i40e, iavf, and ice. > > As part of this process of deduplication, and in preparation for further > > cleanup work, it moves all existing Intel drivers to a net/intel > > directory, with a "common" subdirectory being created there for the code > > shared between drivers. > > > > The first deduplication patch extracts a function from the Rx side, > > otherwise the majority of the changes are on the Tx side, leading to a > > converged Tx queue structure across the 4 drivers, and a large number of > > common functions. > > 394 files changed, 1495 insertions(+), 2510 deletions(-) > I like this kind of series the most. > Thanks, I was keen to hit the 1k lines saving. > I did not enter into the (ugly?) details, but overall it seems good. > Thanks for working on this Bruce. > I'm hoping this is only the start, there are plenty of other opportunities to reduce code duplication, but I didn't want the patchset to be too big, and I also wanted to avoid having too much scope for breaking things. I'll try and get v6 out today. Thanks for the review, and the suggested tooling changes. /Bruce > > -- > David Marchand >