From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 637794612D; Fri, 24 Jan 2025 17:33:50 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 426E841101; Fri, 24 Jan 2025 17:33:50 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.13]) by mails.dpdk.org (Postfix) with ESMTP id 9A0AA410FA for ; Fri, 24 Jan 2025 17:33:48 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1737736429; x=1769272429; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=YUIzE3hQnAB1dAjtxL9EL25k4KlbGPn6MIhRgD+BJWo=; b=cbcCdZWavv/miD5b+PTaoiCYUV/K5OZPE/lhq7uCFFPFUNznRI1I+o/U IqkpTiQOPgNZc9cMs6LywK4YXtnBdQ/MIBx+FQecOeaaN6oDFXWu7qh9R Amlp4vRH+ml6adN5jnhEJNuzP+gynHKlfuxwWuk4l7VK4rsprvrSb1zLH 7EV72gKVTyj7qBFend8Tz5RuCNrM1FtyzHQnhMcmCV5ECkmtegu2nmHoy 1RJ5qpfO29SULaN6MpZl6kpPlINiD34aA0Oc/mh1Ri9TquRRTnZhikgFf dfxklaAMdliT1tb7q+QXuzSFcUWoOJ+ZjtymggZ2o0Hilwk4zuVQyzB+b w==; X-CSE-ConnectionGUID: MGAD0/eoTG6OdjmRdfITyg== X-CSE-MsgGUID: MNBwvGSzR0OPhVU5Z4SRpA== X-IronPort-AV: E=McAfee;i="6700,10204,11325"; a="41109730" X-IronPort-AV: E=Sophos;i="6.13,231,1732608000"; d="scan'208";a="41109730" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by fmvoesa107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Jan 2025 08:33:47 -0800 X-CSE-ConnectionGUID: Q/fWgV26SZ27tbvuf7JV+Q== X-CSE-MsgGUID: 26UpdaKeSQu35kGa3QMQsg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,224,1728975600"; d="scan'208";a="112440095" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmviesa005.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 24 Jan 2025 08:33:47 -0800 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.44; Fri, 24 Jan 2025 08:33:47 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.44 via Frontend Transport; Fri, 24 Jan 2025 08:33:47 -0800 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.175) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.44; Fri, 24 Jan 2025 08:33:46 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=GYrEZpMDYf99sJT6C5VAJCTWcUBhaBmwVG+8En7NlyOXxPbaMDPbjI6sPhuFqv//E9yjxSvRwNn4eXY6ZdRNJ4xqavbAT4NLDseV55hckQ12l6VHz+7AFjZ7bJySbYhPiGYc9UmI/Y9a8o8TTDg87XcUTVBJySAldkonmHT9Vfx8YfTQ+uF30FckelsM1EB1VesomUv4DCyOC1sAQ1sAdenf+zOge1mb0w7l2ekn/DUDfFkFg0QCU7XGJf2/pkeWFLrEPtWNJD9Bwex8X4TYg1YiJ3mT9UpM6fJGL1BBIg/mg2hTdaGQwiTWzGBpHN2klPZ2IlL3E2zmWbiXHzhAlw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JdDi6QyToVUIjSRCOhL4dqKvVkDo4WMPftSU67ayswk=; b=vTfbq6U+ZVF+uHTdzy0G3a12UMtkfWFpfCplbyZzq9PSjzBq5bpZY49vZ0x56finI47dYuukwidSeA4uEVEemmmDVDmbmkkAQBYRCaAHOfNbJeau2X5hqbHm05jlUYNTYZSk1ai6iDOJ1mxzD+TjTcUgfsLAGQ5yqqlZilsmiXVJfVHGV8NvI1QBdBTsJihU9+LjOp02aPCMIIdAnaSmLkTPOw0sq+cX0GcyOj+UHAwOXrU4JNKlT8nc9LaqyCS3NunpoPXoAEt9TnMlRxaORH3ThzWGREPeuqKC2oTUAAl89pd8N4mKCFUTMJEGJ3k7zVWP9plGv98Z1HH+mY4gGg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by IA1PR11MB6444.namprd11.prod.outlook.com (2603:10b6:208:3a7::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8377.19; Fri, 24 Jan 2025 16:33:44 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%5]) with mapi id 15.20.8377.009; Fri, 24 Jan 2025 16:33:44 +0000 Date: Fri, 24 Jan 2025 16:33:37 +0000 From: Bruce Richardson To: David Marchand CC: Thomas Monjalon , , Konstantin Ananyev , David Christensen , Wathsala Vithanage , Praveen Shetty , Ian Stokes , "Vladimir Medvedkin" , Anatoly Burakov , Jingjing Wu , Rosen Xu , Robin Jarry Subject: Re: [PATCH v5 01/25] net: move intel drivers to intel subdirectory Message-ID: References: <20241122125418.2857301-1-bruce.richardson@intel.com> <2297034.HovnAMPojK@thomas> Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: DB8PR09CA0004.eurprd09.prod.outlook.com (2603:10a6:10:a0::17) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|IA1PR11MB6444:EE_ X-MS-Office365-Filtering-Correlation-Id: d0073f5c-14ed-4c9f-0eb8-08dd3c94de3e X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|366016; X-Microsoft-Antispam-Message-Info: =?utf-8?B?dUJJUk96YWkvemcySUxqc0huamkyM3BxOEUxelRzZXRDWGNYcTBaRUc5ZUVC?= =?utf-8?B?VG9RZnF3b2V4Nm1mVWRLYUU5OElCZXM0TndTcmlQRlF1Q1BQeXR1aFJMZG9l?= =?utf-8?B?V014eGtZcDNlaFBOWUQvY2JpNEZoS2U0dU1nQWFNZU9hd0Z3b0NVby83eTFr?= =?utf-8?B?S00zQTJ5d3M1NDg2b3JZTEo1NkNCY1FiZEQ1aVQxODRXNStaY0NzVUNzOHpo?= =?utf-8?B?WVcwdS9JVVV2cCtRR0V2TFc3Z0ZnRkVQczBFVWV6VWN5SmxtdVRFWjl2U0V0?= =?utf-8?B?M1dReHBab2wwRmh2VzdlUC9VWHdPemlzKzJMcEF4SThDaVRzdHFHNlhLbHlX?= =?utf-8?B?SnBpWm9JUzdmbE1iMjdwZlBrVy9tNHdvdm1XRi9ueXlPQjQ4RHFKc0FvVURo?= =?utf-8?B?NDU0b3habjZVQStQdWVFaEVTOG1vZkU5dHpzN3U2bHRMNjJOdkZ5ckdTNXp3?= =?utf-8?B?WWREZmZtblZXN0Q3SHB3M1V4UHlGMDdudGtjOE0zK2dUMXJaTTdnN3FVVytC?= =?utf-8?B?RmxEK3lvSUphUnZIMnhqZ0lXYWRQWFh2ZUQ0V3ZiRkRlOE9LYlBwL080L1Jh?= =?utf-8?B?Q1VBMzNzQjh4SkViOThabHBwaUczUVpWNFNIaGZ2Vm9QaXVRT2NBSkNXeTlK?= =?utf-8?B?d0dUYUdMVnNBTWN0bXJITFFuQ1g2cWFPazZmaWlGNFk0ZU9BOVZPSE5ubmF3?= =?utf-8?B?VUV5U1AvMHp1UXFVVi9kQVZGV3VyanYwYWRDekFUZUR5Y2NkNEp1OXd6bmdu?= =?utf-8?B?Qk5RN1NaR0R3Z1JZQTlWT0lEQWhHeFE0WFU4Vm5WSUZIMWxNY1hRaXBQZTBY?= =?utf-8?B?OElXalhtVjMzNWprcU5LTXRRbWduT1FDbFMwbi80RWN0enlnT2xpemNGdWpU?= =?utf-8?B?OWRuOTNoNmFGUHJLQ2lGdk5YNTRFSUpRTzZ3NUYvS3lDb0c3dHBGbnRiS3Bv?= =?utf-8?B?NWpKZCs1T0lpTGQxcEdqazlub01IUVhkS0xvRnVvWkJNb2VmeEt3ZGs4VUJj?= =?utf-8?B?TXNjWE9aaS8va3NyRllIWGRqZUVLc3JKcW5aaDNFSGRwSXUzWHF5Umx1K2xZ?= =?utf-8?B?M1JJTXd5UlZrQTAzcXczUmc3MW1NQjVCQ2ZGWFVONHVCbStjSjRWRVhNdGdK?= =?utf-8?B?U21yaFZiUGV4eml6VWpVNjdHZyt0SzEydEJLTWJCSDN4UnBrNDNFUFk2Vkg2?= =?utf-8?B?RHM4SUY5WE9UYnJiRnpTY2RRN2R1eXQ0OEZsVnNnSzV1KzlocXE5bXNwN285?= =?utf-8?B?c1VYR3VmR2RUWFJLVXZ2aE1PYWdSQmM3d3l6YS9RcWF4WmJLKzllK2czTEwx?= =?utf-8?B?cnlEQXVkd2JXQVhLamJNTFp5Sy81L3lMeTcrRDZHY3E0UjBMY1NnM3pKOTVE?= =?utf-8?B?ZXV3ZUx3d1NxMUhqRGFwK0U1dEowc1p6ZEhIbHREWTQwT21wZ1ZUS0FlNHJC?= =?utf-8?B?SzJiNWMwcDY3cjB1S0xnTDJPMCsxdlRDYlgzUkJ0U3JmeUNUdm85aFJpNlI0?= =?utf-8?B?QzI3YWVTU0RWY0IvRG42MSsxM1k5UjNBTUF5ZUw5UlJVQXZFbjRpZEFBOUt6?= =?utf-8?B?MWVXa3M1STJ1d21nblhRVUV4Z1FLTjhneUhBbGlSUUVRbkFzZit2ZU84M2Mz?= =?utf-8?B?MkRrdUIrMTdFK0d2Nkk0Uk1yVmFPa1J6OVova1dTcGR3VTBKZ1FZTFdvbTV1?= =?utf-8?B?SklFemVKN3hBVEFYQ1FRQ3Fzai9VNStIN3drK1I2bkVLVzZ4akFZaGJkL0Jk?= =?utf-8?B?d3kzVTZWcmE1cm9lak9ZNTlaWkZRcXVwOFV6UUVBcGwwZnN6ZnNBQ0xzOU5h?= =?utf-8?B?WURPU1k4bUpaVkdCU1lrWVpJTy92Y1JQMDc4T04vQVNhK04rT1E3VzdTWG5z?= =?utf-8?Q?afhUwQ9zhxdI/?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(376014)(366016); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eGEyOHlDR2tOZExNaDZjNXNBSHI5N1F4UlFla2F2QWtVdzBEUkQrR1lsNm96?= =?utf-8?B?MkQ1eUp2SmRXQlk1QTNVWExVNEhKbVVMSWJSUDRnNHFDM1V4b29uYllIU1NL?= =?utf-8?B?RkF3OTcweU1oYVhPcFdML00yMjI2aExYMzJQMHlZZFFmYXRPUjFMV0p0Wmgv?= =?utf-8?B?NmJ1VG8vdkc2OFpwb3ZWN0Q5VFVOVkdkRW51S0duL3lvMjQzZUhibWUxL3VZ?= =?utf-8?B?Z012UW5hOVZ1SFFlN3RDTTg5VzFhc1NHS2dNU3ZsdnIxU3NvYTJGeHVyZDBK?= =?utf-8?B?bjB1R29ZNi93S3c1eDVFcUNNZ29iT0ZkUENoNXBTVmMxQVBDeEVoU0lwVDBO?= =?utf-8?B?dGxSNUdqdVZ4dlkvTktVenRWZ2UvcDhQdWczdjdzdWIzcjFuVmFPYUJQbC94?= =?utf-8?B?YVhlNFYxeWFWYWZUMGVMMUludTByeC95T1RHRzRzYUFLR0FzK2NOMDBYQkFH?= =?utf-8?B?WFZBeWYxU2hmbnJYTGVQUzdCWEZRWFJ5eXpJQy9DVm54ZlR1V25iOFBXbnpQ?= =?utf-8?B?VVJNektGc3krNmE2ZlVQWFd6am1KeG5mQy9Ud3J2aDVqOXJjVi9tWU1McU9X?= =?utf-8?B?elVTdnF4WnBraW56UHFWenpDdktid1hic2R2RHJDUENSeTRqeUtibDJIWFVl?= =?utf-8?B?SStrTVoyR1l0cENUYlB4blp3bEpKank4MXdEV2tyVHVZUFlzdFg0ZHdNd0xB?= =?utf-8?B?TXpxNFdOYUh6ODV2bHRCRFRQMUkwRGNwc1NUWW1yNTZNakNURmZYcVdYZDBo?= =?utf-8?B?RjR3QmFNWDJ5aFRFUjFoYVVYUnVvRmVZTGhLTHR1MWVMYXJDL1k1Ky9Vck1L?= =?utf-8?B?aXNFcVZiMFJsUVRpdkg0YS84ZWkySy8zaEFtL2x3Q0ljT2V1b25OYjJYTngr?= =?utf-8?B?cEl0Um1zZEwzOUNESE9HNVhEbHhzNkswZWpoaGVxb0VsU1E3ejMraXl5eXk3?= =?utf-8?B?dWJRVUxPdFZLVkU4OFlXQ210blRkU0xkMW13dVViVzczMExlTjJuRm5zcDVB?= =?utf-8?B?dzlQTzhFbHd5Y09XdUlRWFJRUGVqMmsrUUowb0R2Rm5CVHBHZittNFl3S212?= =?utf-8?B?aUlja2c5MUFKTmU1SE1WUXo4b290TEhuK1gxdjFjYjlTWTJUOEZ2TmtSQ3RK?= =?utf-8?B?Rk5VVlhra2VaQ1R4eWZ4WnVSRnI0VlExcktEbTc2TnhxYytKSXdpMU5jSjVM?= =?utf-8?B?KzIwanR3dG1pdTlkM3FJN2tHaW54eHMwd1FldENWQWxYOFB1UCsxSHZnUG5k?= =?utf-8?B?RkZZZldpMlA0djFsUzRhRE5QRmRkMlgzZFZKRzJWT2VnRlN4c0MvYSt4OCsy?= =?utf-8?B?MlV4d3dpRDBOVWllL0tVYzlWaW9xdEhSUmsyL3N5MVhWV2FGendaNW9QVUF3?= =?utf-8?B?UXR2c2VPckE2L0tYVUI4WHZTbThMMHFEVzhZcjFvV2dFM204d1NZZlNLZUVV?= =?utf-8?B?RWw1SGhWcFRaRnJ4MCs2YmR6YlBYQTlDeXlQNHlVajJWMVVTcUNlNDhnU3Zn?= =?utf-8?B?dncyRzN5VytuODZiKytsM2t1clZkcjMvZ054SzNlM2Q0MGNuRDM2TXFMZEhR?= =?utf-8?B?YzBwVGR6aHJ1MEZGbjJGbjMwUEw2aGduQitQVmVZbGFaVExKUm9wOE43MThv?= =?utf-8?B?bXpERkNRYzBEUWFkalRmSW5HcUwwL3gzSnlMM3VmZnQ3bzRNSUdsb3g2Tm8x?= =?utf-8?B?ZHdSa1U0WFdkU2MzT29CZ0Y5ekNSRTFyZmZmbmQyQStvTWJmRkpqS2VzRkNh?= =?utf-8?B?M0pHSnYyWkRYSVJJbklqaEVsenFuU2FHaDVGRGRyK0IzQzFRNW8vT09UYnp1?= =?utf-8?B?cndhYlhQaHFsdXNJUm9ZQmsxV3JZdUg0NXNzZmVTWTF5V3RaMGNiT2RlaXBa?= =?utf-8?B?cW40ck5haEZrN3c3QUF5MFBMRmlhWURHMmFLRUYwM2RrM2VUcnVFRWNsa0gw?= =?utf-8?B?WnREY1dBTzRBeFNwYXIzbm9PLzJXWkx6eGFFRkptL1JaM01QZTJtaFZRY0J2?= =?utf-8?B?aUw2Z0JZSURwQjVGNzd0VHhpN2lnN2tmcVNMeHRtdlNCcnpiQlI3ZHgwZmdM?= =?utf-8?B?RGJxQXFtQVhVb2ZkeFNxMkxzUnlKWkhFSllpYzVveG9KVEJMU2pLcldxU2Ri?= =?utf-8?B?UFYwaW9LWFg0aURHUEZ2Zk9ycEF1cHJxMFFGc0ZXdWQzeUptbnhQMUI1UjFv?= =?utf-8?B?aEE9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: d0073f5c-14ed-4c9f-0eb8-08dd3c94de3e X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jan 2025 16:33:43.9904 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: TmLG1gQsAUdXf5DkZqOX6pZL6C1+LOqXlXOR+pb+CLazHbNmZftNyS3z4wEPqiEX2QDbDeSPYzc475aoiAzRg84V6LJE9gHJwyn7p7mkz+M= X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB6444 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Jan 24, 2025 at 09:32:25AM +0100, David Marchand wrote: > On Thu, Jan 23, 2025 at 5:02 PM Thomas Monjalon wrote: > > > > 23/01/2025 15:35, Bruce Richardson: > > > On Thu, Jan 23, 2025 at 03:16:40PM +0100, David Marchand wrote: > > > > On the check-git-log.sh update, we will have many warnings with current update. > > > > > > > > Wrong headline prefix: > > > > net/intel/common: add pkt reassembly fn for intel drivers > > > > net/intel/common: provide common Tx entry structures > > > > net/intel/common: add Tx mbuf ring replenish fn > > > > net/intel: align Tx queue struct field names > > > > net/intel: add prefix for driver-specific structs > > > > net/intel/common: merge ice and i40e Tx queue struct > > > > net/iavf: use common Tx queue structure > > > > net/ixgbe: use common Tx queue structure > > > > net/intel/common: pack Tx queue structure > > > > net/intel/common: add post-Tx buffer free function > > > > net/intel/common: add Tx buffer free fn for AVX-512 > > > > net/iavf: use common Tx free fn for AVX-512 > > > > net/ice: move Tx queue mbuf cleanup fn to common > > > > net/iavf: use common Tx queue mbuf cleanup fn > > > > net/ice: use vector SW ring for all vector paths > > > > net/intel/common: remove unneeded code > > > > net/intel/common: create common mbuf initializer fn > > > > net/intel/common: extract common Rx vector criteria > > > > > > > > Invalid patch(es) found - checked 25 patches > > > > > > > > I tried to tweak this a bit, with the following heuristic: > > > > * if touching only net/intel/common, accept net/intel/common: > > > > * if touching multiple drivers under net/intel, then accept net/intel: > > > > as prefix, > > > > * if touching some net/intel/$drv (and optionnally net/intel/common), > > > > accept net/$drv, > > > > > > > > diff --git a/devtools/check-git-log.sh b/devtools/check-git-log.sh > > > > index b2da013f6c..41c290f0ca 100755 > > > > --- a/devtools/check-git-log.sh > > > > +++ b/devtools/check-git-log.sh > > > > @@ -79,11 +79,18 @@ bad=$(for commit in $commits ; do > > > > [ -z "$(echo "$files" | grep -v '^\(drivers\|doc\|config\)/')" ] || > > > > continue > > > > drv=$(echo "$files" | grep '^drivers/' | cut -d "/" -f 2,3 | sort -u) > > > > - # for drivers/net/intel/* use 2nd and 4th fields not 2nd and 3rd > > > > if [ "$drv" = "net/intel" ] ; then > > > > - drv=$(echo "$files" | grep '^drivers/' | cut -d "/" -f > > > > 2,4 | sort -u) > > > > + drvgrp="net/intel" > > > > + drv=$(echo "$files" | grep '^drivers/' | grep -v > > > > '^drivers/net/intel/common' | > > > > + cut -d "/" -f 2,4 | sort -u) > > > > + if [ $(echo "$drv" | wc -l) -eq 0 ] ; then > > > > + drv='net/intel/common:' > > > > + elif [ $(echo "$drv" | wc -l) -gt 1 ] ; then > > > > + drv='net/intel:' > > > > + fi > > > > + else > > > > + drvgrp=$(echo "$drv" | cut -d "/" -f 1 | uniq) > > > > fi > > > > - drvgrp=$(echo "$drv" | cut -d "/" -f 1 | uniq) > > > > if [ $(echo "$drvgrp" | wc -l) -gt 1 ] ; then > > > > echo "$headline" | grep -v '^drivers:' > > > > elif [ $(echo "$drv" | wc -l) -gt 1 ] ; then > > > > > > > > Which then complains on patches in this series that touch many drivers > > > > (but have net/intel/common: as prefix where I would suggest net/intel: > > > > instead). > > > > > > > > > > I tend to disagree with this suggestion. I think that a prefix can be valid > > > so long as the prefix matches at least one component in the patch. For example, > > > for the first patch in the set, I think net/intel/common is a better prefix > > > than just "net/intel". I don't massively object to your suggestion, I just > > > prefer patches identify the most relevant component, if possible, rather > > > than generalities. > > > > Saying net/intel means the same thing as net/intel/common to me. > > Why do we care whether the change is in common or multiple drivers? > > At the end it impacts multiple Intel drivers. > > The goal of the prefix is to quickly catch the scope of the change impact. > > > > One more argument: net/intel is shorter :) > > True that any change on net/intel/common will affect many drivers. > Whatever is decided, I just want the check to be less prone to false positives. > > With current series, output is a bit too vocal to me. > Reworked this a bit in v6. What should be the heuristics now: * Use of multiple directories in net/intel/* looks for prefix of net/intel * For any one directory in net/intel/, use net/ e.g. net/i40e as before * Special case for changes only in net/intel/common, where we use the full net/intel/common rather than net/common After this, the number of warnings from check-git-log is down to 5, and most patches have prefix of just "net/intel". The 5 warnings could be fixed by changing those to "net/intel" too, but I deliberately kept them with specific driver names e.g. net/iavf, where the vast majority of changes in the patch were to do with that driver, and only a few lines changed in common. /Bruce