From: Bruce Richardson <bruce.richardson@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: "Morten Brørup" <mb@smartsharesystems.com>, dev@dpdk.org
Subject: Re: [PATCH] build: force gcc to initialize padding bits
Date: Mon, 27 Jan 2025 14:34:15 +0000 [thread overview]
Message-ID: <Z5eZZ3GNyAusuZQc@bricha3-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <20250124103748.6b9b85fa@hermes.local>
On Fri, Jan 24, 2025 at 10:37:48AM -0800, Stephen Hemminger wrote:
> On Fri, 24 Jan 2025 09:38:20 +0000
> Bruce Richardson <bruce.richardson@intel.com> wrote:
>
> > >
> >
> > Does this flag give us additional guarantees of padding being
> > zero-initialized that were there before? From my reading of the gcc doc[1],
> > "..padding-bits=union" corresponds to the old behaviour, right?
> >
> > This also means we will have different padding behaviour on clang and gcc,
> > since clang (at least v18 on my board) doesn't support this flag. Do we see
> > any issues with that?
> >
> > /Bruce
>
> I chose the setting based on some email with the Linux kernel hardening
> project and their choice.
>
> Clang decided to fix and just do the right thing.
>
>
> https://github.com/llvm/llvm-project/commit/7a086e1b2dc05f54afae3591614feede727601fa
Excellent. Agree on initializing everything being "the right thing".
next prev parent reply other threads:[~2025-01-27 14:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-23 17:20 Stephen Hemminger
2025-01-24 7:48 ` Morten Brørup
2025-01-24 9:38 ` Bruce Richardson
2025-01-24 18:37 ` Stephen Hemminger
2025-01-27 14:34 ` Bruce Richardson [this message]
2025-01-24 18:26 ` [PATCH v2] " Stephen Hemminger
2025-01-27 14:35 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z5eZZ3GNyAusuZQc@bricha3-mobl1.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=mb@smartsharesystems.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).