From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 83000460DB; Tue, 28 Jan 2025 13:03:48 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 593F440150; Tue, 28 Jan 2025 13:03:48 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) by mails.dpdk.org (Postfix) with ESMTP id BD84B40144 for ; Tue, 28 Jan 2025 13:03:46 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1738065827; x=1769601827; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=VN4QSHoHDMDjX9B02wMQIN4UQjI1itta3jMq0bNHK9k=; b=MDxTtfWaEIXCOTxBGOhaAYX29O89IheV7mgWcAv9iSYNQnKVGoOQv4Vg pDSQM13k4LKhPc7N/JbFicBxIvlK3UO1isDIRZcI8seoN5spqtWWQEIsK 0s2pfq+359gQ+CiXKren31UNTnCzVt6HcF0E+V4L4aU37rJWllFbIdhUW +D9zZcG1MHIjP6yXD1IxRVBd8q+tZnbS2DG6khBdKjIxkIuhlvp5Es615 Mvi+thmOqYh8gn18oE3nPamqTBz3mbbWN836b6SAU3/8yBuenUi4kMbZS NSYZ5HaiacJ1I99SIxijaRDgpD7DUEmOuVoWFm7RbPUXGqidb02VpV+DV A==; X-CSE-ConnectionGUID: pt/Eh6ENROGpQmlWLA2iZw== X-CSE-MsgGUID: DTg6zZBFS4CHz4N0iH7vIg== X-IronPort-AV: E=McAfee;i="6700,10204,11329"; a="49938933" X-IronPort-AV: E=Sophos;i="6.13,241,1732608000"; d="scan'208";a="49938933" Received: from fmviesa004.fm.intel.com ([10.60.135.144]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jan 2025 04:03:45 -0800 X-CSE-ConnectionGUID: ZH0fDKAbQ1uk8nSEpJLd5g== X-CSE-MsgGUID: +WazZEmkSZmaNlZU83LeBg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.13,241,1732608000"; d="scan'208";a="113720892" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmviesa004.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 28 Jan 2025 04:03:45 -0800 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.44; Tue, 28 Jan 2025 04:03:44 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.44 via Frontend Transport; Tue, 28 Jan 2025 04:03:44 -0800 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.171) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.44; Tue, 28 Jan 2025 04:03:43 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=l+LVEY7jlAvOY0Lfq+C2k2U+V0zuSKCGTkhQ8nf+Hm26E6eB2ZQUwa3cF7ZYqdf5CV70nGMYXRoISPcSWiAhO2+9vMsHZYR3Dne/j//2HDSikHQL3Gmpl1Y0xP8s1opCnu7cqW7S7ZYFMUDziNgjLqfaxFomOofOUlnrM84kN1CkmmWvi8bwCGBC4a11NvrcWwdLUz6SPKG19In6/QoQkIV7aBCSn/MD4F0jqYMlH31aUxxhPPWplMd9Ski6WSZLdmWpW6KUxVVrPY6L8WKiJweaBqFbqs4slO3R/06qTFI1OngF1T0s3Xbz7q6a8leX8dZSlQ0iLpUNxmv21HelDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Y8ta+oDInZk1cMNgS0PoMhNTm1fiAWlg4Bg8b4R5RxI=; b=ZJapDtihCj48nM4vttD3XIt2AOQW5emXjD5nryU+Fs+1iCkDNn6etzVpk5Yr1gAWS2SJaDDoxPZMLvlHEhCyGLqP3yQLjqvei9TTqLqAPPLHmSghDQVzHmyZTp1HoFfSs9f5eRr9uhhHaVS6uTJSysGMGTV4e30KuxsnF6B5Sbvp2+6Iv8QJAIBHy5fQE3AzAEIU8pm7pUWaGA4LjdOHHR5XB+cGNaRmS+mKAE2fDNEfgbCAca4PZQjPxr75cIl1i2W+MXN1ORwGMpYJ76gjCClHctx46eEEm+sNlWnlLtJZF81c7DxX0a+UtCVQw8Xey9bJlbOxZS01nQpo4PddgA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by PH0PR11MB4821.namprd11.prod.outlook.com (2603:10b6:510:34::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8377.23; Tue, 28 Jan 2025 12:03:27 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%5]) with mapi id 15.20.8377.021; Tue, 28 Jan 2025 12:03:27 +0000 Date: Tue, 28 Jan 2025 12:03:22 +0000 From: Bruce Richardson To: "Shetty, Praveen" CC: "dev@dpdk.org" Subject: Re: [PATCH v6 00/25] Reduce code duplication across Intel NIC drivers Message-ID: References: <20241122125418.2857301-1-bruce.richardson@intel.com> <20250124162921.1406103-1-bruce.richardson@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: DB8P191CA0020.EURP191.PROD.OUTLOOK.COM (2603:10a6:10:130::30) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|PH0PR11MB4821:EE_ X-MS-Office365-Filtering-Correlation-Id: 0c8e2c01-5f3b-44d5-0350-08dd3f93c622 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?oguQQxw1kOVRUu9+pr6lXbD6C5WXIJ+W0LWZr089XFmp24HZCYhsjlsSeWUn?= =?us-ascii?Q?wfHtDB7FRsDuIIzOXxsqqWOmO2t5SkLC1wf/ZnPuPh41rimcl2sht/Ly4DZt?= =?us-ascii?Q?OOFbejgYoh2G+ihM9j/2aZS0dkFH21r+xt1xZvmaoJeSd8JOGvkCUDLVTlGd?= =?us-ascii?Q?VcMvruJrlGci2ktFe7lOrC98eoTzUKXmlY7NC1IzA0vHWsunhQeDOUIKql6k?= =?us-ascii?Q?xBkWcqW9ZM5CfzX0iabAk+mRISVGajoU2qOi192ebAqQb1itiPiR+LTRua5Y?= =?us-ascii?Q?DfB6nvAl9BUu8bD11XPFaDHs9rPXvsNU4JDgv2AlA28dbFmyp4qb4zn4R3+T?= =?us-ascii?Q?3uNHRbLQK/oxuncKbT3VjUk9S1InWfBweCfUMc8H18wLWj80WWzr06KGlmjs?= =?us-ascii?Q?8j3XoNrvqww9RpwJlkLPozZxDai25QRhFKyy6k+q6Yn8zradvJ6sT0Nh0muN?= =?us-ascii?Q?wV3tqInzm0Ga/npBn8TjJNI4D0ZiBdFVtdS48qZddf2er+Ed5uJbU1Tbt1xx?= =?us-ascii?Q?CGcT+KncC/XFCSRdaE4cEi620g7JsXNR0kYgrBg44VIisG7zQgYmy6lcGGbn?= =?us-ascii?Q?q48tC/VwgPUBC2IIUv+L6SKcApwEYDdABGfKtsbJLAlj4eNlWmxfDijk8mKq?= =?us-ascii?Q?NLbICj9BnsTgIM09NGH+B082BF6pYdqEFpsMMYd9ZSwW0oukfFgEqrKKRnpn?= =?us-ascii?Q?QAqxbtfLBEuCzsR29MgOrpfqGgjlskgH2UQumIanzpFNC5YOun5XVtGCE9R3?= =?us-ascii?Q?0AYW3RRgGI1jKxz1cb22ENXS0gWevVMyx103g++/xkIlzIjjslf2qS/GYTtA?= =?us-ascii?Q?edpI+SE2aTBl2mE6EqJM5CAW038FH1R+d/Qgv2YKxNJIxuUcI1MiN4TS9XuM?= =?us-ascii?Q?93e+tvAk9K6ci5VsowXe2lrnPjnDR8Sk2zl2Rr3I+iAepoKITFFoSJGZS9yY?= =?us-ascii?Q?TUFM2GxTsas/mcSAVlsogajWmmzjKYcKj0UkxaOKl2X/p106a/x5+ABGxh2F?= =?us-ascii?Q?nqWVLykQPkLkZY38w/xdP6j7scOyun57fmcLXcu6xkEwuwW1Bg/CkebllbHO?= =?us-ascii?Q?zA7F8dYw5iNWC2pSgUQCQgA5Sp2GShiWVBVjImjggbRT4/LWCb8pRb8+sw7R?= =?us-ascii?Q?bt9+wyLu9kejvMrg8pB+x9wJIpkC9kF78BylSscAUg3v1TpAO6KOrK8o2fXv?= =?us-ascii?Q?C/khSzu0ljI25OXRFk54y6a0t7DDcQ2JN5HsilPXzxWateQC2SNB45dePftD?= =?us-ascii?Q?U6UL2F0yzeEc3xEFZkjNy6Bm2ZUgsTLRKOeBE9hISThojq2z6MVMJOh3ZC5S?= =?us-ascii?Q?UrMmyfODVbUHlk7xXNuGrYeBTnWuNWst2ZLi+mAiFEUpPddOIZ+OkclrJMA+?= =?us-ascii?Q?CB0YgrDqJ5BGbw647/FjJL45ugHb?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(376014)(1800799024); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?gbL+W8yZQ/K6FIyFqEgkaeQSMw7ko10DeVJG73xG0/mNNY9PktZnwZ7qPsTf?= =?us-ascii?Q?QcXiTt9TA81DyX4aChfZgNcix+tQ6Iwi2Dej8bmmW7x7Wdq5i3UEYJlX4goe?= =?us-ascii?Q?Lln/Iejirj9wI++nwzOXtUiz0TRxuR67OQBbcUpk61y317JAtm44T8vvJzQb?= =?us-ascii?Q?rlQGDFvt3JfzFdjbkpl6/bONsZ88O9FX+VcMZPqnSTp/qbpjzj67jHKbKiTa?= =?us-ascii?Q?c46WQPgsjW/gmoZgZMe2+EZTZOJ2biEc+9+EjZR9x5/SJXxmwk40W9/nr3kk?= =?us-ascii?Q?+Oqz1Egio+mCU+f152KOzkOfM9aLLa6gEmLm1mYZrV9yoY5lOCNAZ1TMDwyo?= =?us-ascii?Q?JHhgjw5Lu0N4LKYBVPBdnsHjbs8cF8iOmgD03DQeSw9Dp7YFDPAfE08OUx6s?= =?us-ascii?Q?5NtLqywHA6tVJy2FIBYILlzR0m1UOcPjRzA+QFBEjb35DmnhSHjCtQb+0zsx?= =?us-ascii?Q?IFeaqgvnnMC2ukKamHZ3ijR58FNlblx18ZWgP3Nn/HXGWnfjHFblFTCE0XBJ?= =?us-ascii?Q?kk9M1begObs8SocvWhvkQPXVazAbTiGWDTYqP5HqOsKO7R1JtM2LaPWqj0B/?= =?us-ascii?Q?1EI5+wdNqYdvlQmEezCxMWwhSBQbiiSIsN4oPrtXhnzG5F3IIuT0uqRidNtC?= =?us-ascii?Q?JFYkHkkCszDJvrOA1xckUC4S6xRLNA/czKrtMv858MdmpxycFvpsTvHVxk7w?= =?us-ascii?Q?Wq7InbRml7uUk14S2y7srMCHPsfE/Mw2wHz+oIM2GacCOPY5OwHu/UCIOlmO?= =?us-ascii?Q?De8LfHPPcJRPuPZ9JOG6d9P4jLHCVe4XkP5bFuGd52NXssQDl8/l3hUgy8DX?= =?us-ascii?Q?mH53ZfuxANR3x12lWI25zUhtxZ1Apwfy52AS1ReNIrmMesSM/aWY3CKDpLDo?= =?us-ascii?Q?+iAlaXMnv+lSrsk1nyU3SQQtxsb4wI77o715NRFf01IDS2NkiD1Qb3jtKqkT?= =?us-ascii?Q?XpmM/3GZE0pWzCUBRkUpXiAhWmyRZNMzRu+UzOc5U+3mBWJDXZ8U4Ec3ESKS?= =?us-ascii?Q?spaGNw50IhZ5isgTT86r/s2rXPrbOraVccHdLV2bbqhKjWyCG0I1L8+pb0d2?= =?us-ascii?Q?OZYSqKsmQoI7oge/iiixr8fDXvE8FuMGIIAGDVb2aeMSr8NOYErZxFDOcj17?= =?us-ascii?Q?Ja8gBLQL5JCP+gCy/QhrytTyBqlD3sS2WstqlczGpk0hz3Ecqe8T5ejpeEwB?= =?us-ascii?Q?9SAvyEvpX/ZJBX1eS2fGTnKNV/gbqCZ+qCqQhiLMjzJNGSdPsX7zOjnslUVH?= =?us-ascii?Q?DTwhVTFppTtIfEvqZWmODmOCbMyOASO8YbA8osxcKTwKLVBrS6dwYTZNgr3/?= =?us-ascii?Q?hOn9b6yumyWvjiR3Jk4tdUQpNknw0lYQtwZ/KjYnmARwpTcTfF7XgTBbxXoB?= =?us-ascii?Q?oYaP1/Yk9yW/pJDjkvT04YTnXYZaFlDCtZ947+4mEoLevw0ANrfyieNMzYpm?= =?us-ascii?Q?zUyLHjQnH1dA2v0PXQLd4DP4KMJv9Np8/+9UbO+af44DFFHpysacGDcCJtmY?= =?us-ascii?Q?drjubK6OBhYLsSXO8cDiZ/+bKowjerXWWIJl6+mkaXbBeWWC3ODkYt/3eAj9?= =?us-ascii?Q?fp30zeH9Z29dBypzVrnnepVv3NT9PPB7HULOLsT7l9HkmdUI4P/z3L7w2S0P?= =?us-ascii?Q?3Q=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 0c8e2c01-5f3b-44d5-0350-08dd3f93c622 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jan 2025 12:03:27.4665 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 7q+4/1m+byuL5/P97E3pOYBff4chR8pNCzRaX9KRHNEKOCIiXjQQYM74J4ZM/keGfyNoFnq12ruVWVou4lit3akBA3jK1DBH0cItAq7hVFA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4821 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Jan 28, 2025 at 07:20:43AM +0000, Shetty, Praveen wrote: > > This patchset attempts to reduce the amount of code duplication across a number of Intel NIC drivers, specifically: ixgbe, i40e, iavf, and ice. > As part of this process of deduplication, and in preparation for further cleanup work, it moves all existing Intel drivers to a net/intel directory, with a "common" subdirectory being created there for the code shared between drivers. > > The first deduplication patch extracts a function from the Rx side, otherwise the majority of the changes are on the Tx side, leading to a converged Tx queue structure across the 4 drivers, and a large number of common functions. > > -- > > Series looks good to me - great work Bruce! > Series-Acked-by: Praveen Shetty > Thanks for giving it a a review. Series applied to dpdk-next-net-intel. /Bruce