DPDK patches and discussions
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
Cc: <dev@dpdk.org>, <kai.ji@intel.com>, <anatoly.burakov@intel.com>,
	<qi.z.zhang@intel.com>, <stable@dpdk.org>
Subject: Re: [PATCH v2] net/ice: fix how ice driver handles flows
Date: Thu, 30 Jan 2025 17:54:43 +0000	[thread overview]
Message-ID: <Z5u842Y82Kg0r33X@bricha3-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <20250130161442.2730917-1-vladimir.medvedkin@intel.com>

On Thu, Jan 30, 2025 at 04:14:42PM +0000, Vladimir Medvedkin wrote:
> Currently ICE PMD uses group attribute to select the appropriate HW engine
> to offload the flow. This behavior violates the rte_flow API, existing
> documentation/examples, and reveals hardware specific details.
> 
> This patch eliminates the use of the group attribute and runs each engine
> parser in the order they work in the HW pipeline.
> 
> Fixes: 9c5f0070fa3f ("net/ice: map group to pipeline stage")
> Cc: qi.z.zhang@intel.com
> Cc: stable@dpdk.org
> 
> Signed-off-by: Vladimir Medvedkin <vladimir.medvedkin@intel.com>

Thanks, this seems a great idea, to automatically put the flow in place.

Question: is there ever a scenario where a user may need, or want, to
override the automatic choice made here? Or is it just the case that once
the flow is installed, it works the same whatever group it's added into?
I would assume the latter, but just want to confirm.

/Bruce

  reply	other threads:[~2025-01-30 17:55 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-30 15:50 [PATCH] " Vladimir Medvedkin
2025-01-30 16:14 ` [PATCH v2] " Vladimir Medvedkin
2025-01-30 17:54   ` Bruce Richardson [this message]
2025-01-30 20:18     ` Medvedkin, Vladimir

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z5u842Y82Kg0r33X@bricha3-mobl1.ger.corp.intel.com \
    --to=bruce.richardson@intel.com \
    --cc=anatoly.burakov@intel.com \
    --cc=dev@dpdk.org \
    --cc=kai.ji@intel.com \
    --cc=qi.z.zhang@intel.com \
    --cc=stable@dpdk.org \
    --cc=vladimir.medvedkin@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).