From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1B9A146145; Thu, 30 Jan 2025 18:55:20 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1FD6840275; Thu, 30 Jan 2025 18:55:19 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) by mails.dpdk.org (Postfix) with ESMTP id 27E954025A; Thu, 30 Jan 2025 18:55:17 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1738259718; x=1769795718; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=acZNamRndgAuXHXyTRkKAM7NVvj3nvRLbwELOBZWl08=; b=TiWcvp6vODAEnfamd2aeS63HKQ0sUvfxYTOdJXVUZBdPi/Eu4p1AwXkm OzsbCEoye8CDBhiIrK3ht3x4lTbP8x+0N/HWh24Q66W1bJwaziMVnHXxE 1KdSZzWItODOmhxD+lasQT/SkaH/n+nz95kqSS7wZZg1wnw/tz+xFMbUl Ils7iiv/kdWgANQjDTJ1BmOPaF68mIU6Z60K5ExRHER1rRfSTDVdNFiN9 nBeZ/zZr0J7GqjgWaBgwbHYQmdx5qo5CGprk1aI0ABEE0fATak8R1ebXf TND5YaeEdaxoH2V6pT8H3zFwcN04f/YYPSOu6rZntGTec0nVBP4EPMtpY Q==; X-CSE-ConnectionGUID: /5GZhp9xRH2wJyQyblWd7Q== X-CSE-MsgGUID: ffp5g9VqR4yQMHoNSBgjfA== X-IronPort-AV: E=McAfee;i="6700,10204,11331"; a="56246981" X-IronPort-AV: E=Sophos;i="6.13,246,1732608000"; d="scan'208";a="56246981" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jan 2025 09:55:17 -0800 X-CSE-ConnectionGUID: VTRhO2FFQ++o6q85kgsmVA== X-CSE-MsgGUID: YmA0CMP1TbaYRY9ssh2C4g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,199,1725346800"; d="scan'208";a="114382154" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orviesa003.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 30 Jan 2025 09:55:17 -0800 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.44; Thu, 30 Jan 2025 09:55:16 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.44 via Frontend Transport; Thu, 30 Jan 2025 09:55:16 -0800 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.41) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.44; Thu, 30 Jan 2025 09:55:15 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=BC6gAR8UTcXSve54E8jjTbsfipD5aux0bnjPq3mL9n2MPldVIeVMG2HBPa6t1CUnWrY8fFN0WpFFN9BALtvCDUvq2HBCCSO0tsnvn1N4kXuI3vnCZaED1v/1U69xBvUoJI63qHyYRIkD/E4rSJVs2tp57a58Pe+nd/bJ/UWahq//lzNiDC+6RxxyNS6AsOnCkxCjmSydHQTT3rxyEZwaRXQJWxHxbXEE8MmvO/vQXhT4JP90EM+KNHxstsCNDb6gA1RbQSV7FqMOP53LQJJI9vU0zsAHwRbQRhsQEgOocCeBcDFoLOHdrqYvTbxHa42FaP30rfMib/7yheDjfWW1jw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/1qo9OwXe08xNS2oUfuHJDywwVJkCI5ZAvhOxL/VLYY=; b=YjwSuW+T3PZQZ925SZMTfwfwkKUpaq46n9RvmvFBKXnA5I6AFkxgv106Fwp+s8PF73Tnxk3k6qcVQ5XmnapssDgVPyBVXLw2fb0lY9FYs4fN2chf43lxtVv2WLrFvh/wCk7mSSJUn6fB5V1b9NEbPgXBXUYEkgM15sgeQakTjqi8vg8XztvCZ2EtMM1gpBNTQ/D474Z7eFUMwSecvslcP7GkTfINyaZwYJ17WrdSleQZ9/3tvrIdDz3Qr80iTSu27Wkmi7dboTjWvSuKq+Ks/X9pJPM8Q+JCCAj/M8XSYcj2dwVyNsuTwfnst3314A38LqiyYD7vQnMFyUoDn7ajlQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by SA0PR11MB4654.namprd11.prod.outlook.com (2603:10b6:806:98::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8398.21; Thu, 30 Jan 2025 17:54:47 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%5]) with mapi id 15.20.8398.017; Thu, 30 Jan 2025 17:54:47 +0000 Date: Thu, 30 Jan 2025 17:54:43 +0000 From: Bruce Richardson To: Vladimir Medvedkin CC: , , , , Subject: Re: [PATCH v2] net/ice: fix how ice driver handles flows Message-ID: References: <20250130155011.2658800-1-vladimir.medvedkin@intel.com> <20250130161442.2730917-1-vladimir.medvedkin@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20250130161442.2730917-1-vladimir.medvedkin@intel.com> X-ClientProxiedBy: DU6P191CA0066.EURP191.PROD.OUTLOOK.COM (2603:10a6:10:53e::6) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|SA0PR11MB4654:EE_ X-MS-Office365-Filtering-Correlation-Id: cd1c11e7-49d6-47ee-9699-08dd41572f91 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|366016; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?FQ52SgQvgAnI5IHOiOYES8lHQ50Xqdf+5Fnt2vhPJ7G1iKwlUC448rJWDpmo?= =?us-ascii?Q?nOX65Vzj9PflR14dFTo8vmbI5xrdkpvASipAV/wbhIGdtC2bgqwPzKZ8Es5E?= =?us-ascii?Q?KYwDOkYqKe8TBGYejGLkRfOdLqGmxFU5IJqgy1pX/wDYrWY7HMbJbxNPgJKx?= =?us-ascii?Q?4IBbzWPcm2SSKj2HmEAbWipHzkUCQP6T0PVenPDd6Iq2GcLqVo9Whg3EY087?= =?us-ascii?Q?6dwiLtUSnt4f3GKPg5XxVo9Kkxk4SBQaXBI3Q5qtRNaDPNOBUFOD85XX9Lvr?= =?us-ascii?Q?0RMEEusMb/OL0sxBxHhDXuDfu/FpOsE5Ps7Qxsw50xN1bbNkoriLKJlGJZkY?= =?us-ascii?Q?WD/p08u30Cksi4PgoS4NVZ+pQPIJSYbASsocncJPHEG21FqHzMn7kIuNAVap?= =?us-ascii?Q?87Ryhov74UgbYNhKl2ilLU8/Wd2H/g+PVa/ViTJvFdwCm+lmO+bRngiEGU9H?= =?us-ascii?Q?AqXTJpHPz0S5DKTsOW3uB2CvdQDRxCYevUY4MukeYLyu5JA5i2gFR0231HGI?= =?us-ascii?Q?/atXZ6z6MaM+10Hae6eC8lvOQ0g4yT2+J6iDhrliVBZyhbqsImtSFQLT4J9J?= =?us-ascii?Q?TB4oWE8qMbPFOfxUsq7V4H2eDK7np/6vJByHWqjTO69X0Xq3RFj3fE4sjr41?= =?us-ascii?Q?WkO3Sas90FWPh2x1COgbd2fT+bIuiCrJRhBhlhT7gkpKwbSMp0KKQThu+tCY?= =?us-ascii?Q?1/1y8gRLE28T9pTTU13JthJ6uvNwEjsA6AM2M6VpRVprzlmRkuUPUFY8bGVc?= =?us-ascii?Q?huk2Yd3ryvR1Ly3YJbyeRF9T4PeT6EsRE1XYATckEjnVDmvaFkD3LWiNa5OX?= =?us-ascii?Q?lJi0BcKrHFaSNoKUw/6Qvns6DfS/ut6c/X1xDDY3h3qo0oLT0hhp1tgK3cVT?= =?us-ascii?Q?43TIFcygJUn5dd9h72rySe1EixYoq5OR53PaWIp7Ur9NuLkXXuOnuwg7fkSL?= =?us-ascii?Q?0tFFhoc0HV7hVyZ+D3KtFTqvfcHBN4iS2xG99nsdglNhHIqSJ7t3V/XspcVC?= =?us-ascii?Q?5pGpoQBORMPgtI/xnWKkrNnQ+RVApu7jlCJkWUitPM5v5wbmq3aVDipJjr9b?= =?us-ascii?Q?McPJlRBaZqUhMal4lyZtkBkwn/UyKDzHEbkZZLostcDpnUFJQyoNF38AEnQO?= =?us-ascii?Q?pgqY1+WKvZm18r3E6JsQBrRc/FsswPBOlNjyU/t0JSy9QcixK3hxdo4dzW0j?= =?us-ascii?Q?gWCxPsyc7dm12Lw05gk4lDdCnLbCRo1nyIU0cPXVGyLkPXyS/2Es5G1PKulB?= =?us-ascii?Q?PQQMJv603Kh/cbceQ/tKJlA/kbmhrWWZr5cMPQ3zVUW//l3tFWCnVxfyGUD3?= =?us-ascii?Q?U2mIZIaMhePtAEUrC/eOqyPg98gsyisvceIBkqF2W9o34mjl/gnP9ekTFoRe?= =?us-ascii?Q?W8sqkJsvkw2W8MQMjVT/TfXHfxs7?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(376014)(366016); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?QuitmFB7qamrD2FlpS2+fm32j4EPFJHX5pRsHskaCfzmcg7O2rHdpHEbpRrV?= =?us-ascii?Q?qfcaC398gOhwu8X7xDDLqzuWhJQLu77DxNPKas3LZTj3usJAxxgeCw4OHdsY?= =?us-ascii?Q?/t3LFSsAKQlLttoPOgKMQzrBc/X+Ayew8cZ7nz3tMQ4J6bE6YdSWhRnKl1Fl?= =?us-ascii?Q?cJTLtNyK3/4zILH3OmCF/p2cIj7Zfi/iboGFSLoom376HK0eAw2HEjcIF10P?= =?us-ascii?Q?1IlLxnGgcbFeZgqOd4l83TmoyfgewHpXGf1dGjiMoD/VDq8m3FnJCUhhhra2?= =?us-ascii?Q?G7fm5Ji2XWAOv+rYmzup7gqWUhErQQuHB9gEdykTcIIvgqFfI05s8Tfp0EJE?= =?us-ascii?Q?tVo7TvvrpBU/pXfWXlaNwTbkBBtPmYR60ABAwEC9eT42VZS6l7frwTn4vjeF?= =?us-ascii?Q?CSahQxWDkJGv1FwusB38c8iXtGstTYc9zWdlOA1PFRT5l9gaXoaXRf5qvb/v?= =?us-ascii?Q?D+zu1f2BtjpSsiB5wyTwPpETfrv/sGg0hQiaA/0IDBlfRzlpL9ZYu2I5jetA?= =?us-ascii?Q?LbPlBJAT2msVojCccEu0vxB/bm7aCdxKm9jd8I02NL1ByWTt4gBLZvjZOpuM?= =?us-ascii?Q?HlzcUV7NnmSpTXz3zx78FO/6dPAQt7YPbP4XQXK6T3+k4dtvIA07H95hOR9G?= =?us-ascii?Q?VDwwGsEwm21u00AGUYwjy61SLM8XMS+0fTbN6PtqYatSbV3qyWC17q91jOEl?= =?us-ascii?Q?h4Mx9gq8IacEzcCPxRVuARGea3QNs38buH9Pia1tWKOx1n+GMe6QV+SG8Bq5?= =?us-ascii?Q?d2j+Bt92ov0z9g+d6lnJ+zt3rMlBuKn/T8Dh+CDL8UjpxwvfBIAfymQoY9V+?= =?us-ascii?Q?W4cTetKOkByJbD4rK1gU36FAN0KegDydyndulpnyd+8SiDCpbe/zIiDrHkR1?= =?us-ascii?Q?wKKC3lWplR7UzFpzDumZfKrKnh2MfvXnwjr2Now8UchPSDBtev+k9KlHa5UZ?= =?us-ascii?Q?fOkXD65p2R8kKqHcZGtChbA41vsKUxwNpgjfEYNtayZL2CHOFg8E0WQLn0g0?= =?us-ascii?Q?EZF2cGvewztD+Tdg+YMXAW5jmTOHV8+zL7nXa8v0DHU+cwtFkX3U3htoN+Ec?= =?us-ascii?Q?i5+snZfa44YWBOloKinWf6OqwxuDZYUyWaYmNn4/jhIJqA3K40bhvqgrodk/?= =?us-ascii?Q?rTipR7mmtKhRVOcOrC+nJRABoICvNjdvCJ1xZxVLGIlIPtt1ZayMJFWxu0Dt?= =?us-ascii?Q?HRMT5btzmrbBmD1n8eJYOEmhIXjyON8Uf4twEdsTdkVCGcDRPF2uSSHwWoLe?= =?us-ascii?Q?BHBdruv71GPzxol+pY/cGDUkz4bkZ9WmzJrrc7Bjp5xES4FdMl75Y/a4c5FH?= =?us-ascii?Q?r5r6mGza5uzvRuUPKqaLiNAO2wIh4ewPV1iUrN9fprG0IaHh2LhIGKBbRtjq?= =?us-ascii?Q?kM3C/5JzooqEu1ifgHvEKpO/bgcQhI/opy6UvHg/MlxLNJx0VD1v33FL45Gq?= =?us-ascii?Q?LX0TiLqrRORyFPInAokwMNu6bdDl+htUUYno1dES8Z91UlPkBIiD2LHHn3gp?= =?us-ascii?Q?cllBnqU8cD3bN+XYoq+dTjYaje4/HdEhpqhUv3C8oKqraqwd0XLg3z1OLSC8?= =?us-ascii?Q?gRETfn3UVCQW0o21tlsMMvD4EiUKwPYJWkMiu7YZoUV/wo98nenaLqXUISkq?= =?us-ascii?Q?GQ=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: cd1c11e7-49d6-47ee-9699-08dd41572f91 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jan 2025 17:54:47.4491 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 1/w85d598tnutvtwnwcl5XRDewaO7QY/hWKbkoSWBSCk9Z3oeI1awBmc0f7VwxXLFX4P2M+RBhnxIEJ+LcFwE4bF2U1x3cJZ33+/LQLVYUo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR11MB4654 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Jan 30, 2025 at 04:14:42PM +0000, Vladimir Medvedkin wrote: > Currently ICE PMD uses group attribute to select the appropriate HW engine > to offload the flow. This behavior violates the rte_flow API, existing > documentation/examples, and reveals hardware specific details. > > This patch eliminates the use of the group attribute and runs each engine > parser in the order they work in the HW pipeline. > > Fixes: 9c5f0070fa3f ("net/ice: map group to pipeline stage") > Cc: qi.z.zhang@intel.com > Cc: stable@dpdk.org > > Signed-off-by: Vladimir Medvedkin Thanks, this seems a great idea, to automatically put the flow in place. Question: is there ever a scenario where a user may need, or want, to override the automatic choice made here? Or is it just the case that once the flow is installed, it works the same whatever group it's added into? I would assume the latter, but just want to confirm. /Bruce