Re: [PATCH v2 0/4] remove common iavf and idpf drivers

[Bruce Richardson <bruce.richardson@intel.com>]

On Thu, Jan 30, 2025 at 02:55:54PM +0100, David Marchand wrote:
> Hello Bruce,
> 
> On Thu, Jan 30, 2025 at 1:48 PM Bruce Richardson
> <bruce.richardson@intel.com> wrote:
> >
> > The iavf and idpf common directories were used only to share code
> > between multiple net drivers and did not need to be drivers in their own
> > right, since it is just as easy to have a dependency from one net driver
> > on another as a net driver on a common one.
> >
> > This patchset therefore aims to eliminate the two unnecessary common
> > drivers. It does so as follows:
> >
> > * merging common/idpf into net/idpf and updating the cpfl dependency to
> >   point to the net driver.
> > * merging common/iavf into net/iavf and similarly updating the
> >   dependencies, including the paths from idpf (which does not directly
> >   depend on iavf, but does make use of the definitions in the iavf
> >   header files).
> >
> > Separately, two other cleanups are done - one to remove an unnecessary
> > warning disable flag. The second is a little more complex - it makes the
> > dependency between ice and iavf an optional one, by having ice compile
> > in the necessary iavf shared code files in case iavf is disabled in the
> > build.
> >
> >
> > v2: include Release note updates
> >
> > Bruce Richardson (4):
> >   drivers: merge common and net idpf drivers
> >   net/idpf: re-enable unused variable warnings
> >   drivers: move iavf common folder to iavf net
> >   net/intel: allow building ice driver without iavf
> 
> You'll probably need something like:
> 
> $ git show --oneline 9863a695075109f15bbfa2f1a3042139f25d6493 --
> devtools/libabigail.abignore
> 9863a69507 net/liquidio: remove LiquidIO ethdev driver
> diff --git a/devtools/libabigail.abignore b/devtools/libabigail.abignore
> index 585eb23c5e..03bfbce259 100644
> --- a/devtools/libabigail.abignore
> +++ b/devtools/libabigail.abignore
> @@ -25,6 +25,7 @@
>  ;
>  ; SKIP_LIBRARY=librte_common_mlx5_glue
>  ; SKIP_LIBRARY=librte_net_mlx4_glue
> +; SKIP_LIBRARY=librte_net_liquidio
> 
Yes, I see the libabigail errors in the CI now. V3 coming up...

/Bruce