From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C266C4614B; Thu, 30 Jan 2025 15:29:41 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7BB3B4066A; Thu, 30 Jan 2025 15:29:41 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.9]) by mails.dpdk.org (Postfix) with ESMTP id 4D665402E7 for ; Thu, 30 Jan 2025 15:29:38 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1738247380; x=1769783380; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=MJy20cyCIUpiCZYdc4xD/NOwLFec9xQ2XijvCXedey8=; b=RcjXqMhy12PWWaP7koQC/OWgQDCdNXYxxc2qlKamCJXql/1qI9UeGx6q iJA+Xi/NV3Jv4YSdBk61Gbn9C9dTh6EUg86Vr0jKObEBOsXz8BNs1YcFk 4ZQeircMLrKU6W4TsoapLrDNpDTgzA6bJ32BUEcbxeco1hnpx46hDMGEq irBostYfZQA6+YWEo5etK5oCrf3aF6K7L92Jcrte5blFHEllaIaB3RIXO NUUjAsJPKqoMTR/ncd3o7iF0T9QLEXlxmttY2Wm6qphvuD4gjTdIABeMF LdqzmbGWwfsqKsKls8kFR6Zi4gRriuCYkYi5uVobVC35Fe5twcD8S2wcT g==; X-CSE-ConnectionGUID: bOTCSYvHT5yyU/a3GXDaEg== X-CSE-MsgGUID: Qqj5EfLnQW6p8bwWQ6TeeA== X-IronPort-AV: E=McAfee;i="6700,10204,11331"; a="49445587" X-IronPort-AV: E=Sophos;i="6.13,245,1732608000"; d="scan'208";a="49445587" Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by fmvoesa103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jan 2025 06:29:38 -0800 X-CSE-ConnectionGUID: zksrprnfS+uhbWYuTcwOOA== X-CSE-MsgGUID: Gz30i77kReajxiLBF6P6Hg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,224,1728975600"; d="scan'208";a="113347436" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmviesa003.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 30 Jan 2025 06:29:34 -0800 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.44; Thu, 30 Jan 2025 06:29:32 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.44 via Frontend Transport; Thu, 30 Jan 2025 06:29:32 -0800 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.45) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.44; Thu, 30 Jan 2025 06:29:32 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=nUeD4Dw0Z5XSz+zxCw/lQKg6dJm/vgUSLv8oqGYtZRb2hS64pVkbEn1W0IfF5xMv43f28FAZRIX7VctEi8aTNzMxKBzB629uwy+sK7o79lPF95A272XcJjKiicZfHERz/eXaqBL2p1PztetUA7K5GD8zgWgLGF2KtRGFYFfoAvopuJwn6dcMnXCGmA7K2GqMl8qPseG1DnOOgX0ZY5BPAzZcCaOU8h6jnQ4rTYW7oXTEmNsS9+AYOnLdkMSKxnwUIuO99fvI5jGIBuJYJ7a9TK77eGrlIY9DlSq6OkIpXNbIj0xLqwMy3UvlTdQUDwBFCcmMvf8xgcHeA1cxj+91Og== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aL6Uz2yeCBoQeM+18XaUjybCgJb0qFZGJIKOO4mp6RU=; b=NLTwUitzU3/3QvPw1+FQ+rphAMxF459BNRF3Jwpbs77PL16E5wfll38Dk9bPt7OhPMHrcBrUoa+rI98sfJCDnQ6xzOA2Cr+fD1YhRsCziRQaUB69o5RkmFMWky+CjVBYjaR9rkze3T6y8wwzXsCTTzBTGCmSL+cf4mrUSgUxmVXCgeSVVqVWGKLZydAZI4cjfnJ4/cam/w+XE1z0Ykz2W5/7Tv1dTmelrzwKM/WHKCytbW4F6wEdUJJ/4yYUauPlC8H8zgoO1CnmwOBvbFwLN62xSr/A7HRVdDN1pEhF6DMXTp2D/IucAy89cNOcdMEfCDRza6m78PgH+VsLRUF0fg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by SJ1PR11MB6226.namprd11.prod.outlook.com (2603:10b6:a03:45b::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8398.21; Thu, 30 Jan 2025 14:28:27 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::f120:cc1f:d78d:ae9b%5]) with mapi id 15.20.8398.017; Thu, 30 Jan 2025 14:28:27 +0000 Date: Thu, 30 Jan 2025 14:28:22 +0000 From: Bruce Richardson To: David Marchand CC: Subject: Re: [PATCH v2 0/4] remove common iavf and idpf drivers Message-ID: References: <20250128163649.343336-1-bruce.richardson@intel.com> <20250130124820.433890-1-bruce.richardson@intel.com> Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: DU6P191CA0010.EURP191.PROD.OUTLOOK.COM (2603:10a6:10:540::7) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|SJ1PR11MB6226:EE_ X-MS-Office365-Filtering-Correlation-Id: 1ea79d9d-f5bd-4fc3-2d55-08dd413a5c60 X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?SFRMenJ1NkFSSHJFbjVVSCsvSFYyR1RSMzF4WUFNbEJuVEVkK1ZGdHpXRzdx?= =?utf-8?B?NEZ2WllQdzkvK1A3dkN2UmNQZklVVlQyS1UrSW94RU5TU1pJUTFDaTMrV2ZB?= =?utf-8?B?RHhUUStVek9uSlV1SVBBUjhlUHhHM1AxTE5EOW9mbEkraWpIQ2F3RzdDUXlU?= =?utf-8?B?ekhCd3hIbW9pT1JsU1JDRGlJRkNZNUo3Vm92TFIybVgvOWVycEhVSkhLaEFw?= =?utf-8?B?N3lrSG1RaFBlUjc3djRsR25XbkVpZmFleHNPdjQvQTJ5ejlVZlhaR2UvdHVH?= =?utf-8?B?R0JCV1kzdzFYb2NuOVAzSXJIUDZpWnhnS1E1ZGNsN2NXSjNuczBGM29PK2xv?= =?utf-8?B?TmllRFVNYUhFYk9aWUs0NTBENnhMOWZnYkgrN1hoQ0E0K2NSd2JPaWlHL1Bz?= =?utf-8?B?eDFQeEFnM0pPbTI0ZWludExLNTlQOUx1WmVta21KVzJUVmNjOTJQQmo5Tjd6?= =?utf-8?B?WnUzZk5uRnJ5QzNVaytBbDN3L0sxbEtvUWNWN3Y1dnVORUFSVWJncGRub3NO?= =?utf-8?B?R2pMM1dVSFBGRThpUWxFaXJwOW95aXZHOWVzaEJOd2pxTmoyeStUMUJySnJK?= =?utf-8?B?MUdyVTMrcmVCaFA5ZnR5WnZzRGFzSE5mUjRnQ3lhc2V3cTZHMjR0Szd1VlN6?= =?utf-8?B?ZDd3NzVZVWFLellzc29SV2Z4Q3hGZ1ZINTB0ZGxHN0pkYWdaK292bmhqZHZm?= =?utf-8?B?VFB2VXA2OWhRWUhhUk9aSTdWMmVxMDI2OENwVWF0MFdrY0VmUFE2bmFYSUR1?= =?utf-8?B?MVFJZGhhYkJvWmRrclRPRFlHNHJ5WmZ4eklXb2hDWEVkT0ZkaGFUNmRrZFFt?= =?utf-8?B?L1pRZG9Dam5zU0lwUmxtSStNRE9jUlZNNis5ektVMjhSbkZtL3FjUE05Ly9L?= =?utf-8?B?OTMzang2WUpQajBtRkVWY2ZGTGN1S1h3c1hXeDRldkVRbXA2MjdhWDZJb1R0?= =?utf-8?B?RWJKc0tGaHdrRUtjbE5iMWM1UDBWRHNBamt1VEdoNnM4eFVsV2Jla2NRUkNW?= =?utf-8?B?RU1ZaS94RWRKdTUwUVJTODVCbVhzVmNkcUY2d3E1MlpyTHdrVjZZd2RSQTBE?= =?utf-8?B?UGd1eVluazMvbFlkMVQ3OEIxNmJVTXR3Um9BbGZkdmhSZ1h2QUEvQ3JCV25P?= =?utf-8?B?ajdiMEhCMHBlNmNkbGU1ZmdYOElEZ0lKUnBqVEVacFFOazJFSW13ZVdBNmx5?= =?utf-8?B?a1R5RWN6Sk85V3lLbURnS0NBRU1CaDBnOXIrYXBzOVFEaDVFWml0ZWZwanNz?= =?utf-8?B?WGcvQXVVWlg4Ky81WjhmR1VWRDZ4cWtaK2w3VlAxQ0VOaTZubjlPdnVlRTBn?= =?utf-8?B?OGYrV0tIN2wxK3M5Sy9hOERvSlR0QTJJMmVFN05DMjgyT1Y1Q3k1cEZDZFhl?= =?utf-8?B?QWVCNFVqSGlQL0k4S01DZHFGYzFSRUdtOGRicCtGbXdGOG5HL0g1NDNERmFH?= =?utf-8?B?Y1NIZVU0Y010UUxacGhrRTY1NUJSeUY5UEtUMkN4clN6bExTOHAyeFM1WDQ1?= =?utf-8?B?UUIza3lxelE1aXNxQlZqcmQyanc3dU54cXVoeG1ITGxlbUJ3M2xUSFR0K2o2?= =?utf-8?B?K1E4dkVXTVFQZTdCaCtjaUdmRFVrNHJZTmE1aFlJeEN3VTlhQTkxNTZQeita?= =?utf-8?B?OFNEZ0RuQ1luUERVUWhEZVA3QWE4TGJ3Y2NFdXF1TGZZWWhFOVB6aWpKaGZE?= =?utf-8?B?M202b3puZmhkcXZPcVpZQ1RjRG4vSzNKd0JQVElZRmFMVzA5SWZwcm0rYzY0?= =?utf-8?B?SVpRYzRWMEFaL3BMcGRBdE91eHdvOWFkeE5JS0lSd1FhQ2EvVVlBVkNtcDZj?= =?utf-8?B?eGFLTEdsV2ZVWXl6SUcvY25ReWVISjVMZVpaSVRPUWZFSElnaTd2MWh5Y2JK?= =?utf-8?Q?jfNoh0D0lpBwF?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(376014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bEh1ZHcvZHNaZ2xUSnFSTHhRZ3pDa0N5QklqOCt1bytNUElqSGRpeUNRRjAv?= =?utf-8?B?RGlrTElPVitidE5WYXI5MzdwS00zdnJYbG1BbExjNW9EMkE5TXRwMDVNUEU0?= =?utf-8?B?K0FoZmk1b0d4VHVTYUhERHpZd3FrVk02dXNxa1FiNnBWeFFIYUVIa2IvN0NV?= =?utf-8?B?SFRkaVpHenRsZVhPL0xwd29SNnBHQjJ2QXdpdXhmcE92RmJHS0dGWDJrK1hJ?= =?utf-8?B?WTN3VElPZXNIcXkzc2xVN1l0NFRiL2MwanJ5ZjNSMkdxbU44Y0RyTjB6Szdi?= =?utf-8?B?bVRnV2FGOEFZY3JpYlZHNmdkVEtaYlJPN3VnbzJ2aFZudGp2OXNjQStIN3pa?= =?utf-8?B?YjFRaTNUY1VuTnhsRXVpZmVsSnV3K01ldGprN2t3djluVERCa1BYZ01uRUpT?= =?utf-8?B?ZGo4SnlMUXNhT0FFMmc2UCtYb2IxR1I3K29hOXJic2xXbEZZU1h5c2lOanQ3?= =?utf-8?B?RDhWVEtldW5GODhjaVdvb2ZaV2pCTjFJMVBoUkpzb2x0Rk5OTExySEdKblo5?= =?utf-8?B?SE9NZjArRFRzNEczbkY3TDN5SjZodUtVNDVzbDVzb3BMZDhrdlM5SUp2OVdj?= =?utf-8?B?ajl6c1QrQlpRVFNRSjJKZlg2QzVDemdyek80RWwrQmVrdndZek50NFg3YVVJ?= =?utf-8?B?cWxyK0lJN0RMNC9QUnJqMVpRVHdPczNSd1ZSdjdxcUdVYTRLUUZqQ0p3TGFy?= =?utf-8?B?ZStHTVRvaWdSS2pLUVBWMGJjeHVYZmhUUFdVelQ5bno1WklndzFVZURXQzJu?= =?utf-8?B?SzRITGZzdjBIOHJMcnNUa0hxR2tiT2QxOWUzUEFSd1pSUkFScWY4MEM4S0JJ?= =?utf-8?B?ZHR0Zzl4YlluV0t1aTd2aWZXR2JVUC8wNTVtSWZnVGhkOHdQQ1owaXJjeUFB?= =?utf-8?B?WmlMaHF0RkljcGhFVmFpSDNmL1lKZ0VCbnY4a1BINkQzY21menoyWnlrV0Uw?= =?utf-8?B?alJ6S0xEcDRaajdwRW9CdG9qVGs3Q1JlOVdrNHkzZGFLSUxtRHlrMWFDWVpr?= =?utf-8?B?b3ZjbXllOXEvVUV3K21MWEwvZWdhY3l2a2ZCemtMbzdQdGFXdVJ2ZDBtanht?= =?utf-8?B?ZWxHbk9IZVNUOEEzZ1RQcWI4ZzRLbU1kMmhkdVphaUpMZWM1RkRxdyt3SUxO?= =?utf-8?B?RnZVVE9xa3piay9yY1hzUGk0MkFkV1U0VDBuMk1PWFRBSHh6MytaRk53WEJU?= =?utf-8?B?L3laYzFFOWtGeWZUYk1USnREWFRkUlVUT1FpczlqSy9yNzFEVDF2WlMvYm45?= =?utf-8?B?RHRBSVo1RzFyWWhtdGZsc21wcGU2NmhWYkptbTduRmN2eG5pWGEwczducHUw?= =?utf-8?B?NWJUa1ZlbHpEZzJuYjdBN3JDem5EOVBQYmt3ZXA3MDhpTVhkdHc0ZE13cGlt?= =?utf-8?B?WmpET291YkZIRUgrMkVpSHdhVjRtWmZxMVV3QXQ2RkEzMmZaYUFFQW9tdndt?= =?utf-8?B?Y1NXTDJ1c2tBbVNpTTR0VmI0WUhiZ2t2aWxGVVpONDFOUURWM3VCUTUzQ3Va?= =?utf-8?B?U1dVOTFha0RRck9jS1dNNnp4TXE3blQxNWxHUUVYUThxUDZuY005ZG5mdmZy?= =?utf-8?B?Ukx2bFFuZG1adG5PYmZzbmtWVzVOS2kzeDZFcWZYbHBkRGhpUWtIOHVMeDlF?= =?utf-8?B?YU9ZcGtKU1VqOHd4WjNER20wOHZOaHpNRUhtNnIxdHFQeU5wRk1HZll5bjgz?= =?utf-8?B?Qy9UOUk0cUgrMXFMR1l2aWEya2RlL2QwQnNXUlNJM1pHdGllWitNenhZOHhw?= =?utf-8?B?N3owWk1VYU1YZ1R4aUx2WjlIY1hCYVZuMXRxWnNkbklzNVJtcmxLalkrQlFI?= =?utf-8?B?OENhbVJzMmF0V0JXK0NQNnltZ0ZQUVF6c1FIaDV6aXVnbm9ocGJXUnlFUm5U?= =?utf-8?B?cFVYeHNva0dPSDNpUXVTWDJDZ3JhYlJ3MUgzaXNWV0lvQU9nK3RodXkzbXNy?= =?utf-8?B?dFpLbVhObTgrb0NlSStNUUwzeElERHRpc3g5VnNycUU2VXIzZ09KU1gxVHIv?= =?utf-8?B?RHBjcVM4UldiRXVCb1VPU3lMQ2VxL0lEdXVkNnZHRyt2ZmhtVStqRGNwMElx?= =?utf-8?B?M0E4c3V6c1BIWGg2czJDck4zZi9FaFlGb1dkRW1tZWZ5S0w4VVpXMldYcGFN?= =?utf-8?B?SFIrZEdaSElRQnNER05UWk5FQVVUS3RvRGF4bFNHaFlzU01ONXA5WVNWd3Z5?= =?utf-8?B?emc9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 1ea79d9d-f5bd-4fc3-2d55-08dd413a5c60 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jan 2025 14:28:27.2405 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: nqyloAe84G2Km6PACVFCP3fZHsTAh63481FWlrRBvnGtXEFTdIUJkF0lIr65S+iyg8kYxIxKRRn963WeBzM2gQXQqAg8HWRcYfqkto8YgIo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR11MB6226 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Jan 30, 2025 at 02:55:54PM +0100, David Marchand wrote: > Hello Bruce, > > On Thu, Jan 30, 2025 at 1:48 PM Bruce Richardson > wrote: > > > > The iavf and idpf common directories were used only to share code > > between multiple net drivers and did not need to be drivers in their own > > right, since it is just as easy to have a dependency from one net driver > > on another as a net driver on a common one. > > > > This patchset therefore aims to eliminate the two unnecessary common > > drivers. It does so as follows: > > > > * merging common/idpf into net/idpf and updating the cpfl dependency to > > point to the net driver. > > * merging common/iavf into net/iavf and similarly updating the > > dependencies, including the paths from idpf (which does not directly > > depend on iavf, but does make use of the definitions in the iavf > > header files). > > > > Separately, two other cleanups are done - one to remove an unnecessary > > warning disable flag. The second is a little more complex - it makes the > > dependency between ice and iavf an optional one, by having ice compile > > in the necessary iavf shared code files in case iavf is disabled in the > > build. > > > > > > v2: include Release note updates > > > > Bruce Richardson (4): > > drivers: merge common and net idpf drivers > > net/idpf: re-enable unused variable warnings > > drivers: move iavf common folder to iavf net > > net/intel: allow building ice driver without iavf > > You'll probably need something like: > > $ git show --oneline 9863a695075109f15bbfa2f1a3042139f25d6493 -- > devtools/libabigail.abignore > 9863a69507 net/liquidio: remove LiquidIO ethdev driver > diff --git a/devtools/libabigail.abignore b/devtools/libabigail.abignore > index 585eb23c5e..03bfbce259 100644 > --- a/devtools/libabigail.abignore > +++ b/devtools/libabigail.abignore > @@ -25,6 +25,7 @@ > ; > ; SKIP_LIBRARY=librte_common_mlx5_glue > ; SKIP_LIBRARY=librte_net_mlx4_glue > +; SKIP_LIBRARY=librte_net_liquidio > Yes, I see the libabigail errors in the CI now. V3 coming up... /Bruce