From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A921041E15; Wed, 8 Mar 2023 09:19:42 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4624340FAE; Wed, 8 Mar 2023 09:19:42 +0100 (CET) Received: from NAM04-BN8-obe.outbound.protection.outlook.com (mail-bn8nam04on2103.outbound.protection.outlook.com [40.107.100.103]) by mails.dpdk.org (Postfix) with ESMTP id B1DA940ED6; Wed, 8 Mar 2023 09:19:40 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=B3JgzSU/iWQ9unm3qNxtoi/wVeYRm5+iL9FydGRGv2eVFDZM5veJ5A33kGYFCLoCVb9uTsl2qtvGSMewEhArIA7PsEp0GtdxeoibG1+ffp6UOIh0kJTp78weODjwE46Fm3xGEL2N6QXmbEUnUhNWQiqUaP8RHAicNenla7LL8O/LqKvO3zjOdNeP5EBODhyxS1gwEAQlzi4Mhzv57+zOEKNbJ2KUUCKd10Ln8fbc/uG15WLNXDqXHpxU9S9ZIKJMI/eIsfYGgqXUYPMpItP0Pth22WjvwrrgyBOoQYduAkaeqbcwJTFH5RznWH1Qdkpqz15wV6p/+NKZ4PMA/f0qGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YNIdVe4JlATrHfhVrZ0lXAfD8NB2KeNHaJFtx9HtrN8=; b=lKwubkSPFvcFfDhquvYyvJucOFTwaK1ribaYSde3CEvvpxjclD7qNSzfsJuDfFB5bUjS8lOVWq2nmEbTpf5m+Vx7STochgGXGyfJ39IRRnXkkLtDdQp4O+q0reCtWMWaqg0H9xtk51ND1tVTB22K2WuhEK1V1R0PRdmrwOeFV8blcP1Vdnf5MoFD51ScdNqum4Ub4eTcurj00O/I5PlsOdGs8gMoRNrH8dkn+j9tZg+Gs8Xau9QECeou88/Br5y8LiEzQ7+reXNOfAsSCg/QLJeMOiGFfRs3PF1Yn0BkYwnu5M2u7kpF+rOsX8yWzs2yU0/a+jkLMIPjA/Eu7Viasw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YNIdVe4JlATrHfhVrZ0lXAfD8NB2KeNHaJFtx9HtrN8=; b=j6o0YYfX0iggdPVbuF8B5IeePdjfc4Bg5iRjxoqLTf4dBARWSdU7MhSx9ZBKX77VU7xfi5cSPvBLR0XMtM8Kl56dCpqK5e9/ptuZWOyndATgY1HLidj8GU3CvNYhFjSzy9SBcLvhKvUsuK66AKot3s+KU/xV551nM1uGPaCv3Og= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; Received: from SJ0PR13MB6037.namprd13.prod.outlook.com (2603:10b6:a03:3e2::9) by SA0PR13MB4112.namprd13.prod.outlook.com (2603:10b6:806:9f::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6156.28; Wed, 8 Mar 2023 08:19:37 +0000 Received: from SJ0PR13MB6037.namprd13.prod.outlook.com ([fe80::3de9:ee63:e093:7866]) by SJ0PR13MB6037.namprd13.prod.outlook.com ([fe80::3de9:ee63:e093:7866%3]) with mapi id 15.20.6178.017; Wed, 8 Mar 2023 08:19:36 +0000 Date: Wed, 8 Mar 2023 09:19:27 +0100 From: Niklas =?utf-8?Q?S=C3=B6derlund?= To: Stephen Hemminger Cc: Chaoyong He , dev@dpdk.org, oss-drivers@corigine.com, Peng Zhang , stable@dpdk.org Subject: Re: [PATCH] net/nfp: fix MTU configuration order Message-ID: References: <20230308023318.3041151-1-chaoyong.he@corigine.com> <20230307184409.46daaefb@hermes.local> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230307184409.46daaefb@hermes.local> X-ClientProxiedBy: MM0P280CA0008.SWEP280.PROD.OUTLOOK.COM (2603:10a6:190:a::30) To SJ0PR13MB6037.namprd13.prod.outlook.com (2603:10b6:a03:3e2::9) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR13MB6037:EE_|SA0PR13MB4112:EE_ X-MS-Office365-Filtering-Correlation-Id: 5f587968-3a3c-4ed6-e72d-08db1faddaa7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: PJAyA52QWIU5/9Uj/6VJrS1/lwRao71JCIeJa9ATEeBQX1klMvRHwCHMav/X3azQ38gb+gcM3ZCfw9FXShAxX7L5KPn6DrJ7N5dNI50058K1qAvVTwLat9YD7khQbsM5l1If0EwWqqbboU+K/xxMUXsrRnX+7ue0HjClTzMpc0Flnb+YBnhgM5C1ojC/sUJs3yXy8xP1JU8Bm6Pzs63hnagpxUOeMYHQ4U/X08l8NGa9oSnEH3eyxa5BRCMP/SyMKVdlgcFgcOd2zSMNlqiYCUjM30V+I/vhwM9whsJHTibwC+fVoyiiSKHOPADoZL44Usll4ik/KnT3UL7sGRc1z9nh/kArmutvEeQ/UBVDpM/pRI/vTHwtp63Bod65S07yvF7dEeTpyX0hkBPLDRneTYAojO8rXgAsES1+lNTD5nGGWHENmxeiVp5HA4oICT9XuyzRgm9WS1G06K1RRvWXQ90bY+kYThT2tU51mr08TQazohLgsAsaW9CAIIrvoLvOodELmOf/gBIbSRbKNMW39vv3joBxyYHhc8D00BgK9KwKyenCVvfipdRbvPoPG87cjn7pnM4lRwph3XpWpBhVuetZSXzkxYv6EhuplApqECXQRXebmzKtDfIc9BDqAQBbOlCQmXE/8dGutgN0o+ARCA/T5bQNJqcfXZ9Nt1QKzdoQBHekoFZIoSCws1VJYUgU/oOdfVzMRYl/wgX6dAH4itgrplKaeuJWuBnphwrjVG1l1c5FQgaE75/YdEoGo8/5 X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR13MB6037.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(346002)(39840400004)(396003)(136003)(366004)(376002)(451199018)(66556008)(41300700001)(4326008)(8676002)(8936002)(5660300002)(2906002)(66946007)(86362001)(6916009)(66476007)(38100700002)(38350700002)(54906003)(478600001)(52116002)(6666004)(6486002)(316002)(6512007)(6506007)(53546011)(186003)(9686003)(26005); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dzJOSUE3T2F0VEx1WlNWVTBwT1pqNS9sSWNhT0xYbktIRW5CMWExaTlyaDhZ?= =?utf-8?B?bmhSOVduVDdXTm1EdWJWWm5KZEllUmxtUkNEeXRjN0FkYS93YlI5RGN3RHNl?= =?utf-8?B?d2tXU2VnMloyOUIxZlVKTGhtSTdaa2F6WldHU0o4NHFFZzYrL2VETlNoQ2NY?= =?utf-8?B?cGZML0R6THk1bm1KKzlwamNTczYzc25aWlFyaGJSQVlCMmdTUmdSSzByaC9a?= =?utf-8?B?U1JwKy9rN29zMHl5WjlEaG1tMk1ZQkNpRGVWTEZaYWowM2xITXRyUHJhazVu?= =?utf-8?B?Y1pkdVpteUxhSERsY1ZRWjhmZVpkbFg4VDkvMDYxVjlUYmh2YXJGejA2QmZu?= =?utf-8?B?bExtdm8yczVvS09ldWJ4alMrTTNCT0s4MkRlQkZ3OC92R2Yvc29Fc2lZY3R6?= =?utf-8?B?bzBEZGRsT3hXZS9aTWU0ZnVVQWFFL2hqUE5XWWEveWlGbzMrclh4YzdjaE8r?= =?utf-8?B?MFZxMzlXcFM3anFmcHVjbSt2VXNuYXY2UnoweUpFb2xmNUVPR2xDN1FRZ2RI?= =?utf-8?B?MHhBREpwZ1NhUW9CNWpqWDQwZDVvTHhyMFdsL2VrN3hlWEUzMEc2N25KVWw3?= =?utf-8?B?RzRuK0cwOS94OVB5dzJQazBjOXZjZk5VS1c0c2lMRFc4dzBpSVdrZmdqODdN?= =?utf-8?B?QVZMVGFUbS9yeFB4YllIVWVLeXJIdVhXai9laUQ4ZTd3VzhLQVN6Yi9GUm5T?= =?utf-8?B?d09VY2hGTEVtNzFaSEJqQndrSEtzWWE1eGpXS0duckYweWxHdU1ydmZXck1u?= =?utf-8?B?K0pvdDA5em5QNWd3MW1XMmRiK3VTbG15Mk5WMHcycGNmclhOZW1LK0Q0L056?= =?utf-8?B?S3FVcXdWa3JGOEJiQ1dCNVZLL1l1bXNndFZwYldCVDlhWDFIa3l6VmIzMmN3?= =?utf-8?B?aGdTY0JRUW9OYjEvMm5Nak1FWHBYNjZDL1pTbVYwSXlMYXowNXJwbG9jVm9R?= =?utf-8?B?eGc4eHo4V0g5M2hTSm5SQzJ1ZW9VT2p1UDJZU1hQZHZhSUtNbFZjYk9wVTZ1?= =?utf-8?B?di82N0xQV1ZQb2tFaFEycmQvdS9pVEpKOGZKclp3aDBSVWtKTnRaWHcxVURC?= =?utf-8?B?Q01QQWp5WDAzdDJCQkg4RHZtc0ErR3pySEtmUnFzcjBycGhXQ0JlelNxVW1M?= =?utf-8?B?ZVY2NU9Hb2ZKTXc5YTQwRVpYYVMzaWdNVEIwN0VqdXo0ZkRGR3htdE04VUNj?= =?utf-8?B?eFZ4V1R0b2Q3SHUzbUFLMWMwaE93OTRDaFJKU0VUWVliNlM1VGdPa2t6dUN6?= =?utf-8?B?MGdCWDZXb0xIekthVXlGNDNoUFR1MjRrT2p0Y2lMeVBWY0E1L3RsYktnRjdo?= =?utf-8?B?SFh4VUFTc2k4RFZCR1J4SE1LVUtNRGI1blM3RlJ1QWRyQ1Qrbm5EZGRpQ0pj?= =?utf-8?B?SkFvSUdGcHAvZkJrK2U1azN2TVJpcTN6cWd4YXB3Y2dJSEpERHJrUU9iaTd5?= =?utf-8?B?U1lvdmNidmlXcVJJQzExV0NQVXN6aFduTnZOekl6MkJpWTZiZ0pHUmYyRUJ3?= =?utf-8?B?c0NBNTRFL25ZYW5vYzBqNWJIUXZlQU4zamhjWlF1akR6djgwZkROWFRzT0FL?= =?utf-8?B?OXJMWlJrODlHUmFUaXhtYU81SjBqQTFVRk9JWHFQUlA5Mldhd0xZUnEvRFhD?= =?utf-8?B?ejlOeTlhOXhxNHNIVWFaL3NObXVmbDVzT0RydXdZVDNvT2lHMW5MVXh4K3Ir?= =?utf-8?B?N3Iwd2dXSVlQdjdJdk92bmZRZVJSWEZuWkhNb25zK0Fibm9md3lJcG9ZekYr?= =?utf-8?B?dUphRWFBWWo5NE5aUW5oMzNLVFNhbEI0UU8vaFdvaXBSMnk0VmFnU0h1Yktn?= =?utf-8?B?NmJWbzNySTB2U0xHbi9yQmRkQ2hyaXhKTzdnZ2o4b09mUWN5ai9xYXcwOW9m?= =?utf-8?B?cW9pQ29MbSt6djFIRFNiR2ZHUGozdEZwYTd0V3h2UEdFdWIwbG9qNm8zV0lY?= =?utf-8?B?V3Y3ZUF0UDhEeXVzMUFkNEw2dFFoNW9sZVA2WUk1Uk1Nb2Yva3g3dnlFa2dk?= =?utf-8?B?L1dkbGJETWU3YTVFOVAxbkRsRXozc1p3WXJPMU14QmdDR3dHYlFwU2NBenhI?= =?utf-8?B?Z2pVTmFseWtlUHZVK2VVODZKRDd0TzZSVzJoclZtYzdWdE91Nk9jZEo5SVhG?= =?utf-8?B?OUJhc3F0UEUzVklTQzNwUytINHRSOTV1TGJMc1BNMEZ0M0pXWlU1bnBFdXd0?= =?utf-8?B?blE9PQ==?= X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5f587968-3a3c-4ed6-e72d-08db1faddaa7 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR13MB6037.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Mar 2023 08:19:36.3640 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: cO4gxa+vXfE0lJDOm/m5gVLiqf+iVTZuhtHKBsQ9Ys6EEw+UALwVLzYdT+7X+ptS0Q8FbgNCZakIg9/1HdKxyXiXxbMpAsR65s/pEKDkQOY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR13MB4112 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Stephen, Thanks for your feedback. On 2023-03-07 18:44:09 -0800, Stephen Hemminger wrote: > On Wed, 8 Mar 2023 10:33:18 +0800 > Chaoyong He wrote: > > > diff --git a/drivers/net/nfp/nfp_common.c b/drivers/net/nfp/nfp_common.c > > index 5922bfea8e..5d92b476e2 100644 > > --- a/drivers/net/nfp/nfp_common.c > > +++ b/drivers/net/nfp/nfp_common.c > > @@ -1126,9 +1126,9 @@ nfp_net_dev_mtu_set(struct rte_eth_dev *dev, uint16_t mtu) > > return -EBUSY; > > } > > > > - /* MTU larger then current mbufsize not supported */ > > + /* MTU larger than current mbufsize not supported */ > > if (mtu > hw->flbufsz) { > > - PMD_DRV_LOG(ERR, "MTU (%u) larger then current mbufsize (%u) not supported", > > + PMD_DRV_LOG(ERR, "MTU (%u) larger than current mbufsize (%u) not supported", > > mtu, hw->flbufsz); > > return -ERANGE; > > } > > Patch looks good but this looks like unrelated whitespace change. It's a tad unrelated, but not a whitespace change. It fixes a spelling mistake related to setting the MTU, s/then/than/g -- Kind Regards, Niklas Söderlund