From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9E32441EC3; Fri, 17 Mar 2023 22:12:23 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7CDF842FD8; Fri, 17 Mar 2023 22:12:23 +0100 (CET) Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) by mails.dpdk.org (Postfix) with ESMTP id 7087542F98 for ; Fri, 17 Mar 2023 22:12:22 +0100 (CET) Received: by mail-wm1-f46.google.com with SMTP id az3-20020a05600c600300b003ed2920d585so5874645wmb.2 for ; Fri, 17 Mar 2023 14:12:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google; t=1679087542; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=v1QK4JESYS27VwjJD5oJixRC9hF49l+WBITwFBGf6qk=; b=IZulLmmFtZQJaKF9fgZdgqhTSzQqKe1cDr6sQ6YDYf2ClVbD53keiuRmCXrHhfNXf7 VPAkvdPHyzVXAD21c1Xl7x7kQ+HSYAnGIhFVszzqlcg1cx8tOakXZtWEgXKvE7hnJLSf ik8/TXTQSUU4paXO5yHwH9HFfMVeyev1vuV/T2My56acMOze15nytGrQ0N/tG8h5W/Sb m2L2DgJc/qECaUMAmS1oNpkONWAlCvnoV7Jo+EJDJ498ua1w+PGOrDhDLsnFuhgIROGx 9ZEdGkVmHVJxPgfBnTLKMFu7caZs5T461IevbqAfC0Gftmk8BCw1FGnxb+PsVzpPliiD lmXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679087542; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=v1QK4JESYS27VwjJD5oJixRC9hF49l+WBITwFBGf6qk=; b=fXf0qQcqLIaIDbWzr6COCb9/y2OtLUN2iIC8O5Bttc0COyfawgstVe33XM3NOirM3s M2AFaWLreLTYJWdB7DSoxH7ctbQQ0MF9XzreBt7X7IF54NV2MJV2cfIM7e3NYNSNnUBP VFjhRg4AaMi0XjnHSc/Gs5yo37rSwJBGH+TyxS8IHbi65HDwLkHHxdLrqi5M+vmdmx78 1q94viSml4rMU4CI5cIfudufq0vgzMb5wA1nA5XYLVSeKXW9pqcox2v1fQCLhYNjg65c JVd9xeyt9nPaLhUZzIBhWYYiHNONm0NrG8n0SjpW7/PxpRF3dRGsMjz2GB3eOiLk8Y0t D38g== X-Gm-Message-State: AO0yUKWlBvJzttzBs0FDaEtfq+bb80NBMNkn/RrpfBW1tU9tSoOp8XNN AR3pFZgUEx6WJahx6UV9qkNpWQ== X-Google-Smtp-Source: AK7set8B35curDVZSfRqVyYBlSBdOHepgqqERLTIaRpVwc6WQpbpDS31RSBSRuOnluxRUClc4PTgnA== X-Received: by 2002:a05:600c:5250:b0:3ed:4627:ed09 with SMTP id fc16-20020a05600c525000b003ed4627ed09mr7638681wmb.28.1679087542107; Fri, 17 Mar 2023 14:12:22 -0700 (PDT) Received: from 6wind.com ([2a01:e0a:5ac:6460:7be5:dd98:fb1:278]) by smtp.gmail.com with ESMTPSA id o4-20020a05600c378400b003ed4e078c92sm2998239wmr.11.2023.03.17.14.12.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Mar 2023 14:12:21 -0700 (PDT) Date: Fri, 17 Mar 2023 22:12:20 +0100 From: Olivier Matz To: Stephen Hemminger Cc: dev@dpdk.org, Aman Singh , Yuying Zhang , Ferruh Yigit Subject: Re: [PATCH v5] testpmd: go back to using cmdline_interact Message-ID: References: <20230313171905.67720-1-stephen@networkplumber.org> <20230317165941.62619-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230317165941.62619-1-stephen@networkplumber.org> X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Mar 17, 2023 at 09:59:41AM -0700, Stephen Hemminger wrote: > The cmdline_poll() function is broken and was > not fully tested, don't use it. > > Instead, use sigaction() to cancel read character on Unix OS's > and a new helper to cancel I/O on Windows. > > Fixes: 0fd1386c30c3 ("app/testpmd: cleanup cleanly from signal") > Bugzilla ID: 1180 > Signed-off-by: Stephen Hemminger Acked-by: Olivier Matz Thank you