From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2D010428D2; Wed, 5 Apr 2023 12:56:21 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C781441153; Wed, 5 Apr 2023 12:56:20 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id 0E4FF41133 for ; Wed, 5 Apr 2023 12:56:17 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1680692178; x=1712228178; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=u8idBXpLSMMCI8V/1lSpAIGCsJZOe0k+sxQa2DG5ggg=; b=MXB1LizX5to/rQ3jPwtOodO4qgv+7V2v1tkCK0ihGYaHp/LjS6TG81OA LOyDHNrLSTTdvn6qTrKNyBsRj+7KG8HGIym6jyBFw6IptY2E/fqAo8OsH 7WvBIweOnVPwC/oFBUZ8+6h/OJdvpN+X20nNXgurNYR3FAoe5MD4mwhrD pCKc8TqjzOT2yK2UjwZsls0d6h0X5E/QQqe1xSzdQ6RJxVbjcIy+2pQ99 xvpHkfX2bGKCnOJFgPI0ecTpozugYUP65ehiSZdQim4QzM1BJNPrkU5j2 ycMFlSZypT5bkJBrBxyW+EhZZf5ZIwuEzv//d9F0Krt1Xfgc3L9HLqD4a w==; X-IronPort-AV: E=McAfee;i="6600,9927,10670"; a="341146076" X-IronPort-AV: E=Sophos;i="5.98,319,1673942400"; d="scan'208";a="341146076" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Apr 2023 03:56:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10670"; a="716988618" X-IronPort-AV: E=Sophos;i="5.98,319,1673942400"; d="scan'208";a="716988618" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga008.jf.intel.com with ESMTP; 05 Apr 2023 03:56:16 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Wed, 5 Apr 2023 03:56:15 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Wed, 5 Apr 2023 03:56:15 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21 via Frontend Transport; Wed, 5 Apr 2023 03:56:15 -0700 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (104.47.73.44) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.21; Wed, 5 Apr 2023 03:56:14 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XRFVlFXoeGXC/3w/vsyzcMrcoR2nPWAzlb2oN5ivgKYlOVNsYfJXipeUXuvUSslYDsyf3nKb0iUMETyb+1zBX6lz9dbzQAiWKslPTKV0mC6wuWgpk/+I0GV63+pKOah4yMnudLSDNKYzkT+kNbHQ2+eWQr8JZYxWXTPt/z0dEWx/L0y8DVdwkNSpcICKQOuLTQ5kTsApP04uYtiyW+M/zZ9KNH4AtS4xIu7XYDZZ/vxf2d//HnQBTj5V0+EuD2BUO+0TaQRpyxH0OR+D3LPFobbNZ20Y7YhEoEgn/K3qhQojG6XXJHNlgCKrtNWnhOgRjOnOrzE/d8LJRuZQa8Wmow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7WejWCYQw0vqSo5EM2aqtIVG/0mLr1STMKGadsLHe54=; b=g0ZUVGzWoCdDt1ST14byGNYGCFEHw5OmeLAO2nQWMtMBLW9xUiWSe/A6TLrwNOqUQhfCmQ2oZ1w1EsIaVrgZYTt8gaNVFSub5yU8dOTzFm/BY0XgoRgsfwT/a053A6NzWHMeQBvy8grZGBI90klO63qmM0FAYedwPvsdl9Ajs9suIe7qfbaFLMu7X43jfxS3ylLiBFTDiFYbigBiV68h7oOwKCzKAIURACg5x8PesPbE6JOcUE0cx/VDEo9nuCcbJT6bMtKcJPLme474VR/Gd5ITkGpckn0zSsHltVDb1u92bNh1nZIgovVLH4gAE19EVN8PZi0x5fI47mF5OoXUFA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by BL1PR11MB5553.namprd11.prod.outlook.com (2603:10b6:208:31f::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.33; Wed, 5 Apr 2023 10:56:12 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::18d0:ac53:aa1d:d19c]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::18d0:ac53:aa1d:d19c%6]) with mapi id 15.20.6254.035; Wed, 5 Apr 2023 10:56:11 +0000 Date: Wed, 5 Apr 2023 11:56:05 +0100 From: Bruce Richardson To: Tyler Retzlaff CC: , , , , Subject: Re: [PATCH v2 9/9] telemetry: avoid expanding versioned symbol macros on msvc Message-ID: References: <1680558751-17931-1-git-send-email-roretzla@linux.microsoft.com> <1680638847-26430-1-git-send-email-roretzla@linux.microsoft.com> <1680638847-26430-10-git-send-email-roretzla@linux.microsoft.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1680638847-26430-10-git-send-email-roretzla@linux.microsoft.com> X-ClientProxiedBy: LO4P123CA0019.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:151::6) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|BL1PR11MB5553:EE_ X-MS-Office365-Filtering-Correlation-Id: 143687e3-4e5d-4c2b-9e5b-08db35c45e41 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: sQGHe7Q1gEvAeHtyCobXCfcoy6XExyEH0s/bhas2KN++YBBej5A5oY130GFaHoPL7Cr9RUQDjOgMo9lyTeTjlVcKYzx/n1IdmWLXif3Sc3kcDePAe2mNxXZDi8nzUUOMWukFoS3ZrnPrBR94ZKFn50UlbXMRsUur9z/L2D1I1bBWioGgYECC8wTEDc09VLLp5ARcqqv9Sc5aQHV5WBn9L2vlkhsvK3BHFfWedYVe0vdBsA2J3/HnnvOb786K+knvV4HkH5uLqkJ6OtgGp2ddXpwqcvNBTttH2MyVA7erQeTvl2pA+XgslgurxSi28y0KrwTZLsXGMAmckM9+oFVLk4ikG6YLBqJRZoyMcB17I4PZw3IBsAOwcYlkAaMNbDV+lxGJwwBZcli2etnn9+fA20o5/G1RDVGxGfpidLesajPWwocNHVOe+BOrAbJSW1ey12qNzKl7hI+p9qQhDXagpxFAQQ5psalO0JdmYigsl3UXKNXeS4FGM2DdN1Mg8V+BD6euUK+OUcBEJvAEzqPZfOQccINGW+OoWYqrFRDuNNyuKdfZBVWQmbayUw5S1b3G X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(346002)(136003)(396003)(39860400002)(376002)(366004)(451199021)(38100700002)(6486002)(6666004)(6512007)(82960400001)(186003)(86362001)(6506007)(26005)(66556008)(66946007)(66476007)(8936002)(2906002)(5660300002)(41300700001)(8676002)(6916009)(4326008)(478600001)(316002)(44832011); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?1cWhQJdcC7rKj5G8sysgvctv8wl6XB4V+TS3jzNbiinmsoqGNc773fMsblst?= =?us-ascii?Q?l6fSWvoF4SKe4bgriQfIVrM5t//PjTRnkpU1DiXk+lW3g3OfRK2fgtnE1B7b?= =?us-ascii?Q?N99JOEAqZQ8gk9Rn217lCvkkW4sYNNfvJktf99uQ3YToC61QWS75upiUfLEC?= =?us-ascii?Q?Y04UKa2YF00egsStR5ufJVv05vPgGClEAGfqT4OPSFH38fRLBGI4ZV3k2pDO?= =?us-ascii?Q?Ype/06VT5pJajAyNC4YHEyEOptAPoafJlPHPx9cPdGPWTRxrROWN+xL7Igje?= =?us-ascii?Q?iP/rEZrjOq/PAqjDYeDX0jGZOMCx6cic7+QfYrVd5ttPS43oOcsoJPNcGaH5?= =?us-ascii?Q?14jxDXe077v8fx1uooEBd0ZHJRw8GBgPxflxfQ90kFwYrjX+IGH40+zenrBF?= =?us-ascii?Q?4yfAqNUtjW5Z1zC4kLqlTZVqeQuPolfLs6VP+LjSWwu8Zw4y/NAWyAfVErsL?= =?us-ascii?Q?Z3LoPE9BevNib2Udgh5yMYTCgR1UIzBWVQ6oCcvq538hB5jZj7BaSiaLhoS4?= =?us-ascii?Q?XiVe3gAT3po4tmLucP0I8f8PMTrjUeW6bM8SV5Zy6aBeZHfpmNAKw1uTRhlu?= =?us-ascii?Q?jEsEmPyGMOEcbRlVujr+oVpars5c+QRHzDu5BLjLdKL4gQ/KSVwBq7F4YEEJ?= =?us-ascii?Q?vqlB1lLOJU2X6w+q/ZeKluZnpI8YLpaOADW1goUJ3yNkk0SNp9aE7RHbkOCG?= =?us-ascii?Q?3/5REvKJWySSBDDxW71ZA5tVOsddrm5BX0Pu5/3zdovsrvwuEeDwjxWhh3zq?= =?us-ascii?Q?1ISBtZPCqtT83vzS87fcfW5tqjiqnl56qGwDTUvwO/j8giz+I8VDWQ4hwair?= =?us-ascii?Q?9YNuwvNG3TCq8EjG23M3CkgBWz2od5aYFr6H796C5kX6f7MSK73vEiFDF/K5?= =?us-ascii?Q?4oiDt/ltwHUtpt1KTu9zvmRx1CSOjAlnbnkgK4tB9sgKoc9muPoqdLufJA97?= =?us-ascii?Q?71eQtWhY3r3He71IxU2WbQL4+dS8kKnwpqH1JXzH5YWd+MiVURfgRR7rPrrO?= =?us-ascii?Q?57ld9Rz8nHAccSQMOps0zeE1wtRnqAa+s7rQu4tzTGBfLfHoRVBsLBYgXfnk?= =?us-ascii?Q?9ltouQEcPd7DKaagYLvI0SnpATbPJhpS/Zsbx3oEv/hjK24EuzAHWfDNiinC?= =?us-ascii?Q?IscLlHj5hy6hxN02e5iuZcPPARwxLCLV+d6FsyneEQh7S0gUk3fdNN/SnIkR?= =?us-ascii?Q?7zYgQsotLS+Ig3QnN1Q6jCsDSCmDwQSjwGIDYKHblYD751JZh6+GsCJfj696?= =?us-ascii?Q?IWduL3oQGnFnyQQCvJGfge3Kacd3KuOprBxN+s3fkECSDxCDhWOdza6Wi/5J?= =?us-ascii?Q?1dTIEUZM5SWb2370s73x2rWiQubLQemZQ0YdbNfk6SUShA+th9SWm0Y8Zshf?= =?us-ascii?Q?oCfZED0IkcfGj1h0bNBmhZQ08SrqRCEhumkeSvITQGZqewT/eMYqr2OSm73M?= =?us-ascii?Q?WfR053WyyC/zawLM4iHT84v0rwZyvSMj99/oR5C8TlWhFm6xMxrJ+YP9ulHb?= =?us-ascii?Q?tPJfcP5ABmMFU8SSRBd+nChtyKm/4XT5qVFl8yChtDRs+4xODGzPTMjcFuYz?= =?us-ascii?Q?VYHkkiUnHvaGZP4S60gTgQVCjv2yEIVfV4xg7vmP4aIjEx0QjhD0eN8QBZLl?= =?us-ascii?Q?6A=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 143687e3-4e5d-4c2b-9e5b-08db35c45e41 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Apr 2023 10:56:11.6042 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: c8mNS89KywNFpqZK5PNQaE2qoYA7y4hSQFvA2+wxf4qI24DEIIsUlevrohDhqKdQsr7puZz7p/Akf0My2Hl8NHp42GyZRUWFZw7zF3x7bFc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB5553 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Apr 04, 2023 at 01:07:27PM -0700, Tyler Retzlaff wrote: > Windows does not support versioned symbols. Fortunately Windows also > doesn't have an exported stable ABI. > > Export rte_tel_data_add_array_int -> rte_tel_data_add_array_int_24 > and rte_tel_data_add_dict_int -> rte_tel_data_add_dict_int_v24 > functions. > > Windows does have a way to achieve similar versioning for symbols but it > is not a simple #define so it will be done as a work package later. > > Signed-off-by: Tyler Retzlaff Does this require a change in telemetry itself? Can it be done via the header file with the versioning macros in it, so it would apply to any other versioned functions we have in DPDK? /Bruce > --- > lib/telemetry/telemetry_data.c | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/lib/telemetry/telemetry_data.c b/lib/telemetry/telemetry_data.c > index 2bac2de..284c16e 100644 > --- a/lib/telemetry/telemetry_data.c > +++ b/lib/telemetry/telemetry_data.c > @@ -82,8 +82,16 @@ > /* mark the v23 function as the older version, and v24 as the default version */ > VERSION_SYMBOL(rte_tel_data_add_array_int, _v23, 23); > BIND_DEFAULT_SYMBOL(rte_tel_data_add_array_int, _v24, 24); > +#ifndef RTE_TOOLCHAIN_MSVC > MAP_STATIC_SYMBOL(int rte_tel_data_add_array_int(struct rte_tel_data *d, > int64_t x), rte_tel_data_add_array_int_v24); > +#else > +int > +rte_tel_data_add_array_int(struct rte_tel_data *d, int64_t x) > +{ > + return rte_tel_data_add_array_int_v24(d, x); > +} > +#endif > > int > rte_tel_data_add_array_uint(struct rte_tel_data *d, uint64_t x) > @@ -220,8 +228,16 @@ > /* mark the v23 function as the older version, and v24 as the default version */ > VERSION_SYMBOL(rte_tel_data_add_dict_int, _v23, 23); > BIND_DEFAULT_SYMBOL(rte_tel_data_add_dict_int, _v24, 24); > +#ifndef RTE_TOOLCHAIN_MSVC > MAP_STATIC_SYMBOL(int rte_tel_data_add_dict_int(struct rte_tel_data *d, > const char *name, int64_t val), rte_tel_data_add_dict_int_v24); > +#else > +int > +rte_tel_data_add_dict_int(struct rte_tel_data *d, const char *name, int64_t val) > +{ > + return rte_tel_data_add_dict_int_v24(d, name, val); > +} > +#endif > > int > rte_tel_data_add_dict_uint(struct rte_tel_data *d, > -- > 1.8.3.1 >