From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3E97E428D4; Wed, 5 Apr 2023 18:18:15 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C14E641153; Wed, 5 Apr 2023 18:18:14 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id 8B94141133 for ; Wed, 5 Apr 2023 18:18:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1680711492; x=1712247492; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=SmCVwYy980lx43HkCEgQuPx1xBhGS/GKaxQAfHzJXAs=; b=FiZv267PNMjTkfM4rYcv6N80L2yLgCdV4rutVN6mtdd1O6wVTFTfxRra URYgHES4zlTPwqWiKvwYaXHRPO+8On0H07GczNwbzxT/4q10tFxG63LED qfnKBasjkPeUWuTCq+d2u/T2kdl+YaJ5prXjlUX8vev8b+6hCPTDmrM0C K9VUr7aid2i56sihD0oco0H40xDZ/B6JbJ3zs2+HFHHVXpeet6VRnIRed 1QVWY+FvtmNCCJu6Pb6ZAPVmpcphBDnjVD5nqOOMU+zv5UuwStBqE47W+ t4JDCQFLGI7HDQCqzvuZdLBGZG4uwvYqBLp2sTIcslQVawMWr1lr1gGIt Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10671"; a="331103148" X-IronPort-AV: E=Sophos;i="5.98,321,1673942400"; d="scan'208";a="331103148" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Apr 2023 09:18:07 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10671"; a="751312981" X-IronPort-AV: E=Sophos;i="5.98,321,1673942400"; d="scan'208";a="751312981" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga008.fm.intel.com with ESMTP; 05 Apr 2023 09:18:07 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Wed, 5 Apr 2023 09:18:06 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Wed, 5 Apr 2023 09:18:06 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21 via Frontend Transport; Wed, 5 Apr 2023 09:18:06 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.43) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.21; Wed, 5 Apr 2023 09:18:06 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FN5ltLx5QZrt8uFrV2WZL+iGtq8HVsjghB06jjr/aGZ3BwMEW2o1P8J/IiMCf7GUXn7EA0oTRGCqDSgFfnQCH3wInWL2I5stNl99CF5xp05hnjjFVYi1Yig4Zn8ZhY69a5gGAFf3LD9NUi5WjlMEf8kkqyDpfMFQ7BWOmwbGc/9hGU9BaenKkyq/loGtNhVr9Sze6vHAZjmT1T98b/V51WQKQWDZ8jWYzngchVTNltdx6i0TXI5qBSFhKZq+YCZN4aqQ+aiXianhhjof2ziaC6t2y49/h8Cn1pwrfgbNrR/P1kpgIFVGt14P0HnIPe7t2hlK2QLsmVpVSmkFisBcnQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6tb+R7L1IDYFzGIm3NXAkMfveh7rEI0vCozOK05pHT8=; b=G1Yjqyq3GgRsJK94zDR5R5tEJ0CRPhvaoOSmmrqI/LUwd8vVdJKg0BNdTLhFeA5X7+M4aaRlGwEWrKZy+E8L42bPn4CgfMlq9LarkszeILhkiaDq54rZqG+rXmS7AbJOR1cADZ6lyQz01H1OtAl6ITtQVIunSzKyIdKf2alfuSmsNywySCqw5HegI0DA6J7Lh5tzyuKQtRVjH5D+vkXY7F1fO4PArED+WQJLC+UxkWESmaVR5FXFDS/GKRtILIC/8NUyEOwXnWog7KV6hWohmhfGSZ+QZd27WMmW4FXWWfRxWS2t18X7OgPMA6R9xRXBGJObaSR47wbzANUPoJtXag== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by SJ0PR11MB5894.namprd11.prod.outlook.com (2603:10b6:a03:42a::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.29; Wed, 5 Apr 2023 16:18:04 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::18d0:ac53:aa1d:d19c]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::18d0:ac53:aa1d:d19c%6]) with mapi id 15.20.6254.035; Wed, 5 Apr 2023 16:18:04 +0000 Date: Wed, 5 Apr 2023 17:17:58 +0100 From: Bruce Richardson To: Tyler Retzlaff CC: , , , , Subject: Re: [PATCH v2 9/9] telemetry: avoid expanding versioned symbol macros on msvc Message-ID: References: <1680558751-17931-1-git-send-email-roretzla@linux.microsoft.com> <1680638847-26430-1-git-send-email-roretzla@linux.microsoft.com> <1680638847-26430-10-git-send-email-roretzla@linux.microsoft.com> <20230405160210.GD31673@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20230405160210.GD31673@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> X-ClientProxiedBy: LO4P123CA0696.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:37b::10) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|SJ0PR11MB5894:EE_ X-MS-Office365-Filtering-Correlation-Id: 1ce814c7-d6bd-4d79-c00c-08db35f155a6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Glfax1VYvI1a1opmueqYItriXqcXR9CZIaPvb3IxsJeALcPAMcxV57ekiagu928NmlNh6jjl0jIXxjhc+tRv6QhP1tixS9SrRrJR4m8Y32JxPtqetijdt6V1egtEAMIPFIn3Mn50HJ7/R2kezP4nAjEyahUY5aZcPJ2kbFRMHOZVvlpCrojvXrUww2LBzwOOixS8bMXwVWg4aN2063kXOXFQx4/otC1CLq2zha/AFRITBU33i58H5wY7vcQ8PaDn81fWJokLhAKySPsiTr7jPR6hBVCud7S+9jRfe67o35nz02d9ALTAZyiP7jTLzUNZtCEKmgYiUu+Cnw0O+ELvUf957xPB3QNI6kOuat1dL+Y38HdoAeEio+3EoK6b2Mc2qH4uhex238I8h2zFT2MFr5YwDenfvRHAthWlXOQgEeYsSti/3VguwKKEPtiPoLWCHPGEZIKhYKhQHb1MJy36vhblrrkgHLS+ihpH3e50dfa1irs9mEMlME7mxRjCPCQcaeX1NkzqZD3GXhZUaX44RM6GVqsW6Y3LH+lBpfBbEcNO42lPV3Zv09qSGrlof/ZT X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(396003)(136003)(346002)(376002)(366004)(39860400002)(451199021)(8936002)(66556008)(66946007)(6916009)(66476007)(4326008)(41300700001)(316002)(8676002)(5660300002)(82960400001)(38100700002)(6506007)(44832011)(6486002)(26005)(6666004)(6512007)(478600001)(186003)(86362001)(2906002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?no6/PZKgcVJhh6ackPzxyeDp2FRcFQtq0+VwgFfJ7RCEvFNnIm/7mKEKQ1wM?= =?us-ascii?Q?eivzHWYJ76mbskUiNYz//ip5Rz/P811irLn+A+AurJmxM2QO9l2TOnfAry+a?= =?us-ascii?Q?/YJLojtqE8taDS410I/Yk8w0r77O9qCuBw0UygNqW/HJQgJZK3jPFV+bihHE?= =?us-ascii?Q?dS7EdQzHZg+rMbUSxrrZCmjZqJc2yAm/Cw8fPvm8EViID3gB3dlm3nIEK9wM?= =?us-ascii?Q?Hp1y3jnD6mo4vtL0VNtUYFoP0OloPPCID5ehu5m+L89EG8W2gOx5RWRS4CpW?= =?us-ascii?Q?kG5q9okOQMMhgdv9kd9HEXqKLHUcd0lakZmxb8VqYklcjJzTk0gPvgZton4a?= =?us-ascii?Q?Emanu4HrTnlB5SYln7MFTOBdJRCFp/CcdDEFVnNvCmatpsw+UBASRMPhxOk/?= =?us-ascii?Q?/KY+1TxzC5VLo1npF81HxcaR8cpV+BQdlk3Yq8RRDtfrZoOKydC2UhiPqlEp?= =?us-ascii?Q?GidH02URXnKbm4/rD4iYzVLOMDItQMlZEfPhaEJDEDYVeRBMNGasUaLP55Mk?= =?us-ascii?Q?OamTJtZnENUoWaNBv1LMMOgQtbOER8CJ9kFdXbxu/YUC+d/9LsWa8FJaqJjl?= =?us-ascii?Q?rnuGrUNhT3MBT4M/DPlJT29MGK7UI59MBD2PS7WO4IXTw6QyypobzSlqXDQp?= =?us-ascii?Q?k4Rf1gnRNFkDaJd94OFIHGVr5YizX4H7N7jclDYs2KAhsx6V/2P+fZJa35FK?= =?us-ascii?Q?jpekaWp9ptxYmA+iowIoeoyy+fYDQo2OX+xP7A07T1aMmanKSI1WCO/mbH9n?= =?us-ascii?Q?oTjGxCo7SPwR0JrU8klTGTk8iRtMJ1gQ6FatY8auSbGuLV3QnANJU+Gei3Rr?= =?us-ascii?Q?7344lldLvYv+3kqqdQ7LY9Y3Rbd94KLS2UL+pbpXPkr3BWNYITEFGpmP69w1?= =?us-ascii?Q?jf9CJY7nUZvqeXoZnFqSpgK7L5xIT8kHF8ku/QnVMpwLErrz3Q4I6Bep7lvr?= =?us-ascii?Q?MFuixidaY3dRi4BR4X6Y5x4p1ZKXM3gMuXdsnBjKYpPaZ4AoUbdVcHihvz16?= =?us-ascii?Q?SSkTlI2zQjvRzbG6tiHtgky0pc4Dv7b3Qh426tkx0RosGx+h4NFpEfnl+t+b?= =?us-ascii?Q?HVXhNOFq0XhVXzbiCWe3qGWybc5m+3UG8CLBoygVLN2nlAa+/irBZmOF09HH?= =?us-ascii?Q?WVD4f3jIBGJyI7tICo4EuLSjZ5GWcPPEYpcWt2ffl5rpfxZR4jYsHOiWlLUb?= =?us-ascii?Q?TGS2dIp4kO64ylAUFTKM4ZdKqPoR8LtnX/Hq973dhIXoZwgpFZRjqhVfBk97?= =?us-ascii?Q?L57xUquWUV6ts4JsZ85dHl5LozJM8noxODaEmyvWw8hw/gqQ5zwkdvvIW2hU?= =?us-ascii?Q?oWaGxN06+Emdy2LIABUDDWpO7A1bEI+NXENdjVLeeUnGUrrz9qdx/K5q88AK?= =?us-ascii?Q?kbcCpEUfgSxQHkSOorAlWds5HvpxI6W2gISq1gE+nO6RTq3+Ccn5i+JVJKk8?= =?us-ascii?Q?Ss10XsgJCJ54Vaav6KtopCgmqtSLa0DCxKJRA8JX1Hn5DgbdSo5TxhwcKXoT?= =?us-ascii?Q?OGmkpNoKiQOaXYZEZOjtluhndZVgC528rldnvH4S5QForoeOBdLzM9qn8kQt?= =?us-ascii?Q?8JEPGq+IYfnKgn6NyVcVqbLqa/cOHSvRNkY+F391ZJB1k24qIWJmmiAV9P/q?= =?us-ascii?Q?xA=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 1ce814c7-d6bd-4d79-c00c-08db35f155a6 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Apr 2023 16:18:04.6365 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 7Wqsy17y1ZZfI6gEvq9NfRWNU3NA4iC0NkIdw2sCsMQSgEHS+tU3G522RbDjJg2MXBTAAe8fHReJva3jJ09VdbKIkGTGMhrhnQFouAoqNxk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5894 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Apr 05, 2023 at 09:02:10AM -0700, Tyler Retzlaff wrote: > On Wed, Apr 05, 2023 at 11:56:05AM +0100, Bruce Richardson wrote: > > On Tue, Apr 04, 2023 at 01:07:27PM -0700, Tyler Retzlaff wrote: > > > Windows does not support versioned symbols. Fortunately Windows also > > > doesn't have an exported stable ABI. > > > > > > Export rte_tel_data_add_array_int -> rte_tel_data_add_array_int_24 > > > and rte_tel_data_add_dict_int -> rte_tel_data_add_dict_int_v24 > > > functions. > > > > > > Windows does have a way to achieve similar versioning for symbols but it > > > is not a simple #define so it will be done as a work package later. > > > > > > Signed-off-by: Tyler Retzlaff > > > > Does this require a change in telemetry itself? Can it be done via the > > header file with the versioning macros in it, so it would apply to any > > other versioned functions we have in DPDK? > > i didn't spend a lot of time thinking if the existing macros could be > made to expand in the way needed. there is a way of doing versioning on > windows but it is foreign to how this symbol versioning scheme works so > i plan to investigate it separately after i get unit tests running. > > for now i know what i'm doing is ugly but i need to get protection of > unit tests so i'm doing minimal changes to get to that point. if you're > not comfortable with this going in on a temporary basis i can remove it > from this series and we can work on it as a separated patch set. > > my bar is pretty low here, as long as it doesn't break any existing > linux/gcc/clang etc ok, if msvc is not right i'll take a second pass > and design each stop-gap properly. it already doesn't work so things > aren't made worse. > > let me know if i need to carve this out of the series. > It's not that ugly. :-) If no other clear solution is apparent, I can certainly live with this. /Bruce