From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7DA95428D7; Thu, 6 Apr 2023 11:25:21 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 473CD41153; Thu, 6 Apr 2023 11:25:21 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 457A240F18 for ; Thu, 6 Apr 2023 11:25:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1680773119; x=1712309119; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=xLygJpThVWAnrpr8zoFyBhTHn/WLHNpZZN+Jm4Jux9g=; b=WbAT+4qrz+4RNnU+sgf9WA6SVmUlIy2Y5KqnvNXwWs5tKJxwZ98QfPIb KQB/fc4blZOyWd2LA1ubwNSTL13cM+DN4YyysczHjLRabS7TmSz/Xwfrr mdyiM6JP+lMwxekTo3Wszn+BefFIb4wQ9h0DVfchZbwr2kpfKI/QaJ3wu DlAHPG/ZxWAsD+4jbyYYwrjiuFkeZ3HvELbVjO9CZORFrbB3XyW22fGS2 wkSZY9iK2mbCPIDfNJOYTbjWDQSpkXybn13NEJkTCI5ZcREyZUxUD5wEu wPjwOXHs6dCjoT2un0pc/wgOlb2ju7Je95ZKz/kmpILIZnPIUt8HFHyUK Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10671"; a="344423974" X-IronPort-AV: E=Sophos;i="5.98,323,1673942400"; d="scan'208";a="344423974" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Apr 2023 02:25:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10671"; a="776398342" X-IronPort-AV: E=Sophos;i="5.98,323,1673942400"; d="scan'208";a="776398342" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by FMSMGA003.fm.intel.com with ESMTP; 06 Apr 2023 02:25:15 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Thu, 6 Apr 2023 02:25:15 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21 via Frontend Transport; Thu, 6 Apr 2023 02:25:15 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.102) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.21; Thu, 6 Apr 2023 02:25:15 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Uge99hN2Qm1j7+LU5jclM0CwyzLrvhyIWX2dxWpfVGkB/9U+SjjIAHBaVTiWGO4TSpkMyZP7JoL4/U9dAs7DtVZ/WLlZh7rIOQXdB+XVt5VWrHaFFmu+1/yBJ+ZH7hoo/UO+vKEsafGov8lYNnTztJMpUU0AYLk94UQzd1QAsdcOk/HOcelrekOyy75GIPgwG2KcR3+pj3UQK9LMv+/LUHBNnVZLXL+JbnIVr0trYXAjkX23yS2FrW/iYOtcRg26AXkUCH9GmS5NNpQEXR8v8nI7lYPykC8M9VljpHCZQw2ztE6NS9qADlR0nDCBW64C+MN9JE7isYm1Ey9NKAC7Ow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eCrodjaFxOEX6wP6H24OqvRWFdhexoKMdLV1wkm3f/8=; b=aJ++qPkIc8QNizWD3yrgj+/sWaRbfH+4HDGcnXEsEZ0MVyEITl/4BwTBjeBqLr05tdxsDRzhTmSFkFF4l03HeZl6unj3pKZGlUbngV+kbMnLCHP1JdcT7MN46PhI9odsziE+vdn8UDKP3OQx1Ys/l6bKZ6KniWA2Yy9Vpx6zkYFuUkMa0uJLhfaJd4V0eUHcMZJ5EK2DCvQba9twmQr9YI8oEnEel2dAnWnyX43rUDW+16HWqa/ADtRixNjeFzHMDo+NeRr12aTFnPR/3fbcAWjoiXjVnqZfW5gRf9HcdgXnH82kJStnJA+8eYknHAw0aqlUE8NIOL4qilQYjkj+XQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by MN2PR11MB4583.namprd11.prod.outlook.com (2603:10b6:208:26a::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.31; Thu, 6 Apr 2023 09:25:13 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::18d0:ac53:aa1d:d19c]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::18d0:ac53:aa1d:d19c%6]) with mapi id 15.20.6254.035; Thu, 6 Apr 2023 09:25:13 +0000 Date: Thu, 6 Apr 2023 10:25:07 +0100 From: Bruce Richardson To: Tyler Retzlaff CC: , , , , Subject: Re: [PATCH v3 10/11] telemetry: disable json print formatting with msvc Message-ID: References: <1680558751-17931-1-git-send-email-roretzla@linux.microsoft.com> <1680741919-22102-1-git-send-email-roretzla@linux.microsoft.com> <1680741919-22102-11-git-send-email-roretzla@linux.microsoft.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1680741919-22102-11-git-send-email-roretzla@linux.microsoft.com> X-ClientProxiedBy: LO4P123CA0241.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a7::12) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|MN2PR11MB4583:EE_ X-MS-Office365-Filtering-Correlation-Id: 11ec0d17-5585-49d0-4bbd-08db3680d350 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: lAEqC/C5qmcuFDgGuUD25Ywsm+UicKk0tYdXitTgNyh7wG3ng8LIEejchPQ4olrA50lVxvsaYed4+zdzaG5va4B+m/h0E3gFR8iSSrocRoh/r1ElrQEaIv7r9m7YnCqB4Nhdu+THoPVkUeuTtWz39bLuBmPcr8Fse1CDu5CHJ+zcwcYWUUMQtgEhzPXjSnKMSA2P727dpm80wz5FiMmV0fJmbQvRbAirLgVBsXrdtE8drIRsHUOboJgf2h3Xor8WMcSP5zK2c+OX92PgiNl1L4bzcX1cmBK9umiZU18nZIXZ+pgfDxsWp9DNatS7WMb384OCsXxrUIBGbMjO4uj+cnGtYS33zF05C9ZmZybrDrU0vilXz+2n4m6eNckIrfZlVRluIuShPJyzs8r35YcUNf63JSC2R90qN58Ani9scJ/1ulGHYCHGfQ1HqB+0nogEwFaFtYX0gRUJc8OXLH1UnAQbIj3F/Xn7UPZfJG1bgxhbVWlLjh1vQyFWBAAR415TmnQxalO+xtc99qHMeXvOsIkrdj3+UpJ/c5jSVB7QN0A= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(376002)(39860400002)(346002)(136003)(366004)(396003)(451199021)(38100700002)(5660300002)(2906002)(4744005)(44832011)(4326008)(8936002)(66476007)(6916009)(41300700001)(66556008)(86362001)(82960400001)(8676002)(66946007)(6486002)(966005)(83380400001)(6666004)(186003)(6506007)(26005)(6512007)(316002)(478600001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?d5BkUOaSYzy5UzrG6q3FB0Iu1cZZqoPJroRD61RSmbWqlyt1vtdn6Dxq2Ngn?= =?us-ascii?Q?EXy5LoohqRFe83ZB+v/17TiclhMla66qhgchts/k6/FoQr/2ircUY4GbA9nz?= =?us-ascii?Q?geJLdLQO8DAxB/0c94kZzPWKRqP2sQp0IHkZbJr9hYJpZ91KsP7uXgmZHljb?= =?us-ascii?Q?HqpfWnP1ruies1y2H/8e8MiLGgHJKt0I9SQhvbW0YPQ84nsojOvsN6Oe3tWL?= =?us-ascii?Q?wdWoQaBHE/ajuUB/1NlT68+ZVvqx+UlnN+V3gD+MLU4EGUXCKPe81KPErj0I?= =?us-ascii?Q?xFwnmbg1h//eSrSAC9Xba70TnLIhzECUNyhs7l+h8D307uRzksNJUDA6Jaaa?= =?us-ascii?Q?f4Jhxbso/8jwVOEAqVfZmrSXKabr/b1cG0mtYW+1tEkQ5xGtS+cNjZR5bHTT?= =?us-ascii?Q?YStLjbBLKiS2t6PArz2ZgB3J5pE6XC24xUJeKIjxl2m3FzAqva3My/vDnucu?= =?us-ascii?Q?6Zxhr4m/8h+Hm2qP2aDYnbDI+hsPC380cd9Qg4ZEfyh0r0Fg4va7lBMEVXj0?= =?us-ascii?Q?AdOc0IC3nPG76rV/OIkicfedHLvXA7F22CWAID4xTl8mXEDiR5NcrSVUkBix?= =?us-ascii?Q?mAo+xATKywYXqLjg0nviSsVmCmfdIXlxXXOQTCA9rokCIEegvu3HFhMHzjKm?= =?us-ascii?Q?I6GEZsmP4KXfJ73qeVmfuEbwxFb9+GoeTo5KJDxHHVs5eET0LreD0bCElpvW?= =?us-ascii?Q?wgVRwoAI8x+LxJo4s1EnphoB5rOedl8g4MtbPcrOAo73OUAXePcatoU40rtR?= =?us-ascii?Q?S6jPSsEVgko8CU3jm/skqHxGgUKqP0qYuXQENyi1T7OkzVp2ExmZpRR+jpzz?= =?us-ascii?Q?3NPxI3S5YrOOJaqxTi2W69nUT8b4OLHFTF/sQViD47WWB7YIrvXrll4rE868?= =?us-ascii?Q?hyRCRxTCsvj2Bg9eb6wF8Ntm8zNGvq0+yojufOd1dLbPisFEg2QXwQIxNPSf?= =?us-ascii?Q?vzMwxAb6lLECBhkT6azCdGDuRPXHFCfhI0HMyYEPZ7OjgyheerRJ16SgHkzG?= =?us-ascii?Q?rbZiiWMaS09gn48VEBc/2MGJ5tog/O56nfWZg5GTUnBTvwSvMM/nlRwQULVL?= =?us-ascii?Q?wd2PH2FVZWH7d++Pu8SoGXIbnbr0Lbxz3iH30xVfqOvblsc4hTLrE3ll8qb+?= =?us-ascii?Q?hW8XqJHJkEyVzwsA9Cy/h4psyvasdsGHgd1OyrWd3fxX2b20mszJEAfbDxFd?= =?us-ascii?Q?+2D8dXn6onhpWVTb1oR+AatEWGlP1YlBHficEKuvb8o+vJsfu+YgG48c9CqV?= =?us-ascii?Q?PR3m4xOBSKgqP4xg3ALX37Xg/m9hkziEND0xAQoEPhaa9VXeoLYKlrNwhLQL?= =?us-ascii?Q?KbR25dJArHcQgrqx/waA+ViEY0Jdtma15zA4DuO7hj17d9gaafPyYQHs5WtO?= =?us-ascii?Q?nkipqfeAnR3WndQIWpUMy0jsN+8FWmWAnnNe0qmHi2iBSeE67jxrMxq5vvhy?= =?us-ascii?Q?A86lRY0vnT8xXQ1X2QlgKs+5m0xy1uHTktVOLlUPEIl8gLHyF3uXdyUDcMi8?= =?us-ascii?Q?t0dRPWRCuqwDsB6QfMWdZWXrRxEg00ci+zbjCiLYCu07zMzhWou4MImeBpN5?= =?us-ascii?Q?7Acj3wsBNSxKmTFjBDvALpws9r1O0i4Itzq/Rej7p/ZiP9Su1AfQrVC0rEC/?= =?us-ascii?Q?Eg=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 11ec0d17-5585-49d0-4bbd-08db3680d350 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2023 09:25:13.3307 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: BFzPC2gbU1NxNbvkYhyCDPS/QKjP+gl6A7UNYT9U7tSSpwDZnMmcX8ElXG2+VgbH+Ns1AujpB6suXDc/gFrgBhxKbN4PhJJoG24W8BOMxIs= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4583 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Apr 05, 2023 at 05:45:18PM -0700, Tyler Retzlaff wrote: > VLAs are unsafe and will never be implemented in MSVC. When compiling > with MSVC just return immediately indicating 0 output characters > formatted. > > For now telemetry doesn't work on Windows, we will revisit support for > the telemetry library sometime after we establish the DPDK unit tests. > > Signed-off-by: Tyler Retzlaff > --- > lib/telemetry/telemetry_json.h | 6 ++++++ > 1 file changed, 6 insertions(+) > I'm guessing this patch can be dropped if patchset [1] is merged, right? /Bruce [1] http://patches.dpdk.org/project/dpdk/list/?series=27629