From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8550942931; Thu, 13 Apr 2023 10:45:58 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 09FAA40A84; Thu, 13 Apr 2023 10:45:58 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id 3F8A84021F for ; Thu, 13 Apr 2023 10:45:56 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1681375556; x=1712911556; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=hgHcfX86kUBnzzaChl99QhlSpYYBXVAhWrh2ztXQ0q4=; b=a7FT1gxByw7OeUIpdtJ5hYlbG0UDNtGcEp1tyDAvbAT+3qxiROvTfD4o S98KyJwHYiUoB6kv9eKs/diTPDy0mYDeGBsxRP2r6EZeD36rx45qNkREn RC9HKlYh/Y39gr/ph8M4Khhpo1OMINogNYCgXC1wliIhWf0doPilXi53d 9DjKrvzNVL52mbMD0GqQIJFfGGn2r8RZa+YKWT9i6ekHL3eKpKe5lunAT m8e7X6u4gbz3GUSlNtqqrPqHAD3g8OTiZHyfV8S6S83DOYQfkcUAe1S0m 5tcOHeVXdF826SM8FPo7noSvmnUiApaF38B+7bPeW+4RfvAiQOFZa6liu Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10678"; a="430412801" X-IronPort-AV: E=Sophos;i="5.98,341,1673942400"; d="scan'208";a="430412801" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Apr 2023 01:45:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10678"; a="778683580" X-IronPort-AV: E=Sophos;i="5.98,341,1673942400"; d="scan'208";a="778683580" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by FMSMGA003.fm.intel.com with ESMTP; 13 Apr 2023 01:45:54 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Thu, 13 Apr 2023 01:45:54 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Thu, 13 Apr 2023 01:45:54 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Thu, 13 Apr 2023 01:45:54 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.168) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Thu, 13 Apr 2023 01:45:53 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EM9eS7/MVnJtWotrUcAlUGes6/8xQ7TvbbibxIwQBUvxdBsUoFc6gVl42DntO1c1KUOVh6W1fQzvqm4ul+wY9JfgogVfIeMk3CqG+bfXD5TLzCgGs+KNVMun6oXqhQ/hIzN42LGt4caRDW6JtLJhU9vy39EVPfEqdCxICa0TeCf2bPk+4PszWtIXLd5NfZSAVfjQAswPYhBda4UBNrNU9xBDKC/kX3SkX2rjWrrchKYDsGIqdlAb898ivwp0YGk7Bj+NTytH9/U9SW3YhalY00l8FjE6mPF1d+ZLfjK/JbqD0GV9V+oYy0gA38/I7JnjjBnySB5OWmT0fflU4nFVKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QhNgJWmM+V5KZBjdseKU+MfUpwX+OHFYqbDrWb84gNw=; b=X4c+LmlMyJ80fC/C5oh0w2nSp7lUjGLzU0Qhm3W82uvGeI71WZKW/Q9u45pYgluYtL5J2k19LasAnwXe3kYSk016U7U1cUiAII1qfboBLUfxDF1+7fzTWWpYnhoqxHFTkds1macrSYR2rBNUuhmGXp1pf1/WXQJXFtX+osy5CkiMQMrWTnu1L13B+TZe514DrUPUh21ENFslwUE2vszsjp++qES6jnPnSsZm8o7hwTQPcpspKI1MOd5FXHjZWGmOr1bYYRPM4PEGCfn7LiaV/Fq11GlI8XCVMsTwDRbLkTsPevJu19OCznbN2YptncM3wriYUzp3ozQ12ENUQZWoPg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by IA1PR11MB6124.namprd11.prod.outlook.com (2603:10b6:208:3ec::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.38; Thu, 13 Apr 2023 08:45:52 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::695b:260c:f397:2b69]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::695b:260c:f397:2b69%4]) with mapi id 15.20.6298.030; Thu, 13 Apr 2023 08:45:52 +0000 Date: Thu, 13 Apr 2023 09:45:45 +0100 From: Bruce Richardson To: fengchengwen CC: , Kevin Laatz , Subject: Re: [PATCH] dmadev: add tracepoints Message-ID: References: <20230412024808.41339-1-fengchengwen@huawei.com> <9dbabadc-c2e6-1f5b-d7b3-d6b23b874c1d@huawei.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <9dbabadc-c2e6-1f5b-d7b3-d6b23b874c1d@huawei.com> X-ClientProxiedBy: LO0P265CA0012.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:355::13) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|IA1PR11MB6124:EE_ X-MS-Office365-Filtering-Correlation-Id: 440e9e97-6a3f-4000-82fa-08db3bfb7c70 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: EqH+nw3Ik+I+XLKb3eTqIXtj2k/We2GOKdyNu98PHpmvYPx+mkTqDL4kOLONbT0ffbo73idye9TVUEZxUo6n8R0Kx1m9uVHg9x5Ka9ttuQop++X+v4D8poaxHe7CMC8MKE/1FKj7ROLpbSwhNQmVUWiu5Vm6STE1fO1N3dGHa8cyF+zk/EalYu0TRYVlOZWfdIWANx/TEM+ldZF/5aAorq93HikQiqMQX27xIQqpPpYSqLItdUpMpeQiCv7tE+en42d2rGQapCEynz9UJSsDWrxu6XyHGnq9wzbwFTSz6Xrc3aMPldEHtVFHhj/3gVxMSD1KHFwZiHoW/Dse54yDgraZSAd2bpdLtewqC2GqmAUIxJIQAh9NnB/VbiGtzCRjxD0+xtGVGRJD+ILJung+W/dV4kZkoouSMgCr/JwunC8Yx7xswKHoHgOAufxBshwHor43qK2/yclzStWxZRDXZPRMSpxBWJdxJU8aEM+rcFKtw5N+rRJZ3CiUrnq52cP7F+3QSgokS0IK/L4uFmpZkJ/GRxJFvaWAj+kjIN3fsF747Pnid6VnRWlYzyPL9NtQ X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(39860400002)(136003)(366004)(346002)(396003)(376002)(451199021)(478600001)(83380400001)(82960400001)(38100700002)(86362001)(44832011)(2906002)(316002)(26005)(5660300002)(6512007)(6506007)(53546011)(186003)(66556008)(6486002)(66476007)(41300700001)(6916009)(8676002)(8936002)(6666004)(4326008)(66946007); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?2KJ3Lusx4vS/QT21svBcVsnwp+zLBIPSwFjw9bmcvNKcRAeohM3eC6ld1x7a?= =?us-ascii?Q?6gB89kqe2rp2r6JfLrNsqqF0UDmJzNXVxctI48ltyQxcs9TVzXJpG/2xPC+W?= =?us-ascii?Q?+QBgaCu7zga2Eo/B/MMd1SGLcPf6aGTQMa0ENieoviYb4NBbqSniYdyGutk4?= =?us-ascii?Q?QOxocUOzGifhauRcYGAZB/BsEnZGkk8iWiCNip3+0ZFN/99ZkGp11GlXp+7w?= =?us-ascii?Q?Ao8agBz7kDLTfPlmppTO6ATPY4uDteRpaEA5SfckLcxCVjK8myrUDBmY+vid?= =?us-ascii?Q?b+7xu+g1wxOCEWnSYL7gK3wZTz6F2odoUq9fZRmKH1+ccaBPsOe0lgi2c0G9?= =?us-ascii?Q?5d+A1L9Pnkwex14K+xWsY5gvm4EkUgiDgyRV6nIceo+ZbfwZ3HtV3gHRmGh0?= =?us-ascii?Q?vuHaPMNZKn6rO3yRbuZSkrbWZSTph6v7He1e+9u3hiBpMLrH6/KTeh3t+hRf?= =?us-ascii?Q?7JceTrMhhWs83DGgR6p43hZ/cR370QU3VtDbnumv4/UpdrPN3ajLJItbekKN?= =?us-ascii?Q?mgnAMTA04YafIPqaUMU9wzN20IyCPhQOvb8/R6dfYHr/+BrOFetzpQA1NvnF?= =?us-ascii?Q?QgeRATODeYf1BXWT19nr3o4FagI+6pWHi9Ow8VB7WBF3DenkQ3rNiQhR7Nyo?= =?us-ascii?Q?Pb21Ow/WpQPk+iRnNUwVQVhZPEykGsYOvlZz3nLabWBY2KATwszQLgRs/8r3?= =?us-ascii?Q?JO8lB4ZjHhVE6quKhPfdmEsUVLDKJzUS+9ONcxR9ms1ovNsAaUvqCGyYyyJi?= =?us-ascii?Q?g3xtsRSFGkPPT6HAmYnUIOZBLZdSLEZyOShydIO7wuf25AmZXPerx2ujA9f+?= =?us-ascii?Q?33FwrP+DwVBQjJL2EBhGnfLS+WOGusHLBgKl9lPQy7yhSudU+SHkZwlLIYnf?= =?us-ascii?Q?wexrSYfXd57913EJudG5zLvk4tDAeOSVKx+cRaz3FFPsgi/uyLW4Knzc1uk3?= =?us-ascii?Q?z9F09VQPsHN/XChjnbVFYBmkJjkc6X9j164Wlywq3yrz3CafsqeZNYwairy4?= =?us-ascii?Q?i4EUpjrevSqvdcVnGAyeZkeZI2o8PoLp+jupeDLlDKxnNnckyepaMlZOvqJ4?= =?us-ascii?Q?Q8z16QG1oGWVQmb2bABeRMgybEBbtkl4cHzPFi/1tpc/g8Ska4777gTZwIQ8?= =?us-ascii?Q?TnO4S0AvwEW+sSxayXiE6jqVw0Oer6ebU6Xc77Cg0Cu7jtCTYa+onX3Nqgzw?= =?us-ascii?Q?bdkC+XLdISS6chobKmdYxOMfk9bqFEgoRolp7qz3gKl8rS9aAnxagBZYcbi7?= =?us-ascii?Q?crd3ySd1lSx+/h8UdXk3tOM3Mqai9FWWMFD0FTTfK4J48x6EtkYSH3YBjtGh?= =?us-ascii?Q?QNnVgPiQuLlBKc77hBcFBJwdHAs0U9Q5gYaoGYPCr5q0cg2XJw7aC7dIyoyB?= =?us-ascii?Q?VcxbowTX1bUzLFx9pLvX0l+VXdrFpdXSjemK5uxwzBf3qKXzNv8aEQ+OUaDh?= =?us-ascii?Q?cbwBq5zPfUDhsTl/LLM+l8swvnktGdavL91F7XJQsQVljX7ZZwRIvds5Aks+?= =?us-ascii?Q?7yq6K3ELdKnnpMXb4Y1BEZ3r0yXe7gIbf+ULhcoBiK2msvRF+0iQozPdyRjU?= =?us-ascii?Q?GIrOsVfOrqUg0NsWPDsYWIin4hu3KD1WteVJu4QUa7Dez/qgC1KSf6E3yTaB?= =?us-ascii?Q?MQ=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 440e9e97-6a3f-4000-82fa-08db3bfb7c70 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Apr 2023 08:45:51.7225 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: KE22Ugkm4OzGkPUkQHw2SjNdGuqCrM3HuWaRdRUjQ3NFEEhbhDYcMaV38N7xP+Lr4HqkLDdFzhPvHfX/EfwoG07+tF5QZodV6a2JUtgvAek= X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB6124 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Apr 13, 2023 at 11:44:38AM +0800, fengchengwen wrote: > On 2023/4/12 17:52, Bruce Richardson wrote: > > On Wed, Apr 12, 2023 at 02:48:08AM +0000, Chengwen Feng wrote: > >> Add tracepoints at important APIs for tracing support. > >> > >> Signed-off-by: Chengwen Feng > >> --- > >> lib/dmadev/meson.build | 2 +- > >> lib/dmadev/rte_dmadev.c | 39 ++++++-- > >> lib/dmadev/rte_dmadev.h | 56 ++++++++--- > >> lib/dmadev/rte_dmadev_trace.h | 133 +++++++++++++++++++++++++++ > >> lib/dmadev/rte_dmadev_trace_fp.h | 113 +++++++++++++++++++++++ > >> lib/dmadev/rte_dmadev_trace_points.c | 59 ++++++++++++ > >> lib/dmadev/version.map | 10 ++ > >> 7 files changed, 391 insertions(+), 21 deletions(-) > >> create mode 100644 lib/dmadev/rte_dmadev_trace.h > >> create mode 100644 lib/dmadev/rte_dmadev_trace_fp.h > >> create mode 100644 lib/dmadev/rte_dmadev_trace_points.c > >> > > For completeness, do you have any numbers for the performance impact (if > > any) to the DMA dataplane APIs with this tracing added? > > No, because: > > The dataplane trace points was disable default (unless the RTE_ENABLE_TRACE_FP is set), > so there will no trace-points code default. > > So I think it will not impact performance default. > Right, I'd missed that bit. Thanks.