From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0CB9342942; Fri, 14 Apr 2023 16:54:32 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E5F6740144; Fri, 14 Apr 2023 16:54:31 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id 98522400D5 for ; Fri, 14 Apr 2023 16:54:29 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1681484069; x=1713020069; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=TQMKQHNUAHNNa51KfPiUdWf5pz/Nm93DNc55ve9WmLY=; b=AvAytxMiCW5KXCgYmrUklsW/D1ybC4paZPZ7152kH61E+qUC18baqlxd XTAGiCoFW8uMo7r9tbM8g6su6Xqs76oK6zMCkgzxdzTG9ln13ZMZF+RQY 3zX4kuClwITXMPL4GcWOnLoohQe30Bre0mVhtpB1TeOZurdZH5X37YRvJ T9IeS0bkqJkS2tzZAKqXV5dDpHZeEbRBADpjBwEga1TbC4uMsBWzOLL2W mGQSxi1fWVPbPkWBplAR1gvS26e3aNBRA7zWmatY4o32zVHprMaKNX1mK OrKSGJLivN4JE+vbQjO7eaJoApK+XHozIgUqNKyvjZGCiGI0PlD1TfOjP g==; X-IronPort-AV: E=McAfee;i="6600,9927,10680"; a="344482624" X-IronPort-AV: E=Sophos;i="5.99,197,1677571200"; d="scan'208";a="344482624" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Apr 2023 07:54:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10680"; a="683343036" X-IronPort-AV: E=Sophos;i="5.99,197,1677571200"; d="scan'208";a="683343036" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga007.jf.intel.com with ESMTP; 14 Apr 2023 07:54:28 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Fri, 14 Apr 2023 07:54:28 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Fri, 14 Apr 2023 07:54:28 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.173) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Fri, 14 Apr 2023 07:54:26 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IJtuR17Yq5iWDZ/AHKA4IQ9OFBxDWzInUZe1FzHloabCMfJw7BA2OsjLEJ8CxNaEIU46lT7hMIVvDitr8CgJwrLnlsvRyXJIk2vpc9qwbYa2ejeuyJoy+7Nh1rJVNecQgjoT9Zbl6uV7Ndl1NeGrymYBulhol1xCtboX4fitvYLmcIfeL/gvzGUuSBWveqTakWOknJBU5SWZEKNZmgOiitlc/BuVm0LbCXdpPeTFlsojFINlrzGP6u6fbyvDp7meDXIeF6woWvSLz73ZllnIg6S5cz3A4Q9DFifM4P/TNUZjn0pcOMct3wNKAGYxXDZ3j7jprDazUJZybSlH3q/S4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OVh/kgmyAt8m99Z7Sq0ysflHJtW8iWIq+EbINqOIr2w=; b=Gny0WSYQ9c5IX3OajL4cJ3h6veJt8pVjCydSdbwTcOI9R9vdM9Mpj5XqSNW1aF38Ewarl0xp2ADyKI7vPLOmg8U2nAMI/AuEWoqJTG0S3Xfoji+iztOCl48pgo98uqzvkj9t1tdAKzDVGOpz9YmIwpmwI3X482p6cOci8aSzvObGY7/ealUqNZbZBRs57gFK2rvwJy4N5jby+s3PG02Xhqe49WIrYby0fa9T40J1ZMzsWoHLUrVtHXS4uDzXd4B5TH/nRLOTX4vWfojWmtjCyx+ni70QQNiL+u+0JGV/fED08e9YOSj1YH1iHWKdRWSTx1CVu36kC4Mrsem11uCbHg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by SJ2PR11MB8372.namprd11.prod.outlook.com (2603:10b6:a03:539::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.43; Fri, 14 Apr 2023 14:54:20 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::695b:260c:f397:2b69]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::695b:260c:f397:2b69%4]) with mapi id 15.20.6298.030; Fri, 14 Apr 2023 14:54:19 +0000 Date: Fri, 14 Apr 2023 15:54:13 +0100 From: Bruce Richardson To: Stephen Hemminger CC: Volodymyr Fialko , , Reshma Pattan , , Subject: Re: [PATCH] reorder: improve buffer structure layout Message-ID: References: <20230414084344.271602-1-vfialko@marvell.com> <20230414075230.1a9279be@hermes.local> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20230414075230.1a9279be@hermes.local> X-ClientProxiedBy: LO2P265CA0247.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:8a::19) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|SJ2PR11MB8372:EE_ X-MS-Office365-Filtering-Correlation-Id: 7906e1ad-21d6-42af-5274-08db3cf82008 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 4u6frAkS3y3y0IxrOULUQ3Otg9SdNwzV0vhFrDZ0Qcy2WA/+CMATzGmAH8e6yoBWo3nsBhD0JY8OG88nwiDLSkxPrMfP11VS+WpYfPh8GTxvnXI1yU5SLuCWOShFzCSXaF7dcMoKlIqbsPMoWUXqr+evkNEsPc5IbRbNFxv71o32q8D8PCzh3V0vDecm8TRT6aTFcMWGquF/WN5ICDyjL/7cedwONJV6DsdYsynCFrnPIyNKWoPeN7TuERrAvYjjkbRhHdCVBi2UcHI7pUJMJdmc9CDjTBfksVZ92oIbXezjjcJoZNXf2MSGBr97iCbSnbXMdD+pON2OgwHmH2bzZcnGchkn7ZtOQ496/898rYMpoU57EsLuIzRb8uZ2cPyATZENO9YymMfaIkR6ufdvav/1+D8mSQth5MoySED0XUFlYnCfRN69soPpZVKp1BMXEkr4jRYR2CwB9U7RGXe2ZnVbSY3prjznY9O8k+6CsV2lvvkL5axSYHuQ1H5aDlNVyr7kqUP4QbhxJRuTnFD6CqsaVPXL5hUCS4zMRoH1L3S4L5+B7u1sOsjvTBmGeMn6 X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(366004)(346002)(39860400002)(136003)(376002)(396003)(451199021)(26005)(6506007)(6512007)(186003)(478600001)(316002)(54906003)(6486002)(5660300002)(8936002)(4326008)(82960400001)(66946007)(8676002)(2906002)(86362001)(66556008)(44832011)(66476007)(6916009)(38100700002)(41300700001)(6666004)(83380400001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Y+SNBQTFkxAs5Sj7HlbKzBnVj5PbZ51pWMc6Obb0ySObrq1Q4vMeXhCog/hx?= =?us-ascii?Q?4YsUzG9i4tdNOyVyg7vf+kMCh1ZEsXl80ERB8re5PWT4To+PbZcnIPWa3vrP?= =?us-ascii?Q?ahhK6S86LXvH3+MSjrM528NoS1NwoNWp0JktQkuqQIzFlxzdIRTg46eUAjlO?= =?us-ascii?Q?alAO4A8bO/oZQjXdGBtVDjBa7fc6Ke3AdefvpXPM3vVSBcPKlHjfIWWkt7RX?= =?us-ascii?Q?OJedgDsLHjzFjtfXBuGQLMNE/UGVcFZCIG1IrFnxnKSYEkXiXITKi6Pe3jJX?= =?us-ascii?Q?y2yMm2fRng5DCDV56g+DOY4NB4PtHzn3D0V1Oycr1UFpejEHLQRtg2wzLx04?= =?us-ascii?Q?7hvgvrUQ6IdP2m3IzgoT5Vz9quN1beVKE+75SqfgHy9VTLO/1/OYAM7rYo4J?= =?us-ascii?Q?KQcDDeQQnSmtMw+MD7iOVES1o2cGLZExG0HEM/F/l/x+ejVDsw3GILnS0kzn?= =?us-ascii?Q?9KvNVpHThIGJg1PkKMbmxC6xe8YPBZZjZnJ9kpU3nIQz7+nw+Hz0Eb2vVRyQ?= =?us-ascii?Q?5EZE6NxzQvTExiR/KG+U6fHd1DcYdurPQKQJRTKKKk5zH/Z2V9IcTeF6dtzc?= =?us-ascii?Q?xWFUMi6lXsWrDqg8+NI2gBQCpS7SeVujzfZ1HjZQikIrj8BYv71f6T4XLdMs?= =?us-ascii?Q?rwMflg4w9BY9QMpOfZz+R7JEJVJO9ttMgxhQNHJqbCVeZbajwe1ubtsHSITF?= =?us-ascii?Q?HAp2L3UFWHIQzKW7Pq3+RHbWI/RE6otpOgn2AL90U87Go7KIb47cDx7bwDIA?= =?us-ascii?Q?rSqrWJfRlxKFDSCO9Sy6GYeZD9blPRkZX1ABUPO24rfsIJmzn/jhAlF1Syei?= =?us-ascii?Q?S+Tg6CZaK1P3EmBQu5PcpRt8Jp+ZebStP4HN6o9EcNNIjvLMMdADPRJCl1Ed?= =?us-ascii?Q?khqaH40LJlGsdslUrQftwxBylYpwWk6dx+nCq7McqPHNAkr0p8V6otje6jKA?= =?us-ascii?Q?VRp3ivRURYsKQSXK1hMT/DicV5u9FJluPzV7lq8A7xAn2Ddt98d563FQbvUc?= =?us-ascii?Q?fXlL67sTzn+2iPfel4kOwf0/r8nfMLVMDEzUw5QrCiYRu2euhRHSrV5/DMXq?= =?us-ascii?Q?Yr8T6GkkDndR4uEwZtANm7/UQlVcskC3nWBOyPrSGZino/NKLkpJM/O62pYw?= =?us-ascii?Q?bK2DDpYo4KIurPnTFyQ/Gf/tN7fon5YxEdQL5zERKBO9b120CVizD4swcolx?= =?us-ascii?Q?yW8XxoRpwNAJuHC2EzEsKgRyyqm1k+eKevKLlPQs7W9LwJqM5377PSkeHOh0?= =?us-ascii?Q?rcrMI9E+aY4is13NUXc2CaUMdlmwhwWdy3TWLGzqWj2Bv1ZBYj2Yd0La3CqC?= =?us-ascii?Q?ZtxwVawPDVPjXrqqUMFa/AYn/ofxAY+zzm9XnkJOzjPQYwPFOnWhk07IdrsK?= =?us-ascii?Q?5N9tp7Oo7nxPYiyLVzi8cJTZ7qtIaSv3r0XjCuumd0LAnYDzasQLXK218+/r?= =?us-ascii?Q?Xg88yM7hNEl1EswixcdG2IEXT5p3Z/DCUyNQz2Aci5gvz+ssyI+OE0duLVhe?= =?us-ascii?Q?t9iaVfSy4b54vM4IGDfB/FgynD2COGIEfadgXU1LVdEiwXbhqYeQHXk6KyjP?= =?us-ascii?Q?1wID64sBGkAJbg1ZYsNZAA09Ma7pT4WwUJskMzRMkOXJEMuBQqbGGlzN3ZRL?= =?us-ascii?Q?9g=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 7906e1ad-21d6-42af-5274-08db3cf82008 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Apr 2023 14:54:19.1658 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: c6Ju2YNwsGj/El5uWTkdT4JGPw4fZcHrNiit5mZgOiPpa+3B8vg+ei+5YkE/kfM7rcyJFbsUFXQF+cCWvzWd3C+Xcpvz+Ctp+SXNJxTWJ3I= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR11MB8372 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Apr 14, 2023 at 07:52:30AM -0700, Stephen Hemminger wrote: > On Fri, 14 Apr 2023 10:43:43 +0200 > Volodymyr Fialko wrote: > > > diff --git a/lib/reorder/rte_reorder.c b/lib/reorder/rte_reorder.c > > index f55f383700..7418202b04 100644 > > --- a/lib/reorder/rte_reorder.c > > +++ b/lib/reorder/rte_reorder.c > > @@ -46,9 +46,10 @@ struct rte_reorder_buffer { > > char name[RTE_REORDER_NAMESIZE]; > > uint32_t min_seqn; /**< Lowest seq. number that can be in the buffer */ > > unsigned int memsize; /**< memory area size of reorder buffer */ > > + int is_initialized; /**< flag indicates that buffer was initialized */ > > + > > struct cir_buffer ready_buf; /**< temp buffer for dequeued entries */ > > struct cir_buffer order_buf; /**< buffer used to reorder entries */ > > - int is_initialized; > > } __rte_cache_aligned; > > > > static void > > Since this is ABI change it will have to wait for 23.11 release It shouldn't be an ABI change. This struct is defined in a C file, rather than a header, so is not exposed to end applications. /Bruce