From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D9B9742AD6; Thu, 11 May 2023 16:48:11 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BA69840DF6; Thu, 11 May 2023 16:48:11 +0200 (CEST) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2114.outbound.protection.outlook.com [40.107.220.114]) by mails.dpdk.org (Postfix) with ESMTP id 6686D406B6 for ; Thu, 11 May 2023 16:48:10 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GNobIpdCCtJ8SND0dshEz/Z61Pip7WoB3DITUxXytQyYXMcmuA2HBr14f88F1IBs5fFwvkS8s44sUSTY6Sjh6lkI+hDOiIwm7t8nsKEZpVgmRp7OBI6sEyVfIDdKiwEAovPZVgFpxQg77JcnDT+GBPsbyGhCAh2TSis6J9L6qu+sateNyDg8//480UoORzMyz71NYkWwIzqSmDYsgyl12wp6TXOHnwoxeP+hSbcQ/+TqVauEhjTYhAXNN3QA7O4wmKzhi1ibmgg3SYU07qaKe+sCEU52i4/XpFgBdsDMCJFxuHrDWxsyN6Igqau1u1+wkOZxzOOJYQlz/5uvoSrOeg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wgcfloQvmHIrRDIZVvyjdPNlJdn2ThVEG4UTXyJ5IsI=; b=musjoUjJhNDSKadJXzPV0WfJwoy2ZcRyhE5P1KVLP3+eW74FDVCjOz0jIlrGwA2Gp/s3fB1LK11JEzEkdbC81IbpLPew8q86PAoQ6n4Ntw/80JyLMiZq/IaT7xqc/Q1PV/RDJ1XtIdlrYOmKW/1Tf87Q9TCUWeuf5I6ZqADfLWtXwwNTKc5oW92FADloaAfESfA9cCr4I3HrYQyPxT6WmgRNFApfaB47sLA670MEq+8OEfd3okCvB9V21avp8qloAAam9Q1WVjaZipXyG0tosd5xYNrB8zbaN5Q3MXuYmg8vbFTUv0KHYGzxhto/iFdKiciLBeRN2buP9EMqF/H8XA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wgcfloQvmHIrRDIZVvyjdPNlJdn2ThVEG4UTXyJ5IsI=; b=ke1ePWItUxptnL3WsnsUNIb/y3FD+7c0UQ4+Ud+ciGN5fA8DMd3oexqTuh1fPOPAYX9dKAV1vELhuQtojxZrJXVZeI1KN5RgcdtxySUdRB0d/stivCfUViHfKYWzprQu5URQd2kYwYVjm7+jOQh7SEFuXl5VxCdBGnezdV8j048= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; Received: from BY3PR13MB4804.namprd13.prod.outlook.com (2603:10b6:a03:355::13) by SA0PR13MB4127.namprd13.prod.outlook.com (2603:10b6:806:94::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6387.18; Thu, 11 May 2023 14:48:07 +0000 Received: from BY3PR13MB4804.namprd13.prod.outlook.com ([fe80::8bfb:3fbb:241f:e41]) by BY3PR13MB4804.namprd13.prod.outlook.com ([fe80::8bfb:3fbb:241f:e41%5]) with mapi id 15.20.6387.022; Thu, 11 May 2023 14:48:04 +0000 Date: Thu, 11 May 2023 16:47:57 +0200 From: Niklas =?utf-8?Q?S=C3=B6derlund?= To: Chaoyong He Cc: dev@dpdk.org, oss-drivers@corigine.com Subject: Re: [PATCH 00/13] Sync the kernel driver logic Message-ID: References: <20230410110015.2973660-1-chaoyong.he@corigine.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230410110015.2973660-1-chaoyong.he@corigine.com> X-ClientProxiedBy: MM0P280CA0043.SWEP280.PROD.OUTLOOK.COM (2603:10a6:190:b::14) To BY3PR13MB4804.namprd13.prod.outlook.com (2603:10b6:a03:355::13) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BY3PR13MB4804:EE_|SA0PR13MB4127:EE_ X-MS-Office365-Filtering-Correlation-Id: 64fdb560-f89b-4711-6057-08db522eb9da X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: T36b4ZfR9stVsvSPhQlakdYcQku7O3aHVgll/7xARoxui9ROO+6dUYIm9DEP/OZrPLKSpa5YW4A2DfXXbbVDd5uXEbY5qUjFQZm3+aE5g+FFgrVmPbC3AdpeMk6tPa5bvd911KRIcdeGtarpKwxDyUG8Z5u9GLiPDmCk/ggsLiPdU07hGql3IaJCbOOu2thyH4Oa1rOCTTll6Z9L9/bTvWXoPNu1o60R2ZfLUiNIA/Z2pW6+ZcsnRUU6x6VhXJkjI+GGYas5ZqGkbtwXV6JbsWkiE9um0ryW43H40KU+vB0Oj8ttktoy8fxoaVbcn8JtnXn7VWQJacalpag/tMkqNTJ6z47j9bRmnePMDrV9P2cvBwhlTT1r0981bEZWoLCncUngfEe3b/xPfg6WLUUnqck5//6DMmkdR2pbLCqAgnwmHM6msKRDNidXUOM4VGom9AxpojyK05ADkAS/56jQ4bP6DE9v6wUaZ/puvIbIrpsqv3ACXc4XA0zdNnRwSGRALaA10P8smitnGIN4+G1lO9ZJnz8aOhmA1pIWbr9K4gm/PcbN/iLONR/o2SbyyAgy6buVfVWQ6yj9/YsPF3yxgQAODUXOZ7NTHWaDKyeUPqz2GjWCxmHx8z7QKIiQZXzG X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BY3PR13MB4804.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(346002)(376002)(396003)(366004)(136003)(39850400004)(451199021)(26005)(107886003)(186003)(8936002)(6506007)(6862004)(6512007)(9686003)(8676002)(6666004)(52116002)(53546011)(6486002)(38100700002)(86362001)(38350700002)(478600001)(5660300002)(2906002)(83380400001)(316002)(4326008)(66476007)(66946007)(66556008)(41300700001)(6636002)(66574015); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UUQ2WTN1aTBLOXg1dUxINm5vZ3g4RnZDVUtzYWZ5NGU0MFcxMzdWNjZmMjhJ?= =?utf-8?B?WTI1NGpVZWtDOEVERzBrYXdIdHIwZXVDZk82V20xN0U5QXhycjBaQ0h1MEtP?= =?utf-8?B?ZFdkT2lsdHlxWERkWTdpM0VQanhLTCtMeTdrOFFhUzRjSi9QRk01NXAxczVj?= =?utf-8?B?Ym83Y0V0eDA4N2hGbFpmTVhsU2w1TjBlMTR4SzJhNWlxWDN4TmZ2WjJDL2d0?= =?utf-8?B?Nm5UMEVpejcwalArbGxxSCtZcW8zaS92L3BHUVZSZERmYzFUUkZuMG5wZnpx?= =?utf-8?B?azZsNFoySnBjWGhRZ0psc2VmNkh4Q0NOM1VnMnFsVkxvWURLM0hXS2pFQVY2?= =?utf-8?B?MDFxZXZnT3o4aVgxTFRNZlFuT1NhTzdvMkpwTk02ZHFuWGY0K0hhY2g5djVu?= =?utf-8?B?YXpiSFFLNWdiWjEvTm9wUUx0eTRLTGFpRkRpOUhSOGRWNWRoT2VJOHJUb2d3?= =?utf-8?B?Sy9qVGNibUprYjBwejJ5WFY5VklqU2pPbWE2SGZFMHc1bllocGRKRjJxVUpl?= =?utf-8?B?a056b0RDZnJ1Z1BzVnVRdkFzdzNhTjh1NTZDazNlRmR4V2U5aVd0WVFLTFhw?= =?utf-8?B?QUtURkVSZ0FrTTFBc0tBVUI5RlBhU3VDQmMwU25mZ1pHY1VqTWliazNtTE9F?= =?utf-8?B?UlFWcS94QUhFQXgxNUpiNmlMK09SOWp2RDRsb0lwMzczQ1RTNWM5a2llZXFh?= =?utf-8?B?R1piWW1FZDRXWHZBSnhTZG1mZUNvZk5kUlIrYjZhQWduM1FpSXlYODlpWk9k?= =?utf-8?B?WTFTNElSbTkyQzczeG5sVEdKUWdYY3d3REVBTU1lZmg1SEhpTnhaRmtUeEZy?= =?utf-8?B?cm1HNWhPN1NuemZ5c3pTdGx5UDFORkdsSGpYckJSL2Z0aGFzWmtsUFVhVGpj?= =?utf-8?B?Und1aFZLRXVzZG5VS1pENi9nSldySEZDMEVGRlBjbXR3aEx1bWprWHhnSE5s?= =?utf-8?B?MStJbTVLWkNwOXZXMnIzajdTRFJKemVMUGYzZUx4QXdBaW9KNnY3Wlk0SzRN?= =?utf-8?B?ODlaaEhDNmNqVDJuaVRkVWVKcE4rOGcxK1h4OG9xclpaVFAzMTJPSkR1M2hl?= =?utf-8?B?MXRleFNWSWhkMW52cTVRNWY1eEtDb2FldjQyZFUvWjRJTm5xaVExMWtIOHFC?= =?utf-8?B?cnFGR0dMZFlBaGxwVXBwUEVXRHBQd0NUT2toWTdhMkRFbzNGYWpoTjZFSTlw?= =?utf-8?B?TUhwNE9ock92OEhPNEFJa05pMnVlckczNmVSWnUyWUZqNGZUYkxyMHpPbWww?= =?utf-8?B?bnBqTUhXakhDNkpnaFZucWRkaUNtVXBVM1BycUFLbHpKdURVbEZqdUVBMENs?= =?utf-8?B?WEFRSFFnNCtFbFZXUytCQis4SG1hVlhDK2NaOTFrMWZLQmt1bm9nN1U5N1Rl?= =?utf-8?B?WWtPaTFiSUlGNS94MVdaMXBNSzhhekxwaThLWFpLQmRBRitCQ2FudVlPUEtC?= =?utf-8?B?czUwcHgxeGFHOHBZalFOU0xseEtDUmtwZjROc0R0V2ZxUW12QW1ieVlBeGdR?= =?utf-8?B?cVVNMkIxSStNeXFQVTdmUE1oK2dGNm15VTlaRXIyeUlsNWNjajJwaUhWODZ0?= =?utf-8?B?SUpzOUxjcysvVEFMeHBHYjVCUkJmL0NETUhKbVJSWHlyVHhQSllxbjBwUysy?= =?utf-8?B?OUp0SGNvY2x6bUVGU1FRbHJwaVMyZDZKMjJFRThob1NxSXRlSnloeDZiRlg1?= =?utf-8?B?ejZacFNNT0RLaS9Fci9LdWsyaFlreDgwOGtGdm10SGRhQVFneEo1NGs2NGZM?= =?utf-8?B?WWE4cm9KNFhiQmpoUUdzWlpxaHVLNUNLbWk4OEc1bEFiV1FPLzlSWWZtYVUz?= =?utf-8?B?eDJremJHeTJhTHNGUUFkVUtVbThmR09QTmoxZGEyM3k4b3ZPcjFWTk53Q0hK?= =?utf-8?B?Y3NkU2xjdFZQY1lwME1xeStTSTJtUVUxY2w0MHRPMTY1UU1iR1BOTTVsUXhO?= =?utf-8?B?QU1EOFpJSUptUFh1cHZQUkF6VDBUdlRsa0VrZkUyRko2aDZGcVhCRUxtckts?= =?utf-8?B?cDNZZy91V3ZERm9YS0tuS0FmbTZlSUVBTWdzNnp6Rzh0WGJNT1JsVE8yL3BJ?= =?utf-8?B?Qy9pOE9ueUVUVSt2MU13QklDNmlnT09mSnF0THpRK3dFTlNvd1hCVllIWTNX?= =?utf-8?B?SkQ2VUUvL0pPNnUralF1MTlpN3lPUWNmSUlVaTlUTmxWZG43OVpuek15OEZh?= =?utf-8?B?VGc9PQ==?= X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-Network-Message-Id: 64fdb560-f89b-4711-6057-08db522eb9da X-MS-Exchange-CrossTenant-AuthSource: BY3PR13MB4804.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 May 2023 14:48:04.6306 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 3TQ4bVT/KYQw2EfC4r1FD1ZVn748QlLXQW5CnUNI1sZlZ4zI4WG24qJC6G+U6BfUT2SrDVudTRsHF02TFA7xa7diec2QUwAjdnm9P+yHODQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR13MB4127 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi all, A gentle ping on this series. It touches a lot of files when syncing the PMD with the kernel driver, and to avoid conflicts with future work, it would be kind if this could be looked at early in the release cycle. On 2023-04-10 19:00:02 +0800, Chaoyong He wrote: > The DPDK NFP PMD share the same underlying data structure and API with > the NFP kernel driver, because they use the same firmware. > > The DPDK NFP PMD only has a very initial version and not changed for a > long time, but the NFP kernel driver keeps evolve at the same time, so > the differece between them are keeping expand. > > This patch series try to sync the needed logics to narrow the gap. > > Chaoyong He (13): > net/nfp: define correct size for configuration BAR > net/nfp: move shared target logic to own source file > net/nfp: remove the redundant macro about CPP target > net/nfp: drop usage of return error helpers > net/nfp: use generic macros for array size and to set bits > net/nfp: remove dead code related to CPP > net/nfp: remove duplicated nffw defines > net/nfp: move NFD3 logic to own source file > net/nfp: adjust the coding style for NFD3 > net/nfp: rename macro name of NFD3 Tx descriptor > net/nfp: move NFDk logic to own source file > net/nfp: adjust the coding style for NFDk > net/nfp: modify the logic of some NFDk function > > drivers/net/nfp/flower/nfp_flower.c | 9 +- > drivers/net/nfp/flower/nfp_flower_ctrl.c | 3 +- > .../net/nfp/flower/nfp_flower_representor.c | 1 + > drivers/net/nfp/meson.build | 3 + > drivers/net/nfp/nfd3/nfp_nfd3.h | 161 +++ > drivers/net/nfp/nfd3/nfp_nfd3_dp.c | 343 ++++++ > drivers/net/nfp/nfdk/nfp_nfdk.h | 239 +++++ > drivers/net/nfp/nfdk/nfp_nfdk_dp.c | 437 ++++++++ > drivers/net/nfp/nfp_common.c | 6 +- > drivers/net/nfp/nfp_cpp_bridge.c | 5 +- > drivers/net/nfp/nfp_ctrl.h | 7 +- > drivers/net/nfp/nfp_ethdev.c | 5 +- > drivers/net/nfp/nfp_ethdev_vf.c | 2 + > drivers/net/nfp/nfp_rxtx.c | 844 +-------------- > drivers/net/nfp/nfp_rxtx.h | 208 +--- > .../net/nfp/nfpcore/nfp-common/nfp_cppat.h | 725 ------------- > .../net/nfp/nfpcore/nfp-common/nfp_platform.h | 35 - > .../net/nfp/nfpcore/nfp-common/nfp_resid.h | 592 ----------- > drivers/net/nfp/nfpcore/nfp6000/nfp6000.h | 20 + > drivers/net/nfp/nfpcore/nfp_cpp.h | 155 ++- > drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c | 3 +- > drivers/net/nfp/nfpcore/nfp_cppcore.c | 47 +- > drivers/net/nfp/nfpcore/nfp_hwinfo.h | 2 +- > drivers/net/nfp/nfpcore/nfp_mutex.c | 39 +- > drivers/net/nfp/nfpcore/nfp_nffw.c | 8 +- > drivers/net/nfp/nfpcore/nfp_nffw.h | 10 - > drivers/net/nfp/nfpcore/nfp_nsp.c | 2 +- > drivers/net/nfp/nfpcore/nfp_nsp.h | 12 +- > drivers/net/nfp/nfpcore/nfp_nsp_cmds.c | 2 +- > drivers/net/nfp/nfpcore/nfp_nsp_eth.c | 34 +- > drivers/net/nfp/nfpcore/nfp_resource.c | 2 +- > drivers/net/nfp/nfpcore/nfp_target.c | 994 ++++++++++++++++++ > drivers/net/nfp/nfpcore/nfp_target.h | 3 - > 33 files changed, 2417 insertions(+), 2541 deletions(-) > create mode 100644 drivers/net/nfp/nfd3/nfp_nfd3.h > create mode 100644 drivers/net/nfp/nfd3/nfp_nfd3_dp.c > create mode 100644 drivers/net/nfp/nfdk/nfp_nfdk.h > create mode 100644 drivers/net/nfp/nfdk/nfp_nfdk_dp.c > delete mode 100644 drivers/net/nfp/nfpcore/nfp-common/nfp_cppat.h > delete mode 100644 drivers/net/nfp/nfpcore/nfp-common/nfp_platform.h > delete mode 100644 drivers/net/nfp/nfpcore/nfp-common/nfp_resid.h > create mode 100644 drivers/net/nfp/nfpcore/nfp_target.c > > -- > 2.39.1 > -- Kind Regards, Niklas Söderlund