From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3EBF542A4E; Wed, 3 May 2023 12:02:35 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0D87841153; Wed, 3 May 2023 12:02:35 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id 2D99041144 for ; Wed, 3 May 2023 12:02:33 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1683108153; x=1714644153; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=6x+ll7QF+MLBe1jQuQZDqBonl0VO4uqOg8SBTConbbw=; b=F9hV1CbDea6krjt3jXvz/Wlmc4u2gieDXGcZ+anA7lYXoI2aREp/PDPQ 0ssaJ1D1GvDtVgMlM5p673BkiS4AqHfnQHxi1p5Mm/82KO4QMsNPk2ZpB mNf4xgMsPV1PXaMVVEyUE+/dXVaGblitw7FoAiCSRwHJz0DVO1/ZhqROd 1RElgET9ZXpI1CoIIK90Ljym6GFy9INQz09qxpBQKwOCxCPKz1PjfAvUS u5kScKBjauXUyPNoWxPZIsuz026oxRoxi+pB62ykY5hXtQenJx06uTodl 5nmUyHOPZAu1ptf8y97gEiHr62jQTXVqB9GSAImTBfFRqaVoc2oAwNsnh Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10698"; a="434928924" X-IronPort-AV: E=Sophos;i="5.99,246,1677571200"; d="scan'208";a="434928924" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 May 2023 03:02:32 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10698"; a="729289651" X-IronPort-AV: E=Sophos;i="5.99,246,1677571200"; d="scan'208";a="729289651" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga001.jf.intel.com with ESMTP; 03 May 2023 03:02:31 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Wed, 3 May 2023 03:02:31 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Wed, 3 May 2023 03:02:31 -0700 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (104.47.74.48) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Wed, 3 May 2023 03:02:31 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZjjFWGC6LJH64C+k4C8Vtd5YKkuvsa5wZXvq7QXBBsl54R2BDROJGw/FL5O5whh4oKPrTAEWDkxBM7OuKwVY8TZToo6urbu0niAzjbiJcTDvwd9NKl8gDQMrlhHq4R23OgJz7TCt3254RnWE7tChv7cyNUEe9tnNU2NzZQUF79l30GgiHkvHqe/te5HSRRYMLdgl5eFyGwIErdWnIk93mmKu4ONMxwoN9HMRx9Grt/s7zzcEapeIFH/q1sfj0PSj5veiGHMn2U8CNB30V9HaMacqEKL1+1r1K65vpAKZfM+8Ml0A+kBwRTQfJQo6Yl4OVRVgshqzbn+HzyjNxhDaVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Wkoz4W4MdqeDVNrII4K7Rg0qgdEdKdXXoAxvcBlR2GY=; b=nCXNmOxJzhtkOAg006uYYQTOp5f2UKF23dmW6XLCljgd+13Jyani4ZxlTeovvEeKxYSfci8RXB58A9Zf2z3QEoj9DtojWtA8sGyav5OMq01FMxCikYm8u1H3HjOL/6xqaPUDi7K2YPL4GQ3ba1BrguXLAYydKxiMEHWVk6yfzOFin+pU+LxOZ5iuenjXUD90nTj2ILN2/6L6gisiklQo7NVueByaeczB1hcIAHrafDh6rU60YsFxY2GySgn/pbTDHUMMPlcKFt7tDoaPwHSq5fNNmM2nTxGXBE2r0KFsJP8n5oqWVpEWFhJOOBLZ7MgBlnY5dDx4uHb4jvsy5N7dsg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by DS0PR11MB7360.namprd11.prod.outlook.com (2603:10b6:8:136::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.31; Wed, 3 May 2023 10:02:29 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::b8f3:958:d2c5:2232]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::b8f3:958:d2c5:2232%7]) with mapi id 15.20.6340.023; Wed, 3 May 2023 10:02:29 +0000 Date: Wed, 3 May 2023 11:02:23 +0100 From: Bruce Richardson To: Ferruh Yigit CC: Thomas Monjalon , , David Marchand Subject: Re: [PATCH v1] devtools: allow variable declaration inside for loop Message-ID: References: <20230503095018.1710769-1-ferruh.yigit@amd.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20230503095018.1710769-1-ferruh.yigit@amd.com> X-ClientProxiedBy: LO2P123CA0102.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:139::17) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|DS0PR11MB7360:EE_ X-MS-Office365-Filtering-Correlation-Id: f11211c9-38a9-4cb1-bb7c-08db4bbd80ee X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: zq61TFA1qISw/h7jtJGb8XCHmOmlvTuREuqbsOX9lus7j2biqPX0QIS7xfaZy1cQH7o1ITe4qG/5ZorkeiMpfgItwJLQhw44IYJN8M/xtzsw57v6oML7B5q2eZtunUtzEChx3K6rdqVbtXOKubew62VIHmCQqf/YCis+IJn3zjGiQCO4FRjubnxliZ4X0Z/eY4YeZhprbUskWN5DXqXdPtk4TpRKtIdDA/yQ2MipO6/wCXgBQh0F/JmHc0kJysabKjq8/U9Cllzl9oFI2REGmKIThpCiTvKI0P8Otl+wQ5ECI4o9h2P4KUJyY5EMFrC0GSq2lOYcr3JLKl+YSC7PDI2N4pgBsAzcwrwSE3w+KEoOxOse9niGhshD6i5FpCjKdU3Pn7I18Hcv8JQEJJNXA59iLDlvCoO+N10J63p5c0OPjth7VNzVUg8xUFmvHVz14xj3SVwfaFVunmp+vbzalaoxWsCUxChQYqgHnXei62D26Bm2ll41JjZSqolQbPpWFPlhItDGYehkHOI927vdh67bbMBfN9fH36PofDwXrhI= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(366004)(346002)(39860400002)(396003)(136003)(376002)(451199021)(6506007)(966005)(6486002)(83380400001)(26005)(186003)(6512007)(82960400001)(6666004)(5660300002)(478600001)(4326008)(54906003)(44832011)(86362001)(316002)(2906002)(6916009)(38100700002)(8936002)(8676002)(41300700001)(66556008)(66946007)(66476007); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?/Xj68pbk0Mx3V0aC/bDmumCNjWmzrmXXVsTipLc7U9RLogAAxL3lYVE17R6l?= =?us-ascii?Q?RkNc1Jv1wsNc11StH61ZCvcx1CGhYiYlBpPk5zfRW/1prWW9ItbrCrwACMhW?= =?us-ascii?Q?Ckm4nmkWV7X77DJH6CwOGe4BUh9m0tX+JaZbJqZPKb8K15kzCDrzuLnnQoDY?= =?us-ascii?Q?PKWIuSeC2uaFIQwZfsh1DrIrUOyp8wSdhkUO/ZvcvBc7DsDfbW/S8v6PkD6o?= =?us-ascii?Q?KSmcgRUGOjLj75RnGI//Eyph2wOH/+hDOOatp5K5b1pquLH9g7cVoJ0qp9qS?= =?us-ascii?Q?2ZCL6ueRYBzxlVKc/r4ggH1a4hYIIw5vZ/XfWDvZr0DZuwAox4+7tN7qTau7?= =?us-ascii?Q?YUlCEZ05nTmYnUTf52Nz6uwmI7SVtw/O1IDD27UWiv05ueKCARe7ULW8108V?= =?us-ascii?Q?k2eaeDeS6PCffN6MlAXfRFgeJ1NIE6P+sFLGKp5HWSSvInbuftY4l5wEFmE3?= =?us-ascii?Q?jDUHPpEDTzeW/rzeNBRq/3JQa2SjUTE5gWLP9eB1Q/g/+O08gKzLMk6+0KfR?= =?us-ascii?Q?TN2HQgrPje209crUq01CGIzUCGKGQ/YpYNykrUMYgs0hshQwJ/IW22DTJaRc?= =?us-ascii?Q?Fzaez197UD27HBY1Mi+o5rBvZa7G++DRI8fnUh3Vrv7JBM3bAFEU4mfIhQcZ?= =?us-ascii?Q?Q4sBQVNkZdDHB8wG9M7HRqCfnvhq/IUnvjYcdfCQ+zygftenODALy4JgGUWV?= =?us-ascii?Q?LKH5S90KW8Nbw5ME+BD+TPHCqgASPdoaefc790oMZkPchaJhNnm4bgCrBfuc?= =?us-ascii?Q?7Cn7FdxwD4ajS5f9XrXaPmaFmpvdX1DvIVGkwtZHzbgJWFGdO7tksFTRofE0?= =?us-ascii?Q?DWgWixBnv64NDhfICDwtJx8NTD87As9+7NX6fV07AgdHRbDhdvYdSx5nWAM/?= =?us-ascii?Q?DNrl7cKt3cArhxW+MxWKhm2coGVdyjEeNL0rIL3W0h/nTfXjjmSxln/B/mp2?= =?us-ascii?Q?YYBl39yJGJl4RL8XP1fxw7ougQFmlXDePWwg1e7Facrm4HNAuoAnqBJqv3wc?= =?us-ascii?Q?wFNqtRw61b8/ot6SHjFkmkzg+Q6lEuwoUb76fihFMorAwVJnJoXJ3aJNbLd4?= =?us-ascii?Q?ysitssP2bL9oeMvkZEi37MY5wFCeOoai/95efvvMkmqvKLihnd8//IhBT5qI?= =?us-ascii?Q?d4IRBoDLvHtqDRCGec7YMPmGzIj3iBwnymG0bwpE3K4nfKb3RG/BSOQTvlWW?= =?us-ascii?Q?UFCySEqkniCSupWT/MQDzlLCrN5ONdOox0imTsUGUy19VOqdjorjBZUPWRlV?= =?us-ascii?Q?q4g/uPRTLtQXs/I0+yTZA9Et9tcq76+BQQMzEe6WskpT2AqTyKXEpD4Jbgtf?= =?us-ascii?Q?U3eD2Qy7gn5IsaOg7jLzUddn2KL/ybn5AW4QjaiCYV74lbkOuX+f9+cg52Fg?= =?us-ascii?Q?tueqgT7bEhjjPHY2Ovx9CpgCt3p2xpJSQMLIBdMBp3dJa167ASOqJ0wKwCl9?= =?us-ascii?Q?JAHeKprmewfYNSDKxSTiRMubQXyNFV05OrxRe6/P71c0jBHD7tCzm0ElpybV?= =?us-ascii?Q?W9je2qzMGVP7+eW7FOyIOGnclPJKJma0+RjsgplsD5bgGY/NKxp2kdmkMT7m?= =?us-ascii?Q?Z06GSCdy9WeYxIoTc5zlJTKXvsb+K5j9rT4ZCsVHipULzxbGR9C7U8wUCHqm?= =?us-ascii?Q?GQ=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: f11211c9-38a9-4cb1-bb7c-08db4bbd80ee X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2023 10:02:28.9246 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: xxomwcFoi0VGOhX5r8tpnLP9/V1M4GEENQOveUBfapLN0aCubPA5Q8lUP4vmcXYJo+3AWtFDbgCNzQLcuRP1Nnr72m224YPRy9TNenhQaa8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7360 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, May 03, 2023 at 10:50:18AM +0100, Ferruh Yigit wrote: > Declaring variable inside for loop is not supported via C89 and it was > checked in checkpatch.sh via commit [1]. But as DPDK supported C > standard is becoming C99 [2], declaring variable inside loop can be > allowed. > > [1] Commit 43e73483a4b8 ("devtools: forbid variable declaration inside > for") > > [2] https://dpdk.org/patch/121912 > > Signed-off-by: Ferruh Yigit --- Cc: Bruce > Richardson Cc: David Marchand > --- devtools/checkpatches.sh | 8 -------- 1 > file changed, 8 deletions(-) > Definite +1 from me for allowing this. However, is the plan still to move to C99 in this release. I thought we were just going to jump to C11 in 23.11 release? However, I can't see any compilers refusing this if we do relax things a bit now. I was thinking that our coding standards doc might need an update for this, but I don't see the restriction on not doing this documented there, so it seems no doc change is necessary. /Bruce