From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CFD5742B98; Thu, 25 May 2023 10:44:32 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BE5A040E6E; Thu, 25 May 2023 10:44:32 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id 4C78B40A82 for ; Thu, 25 May 2023 10:44:31 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1685004271; x=1716540271; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=Kh0AHyFRINSZKhDHsUY06BwGu56CzpBM3VJ9LGIkJ5M=; b=NWPlV3TdaIm1abcQiKsUP7NzuRc49wVYzpnhyd0rojVSDeX1uUiYBjIS 5dGMkGfSSOo+zKp0iF65oOn7hyLRy1jHkoYHXcOr7Vkv7hF3PMrZz+MTp Dv5F+EahMWvpvTmUKiu5RBIC6vHIq+c3pzo4qikkDEB8j0Kp26Ing3mSY JqVhX57M1wBCb6dtoXcfGPk4WgAyzwzUgGPe+RK4Kf7rOrFprdrPJParq 0YFTzCesHUJxwdZmjVF3k4ck40NpP7gX4y3IUp5PWOHMJtgHNfab1YeVd W8QWG8S30LlpbmC3pq4HuOg520kWJutXkv729gocj4u8+mPIWaal5w3pI w==; X-IronPort-AV: E=McAfee;i="6600,9927,10720"; a="352671719" X-IronPort-AV: E=Sophos;i="6.00,190,1681196400"; d="scan'208";a="352671719" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 May 2023 01:44:10 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10720"; a="794575342" X-IronPort-AV: E=Sophos;i="6.00,190,1681196400"; d="scan'208";a="794575342" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by FMSMGA003.fm.intel.com with ESMTP; 25 May 2023 01:44:09 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Thu, 25 May 2023 01:44:09 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Thu, 25 May 2023 01:44:08 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Thu, 25 May 2023 01:44:08 -0700 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (104.47.56.42) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Thu, 25 May 2023 01:44:08 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hxe8BF6woAZpUnVwiTKpZn2ZTtoMRh1VdkEaG0JEpi7JD2572k1hF0R9tNKmCaY693m5oWBLXOm9sIe97g/vJq/GXoUMCw7jG4RB9PuHkE3PUHKCrgJsLeDAUW3hGG98P8lbb4esfwIEwZfALCnpuI6rkFd/8Wgdgp/QiWNI9HsLZlO+vONevrX9Uf3LcKzzKAQRasnTq5oPpXfEp4+FY6MJYFlPctN0J/vs8KXg4BRxx3qRU+DZEDduMECpVvL22C00yIKhNLjK9X7BKc7gNt81Cb2/VIXManfAAKbE4bUHL/pvjaX6dWbux1Xi036C+IKC66F1XcoC4F3jklu19A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bBb0+J8mcrr/aqeNYKRevegYbbuYUFumKix1C9XvuN8=; b=n75yZqqiUEHkoe98r1FEKwOE6t5hT3Bd3tK58cQ7zd0NZbiB2xYlACQLdofWRkAyRdi+1oelg3S0qx+EYkEUleyNO4FPycob1tBsQnh095NOxGK/VhVsadrzYG/WwJTA+xYlVZ6VMos64XqKRE/dwZ5Dpd38PK7ALwqna2RJofdyLpqv9b3B1JQdcY2ZVtfRIDBjO5dDkUHKZyZnu9GPD4t+hRpcM89UQnspHef3t/hZoIwVWU4mqAXYLYV+h9D91Z1H0zT6HiydGo0z+hkqGGKIYBkeQFYsFS5TuJxsXIuNVVFGfwY9cStvBLsvvIAVjX5lrTJK7+Rt6WuXHv7NvA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by SA2PR11MB4874.namprd11.prod.outlook.com (2603:10b6:806:f9::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6433.15; Thu, 25 May 2023 08:44:07 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::b8f3:958:d2c5:2232]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::b8f3:958:d2c5:2232%7]) with mapi id 15.20.6433.017; Thu, 25 May 2023 08:44:07 +0000 Date: Thu, 25 May 2023 09:44:01 +0100 From: Bruce Richardson To: David Marchand CC: , , , , , , Tyler Retzlaff Subject: Re: [PATCH v3 7/7] net/ring: replace rte atomics with GCC builtin atomics Message-ID: References: <1679084388-19267-1-git-send-email-roretzla@linux.microsoft.com> <1679612036-30773-1-git-send-email-roretzla@linux.microsoft.com> <1679612036-30773-8-git-send-email-roretzla@linux.microsoft.com> Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: LO4P123CA0615.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:314::17) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|SA2PR11MB4874:EE_ X-MS-Office365-Filtering-Correlation-Id: e5c7e55f-a009-41c4-d181-08db5cfc3353 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: mFnwwRd9JmkA+N7fIClytvGVyUmYigUnZUxZ3hefNyYFAAg7U5KItyhD0mbWiM83R8xpGan7qzAeiqqc8CruaiJMStXLBkO5f3zVdcfElzF6GQlikwr8/fdSpYcnJ92bEGmRJ13ysKVWapBJHUe7uzzForOs4U+7ZP0xE75PKYigDvxv7DTXim1ne40Mt4TXtlTL3PRHBSuKwliNKTC5BDCX5BFt4RoAPqVyvH/Nsooam0wrtg4W60GOyxFgBFdlbacBnwFKgFfOr8AM+WNoU9XpHmY0bgcX9gMSgf6E/XfhCwd7LGIKiXQJCe2ySxDqna4BnU7PiY828mV5xUlkumFJUfo+O9LwzwbE/joqcBTIZ+ON3kXlCTdcbV8soDRv8Kzyppczy3uyLhuy5XAYxdqJkYWzDdhGeM1RWq4fsS8mGawIOGrRSnFVJUr3yAbEdRlooWm0fLWN8oOvnBGOKt5GABVNaP/okSrrh9/RoiqLxqZkhGA4y/XyiEADimCCsl6B7YZhNx6M5lILsTQYoag+JwAKCsyCi+kQHTHtdXr/ImpCVHPAtaD97i0mj3NU X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(136003)(39860400002)(376002)(366004)(396003)(346002)(451199021)(5660300002)(8936002)(8676002)(186003)(4744005)(2906002)(86362001)(44832011)(38100700002)(82960400001)(26005)(6512007)(6506007)(53546011)(316002)(4326008)(6666004)(6916009)(478600001)(66946007)(66476007)(66556008)(6486002)(41300700001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Mm8zSnlBbDZpQzBhSlF1ejZoSCtxcW5oQ1NNWTRFSmorKy9oM085OFBFdThL?= =?utf-8?B?WmRINnhZVHRtdDQ4bW9YT3dsVEtiYmVNODkxbnYvYkhQWWZoNlo0MGYxZHpy?= =?utf-8?B?dG8wSEZvWEtCK1RsY2FCZjZqSGVRNll6bkRwVE0zZFNKdEhobGduUWVaaVBk?= =?utf-8?B?ZHd1TmRpR0UwejZ2ZlU3dmc4WDN4MUZBK1NWZ2w1b1RZOE5XVHRrRlVOZEsx?= =?utf-8?B?Y1NodU9ZeVJGa2s3c2NEZzZWNFdIZkRmUUlkZldiZXh0R2ZVVFIzU3Y3ekhU?= =?utf-8?B?dnlYOWxZM1JmL3BYMEhKQzlabE1wY0l6VXJraXplRUdXSDJxd3JzcUpDR1FS?= =?utf-8?B?Y2o1R0ZwMUVGMVpWUVZZQ0QzQ09GOUViTWc4OENWdkVUaUwrd2cxNElRTzk2?= =?utf-8?B?SnJ1aHpSRWFlak5UWU95bUlic3dYY0EwZmxlcHo5RTZrVExGRUxJZk41c3pH?= =?utf-8?B?N2htSHJ6MzBMeThMTXdTeU1rdDBKU1BpVGRxanh1ckxacVVNYk9wUmdvRi81?= =?utf-8?B?cUFKWkIxeE85Y2JxYnM4STlZRlNrZmNRbmd0eEZzbkFUK1RrK09tZHNXKzl1?= =?utf-8?B?cEwva3RTUmg3WkJIK3B4djJTNlJoU3Y5NnhQTE0weXJvV1IvN0xtaFZNdm1N?= =?utf-8?B?RlJFQU5zelZORnRBV0V2OHdMRThUK1VNOGRoL1QzY1hSRVRGMFlLcllHd3lI?= =?utf-8?B?bEkxdEtXMXRJZHdjQXdPOVJ2WHM4Y2xKMU9vd1ErTmpsY1A0OWxNUThzeERF?= =?utf-8?B?REtiRmNVNjEySHAzK0lucGs4WXhCbnptN0xtbTFWakU3OE1hckRMckFTSDRQ?= =?utf-8?B?NkdFV3pjblFocVlBR2JWbjlyM3JEZ290QUFIT0FZSzIrR3QwcmUwSFZZRFc1?= =?utf-8?B?dm96TlNsMk16TW9kZmFpMVo3bmkrdmFqeFArMkZVbzZFRkhad01BZVJGM0Ja?= =?utf-8?B?d0d1NWdmdy81Nlp2NFRRbFJpbjdLMUs5VGY1UmNSNnlHUGNjeUFZNHVrSmVE?= =?utf-8?B?TlZMWHFHbktKRmxEajZHNzJtL1dtcnF3akhmM0paU3BsNXdpS3dta2VnOUpv?= =?utf-8?B?NDQzVXJielFCZTd4WUxVb0xxb1VhaHNXaC9PQmxjSEVNMFpPRENxTnJUc2lv?= =?utf-8?B?OE5nK0RML2lEaVFPU2trTzF3dUhvenVla085NC9HSzZKWEk2WGE3OU53STd1?= =?utf-8?B?NWNhNkRtUlNjaXFGdE1aTWxzVE5hSFA3NkJZd1hQbHF0SzhZN1V4OXFYVmo4?= =?utf-8?B?SUZGVnBWbFYxWTErcWFpWUxYYTFUNkZOZ25WZ0x0WWZMalNmSzRnMzNxQloy?= =?utf-8?B?MUw1K0hrbEdpMHg5VzBoaW1nODJmeEN2cjRBN2drYWgyQzFqdzlGZWQ0OFVJ?= =?utf-8?B?WW1QS3Qva2ovaFIvTzJTZi9pcDMvK0MyNmo0Q3VFY2g0SmlWYkdPbTZic1No?= =?utf-8?B?OUwzSjJQSjBXejUzV1VBV1FyckRydmE1MDNQazRaNm5wMXk2cTk2eHpBUDN0?= =?utf-8?B?dzIxWWIzS2VKNGI2NlNwcVJWdTRQODQwZXBKeFV6aTAwcENLWitzUDIzSlpG?= =?utf-8?B?ZlF0dVhUcERFTmQ2OXZ4dktEVjIyMmlhbXZyR0ZpVEtzTU5vOGlwN2dtVHlW?= =?utf-8?B?a1VGOFpJcUVDcmJKaDJOZHVkRzhqakI1WjRRUFlxbGZBcUNKN3ZiVVIzdEc5?= =?utf-8?B?RFRGeisxYUZRQ0t1dVczTFZQeVlKckVIZWxlSThQWVNkSGYxNERESFQvaVZJ?= =?utf-8?B?VDB6SWVmdFduaFY1aE9EMjNmUTVEUTg4SFVFTTJZaVczUE1sZHkzWXFFamw0?= =?utf-8?B?aFkxeE9RdHdXZDJVVUUvZ1hZYXJZWmV2YjE5STdaaEdMMUlkYk5qM2FLVllw?= =?utf-8?B?VTNNeXlTVExRQ3NXTHZkcXdGYzlyQkJrR21OZkVQN3lTUXRtTTJrNEJtOHpu?= =?utf-8?B?clNjam9UUlpNWXlSL0Z6SUpGQTZ5emV5SGJRamRxQzlkaEtxNzlQUlNvRDJv?= =?utf-8?B?WjFlRHFDZ1JFRjhQZXpTZUI1MHZRS3g0WHZvMmJ6UTUzcGFPUis2eS96NmFY?= =?utf-8?B?eHdRZ2p6TTJGc0pxQXViZ3BoYXBqbnd2d3lwdDFkVkRtbzhFTTV2Z3Q5ZEhG?= =?utf-8?B?bnZJMFpIVUV0NzVQLzdxRTd3YjRYaHRlTzRvQUpzOVFoZ3N5YS9qQUJOaTc5?= =?utf-8?B?b2c9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: e5c7e55f-a009-41c4-d181-08db5cfc3353 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 May 2023 08:44:06.7972 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: aPuOuslRGVYF9EscDawz3MAWQMWy5qjfI1VFSdT3GmLj6MoFPH1quIwES63r7UOwKRTNwqz8E8xWFnjIgPRS5wR9/FaM5S9AG9Il5aJcr6k= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB4874 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, May 24, 2023 at 10:12:44PM +0200, David Marchand wrote: > Hello Bruce, > > For you again, review please. > > > On Thu, Mar 23, 2023 at 11:54 PM Tyler Retzlaff > wrote: > > > > Replace the use of rte_atomic.h types and functions, instead use GCC > > supplied C++11 memory model builtins. > > > > Signed-off-by: Tyler Retzlaff > > --- Acked-by: Bruce Richardson