From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3785342C50; Mon, 12 Jun 2023 19:59:22 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 28F3442BFE; Mon, 12 Jun 2023 19:59:22 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 11EE0427F5 for ; Mon, 12 Jun 2023 19:59:19 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1686592760; x=1718128760; h=date:from:to:subject:message-id:references:in-reply-to: mime-version; bh=tHLZU7ca8dtqdUxYDMld20d4JOaz1Zlq90Jsx09a/bw=; b=YE1jf/yFV9W0S0fmINgtAeXZRxVFIhwLs8Yi2nUxJ4QU/bmXSm5vTTCC ykO6VQsB0bOvbEYXq2JZ0anmL2q2+kVDLZ9tPkg+uzuZtFg1o+u7apKR6 BD9Jm0q6WpHBF9RuD/mYkq3ByyiKkG5Vg03G3XF20vXAbu8UaJZXEXsTQ Guv3srzTgEGNERf7aTGQfI8KSGRVpAC5QGMaRyVM3n5AbCA6/PHutHqzZ 6txbpTLGd7ckNwqw+ULvudGx/G6+a3dSnSS07iB+KHa0Fcqzx3/e2Zubp gFMMub22IN++226mK4yU1EjrOR3OkTYx8+SXTGm5OwceAXs+bWQw9LrVS A==; X-IronPort-AV: E=McAfee;i="6600,9927,10739"; a="424000585" X-IronPort-AV: E=Sophos;i="6.00,236,1681196400"; d="scan'208";a="424000585" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jun 2023 10:59:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10739"; a="781326500" X-IronPort-AV: E=Sophos;i="6.00,236,1681196400"; d="scan'208";a="781326500" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga004.fm.intel.com with ESMTP; 12 Jun 2023 10:59:18 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Mon, 12 Jun 2023 10:59:18 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Mon, 12 Jun 2023 10:59:18 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.168) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Mon, 12 Jun 2023 10:59:17 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CixNCHRg0ZxKR3knlQZMUhU/5pGXdhH2UDgn06tcuZGiVf+smlhxgxx0cQv1zlf4DEPg1h1FFOQsRl3jJaPRfoIkTSm1i6Kgdem6vPlpQzJ26t2sZHm90EbyYgn2k5XLjdwh18BG2XHlhCgKx4wNbQDc1Z0/Sc+AU+1pvGsfgj8mNGskxfBTuA04sZjsJQ5o5AGTddgl9wDMhZsdPPZE2tcshoBVfru+Rk+PeubdhU7yeiPFSAVMmmjUT54BlXKEfSb6qgbkkU0K0dD33oXemA63v6SKush3WFBsHCIOzBvcEMLvFjGZc3CqipBtXxQAg8HzXdw44rsGCigmu5G0Jg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dHGe4YthBZmLiUwWULOR0RMFR6WjJH6P+B8SjivqtdI=; b=IKm9Pk8WGUb8+xEavSXRLUubJNue52dU3ifkt/jxsKvm83ZRkklE6zDfR1Er+5JZRaDpOjomLyuWhKE+IGKbHVOwQhPHFdaVtixWdH9Ax+/4TvnpkT+yZnVK/wURnyRox04/Wc+AQchsP7W9bAf6VykOqU3gUhiFkUsboG9/OPswpbBWNCSOo/SQYydqLDGOwcLxXsQpXZFT1FHU4pCzlMpernCPhC6mZixcu/+IKiKYwdpFn4m6TT4L/84fvfsSrAGOpgw0cK6K3H9of/Fw1D7KlVIvAtF4VTd5xuI1X2u7S/AlyHjbQBkSNy0n3mXz/iITPdDDFd/dchO7gbuUqA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by DM4PR11MB5357.namprd11.prod.outlook.com (2603:10b6:5:394::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6477.29; Mon, 12 Jun 2023 17:59:16 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::b8f3:958:d2c5:2232]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::b8f3:958:d2c5:2232%3]) with mapi id 15.20.6455.030; Mon, 12 Jun 2023 17:59:16 +0000 Date: Mon, 12 Jun 2023 18:59:10 +0100 From: Bruce Richardson To: Subject: Re: [PATCH v2 2/2] build: prevent accidentally building without NUMA support Message-ID: References: <20230612162104.170749-1-bruce.richardson@intel.com> <20230612171456.173378-1-bruce.richardson@intel.com> <20230612171456.173378-2-bruce.richardson@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20230612171456.173378-2-bruce.richardson@intel.com> X-ClientProxiedBy: LO2P265CA0250.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:8a::22) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|DM4PR11MB5357:EE_ X-MS-Office365-Filtering-Correlation-Id: 4ed950a2-9b02-426d-c448-08db6b6ebc88 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: sPCr2igFxBe88AFIHuRKR8mBK7Tw/mRLtKqNimGHcm/QkJzW5sl78IuRjoN/3AaGR26j1s4Kymi/HwJ4HQFVpOTLRaVVr+Fa1IMtrbH7XoXcj9RxyZBn8ManxreTOkSb3Olo91bBAensyBDWBKIuuSxomZZIGU3uHSH0MHudYVG2ZNcje/QlgP6ygGhvlMsEtA787pbxMUUoRi5+CCkxYr0GgusTu0mrni/+u29e5lq2pWT1O/KOqogLhvrhwCp8FUcCNjjVvNt6wNN/lUBUNYSjkzS5GAu2RF+v7i2n4w8KbwikR+2+olQwWIi8X4jknzHjs6V9+QRoAvFRFV3IrX7R+wnykIyZ6OpXuY7OuSwREySakGFGw2KLb3W1iQrgE9drQJMIDpiQE+gMHBaastIvbVZ5XEy2JtwpoH9BJCRjJaCrdhPX8npBrxY4FfosRrL4u7IMxTz9bAMywH+nXOYJP2mi4pZiU2XLm+VFgoJtZG7QO6GRi+z9AXQ9zL8H4VMstQTg6Nmny9/Wf/M+V3cVKzb/y5DLj1OXYPIB0/o= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(136003)(366004)(39860400002)(346002)(396003)(376002)(451199021)(83380400001)(82960400001)(86362001)(38100700002)(478600001)(44832011)(6666004)(966005)(6486002)(8936002)(2906002)(8676002)(5660300002)(66946007)(66556008)(66476007)(6916009)(41300700001)(316002)(186003)(6512007)(6506007)(26005); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ZDdhvvflJeJiLq7G0bhWEcQWNh18yxi+izktKoeaklzRRmJISWxlBqk9AyDU?= =?us-ascii?Q?oQzqsl2S0JuKKDCvQmyiYn4kUispWdCelRZhb91pPKx7ZqHVmo9ZnvLW8B7W?= =?us-ascii?Q?vNIOKqURQIdzNEcR5JQWyELtWpLpXFJFEKAjld+drRPYoXbuq/Z/zM9/5qB+?= =?us-ascii?Q?yi7vjQtpAqKMLN/IoeinakBsSkIsVsQfpIPQ4KEvUohgryDuulybSRJzC0Sc?= =?us-ascii?Q?RzEn2FFxG+TSs0vWX7t0ZEk4S1lFzOap2XY3O+gZ8pjgTvTpnG9KSTinlJV8?= =?us-ascii?Q?sBIUCapXh1b9ktWn1zqxMCXEQeMnJQtyLGVYmHU+whz6O2f3yx4vhHT5MVof?= =?us-ascii?Q?0FHoHgrR/ZNghyksf6Y56cYaneKFXJlc5UtAeRXScfrQGlVwK1na9wgi5Luv?= =?us-ascii?Q?rxSNjJCKjBZoHaf3+vto9i8v8F8NwAOVVoLD+wcaERmdv2fgk3EZ8Q1qzuEc?= =?us-ascii?Q?20lqXyl5df8rRbKmMzoXsOj2RqkFd3eQptRvV8kmcA3KUotar2SAt98rTFUw?= =?us-ascii?Q?07zya+UsPPsJE2G85TWIvCkXP9UnnI1i1u25vR2xPxRx2dxxjP2YXiSk7tvF?= =?us-ascii?Q?nbPoZIpC82/M3hru1R184Alz4YA2S3Pi1Pnw2gz0XYK2ay+GiOrbhR2/HIjV?= =?us-ascii?Q?x/MHZuP3Hq7csWDlREAntbb4DoGWsOtueFJnfYOHk5C0djiG0/ISSzLRgcUq?= =?us-ascii?Q?SfONJ26bAiwqzoz+F4huXiw5tTGGjdX95ZLUbIEao2lYNbw/sjKnMnM+N7yw?= =?us-ascii?Q?K/New7DB6ZsPMjiuw7wTRpMOZaEZu78mmS6RHU7CsJtJNeT5iFOBdMHrmpUF?= =?us-ascii?Q?Ie4jPKFPkz4O+XrVm2vvYM+BbtCoGwG0xB0xWWteLDd4Eu8OxkFiNtDYdkqd?= =?us-ascii?Q?4HGErEJ3z4/EqcPTNCwzj43ywmrpvZqUoYPjZCTpIa+/Sp/87rW6zPLDaMD5?= =?us-ascii?Q?81Ip+Yc7ZDUudzsAFLWKkpiONkUfJ0oYZQAWMjeZRbVs2vJZPlVuScKD2pRS?= =?us-ascii?Q?4GMmj/JLGcpMw1M6NuPClZbfjqkznCTuiN0XBckuUUKnYXMIAEmAvg+wwh68?= =?us-ascii?Q?hiCMTYybJ9aQZpd9vjYhfJJAZJKFKWyJAaUhxSHfcqptel+PDf7wuyV23f/2?= =?us-ascii?Q?cz7ewHfJercXKYSNF5RwCI388d/QtuZiq3jpO5wuECWZBR4U+JmCv85s8GEp?= =?us-ascii?Q?lAxXyVG7tnCxvSniYEzXyMSRZNFW36w7c0Lwo5L3fRZib9sWXOI1R8asJMHG?= =?us-ascii?Q?b3Onn4xlA9BzKPDuFG4a6MRMtQWvOgrj46rgT01Udo5IuqgnFRslKyNFl8EH?= =?us-ascii?Q?PSGoJ+NpJKbs1ZflLm6Qnmx4AOn+ELMLrq+v4U48X82rZ+L9LEQsgMDPua8+?= =?us-ascii?Q?jMfIPUFP8ylnCk/bwNrlHqmrxkagO16ySMLcn8wKxBLUP6uvMghtzaP4DRT8?= =?us-ascii?Q?KSTYLr4HW2AM9oJ2tZxWTYCqPmRAPMTA1gCGpbM/9h6Kc1j+MoOE0U8iwabS?= =?us-ascii?Q?Y3XohjknSvswPcZ2y/TYoJDbEek2w9zfasZHhQtjw5W7l6PAxxurUTjmQt2L?= =?us-ascii?Q?BOcwJkMcaJbJIBqtwuWUzlTUdhZwW37vxRMgBP0U0hhiSH9ww7l8DGpmGsbl?= =?us-ascii?Q?pw=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 4ed950a2-9b02-426d-c448-08db6b6ebc88 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jun 2023 17:59:15.9841 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ZmgR9S3yeyphyU4FHHSPWkPnZfyAHvuxJlXEQnHnzPT3En7cqLXcuLNbZniiwOrb37C1D04bepza0jvGQKCfigwwQsitff/1nY8U9B3z5qg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5357 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Jun 12, 2023 at 06:14:56PM +0100, Bruce Richardson wrote: > When libnuma development package is missing on a system, DPDK can still > be built but will be missing much-needed support for NUMA memory > management. This may later cause issues at runtime if the resulting > binary is run on a NUMA system. > > We can reduce the incidence of such runtime error by ensuring that, for > native builds*, libnuma is present - unless the user actually specifies > via "max_numa_nodes" that they don't require NUMA support. Having this > as an error condition is also in keeping with what is documented in the > Linux GSG doc, where libnuma is listed as a requirement for building > DPDK [1]. > > * NOTE: cross-compilation builds have a different logic set, with a > separate "numa" value indicating if numa support is necessary. > > [1] https://doc.dpdk.org/guides-23.03/linux_gsg/sys_reqs.html > > Signed-off-by: Bruce Richardson > > --- > V2: Limit check to linux only > --- > config/meson.build | 9 +++++++++ > 1 file changed, 9 insertions(+) > I see this patch has failures reported in the CI, due to some of the systems not having libnuma installed. I'd view that as a false positive, since libnuma is effectively a mandatory requirement for building DPDK to run on most systems. [And this patch still provides a way to build without it - that way just has to be selected deliberately, rather than it being chosen by default, without the user being aware of the omission.] Regards, /Bruce