From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DF99B42CA6; Tue, 13 Jun 2023 11:20:46 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BAC6840A8A; Tue, 13 Jun 2023 11:20:46 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id 8369440698 for ; Tue, 13 Jun 2023 11:20:44 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1686648044; x=1718184044; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=IcuM+i/NG1R/V2kuc/DHLbNCy7TzFpRCwQPbR1uCruE=; b=iolkU/e7pTD5gjerb7DWFfW7p4OMMOWsFoAf3kntCSHCMpd16Qh1WRlS HTRPyqBFSQta3alFM1XBNneO81DWAJotjcycAxd01st3cxbBG5/yPNbzT HC+dNf5mvpdshBtC13zkz0xgUYr79IJczzfxr37owvax+k/jmQhPPtlqc HmafVMFmLE60IvRo3d8CR+PZgMc1vQOYVwcEGMjICPZbNl9VnKOTUuUO5 uC3OR2ExCEJh6sTx6g1pjj0XnaWgaD09n5rTHlYs3PWb5TIUdC3hezI4z W2Afo7mD8q3YNsbJ8ofp+c3WtsGSxSH7zsqba6+UU63FNAk35ZyhUYmaH A==; X-IronPort-AV: E=McAfee;i="6600,9927,10739"; a="444652239" X-IronPort-AV: E=Sophos;i="6.00,239,1681196400"; d="scan'208";a="444652239" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jun 2023 02:20:25 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10739"; a="856013202" X-IronPort-AV: E=Sophos;i="6.00,239,1681196400"; d="scan'208";a="856013202" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga001.fm.intel.com with ESMTP; 13 Jun 2023 02:20:24 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Tue, 13 Jun 2023 02:20:24 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Tue, 13 Jun 2023 02:20:23 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Tue, 13 Jun 2023 02:20:23 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.104) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Tue, 13 Jun 2023 02:20:23 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZR2VbvBwnpVMhyKFmWSkFUddf4OuJig9dGPYQF4XZ+1RyhpJQQ//G1LfoYeYt2ZcP8bNtRxjeU8qs57JwYsANsNtqEVPMDNmwpIYArQi/0N+QmsUwh2q7up/viRrMCaQCOd89p+5H83bJwtA7pVRSH0iFn8qCwwMxIhR+AXkdHNN8bPUBPptm0atF1Z8AsbYTxiyvXSguLHP4s7mizGnj/PBSduyzvJ7mbPpySEU1HFtPbZwVzf2dlh1OcXk5akWGBCI0YUgt7nPz6Ytf5+GAew9pvah0WMWIb5rOHiR+iz32O7BsZLcbO0Gs+kkMxoB0rEakex85oWLuJeiIwworQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zQRGGogHErzkhf1AdIKUfPnHyhCUZVY04VgSfkzCyqs=; b=NJ+3apnX+jHcHXYTO2S+gZEsph6JJfV1U8oJrCzRCCYjqo4YWzsB4HJNOknbXIlR/KAAqlCtk6a8FGHCID1g3ACyxtm0M4QRSeWfxa6cOy5rjiOkrJOgMEClND8iTxIW0WUqNbntRpkF7KPFD2b5CqDagMa2cm5XZFkRPJmXvWQiYXboq4XdAJ0enPdeLs+jln3iWvAqQkF4zU32fHrWm03pY2BK8q1TdnJQpNCkosU09KeswzVUvtJQGDf1ErKK7IOCXk0NwVgDMDe4ZB4EskiMY3ymFM/ogOhnTPfdBXizPJCCluD9smF8KMCSjGL/14pimLu1VrklMIdOMESzow== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by PH0PR11MB5596.namprd11.prod.outlook.com (2603:10b6:510:eb::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.44; Tue, 13 Jun 2023 09:20:21 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::b8f3:958:d2c5:2232]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::b8f3:958:d2c5:2232%3]) with mapi id 15.20.6455.030; Tue, 13 Jun 2023 09:20:21 +0000 Date: Tue, 13 Jun 2023 10:20:15 +0100 From: Bruce Richardson To: David Marchand CC: , Subject: Re: [PATCH 3/4] devtools: build all examples externally Message-ID: References: <20230613081741.4083273-1-david.marchand@redhat.com> <20230613081741.4083273-4-david.marchand@redhat.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20230613081741.4083273-4-david.marchand@redhat.com> X-ClientProxiedBy: LO4P123CA0556.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:33b::6) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|PH0PR11MB5596:EE_ X-MS-Office365-Filtering-Correlation-Id: b3cc6d6c-3492-4fac-c8e9-08db6bef6936 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: NqGMf41xsfc/IFdZCX5OkHWeiY6t7yY597w2KZz3vgZnonA+US6Yg9UbTObzKXk6KB9cmebPl3RQ8ScHbrD2Evn6wstNdgU/xEoN76An9KeeHxDqdKXMxd21IIJ9CrlReamFDvpfDUzC69lHDwqt84bpWcjzX232my8T4P4/J6AWvJ3iPBiFp4zr8tV+G/GhbQwYGlmmESsUU3V8dnTNRWjutl3qBuN9MY7IcqghpkP9XDLJv60zXAzm+fXZ39Yg/G4Sm1X0vNQUG31jUwh9Oeuz24ldv3Jk+x5Gmf6MOmyHlFG8SAak45yyACF8NGLGVJw4j576jARypEy9CkjqpKSy2hQ2wGkA6FpzWy/HivXfCiaxg7k0YfVZjmyiaGg7pfIv6qWq5BgSTAaUYwnZ9XwMRSJ/oE33xzL49Fq+xEbsRnfguyOx8OwYvWHXMa87KEZv+hyNHjwpfuCs5gzw8k23eaLhkGOxLMxdVif/GAX1lNbJjmI9ibYp3kxUIMfps6FebHidWiSwj/ZGM8BGvha4sVoCTECU8D4uKFQcUTC2mNzhU0EGZzDQrE9dl5b2 X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(136003)(39860400002)(366004)(396003)(376002)(346002)(451199021)(6666004)(6486002)(478600001)(6512007)(6506007)(186003)(38100700002)(86362001)(26005)(82960400001)(4326008)(6916009)(66556008)(66476007)(66946007)(316002)(8676002)(8936002)(44832011)(5660300002)(41300700001)(2906002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?0OMi7mwmJVBXM6NRJ0YIfcIP0WKr870h6zm+eexVMnVjvfJhEeNFGyh8HbYi?= =?us-ascii?Q?ilArkkLL2v0Qm5VHIWsBRynIY55nQ9nZ31wxhzUMatKh4Wub0MKi172tiPZV?= =?us-ascii?Q?irel9kVQHPxO0XUvgOxewPFJ8wB8ZNEmQ234Mmme+ukOamMCxSnogA9Fb5SA?= =?us-ascii?Q?yfytNO67FH/FRLqsX66CGNsMW/NSWvHWv4eDfZIm3MGrVQiYh26FeGtoPFfe?= =?us-ascii?Q?d6CipaveCxyML1FKkYXWNRILHeSh3HOWVHvvnw1Yuitd2piHahiHDV0kACqi?= =?us-ascii?Q?sw1azKi+iJyrdhJg3+Dm3BSv7mIZa4yIz58dPVpnEizEz+vI+WUyYukZdUS9?= =?us-ascii?Q?7NiWjmSR2l7tSDV11p+N52cYpnLtuhx+X96DF1wewkSdUOMs2kTAKJyhlWzV?= =?us-ascii?Q?NYYce95Z1/eD/Ti/uOISEtADtyOYUv6s+ii9l5xC44wHxWCrtK+J053ECPZX?= =?us-ascii?Q?jxejYYTwojDMWQ+2f6e828AwR4eKv6o4eWBvXN72zvjrx1uMm7CbsulUqdEC?= =?us-ascii?Q?hj3G/3+aArdprU5zCU8sJuypqYAy2WgGTogzP1phhkgFIA+DjQBL4YaUB9H1?= =?us-ascii?Q?wXLJo16jRq2iPr2LQ0Gr/4aRK5ccr1YBI1yOw5eqXwtIVrIWZiFU1yzATPXZ?= =?us-ascii?Q?7S7wMeco0MjxwwXzqqHQEUjKQdT6mB0lu9Qj1VHoxeCKMKjRNY5gS35O/+Sv?= =?us-ascii?Q?/syTJO1W00piC6PpYJeFmtcnPiLFYestFC2SU1ZY+AqodxhCJ2E3FP7VEg/i?= =?us-ascii?Q?TN8zNvrX1QTKCzPv5P8QnOtgPuqmV4RBbTj/yJZWYNPQiSeAVVr3U+0fvM7K?= =?us-ascii?Q?1YUDAdwLfhdZNmwdx9x8aoP5tD/ALN4TIIbjSBMAd1xHAq1YkwZwI9oAx3Pa?= =?us-ascii?Q?PfZzBqaD/nE3kiTo/2kslp7IjS7/bQ3VVtkDw6RK038uMCpz588ByH4J6lWo?= =?us-ascii?Q?o93o7pRh5YwuKx3cbNSQo7Qi8Z9H0YBSE+OQcmH615F4l7yqKvJP2n1r+Lf7?= =?us-ascii?Q?8UMNHMbUAQ4zkg5NlzXmd5NEKkI5T7pKelRLOS6K53Ojk0mKGS39NE9xdkNV?= =?us-ascii?Q?aYHWeDjnJ5SckC+XPzVIiOUOhCKdodH5NTTKP1ocDPrV3atcd75bDzk9XKSO?= =?us-ascii?Q?WfUZGjk8XytkSTsT8UBfzuTOrC3LIfktZNRU50gcclCUGRqLoTgbXccyaoxP?= =?us-ascii?Q?OKIBEy6MD3DkfevoxrhEQG3VymW0PZXsRgUk4OLOCQX/MQrI1kGL1rqhOCgi?= =?us-ascii?Q?gx2WQT4dyJ2EhnerRjJevlBAByZ3bCr9v3eVQ4Gy9Q5RpjesKOdr9zVNClfG?= =?us-ascii?Q?KKC++i6MHlnKxx7YDdLPq6+9us+p+HLp0xLveCQ8WuA79Eploo62mXFFIRnq?= =?us-ascii?Q?YbsgC0r52xMm2uxyQYrfMAL3pYiZUE2vXd3LEFgyWZfPybLNKRtSMHS1fy8+?= =?us-ascii?Q?tEJRqHgg/WXBZSXI7oKxUMo+opyo2KEi75UqMqylbNVjLSmLvvq5Ar7BroQM?= =?us-ascii?Q?xTi7o62P5DZpYddFmxZkKPHJqFmYBh3uZ66iHaVU3k09GQS8wJa347HJlt4n?= =?us-ascii?Q?LFaJ5KjvuFxJdsiiOqn37zs2YXJ2QDBvYYDI83rkssZEPNUifJQvqE6aOcGu?= =?us-ascii?Q?gQ=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: b3cc6d6c-3492-4fac-c8e9-08db6bef6936 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jun 2023 09:20:21.2807 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: vqrtWrMJFxQ7ys0VM9imtD/ak66jRRjFL8axhTGaHFx6uqFejAIz/VcfV7Bo5xXRA9+ZUn3U1wwuwvuuZBf0ZUmXjGtPd7GyVp+ChxifUGo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5596 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Jun 13, 2023 at 10:17:40AM +0200, David Marchand wrote: > So far, users of test-meson-builds.sh had to define their own set of > examples to build externally. This is not that great because users need > to maintain this list when examples are removed/added. > > Rework the script so that the 'all' value triggers an automatic > discovery based on what was configured/compiled with meson/ninja. > > Signed-off-by: David Marchand > --- > devtools/test-meson-builds.sh | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/devtools/test-meson-builds.sh b/devtools/test-meson-builds.sh > index 9131088c9d..cab3373544 100755 > --- a/devtools/test-meson-builds.sh > +++ b/devtools/test-meson-builds.sh > @@ -299,6 +299,20 @@ export PKG_CONFIG_PATH=$(dirname $pc_file):$PKG_CONFIG_PATH > libdir=$(dirname $(find $DESTDIR -name librte_eal.so)) > export LD_LIBRARY_PATH=$libdir:$LD_LIBRARY_PATH > examples=${DPDK_BUILD_TEST_EXAMPLES:-"cmdline helloworld l2fwd l3fwd skeleton timer"} > +if [ "$examples" = 'all' ]; then > + examples=$(ninja -C $build_path -t targets all | grep 'examples/.*:.*c_LINKER' | Since the build has already been done in $build_path at this point, would it be easier to get the list of examples from "ls $build_path/examples/dpdk-*"? > + while read target; do > + target=${target%%:*} > + target=${target#examples/dpdk-} > + if [ -e $srcdir/examples/$target/Makefile ]; then > + echo $target > + continue > + fi > + find $srcdir/examples -name Makefile | > + sed -ne "s,$srcdir/examples/\([^/]*\)\(/.*\|\)/$target/Makefile,\1,p" > + done | sort -u | > + tr '\n' ' ') > +fi > # if pkg-config defines the necessary flags, test building some examples > if pkg-config --define-prefix libdpdk >/dev/null 2>&1; then > export PKGCONF="pkg-config --define-prefix" > -- > 2.40.1 >