From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0A8FE42CA6; Tue, 13 Jun 2023 11:23:39 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D64C940A8A; Tue, 13 Jun 2023 11:23:38 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id DC16A40698 for ; Tue, 13 Jun 2023 11:23:36 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1686648217; x=1718184217; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=racbcyG3OZ+PI1hppOe6sERmdYclRUk1HuW3VV5Xj10=; b=OjpqAiD4qGOOE/nYFOhXDkM4pwTnbdpB2YBOcR1mc2Rls2HYdU6ST6Cr nl90zmgm2g7ltRAt+JS/cifuE7cBuG6SDGG/gOSeKiqy80apDgffQSLLP ANK6U4wuVgWXZgeekgsMmN3VhdR3Oep23mx66UYjCuoxl3JGgA0Sv3stQ kVI0jf52NtHRM67I5pxfo9KgmIgKsnX3h0vU03Xr5H7rHTYKqIKiTCRLI RZ1NhfLd+22yFBGgkNw90LAkm6fUrIFfcoWaiyyqMmV2TZ4VgCGvSH4FM 2XW3KXOwrsTGImezZVfhtr6+8pOlfFuzHDthrTfXMKLUiYz1hoF7ZN21H A==; X-IronPort-AV: E=McAfee;i="6600,9927,10739"; a="347931611" X-IronPort-AV: E=Sophos;i="6.00,239,1681196400"; d="scan'208";a="347931611" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jun 2023 02:23:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10739"; a="688945166" X-IronPort-AV: E=Sophos;i="6.00,239,1681196400"; d="scan'208";a="688945166" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga006.jf.intel.com with ESMTP; 13 Jun 2023 02:23:35 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Tue, 13 Jun 2023 02:23:35 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Tue, 13 Jun 2023 02:23:34 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Tue, 13 Jun 2023 02:23:34 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.173) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Tue, 13 Jun 2023 02:23:34 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XOSF3GltBVenf2wcd5wWQEoR6BlruhOYgXyzb9VhfQdq75gKSLKyRR/Kw7nlHE0sTLlVyWVkp0jZbfrvZnpmbGcfWfGjUU0AvVbvSy4ra47dPDQbIkz3OW9+wdZ6GHrWEnfry0SsB6XGYogQk53TOuiLHxn/fHd964EzByIK9Reltu5qvg9q5WS2crrepVOQ9nGsZ3hDHtrFHfNvEglzTLLjCRIE7k9z5IYNkB9QueKY0TKgzfInysEx8QztOjPm7ewhSaRkh4FGx13gjatfY6YrZUPosLaFTUYDnl5jyeXJ7aLC8Gk2hNPMkUGiy1leZk81HoT9zjpU3XLlHdcmXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1hucsuMNIdi795qT8Px5fmweSD0B2JlQVcduEDtijWo=; b=FU3lXL+5tGG1ol7a+nHWbga7I5RRN6F7rzx3DVQLvVJ06+4rjdJgBBel9pO9IzkWY/WwkVKEtkW+IO+9AqyGuOfeLHC1OZl6icuGbeIWUzxNAHtV2o13CVTGnT8+XRSYIfawDVEcuLHsEn+5P1uoMya96oOUk7KYjnSGjxI3VJSCXo0srjh18Co4gczLC4HB2YK/bkuh6+pid/qCNCqvGjYlkLfE6nqhC3GBgbbbYjPzkB0/tKIe9dUSqhwNza1v+4hDISlmU2ux9glIN13DhzYTWzyG1LMo7DMBaBeLJZSzA/hLk/VirF0tBkQ0YSnA51r6gQUVlVWRz8VGjJ+eCA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by PH0PR11MB5596.namprd11.prod.outlook.com (2603:10b6:510:eb::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.44; Tue, 13 Jun 2023 09:23:32 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::b8f3:958:d2c5:2232]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::b8f3:958:d2c5:2232%3]) with mapi id 15.20.6455.030; Tue, 13 Jun 2023 09:23:32 +0000 Date: Tue, 13 Jun 2023 10:23:26 +0100 From: Bruce Richardson To: David Marchand CC: , Subject: Re: [PATCH 3/4] devtools: build all examples externally Message-ID: References: <20230613081741.4083273-1-david.marchand@redhat.com> <20230613081741.4083273-4-david.marchand@redhat.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20230613081741.4083273-4-david.marchand@redhat.com> X-ClientProxiedBy: LO4P123CA0046.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:152::15) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|PH0PR11MB5596:EE_ X-MS-Office365-Filtering-Correlation-Id: 1660c987-109b-4c4f-aade-08db6befdb3d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 4TideCQ8xcEai8daJb7vqgbrAyUH2JHDJqV/jrQZJJNqAi8f4RTU30SSI8vXHlrc1wYnM3cy/IEVB9d9ose2+azM6Mk76U+7V+Tz51qYmhidsm7PJ7dDMNt4aL6SHol3aLiHFCy39Mw84TdV2kM9qXnPxKLrmV4vrEwF+J6V/3i3+DLqmqRFZH8zAA0Mml9UQhvs3JjRRG6tMUOs/w6oSRQzmhYTsQgPQ3VEqPTe9Kl6xQ0hBCaCTF8DsSI1hEzx9gHIr9VLQ27wZOK/aJKwdo16f0SxO4V3ZYW2D/xjP3XEhAWJFQCqKrOuW0Idd7Ra3/ebwKhzgZ4lTstK793RUo3l+o7sfcl+Rysav4I3W/vDroB+dCOA38fnZgJvMxG9EXgNueaH4YPrwAep83XXsOElYJ5uKvho+NEc0k9AmuxWhVhqa5vhKliDJNnxmSOO9s8sogJ24T0Ag4Zlt7Cq1CsKlXdtwmO1Ryuq2kVhXddgEG+/qbmQ3QaHR0Hqw9Z6s9jWwx9V4OXKas7SirNUzvo4EIv3C6ideYYD3e7hcjx0oPwb1mz3T6C/ruxf4Tzt X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(136003)(39860400002)(366004)(396003)(376002)(346002)(451199021)(6666004)(6486002)(478600001)(6512007)(6506007)(186003)(38100700002)(86362001)(26005)(82960400001)(4326008)(6916009)(66556008)(66476007)(66946007)(316002)(8676002)(8936002)(44832011)(5660300002)(41300700001)(2906002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?GzyIB/1iFE6HfF7M9JthmiRRO2xerCrCrzny/5O1Bh+fcAGJHyMl27384lx2?= =?us-ascii?Q?Nh5rBlw8jRlQ9pOOfgg08O/d2wacmMu9ZjUV+Q+q3q6agtSWqeTiIKyRaK3K?= =?us-ascii?Q?Wdwi2L6tPXdFXQbr408knrnYQRJYblEavuAAlZ+kRaN8a8Du90VqFsfHHvyC?= =?us-ascii?Q?42OEvPZOiupSJwB1azMsFstcqgjeuIrcKmUMktG8Uy/MQWnLXivyJEp4FbTv?= =?us-ascii?Q?v2PBqN1HBHVcRnY1eRVCvVDJ+4VnqG1k2MFn2zz5wArPNvLZY42Y7SoMGBQu?= =?us-ascii?Q?ruBE46PUEVqpSB9rbQajCkGEgK4Y4scnNwZWuxko/16XYfAT9MSHNWTJ7vF9?= =?us-ascii?Q?ZGIv6hgEKFUAi2y3iaMWXL0I+Rywlq6c4D1NEFMXpyrXhV3LeQN4FQUXhKL9?= =?us-ascii?Q?VNd/8HfNKtMZeswzK9jKXpd24CYLAaa27GziUAOgpjcLXAXW3GFAFzDpMxY6?= =?us-ascii?Q?Jwaqh06JCDMZgTk6XmYnT/QMjOcofLkQorzZm0nzWXbqw5Lygr16DibbSzi/?= =?us-ascii?Q?5HTNcwu4yq3t2k+3ePJe6rDhLU5ABhYfEZfRsabWm3dULHEwkQrUh28dPhxa?= =?us-ascii?Q?kjHeHq6fEAerPtnjmB/OAah4xL40SCrFRFDFkHE5iobrXHSiLZyTMrIsGGV+?= =?us-ascii?Q?x9Pm0lq0gTf6NEGln2LHdWcQ34Q0bWXbdVe1ojUZF6GWrHdnx7Kb16bx6Ggj?= =?us-ascii?Q?hp2Ng2fuzl7SKF9Y4ucwDTzIrfuohgdm1UHZB5CzcBfCn4Q06LN+riyisln4?= =?us-ascii?Q?Y1KY+NCCpFXZlShGkENwA6/YH98w77kAmFqmc7s9ExMBQgEIteTDxweZ/wmA?= =?us-ascii?Q?64avNEumeuVZXghPC+jCF0plYI834RWK7N6a65OLhdcZrmUOMTGEfIuY6uzQ?= =?us-ascii?Q?06aZ+XR5H3zHcLqU1J7dvyGzKLrA4ygVeNXxPHr0wEIBC9ZKYpg+uuXm0FHa?= =?us-ascii?Q?IFpBDf0hVdyDlljlC3f/+KFIIITm1XiFL1PpNTzHnaWCc85jYtZ5zbMIdn8V?= =?us-ascii?Q?VM5O5VOj0r7ziHBy1q4TLHoXPeguzHOSCZpo//Kkp88Uo+NWWa4uPTWUARJe?= =?us-ascii?Q?xNSe9u1oV15wU2aR42ev+lLU1isNd23NYypjeCyVQEFHODsXFRd66kXhOcRH?= =?us-ascii?Q?L8c+pVmUc3AJ3v65EALtHjdTjqfMXLKXUcUOl8aIteHlwNxhw9AOhZRZk9al?= =?us-ascii?Q?lxxLXodTu/0GjTNlCx56CK1UHAdcouOCKKl/BrFeQRGwo3KshlcZZMG97uZy?= =?us-ascii?Q?2mr6lpMlh0McFoOoGLf+ddqur3ch3o48xm+5cCqmMKrQFfzxTkFvqBSVmkU1?= =?us-ascii?Q?e5Kz3o6DV/ilgUygNZNbpj9+EbZr649Ylb0ajTKuoefm3LBc79m94yogh+8L?= =?us-ascii?Q?yk/83iAvfd7Z1TlXypmTVrZ/5CXFQ1BfB8IrXvjONhSafR467l6BCdqy9WxI?= =?us-ascii?Q?mqr0JE1pL29MEE1nBg4CANlPRVRDk2OnZyP804Z2qUhjJ58SbDlZI1dLaudT?= =?us-ascii?Q?pzcP55FO2NGvYTmSui/mjMATKGLLTc6pzOtouozb7lY11yTXbyKijlgec3Z0?= =?us-ascii?Q?40Tjm4yMnssb2dawAlnxKOX12Uvh8923Cg+YuxGXK0O18kmueqxfM6YlempT?= =?us-ascii?Q?Rw=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 1660c987-109b-4c4f-aade-08db6befdb3d X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jun 2023 09:23:32.4840 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ges8N6R5fFY5g2zVtNJ1GQSr5iSTBGH35sF+olqhGzmOzEyqbeCoLgbbe34tHauac4DZUydol0+e52ybTtoqu18pk7xUk8wrCb0O3PK4xcc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5596 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Jun 13, 2023 at 10:17:40AM +0200, David Marchand wrote: > So far, users of test-meson-builds.sh had to define their own set of > examples to build externally. This is not that great because users need > to maintain this list when examples are removed/added. > > Rework the script so that the 'all' value triggers an automatic > discovery based on what was configured/compiled with meson/ninja. > > Signed-off-by: David Marchand > --- > devtools/test-meson-builds.sh | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/devtools/test-meson-builds.sh b/devtools/test-meson-builds.sh > index 9131088c9d..cab3373544 100755 > --- a/devtools/test-meson-builds.sh > +++ b/devtools/test-meson-builds.sh > @@ -299,6 +299,20 @@ export PKG_CONFIG_PATH=$(dirname $pc_file):$PKG_CONFIG_PATH > libdir=$(dirname $(find $DESTDIR -name librte_eal.so)) > export LD_LIBRARY_PATH=$libdir:$LD_LIBRARY_PATH > examples=${DPDK_BUILD_TEST_EXAMPLES:-"cmdline helloworld l2fwd l3fwd skeleton timer"} > +if [ "$examples" = 'all' ]; then > + examples=$(ninja -C $build_path -t targets all | grep 'examples/.*:.*c_LINKER' | > + while read target; do > + target=${target%%:*} > + target=${target#examples/dpdk-} > + if [ -e $srcdir/examples/$target/Makefile ]; then > + echo $target > + continue > + fi > + find $srcdir/examples -name Makefile | > + sed -ne "s,$srcdir/examples/\([^/]*\)\(/.*\|\)/$target/Makefile,\1,p" Scripts can be rather cryptic at times. I assume this sed statement is for handling examples which have subdirectories/are in subdirs. A comment explaining this logic would be good. > + done | sort -u | > + tr '\n' ' ') > +fi > # if pkg-config defines the necessary flags, test building some examples > if pkg-config --define-prefix libdpdk >/dev/null 2>&1; then > export PKGCONF="pkg-config --define-prefix" > -- > 2.40.1 >