From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6D67742CA9; Tue, 13 Jun 2023 15:56:09 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2D1BA40ED6; Tue, 13 Jun 2023 15:56:08 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id 7C40640A8A for ; Tue, 13 Jun 2023 15:56:06 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1686664566; x=1718200566; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=wm4e6JK6Zc7l3Rm72XqAtrD55K4pHwpBLG1/mgZwa3Q=; b=H8rAEP/S46L5BWXRNxur8sh9EqFBVFpIgbpe1bomI8zgHJq+ybzF0rHT 4rq5UW+qpVnJ2+7ohhRjWgm2VoO+9UKkGUTD8jUR9a9oGhidFfJgXnBEq klO5LqRtjxht0VJavUvGkRkz3zQxMif9tCFdkfe7Pwut01N+H2wepzjaO rv/6kktQE20JyM1vL0w4OFGWs9sr8JF3lR/67kcIo5+o2P33QqoKwz0Kf /qes/jaZ8QXZzCw+py1VeaBSeVHPl6GA5SMdQAOd3guH85eHy2Zj3WWf4 jrGZRg/nb5S5JtjO5AMuz/cdiFRlz58SR+nj0gz5Kk+pD7shYl+ysNNdb A==; X-IronPort-AV: E=McAfee;i="6600,9927,10740"; a="358334982" X-IronPort-AV: E=Sophos;i="6.00,239,1681196400"; d="scan'208";a="358334982" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jun 2023 06:56:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10740"; a="856095893" X-IronPort-AV: E=Sophos;i="6.00,239,1681196400"; d="scan'208";a="856095893" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga001.fm.intel.com with ESMTP; 13 Jun 2023 06:56:05 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Tue, 13 Jun 2023 06:56:04 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Tue, 13 Jun 2023 06:56:04 -0700 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (104.47.73.47) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Tue, 13 Jun 2023 06:56:04 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fDfAWTlboBu1Zyv7UM5kkx1ZiWhEHgXgxM2gfpNMuzfhXOpd+Yc84gq6E6ynWGGd/Drhab+QVV7XZ0I41YdAfKn/Q+fa8Z7IIAMNIHzKPyvz1Ze/uvv7q8JeiEVI1y85OSSogwBxNlZ+TUvx32Lb7Z2aRKsM5Owjxo/AbU+1QlfMATKM2SuITR2pXpo25XWrnjrESQIxeI4e6LrFmhHDVoY6RJTQ8J3W7sxLt3P3dQ14u0wEkSKzN8SNCQu2ueh8bBOCVahAEqOy+aEjAFh3MMx8k0WKPyUaxPUtGOekjJxXnDZbLhZMYjfm66H3YU9lvGitc0YlLsS3/K7LdhzgKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=x9K9oEdpNpj0/JKs68H6bvBt1zCgj4bCtJGhkOZmae4=; b=lKY8afsouk6DfyFG8abbOPhp6JNOBrK4VJXUSSm6hATKPRhS/onCWA2zZH8rWwg57ITIIIeUA/u6WVSMil79QHx5GEBgnrrQY0Xz6OkfLdOZB5YBMKhmdYHGM4C3qzpDFDna01S2QllqG9Xn0mCViw/pBpeaujMw1uxW22MhPrAlmlhM71s1WC7ahLd+VFsJotPK8+EybJU3cYuYdJ2LDpA0gJA5xlZM3kuDMElDgMgn96v7QnGWBqXcEEGMQqBmpvytaBJcMmvhx7Euda3mengTKhelyeauShLjgaJxyKhVgS7BApU7ND0tC5kXPHCktu5KWUA6acBETR8459h3qw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by CH3PR11MB8413.namprd11.prod.outlook.com (2603:10b6:610:170::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.46; Tue, 13 Jun 2023 13:56:03 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::b8f3:958:d2c5:2232]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::b8f3:958:d2c5:2232%3]) with mapi id 15.20.6455.030; Tue, 13 Jun 2023 13:56:03 +0000 Date: Tue, 13 Jun 2023 14:55:57 +0100 From: Bruce Richardson To: David Marchand CC: Subject: Re: [PATCH v2 1/2] build: change flag variable type to boolean Message-ID: References: <20230612162104.170749-1-bruce.richardson@intel.com> <20230612171456.173378-1-bruce.richardson@intel.com> Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: LO2P265CA0045.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:61::33) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|CH3PR11MB8413:EE_ X-MS-Office365-Filtering-Correlation-Id: b2ada2cf-6606-46b0-cbde-08db6c15ecd4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: fbyuR5JKRaKykUkBZO7N9OTmqtZxors6UKUOl5C2bUEEBN2HGGYPNEHLiVVEOTSjSeNDhwbGk7kL/sPHpRu6gD5aitYbWeutvHBWEf10TrBOrMv096KheXkq3evLnR6HG5BznPORfTqXHZjo46e2ZCaw8Ue2DK7nqBUJUchDQqKnQ5pGKFDlgeY8Mg864m/Z981aCIywbYdqrxGqiLGEAmPwv9q9Y3P8eH9VJra/SacLNZNOE0oPh6GX8UvMVUO6j50er2BFpJdX6caVlLc3jwjUgeK23zXcCEOfPfydxcrWb4mc85clMlU0RRDx82f/QG+6I/GUSh0D06FvorPJ7pO0J6wTQukFgh2DR4BCO3jPyx0BIi5xuDGydQ+jV3r9r8z/ZwLM0EiqfOWgTOeXGl1wXpgy8N/A+IFnneBlmendlxNsGxFIy1kRVm+7r4CNggnh0G9BoraADSot8RInmhAuCAfMLW0Ug8NrO8i2TTjM0mNBfSVqoo9OknmrCIKebIDBPBXOgmG0jTncg3sqbF0WjHR3zrwiGO3+2phxExlYb55TB1PzFaUYIBQDLY2a X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(376002)(366004)(346002)(136003)(39860400002)(396003)(451199021)(5660300002)(66946007)(66556008)(6916009)(4326008)(8936002)(8676002)(44832011)(41300700001)(316002)(66476007)(186003)(2906002)(478600001)(6666004)(6486002)(6512007)(26005)(6506007)(53546011)(83380400001)(82960400001)(86362001)(38100700002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L1BPcTdIZE41SzFadFc5cXBSRUpkS2dzc29DQzlWeEpBTkN0dTc3YTNNQWxa?= =?utf-8?B?ZE91VU1uSVhlV2U5V0ZrdmYzbjBwQmh3QkxTbVUyNC96cXd0RFkxYzFOTTI1?= =?utf-8?B?SXBGSzA3d3VhMS8rWllzL294T0NEWlhuSlZSa3FPWnNnSDR3YVRHWjBnaGJQ?= =?utf-8?B?MGJGa3VXZzMydXRtbGZwem5BZHo1U25PSWZlSGhuM000MmNNNk56bWhueWJr?= =?utf-8?B?WDFiSUFSbEpOaXZZVTBFNU5qZEhsekZUMk9XSDM5S2cxTFNTT25MbmFPMSsz?= =?utf-8?B?eWVyNTIzYytHSStOZlhFZ0x4azJVT1VUZnNDd0R3bXpKdGhSYW9hK2dBY3BH?= =?utf-8?B?bCtiaWNzbDgyWjEvUUtMWkxwOTNpYjdtQUdSMHU0aDJiVkljenA4anVZK1Jk?= =?utf-8?B?Tk56d3dENUVBU0lmOEJuRERsc1N2M3ZKSUh0ZVN1emJYRXl1V3FuZlYvSUxF?= =?utf-8?B?T2c5Ui8rbDAzd1V4UnE5NVpkYmFlZ0pmZTRxUTZ2T01iVG9rM2kxOGNrTUtt?= =?utf-8?B?Y2llKy9aWjBOUzdzalRUYjRLT2s0K2hqRzJBR1RkVUQ2QkR6RzlPOVFXWXpM?= =?utf-8?B?b0JGSzVzdWFoZjlGUHFwVlhGQm5NSStFOUZpdGNZeThEck5wQ0E1ams1dUw5?= =?utf-8?B?SHhrdWZTMmNOSE10QStQZmpuMGVsTnRURXdCYnM4VHFaZ2hlR2pnVytDUTNL?= =?utf-8?B?UFRUcGowQkx2dUgrQkcrb3FoNmhuZmxnUFNmR1NYeGNyeTFJeFFRa2RGcDVS?= =?utf-8?B?NzVXaEhUa1lUWURQUnA1UzYyRDNDS0N2R2loNTJHUmNpRkhINnc2K1JzUGdv?= =?utf-8?B?Ky9kNVUwNnZxVnlHNkQ4cEtKbkFhcHlvR0pmRVpMS28rT2lGZSt2TC82TGRz?= =?utf-8?B?ZGU1eFlJbWl2ZTQ0Si9UTWZ0NmtKUi9DN0EyRFlKa1FWUEgrOXJURmc2OE9p?= =?utf-8?B?ek1SbzNCR3VFZjZoSE5uVkkwRmlub2src0hUNjFVaHRzdmQ2cFZjYURHaFN2?= =?utf-8?B?ZHBuN29yS1NQWUc4UHNmMzJjd3JaUzlCaVJ6clI1N0pTRWZ3bUxXTzdjTW04?= =?utf-8?B?dnNKM0dHRHhZd2dlVXlNTHZRc1lEQ01KSGJnc0RoZkJSRVovVzVTN2RwS3Ir?= =?utf-8?B?cGsxOG5xOGRYYTVjT09PaTRleDZvZjJIUFV1MytVcFRSM2xVU3Z4YkQwL3J1?= =?utf-8?B?Wi9DcFVHdmtuZkkvZ0hBa2NFbWRuc2FFVkZvL1Zpc3JyR2N5MVE2Tkt5d3NX?= =?utf-8?B?c095SDI4QklOeHVrR0xSZ3dUbmorS2tuem1ZT1hEd1lqc3hVVFVOTmhjRzdT?= =?utf-8?B?NDVyd2RPL01ZQzRaT0o3NDNHQkhFeEhwVWwyQlRsajNNeWdEd1kybHg4RFJY?= =?utf-8?B?d1c1azdxYlZGOVBFdmQ4KzJVTUFtV08wWjRMSmpMdGdDUXVqNXhNM3pRQkdW?= =?utf-8?B?b0swNUNQdmZEdTBsWE9TVE96bWw0V0Yvb3AwRXlReDdXTXFtT3NhUmxpWC9B?= =?utf-8?B?NXZWaCtDTThLclpsRVBRSFN2aytSVVJML3BON0lZU1pPRUNBYnFMbGZrSVlj?= =?utf-8?B?Y0EvV2drYlBUTjhJVUdhbWhVRVR0dWRkVy9qbldwT3VGa0h2aTdNTmlkcDI4?= =?utf-8?B?QW5CSm5vTDNscTdmRGpmOTNCU0k5aFliRjU2dnVqczYzNmdlSXY1KzR3NkFU?= =?utf-8?B?UWcrQzN6eCtZRE5NVFJZZ0lxUE5IRUl0S1QzUDFNcmp5LzNIMXYwMXhBYlN1?= =?utf-8?B?STdNVW9KT2RXZVYvb2VpTGcyYXpNRTl5SSs4cm5VRndkemxLVzh0WEdwRGtq?= =?utf-8?B?dnhVRHBmUTExdzUwdmk5dmY3amQzNzQxMGpYVk0ybDk3S2o4a1M5REMrWXg4?= =?utf-8?B?Z3dNUTcwY0xvWWx3amRHMENzU091VkU4ZDFuczh3ckNVTUF4NkR5eHUvU0s3?= =?utf-8?B?aVpmS2V1aW9sM0lPNnBkdkJPc0NLSXZwcUpXVHFiVnlLU3F4WkRpL2VBdUtO?= =?utf-8?B?cThDcHJrZlN0eEt4bmpMb3p6eDVsZC9LbVlYcFE2QWdnSHhkSXVXL3I4cnZ0?= =?utf-8?B?NWpHYVVQN3hIQUFxWlNNaG00akdldlJJcmE2RVNQc1BhYVhBMXhYWjhVLzFQ?= =?utf-8?B?c2FWWko5V3dHRklzR2dWOS9hTXdKc0JuY2NtaWt1OWx0MmtSSTVzT1hrY2hR?= =?utf-8?B?NkE9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: b2ada2cf-6606-46b0-cbde-08db6c15ecd4 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jun 2023 13:56:02.9146 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 12TCqoOf4m7ANAjqt+Un2hCSbDHb6Up6Usc4UQN99bqUv8UvIAefWRNvOdfc9HrZVyWrpy2BoYbRype/Vnver7kBwDo7MKvI94zUaauDgGQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB8413 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Jun 13, 2023 at 03:43:34PM +0200, David Marchand wrote: > On Mon, Jun 12, 2023 at 7:15 PM Bruce Richardson > wrote: > > > > The has_libnuma flag was using 0 and 1 integer values, instead of the > > more appropriate boolean type. Change to use true/false instead. > > > > Signed-off-by: Bruce Richardson > > This patch lgtm (with or without the suggestion on config/arm below). > Reviewed-by: David Marchand > > [snip] > > > diff --git a/config/arm/meson.build b/config/arm/meson.build > > index 43f6a551a2..faba5e38cf 100644 > > --- a/config/arm/meson.build > > +++ b/config/arm/meson.build > > @@ -592,7 +592,7 @@ if update_flags > > part_number = soc_config['part_number'] > > soc_flags = soc_config.get('flags', []) > > if not soc_config.get('numa', true) > > - has_libnuma = 0 > > + has_libnuma = false > > endif > > Maybe has_libnuma = soc_config.get('numa', true) ? > > > > > > disable_drivers += ',' + soc_config.get('disable_drivers', '') > > > > The same cleanup could be done to has_libfdt. > Additionnally, I wonder if we could remove those "== true" or "== > false" checks here and there in meson.build files. > I will take a look, and I think I'll also split this patch off from the patch 2, to add an error for libnuma, since the two aren't really linked, and this patch should probably be the simpler merge. I'll see about doing a set for just int to boolean cleanups if I get the chance. /Bruce