From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9246142CB3; Wed, 14 Jun 2023 16:46:24 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 71E4740E0F; Wed, 14 Jun 2023 16:46:24 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id 0F06040DDB for ; Wed, 14 Jun 2023 16:46:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1686753983; x=1718289983; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=gqGBjnV4/KA5wpJ5Gkdjq0+mwgg/Z0aTgX2cZSIzGa0=; b=mivb4+RnGToNaFELjERTmGOk7XrN0j7zh55jDcGMJOk9bCEB+MYnT93f tPU+HxvoBGjfPgsJyktIjPnPi1LZJKs9pLSe4srgGlUl2oZzyOc7ZJHOs W2hJZcj2UOB+fq6nsFIFoAgJYYNtd0j6T23RbUWmk4GUYcuLfXLtek8Bj WF174sULhcv65jcS+8BMyU2E64SjojG0wb/I5NGcOOKN+PPvdzYH/jpVB ZSg2Rkd1dWsDPxye87QNg6IgEI3f7eelmdu3amfTQEutZU8raKVr9S1Lu 75N6rfKANKYoF1H8s4HW18qnfoMXizSBiBM8jurW8qFH2tV15cXl4s04g g==; X-IronPort-AV: E=McAfee;i="6600,9927,10741"; a="343329198" X-IronPort-AV: E=Sophos;i="6.00,242,1681196400"; d="scan'208";a="343329198" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jun 2023 07:46:11 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10741"; a="715246155" X-IronPort-AV: E=Sophos;i="6.00,242,1681196400"; d="scan'208";a="715246155" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga007.fm.intel.com with ESMTP; 14 Jun 2023 07:46:11 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Wed, 14 Jun 2023 07:46:11 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Wed, 14 Jun 2023 07:46:11 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.168) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Wed, 14 Jun 2023 07:46:10 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BCcitY2eXJcjXWpC857aoMqds2hQjEPiicIiHS+m5Y0d3YXlb6qy7Zpnb+2aYW3w64QjkCZjwNt0JckfjTTNrtYM3HL6lZUm7+WnTieyaGq7OtA5YGLax5f53kxoVUBjjICNMuFVBYys84WzyPKl3JSsUkuyLX/vqiHNEeOUyPTd44hsKNocL+vxzfGJGBK+oZ/szYupqfB6BerMAWgRTUDeryNCV/S3B5Rvrfo1xypgTst570vwyXipeuSEiPflCQ8e8c6Eokly7qbwKqiRA5te2ZfVcpauiTg4nYY/F+eLTNNDRtFjH/LFrt0t+ukq62+BYSI9ZOhKr3K1/sZLTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PIcFLXFPD4pEzu8DtTYAA6QZUwe5uDO3G5f76tt4CH4=; b=Y7fBufUvgit+3BC60lExDe6ywoelyrFpQw1W1zbY2QiYNH+Z6EMshw4S3NcMvRrB69aLSOoVKvr9+39iVsB9ILf5ntPwieunSdGItpqrlvVQqVu3SUPXJ+SWisydIoG2lwjpIg06UzSJ8KCEqtMbmNDXm5AV/l5csLrVzPV2QtJ5ad8+gwpFaEFiu4jsDnWNMMM5WFXueee7IoS4PIYC15oCUivYnbXSQn7wXOJzIM3IoXIbdI4AEQ7TUCUW/eyDp0Q+5fmNd1iylCSluDN3U+oXvxGXS6foDV91HUAaGuBHOD5OqWaKrcj5NWR1avJI/SHvNd504IBYmjKOssCDaQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by MW4PR11MB7102.namprd11.prod.outlook.com (2603:10b6:303:22b::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6477.37; Wed, 14 Jun 2023 14:46:09 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::b8f3:958:d2c5:2232]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::b8f3:958:d2c5:2232%3]) with mapi id 15.20.6477.037; Wed, 14 Jun 2023 14:46:09 +0000 Date: Wed, 14 Jun 2023 15:46:03 +0100 From: Bruce Richardson To: Thomas Monjalon CC: Subject: Re: [PATCH 0/5] cleanup in library header files Message-ID: References: <20230614142651.1456116-1-thomas@monjalon.net> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20230614142651.1456116-1-thomas@monjalon.net> X-ClientProxiedBy: LO4P302CA0014.GBRP302.PROD.OUTLOOK.COM (2603:10a6:600:2c2::15) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|MW4PR11MB7102:EE_ X-MS-Office365-Filtering-Correlation-Id: 7647edd0-14c0-4b74-52f2-08db6ce6172e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1u5JbUxsvOsbWgU0dpk5LnLeAgzbFl3yW7JsAok9OOdxRMTIK6euKQwBPVazBN11+l8OQGCxHeKzxW5YpFNCYoahe3XY00gA31bjlnkGq6MFvDkmSFzVA1KS0ZByU2YYd2SFVEeyMJnARNyn48HCvQf/J2K9HI94pqnDdFU1/Py5zS4/YGF5FO8PfazDv5Vr43JVPcJ8yoKtkJ//zF/9XGb+mcrJmkpxZ5c/fi4NQWc4LDHmxrhqHJAs+E4QK6II3qBr20RQn8gboENXSKrtVVre0SfzY9fOM0aEyOM0j4klRkrLeT6zPgbBUMlDAxZRXah8sSKMf0EJgrAr7XM0RaItXisF4GZd5gFeQWKV2NRaRHMBMz7vGcTQYewuWpz3kYycti1FFSMfoGve/ZlPPA+3merIj0/fz/ZNQlu1ou39khA6V5U8P3BvVrrPpejaLCHEtTUvjAqRKPj9aGrzuYDeMLKm4ILLVr+okQtXeYG6PjPDVTVvjKcATMFEqjD85mXzc3plK+SGHEExraL38tIRvYqmU8G1gtYFT+0VHDgYAGCP3w/gN/yP7Ye5Y18X X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(136003)(39860400002)(396003)(366004)(346002)(376002)(451199021)(8676002)(8936002)(5660300002)(316002)(6916009)(66476007)(66556008)(66946007)(4326008)(41300700001)(186003)(38100700002)(82960400001)(26005)(6506007)(6512007)(86362001)(44832011)(2906002)(4744005)(83380400001)(6486002)(478600001)(6666004); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?DDI0aIzX+NkGE4idJy+rpNOc8AJwfFZ9c+rRasSPOz8wt+lgXT+ihWMggGA9?= =?us-ascii?Q?Y6Dmtg7mbD42gTXV3k2VZ9AWCX8iKCdjrcePRCEQVNGET76UWNmidEAPMRhx?= =?us-ascii?Q?LRL35BXiMmwzAAqhQJtuBeVK7Yn8zY8JIBL8w/oBYAEo1LoRd0AdHRxXVQo1?= =?us-ascii?Q?mAWRoRZDbHMPcqoKRKlcttHdQBVXQhu667crR2fowWF4E9mh6QDtwpXZYADh?= =?us-ascii?Q?5QEv63FbLBi7a85wdZniu4ZI5/B6NOukRxWFmbcin1e0O61GtWKplXhj9+aD?= =?us-ascii?Q?ZHxHuedc0MoCHuUdQC1kEDUHQ8zXz3OkhUwzhFYa9R99o3IVr4uC368tY3KZ?= =?us-ascii?Q?wN+2Mats9Mybt/pNOMQLkKgBQ8dpfTzVPkgoxXgqcZ+uV6xVW2bh0M9NXZZZ?= =?us-ascii?Q?jyg7UnXFTsKPKXQ39xhZcPKIZmkMj68GtjP2pv71ChEVHzs4ACHwHbyx4RBa?= =?us-ascii?Q?W785zqe1DdokIALKIMJ6i8w5Qc/WIymFCBWNDnytybgnfEn8zI0Ry9yvIc//?= =?us-ascii?Q?yKJcH+YoPEq6N7Qhxz7jgH7DXO/eSEPkcThJakLEgF5cNLEP2uFrFH673lxw?= =?us-ascii?Q?VhtQXjeRNKe5qTVkoVCuCtA9PGGNfFmjqLfiwyqK8NutqNgNuBxiCH0N2TZ3?= =?us-ascii?Q?PB544+i5NV00kKJGQhNQ5S8SWm8wLMgTUszQ0FKhmmi1u9ZmD5M5+neq/IHj?= =?us-ascii?Q?iTLVHPi60ZwrOc7nyfFgy1a2g7jkCb/b7m4WbsLKHJkQpqLtUo2cL7D8+CmE?= =?us-ascii?Q?VFsAcvZEztt9qWuOlKL91Hu4x97aCFed/k5fzLm7JHSiFrg6iZSXa1Se0WVB?= =?us-ascii?Q?sw0nJEk+kqFJsbeJXaJYJS1TEyVfzN2EaiiK7exXGYIFeIFd4MuHzCY1VENc?= =?us-ascii?Q?Ej8mOg8h19JvbEKt+miCaPTaxuOa9LRiB3ZccgauioFE8QnJT9vzwlrP8RYS?= =?us-ascii?Q?h02LnwkOMgkrGW7bhF+r47pfYakj5Es3QlNmznY7AdboSAaQHhLLjqN7dPlN?= =?us-ascii?Q?oEN/ZuIuHsVyTEiUdroBKazzf73KIDDdyCCY4zL3bG6FTTQxLUpskIflmzhz?= =?us-ascii?Q?2gVOrU/RCOHuO27ad+3iY8MgB+uKnHbbNPZB4V/dh5xs86GsqY0dJZiy0xLK?= =?us-ascii?Q?5ncFv9GRkVTHyf/eWnZUfSHx27zLHIo4XpoooDsWRTDXuD1gR3tOIGwuE1Mw?= =?us-ascii?Q?yj6tjM9UPlyqG0ePfYmLsPhSQbjt/VBDmf5RIi6Zt4Y8EUS688pakSeUWy5b?= =?us-ascii?Q?xE1BAJSCH1kClnW8GVn9coOVSKD19cRmgMw4jtqKseroCRoArnDbmcd52ctb?= =?us-ascii?Q?BgoJI0h99Zoofk3ak40VpfH+mJEtyNSqxZld9EJGWd79nr6jFV5GsTK8WCDk?= =?us-ascii?Q?qZKu0Mx463zLAaCcDsJuOZRjk5ZlL5zmVurDFKpu8UZvttxTerupf1rT0JXI?= =?us-ascii?Q?YRAcxoIdbHq6VKKaLzhwnPp+qBHj6YYmkw0Ai7uzDewOPINRiUzbO6a27bhl?= =?us-ascii?Q?SRvliiJoIYdfdu0Q+/jTVTqaDNJsLMoq1+J8J/uqNgHLNaA+OLq8Hu/l0sYO?= =?us-ascii?Q?7GdIKgWGTYLqbxZdyCfggjtojP8L0K7bR3rbwNRxEgFltbcE8owaBmPlLTAh?= =?us-ascii?Q?2g=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 7647edd0-14c0-4b74-52f2-08db6ce6172e X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jun 2023 14:46:09.1313 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: YumaCXsVRHdtVhFFln032hsHBZPuetfxqf6qyF/hPR+TLIPNlmHnZGItMhxOzGaa6o5TWdcoq2X+a+Ml6sx+Y4zRZ1TX6NcU9Cd7V3f14/0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR11MB7102 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Jun 14, 2023 at 04:26:46PM +0200, Thomas Monjalon wrote: > While pulling some trees for DPDK 23.07-rc1, > I've seen that some wrong coding style for comments > were copied over and over. > > In order to avoid copying wrong comment style, > the three first patches are fixing a lot of comments. > As it is not critical, they are not marked for backport. > > While looking the header files, I've fixed some misuses of "extern". > > > Thomas Monjalon (5): > lib: remove blank line ending comment blocks > lib: remove extra asterisks ending comment blocks > lib: align comment blocks > lib: restrict use of keyword extern > cryptodev: fix comments of modular operation parameters > Some really good cleanup here, thanks. Not sure we need to fix the use of extern for functions, but removing the extern is harmless so ok for it. Series-acked-by: Bruce Richardson