From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 82A6742CC4; Thu, 15 Jun 2023 10:46:45 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 73B2540DDA; Thu, 15 Jun 2023 10:46:45 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id B9AE240A84 for ; Thu, 15 Jun 2023 10:46:43 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1686818803; x=1718354803; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=z1R70kRc7fZU6GxDttNgS49vqUYTwft+R12eVLIW4xw=; b=SOAe6+Ec9hwKqYtJDuE+1egzLd+1YrLFqc8dM4cBJvkzd4l/72Rs19UL sVTpMKzGaCpJglKs0QsONEMw4fvmkCyDg/WcdIJSCecMjnTErIAw2LtT/ /LMlanTzklONxkPcdw0Iw/CNYikuPlaH7hYgtKK4YebAI8OEcULDvSZ+y aLAAFkm0vtek0/SfPNDbxEsPvJn6vc9Zjc6RCL8o20kAstE8fosH4qw/J IPY+Uw8yEUc3ndbDKtBA2qEV9mBKSZC9QocITS11H9ue7ZiUcXy2L998u TbFFclSdEVL4a7xU5yxuO0zp8BfYfwReuNE2heAHi3PLWgxJDkgJAjFX3 g==; X-IronPort-AV: E=McAfee;i="6600,9927,10741"; a="338479719" X-IronPort-AV: E=Sophos;i="6.00,244,1681196400"; d="scan'208";a="338479719" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Jun 2023 01:46:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10741"; a="706578682" X-IronPort-AV: E=Sophos;i="6.00,244,1681196400"; d="scan'208";a="706578682" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga007.jf.intel.com with ESMTP; 15 Jun 2023 01:45:04 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Thu, 15 Jun 2023 01:45:03 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Thu, 15 Jun 2023 01:45:03 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Thu, 15 Jun 2023 01:45:03 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.48) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Thu, 15 Jun 2023 01:45:02 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=A53CC2oaIury6YhA508Agdtd+T02mcQLv9+9i4w1enR196my00gL5Gx0pxVmFIsfwCGke6+Wl40/EGmFiPsfA/Lqx8CL459WWDec4RRBbOaOZ4MpNismC/HNdXYXNUCKtW600tTCOluebtBI0n5ATANWNbw9IFEahqokVKE+dnRl85bRUxfXUwG9jXoppUU1RfY9I2lUkyw85FVaZ3Y7VJBnQVbM7rGZpBd3IvuOOKEF49zLFs3D7MArKpJ+5rAWvVyZAwT09JdIb6Hpc0PUNg/7DaQuLKwm5yIAqlV8QHaM0iMYQTsYKe7c3p58sRCqIudVhzw5TSBdRQJU8vNRtQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KwbocKnC0O6D/YMTvxd3PpYfkLs/2+up2VDGNkZsjTc=; b=LXykq8oirSfsV5FNhlr0PV0lMTkHgewiBaQUux/4Jf8snrNGeCHwa9cFYad4tn7xe0SxZYLR6u5LCWOR0zste03zcp05OuvCQcHBpxJEcQhyEN8uLBZIddLABqkAvLsmO3qyETbylumuJHMmBcL8simG4IdU/GgY4rxTsLq4L05rZXrSVyRThXon2gdxF6dxO0nfInfH77AUjIxEodpXfBhlThBwf1XcV62OKi9e/k4haczRZxc26f6nx7CP/j67aLQs0ixIitUWH+iw0LNDhiIkgpDXlwwxGhlvakLIOprctCDztScInWwhUEq+UkewA7oDVOU/rDUZFcagvb9Skg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by PH8PR11MB7120.namprd11.prod.outlook.com (2603:10b6:510:214::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6500.27; Thu, 15 Jun 2023 08:45:01 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::b8f3:958:d2c5:2232]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::b8f3:958:d2c5:2232%3]) with mapi id 15.20.6477.037; Thu, 15 Jun 2023 08:45:01 +0000 Date: Thu, 15 Jun 2023 09:44:54 +0100 From: Bruce Richardson To: Stephen Hemminger CC: , , , , Ilya Maximets , Jerin Jacob , Ruifeng Wang , "Honnappa Nagarahalli" , David Christensen Subject: Re: [dpdk-dev] [RFC PATCH] build/pkg-config: remove machine arch flag Message-ID: References: <20201211155111.145279-1-bruce.richardson@intel.com> <20230614123310.710fa9e0@hermes.local> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20230614123310.710fa9e0@hermes.local> X-ClientProxiedBy: LO2P265CA0007.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:62::19) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|PH8PR11MB7120:EE_ X-MS-Office365-Filtering-Correlation-Id: 8dfe8aaf-1ca3-435b-7a89-08db6d7cce4d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1ZdrAlezb7/3TXJ/HZyCqmzXBLWBa7lQDK+mOLdnSkUNv8OOt0blBCI2j5GJbiyCBTToa+dOvWi0XEyjttadjeww/PP22DWzEpf5wW5kVXwYDgcqm8Dt4pHdBc/qd9+k3fUDrkK1+aQJep3nT0YFh+bAkvpVEOepCNR6L/Q26IU8VJV6er/nrm+oMzNd6g9xafaJSLFCk7tBHxNyoy5kl7hhcECZXrlSSJMRdJFXDFFUYr+cgI+ySXxhnZnZ3W2b9i9uHF6bh86n6tsyLiZmkUf3ey6wyYs7zWSoKvKzBHOKsTEwECKAn3HdNp3ZyxAJ2PRO+8yD0VfFc/1zz9l0fSPMjzdxb1MvH0Kw0Qgfbd7/tiJ7YW6DnqzqgW48vh/LqYowwVNr7dCtQWvkJrwXYNevrlsWgqdDR6/OUe7FIi9u6tPpjA3gVbgdbF4/Q6C+pwmY5l1QCpbEilcybCl7BqwySfZ01WoWjJAKU4Ti+alA1yLPWZzzeRIFZajx411XrTX8zYIp7fF7aJPiutmt46/1rQ96cODpqEBOUYISDl+07QaWUTa27OJvT9hffHFK X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(39860400002)(136003)(346002)(376002)(396003)(366004)(451199021)(478600001)(6486002)(6666004)(82960400001)(38100700002)(186003)(6512007)(26005)(6506007)(316002)(41300700001)(66476007)(66556008)(66946007)(6916009)(4326008)(44832011)(86362001)(2906002)(5660300002)(8936002)(8676002)(54906003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?3jbY4KD9DhbuNulRQKX5aBsXVq4/HjG/ZX5P/LmeTqbjh2xh6kmBxlt/tZkS?= =?us-ascii?Q?MusHsnANgO+EtSApKzuusr6SP1dfyqqDjHIy71veKcokxvZZzi1irY7Xu6i7?= =?us-ascii?Q?cUZo+T6UP2K/5kA8XnISgB/RVzaI9Ekt/Wf4NV73FL2xm6y8Z6DABZBRkShO?= =?us-ascii?Q?4xtDqpIXmk2Z7xXobFHo5fpj9uWmi4jkeEh4f26kOSYed3SZf6dv/oHATqak?= =?us-ascii?Q?sYMj6uglwXLRf4ZUeKs1K1Wazu2n/J6Ex/C15AmkEpAC538Vz9jyeGbAUcVi?= =?us-ascii?Q?vZ6mD9EbVHzeeBe6VXFdT1G9cCTzpsOYyCEFebLyuxCgqTkpaUo6Bym1CjKg?= =?us-ascii?Q?UqiER8oFjHk9bZwIfYumQzCafTrInw7YQ1LkbgNDFLcfoKw4SWgSui6I9kp5?= =?us-ascii?Q?cbf2v0VAPUPYXxzmPwJBfYwmUILRBnTsSRzhvbti+PB6baHiUxVEEWIPtwSY?= =?us-ascii?Q?VSTsDGMkCRJasZLeGhfQsahMeh4Wl3mbC+zR+6WseJfdoKaWFEhYOo4afty1?= =?us-ascii?Q?PxVhux9mGEbaBnG8IC4MwGHplVK5TqEUpxCdd9H0ibbHdjQjzNdyymjdmwkz?= =?us-ascii?Q?2HuU6yVdDz19bxN8N99jgTLs5YY4JhsxscWUCuI1ufLrx8iu5YHyfI9TE2XA?= =?us-ascii?Q?eLrh2mayCFGLxqt7FuQx1VHo/h5X8VuEy6mqRXUSzVVWneAnjeTxBqARCkNn?= =?us-ascii?Q?QD1SSBwRQ1k/8XwV0zeWwIvYsK5Up4AkEOnL80vMGsSkRPEzGtTDZrOEHOCM?= =?us-ascii?Q?eDGeTyE03prtrlzP3b7GaNr34J9rno5yHDaWC52BwTD0CaLxmOi+Gm5LyGgT?= =?us-ascii?Q?4lR30UA1pXlP+ayg9TMJwaL2eiBi6edrgYCr28KVYCGaQ3m1kqALH6dwPE51?= =?us-ascii?Q?8Ls8k46vsTGqfatdVvVfcNxf7BUsKSRZSkBshqsZqDrnJu0/BrHZJG5npTyM?= =?us-ascii?Q?34yYXhgqx9gYS2lNXrh8biNV2WbAHmr06O9ETjo3fvG04k3KP6vBvz6HVyDe?= =?us-ascii?Q?wwDLUK7TwEawlsE/tuDRKQXDiKK6WDf9cdbbSa8b2/5Gv9MFfNymSKIWA5Xj?= =?us-ascii?Q?5wTxm+MnTVwAii1rUQBuoQU/MpQiI9S/8q1BQC61GWKsBVQJSsAvVxZ1YBtV?= =?us-ascii?Q?/9KlBo4PFH8GmgN3Q+gwGVcnMNumnmVwXqmW92aelIPzzFOcpxuaVoVKIge9?= =?us-ascii?Q?JbHAFWZ9NqZ8ry/2gyOkCeCGGP4qhWAgG3QB14VsP293hf/tk/iJN6VSDEOO?= =?us-ascii?Q?U0V9w8/O9sUDUt9ZQ/5jDGd8R83RnlY5XO73H9e1qSBnRsD5nu3tYw7OG7gD?= =?us-ascii?Q?OMFKiuUJZILW8i5I555ABWQasrxJv+7wpJ8ksWJHXh8lW///c1Xem0LnwOXW?= =?us-ascii?Q?KuLKV4ulTrDvNorxFB0b0/Wo/1xy++/TAwj/BPWc0kOYuwkBIdjARfA0FtpE?= =?us-ascii?Q?bXGh0+/dH8SvzqxtXwCrjsQ5bPRqCdluao4EvHlUb9SnvtN5hIVQHzIclky+?= =?us-ascii?Q?W6FFMC6CgOpinFMHT9nIfODQcsNfozzwKRTh+nIVg+LfcyupR+L6JYqdOVKM?= =?us-ascii?Q?/wNIHPuO/o1NQYlGjOciTwz5uudquuRwl2econbc6yAOgmGES16Bum5DV1KM?= =?us-ascii?Q?NQ=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 8dfe8aaf-1ca3-435b-7a89-08db6d7cce4d X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jun 2023 08:45:00.9757 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 7qURZ4amlrWndLyh/NOI9Rd3gisQpL9Kb5C61IAw9h2/9/FJ34qWsek7MNcLtWFyojjSraBMH06AT0kB3qjPb2wm2W+rMpM/yy/m00r6DGE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR11MB7120 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Jun 14, 2023 at 12:33:10PM -0700, Stephen Hemminger wrote: > On Fri, 11 Dec 2020 15:51:11 +0000 > Bruce Richardson wrote: > > > Traditionally any apps built using DPDK had to support the same > > instruction sets as supported when the DPDK SDK itself was built, since > > that was "leaked" through to the end-app and DPDK headers via > > RTE_MACHINE_CPUFLAG_* values. Therefore, when converting over to meson > > for app build correctness the "-march=" flag was included in the > > pkg-config cflags output. > > > > However, since the DPDK-specific CPU flags are now obsolete, and we > > instead check directly for compiler-defined flags, we should no longer > > need to force the exact same architecture match in all cases. To > > faciliate such flexibility, a new pkg_config_machine_args array - which > > defaults to the existing machine_args array has been defined. The > > individual architectures - x86, arm and ppc - can choose if and how to > > override this value themselves. > > > > For x86, since SSE4.2 is the minimum instruction-set level needed to run > > DPDK, and since some header files assume that minimum level of > > instruction set support, we override the "-march=" value with "-msse4" > > for the pkg-config file. This allows end applications to set their own > > "march" value while still ensuring valid DPDK compilation. > > > > Signed-off-by: Bruce Richardson > > This looks fine, and can see no negatives in the comments. > Could you rebase and resubmit a new version if still relevant? > There seemed to be a general lack of interest in it, sadly, so not sure I'll resubmit.