From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 576AD42D07; Tue, 20 Jun 2023 13:03:52 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 467E042BFE; Tue, 20 Jun 2023 13:03:52 +0200 (CEST) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2100.outbound.protection.outlook.com [40.107.236.100]) by mails.dpdk.org (Postfix) with ESMTP id 15A5D4113F; Tue, 20 Jun 2023 13:03:51 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fbpTQtVLFRQC9zW0D9+1RYhyn4J5Qle8X34NrTTOqiZH5X7ie8lf3j4A73apHSgJ+oVX7pTNRLvcgCSRYH0PRzdxtxjL9/0kEwJz/ZyECW/uPPc1FvhpHkKsPtVF5awBopIF16pkvAJE4t418sPd90qJnzFpzJUY6zYBmlTRu8zLY+3ki2sVO47oYLEHwS/7DT3F2ejM3mHeeYqGkXS0AGKBF8sCHc9zwAu3p3DQ/y8lnt3Ufu59jrTr5NVZcu11TMSy/R7CticJhuRRj+0BX44dixR004ojIneJ99vTaeIMcnt29HXhhV3cCHtemstEOSk7pDsMju34uGMq3wF80g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=w5AIomXy3/ylq0UG7vP3f9o0y4TvVhFZiHKXZMKJrpM=; b=XyBEc4PvQDW8/33L6fMCZl3vtfIsOkCMeMVuNOSVeC1LcvsV5WADq3wkRJQUfutgy5urnHrbiYL/JwizLxoQDzvmsAfCYoQIleBfVqYLQHAfdtINQbXMMXghZwNBrvIkk1YYUdX1S2TP5MXhsI6PPFr3qzMLBeJq2XuHe2zXB9yJuT/q+mJ5SEcIsIS+DgWWRy6aziIWjY3A7g8ABcWvguT/ircODfS7Nov1rxvkIGJakBu4+LAml07CJDIFqi24OeeOhzu9iGGftT6R6ruSXwJ4ImSRN/L3JskHuMF3WEOxGTAwJuuOXxn/Vrhyh7g0A30vyMsuRo+5fpIuozjUhw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=w5AIomXy3/ylq0UG7vP3f9o0y4TvVhFZiHKXZMKJrpM=; b=v6zinGfZqRsSz7sBxKSxWKKnjGW2kcYIeIehIu9pWEt58ENSXd1/mbHcXgKuPeUAEj1LlmJuWOloikKKpLWDgXqlFFVOLKh0y6aH1m42hgYqssGAmBUe8sPt62U/yMPQdnus77v6wmTj3GvWmuvHp/EEttCGXQ9u6FJE4NVGXjs= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; Received: from BY3PR13MB4804.namprd13.prod.outlook.com (2603:10b6:a03:355::13) by DM6PR13MB3818.namprd13.prod.outlook.com (2603:10b6:5:243::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6500.37; Tue, 20 Jun 2023 11:03:48 +0000 Received: from BY3PR13MB4804.namprd13.prod.outlook.com ([fe80::8306:6bb4:394e:c988]) by BY3PR13MB4804.namprd13.prod.outlook.com ([fe80::8306:6bb4:394e:c988%5]) with mapi id 15.20.6500.036; Tue, 20 Jun 2023 11:03:48 +0000 Date: Tue, 20 Jun 2023 13:03:37 +0200 From: Niklas =?utf-8?Q?S=C3=B6derlund?= To: Ferruh Yigit , "humin (Q)" Cc: Chaoyong He , dev@dpdk.org, oss-drivers@corigine.com, Zerun Fu , stable@dpdk.org, Peng Zhang , Long Wu Subject: Re: [PATCH v3] net/bonding: fix bond startup failure when NUMA is -1 Message-ID: References: <20230616071558.1278520-1-chaoyong.he@corigine.com> <20230616072034.1278546-1-chaoyong.he@corigine.com> <3237ae77-bd68-cffa-f1f6-537ff871496e@amd.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <3237ae77-bd68-cffa-f1f6-537ff871496e@amd.com> X-ClientProxiedBy: GV3P280CA0096.SWEP280.PROD.OUTLOOK.COM (2603:10a6:150:8::35) To BY3PR13MB4804.namprd13.prod.outlook.com (2603:10b6:a03:355::13) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BY3PR13MB4804:EE_|DM6PR13MB3818:EE_ X-MS-Office365-Filtering-Correlation-Id: fe29b7f4-2e73-4530-91e1-08db717e05d5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: L738hFC7NWw7TmgP4IWPe/btM/4gf3azPf7/Duozx+POoku0U64xVzFB2knBuIk290HbHNOsaAiPLqW6R553owdWTVnreZAiVtw2NO74y5njtLGSbf/mm2qFK+ElVndYAeYk9Nxz3cxyFv8pLSkerYIL4foBzv2C1WJuJNjH018924X1L/gt2ZfqfzyGZaCBV+QNHPG2F2xUyUbeONsdNDXV1cOfC+PLKE4PfTKHmFv9cVM35jSsNU/Gg04CtqP8KPnoQswKHC/rbybHYbtFLeW/c47FNL31OIRR/Haio0T8R2vxDbDCYO2mHdbSIG4XHmYP6QJ27KIzSkXSuWedS5C8VL+PfH9mEZUzOmJ5bVopBJVtCBGMi6pgXiLPTy1HElSTys1FZivNZ8zjqUsQRKc71bDDi+PxDAW+8zV1qOLUs01ByHWG2BuSNFDFjAK51t0igV+KzXGPOB8RKobkgyHsWdHC08UC64FoDa2E0sQbxyq1wGO1JhPvL+0Y4Ku3m/o/xTqnPHmZQhGLxOpk5S54auGSeqlTUZL9BwJ4kqn0WV0ZwTClE1pzH/pBkIgQeiGbmQbkplIPHSpofpu7XduRgGyPIzKZa/ukw1ZY0K21utIJ1JMtIO+jBDG9zvIfdgYsVxk6875FXJlZ42oc8GF/MObRjJV1LbuvPJlFmT8= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BY3PR13MB4804.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(396003)(346002)(376002)(366004)(39840400004)(136003)(451199021)(4326008)(316002)(66946007)(66476007)(66556008)(86362001)(2906002)(66574015)(83380400001)(8936002)(107886003)(8676002)(5660300002)(53546011)(38350700002)(38100700002)(186003)(26005)(9686003)(6512007)(6506007)(110136005)(41300700001)(6486002)(6666004)(52116002)(54906003)(478600001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cFEycFk1Y21xNFV2UGs2cGUwRjdWYStFMXpWVjRaRGs3MnRwakJSUXF4SWJs?= =?utf-8?B?VnFTWUZmbmFKbW1UNE56bnNkd2lnYjFQZzBaZHVYSjlUZHNaclk4dG4rNTAv?= =?utf-8?B?aTlTWG5oN0w0MGJXRGxJWmVGTGd6REhYTFB1SGVzT1ZZbFpqaElKdHVVQmJ4?= =?utf-8?B?SnduUmtEWGc1N1JuejIyUjYxbnNVYmRPRi9nQzlaQUFRYkRxRU03ZUVxQ3FO?= =?utf-8?B?b1RxL0lIdkZLeTBialRxQmFsa21YRVNiVmNsVXYvVTQwUFBJU3pTSHRTOXRk?= =?utf-8?B?ZW4rQU5uNmxtTVRYeFJXWi9BbjVLWkJVQ3FEWjcrRVFrMS9jZExkZUNnUnpy?= =?utf-8?B?ZjlSSVE0TW5mN0ZSWmFVRVo0SThwUzVZbzJaK0ZObWgyNGpodm9CSlgyNjZZ?= =?utf-8?B?MldpTWRzbGFLbjY2clY5RjZUNW9qeWhiNGtqUFR6aU9xQVlwTjlmN2Q3Zmls?= =?utf-8?B?bG9qdVFNQnh1b1ZwNVJQakg4NmhTd3NEcEovb2hwWkZ4UFdOWlo3bWFyelRX?= =?utf-8?B?Rjcwd2l4SnF4cDlxdE5oRWtxQVBLMWRJaU5KVGRDZ1FxSllOUE5RNllIcDF1?= =?utf-8?B?WmFQb0pKMUN4RG9Ld1YvV0p6R3Zlci9hUHFqMHByYUtRZ3B5cTNzRTF1bTU4?= =?utf-8?B?Z2RjOUlXcm41cTlsNGNva09lOXNuakFMcHozZzVvQVplYWxpeXVpSC9OMHNz?= =?utf-8?B?MEZMMjBucDJPMjRnYXBaTlczT1lHSTlaU2FRbHJTMkZGY3M0WmYvNUNoNjNL?= =?utf-8?B?SmVRZ0c1b3htVmhrWUs3dUpjQnpoWnM4TWVLNjdnMFBrNkFGRHhtNGZKSmdo?= =?utf-8?B?RE9YOVVObkU2RUM0TDliMWdybnFpNjkrUnIxbTFqM1JzOXUzUlRWOTZieXZW?= =?utf-8?B?QUdrN2Qyb3o1ZjhhMHV6ZlhXSy9Tb3J0emswazNSNWFjTElvcWIxNDJSZHpx?= =?utf-8?B?eEJxQjl4Q2x2WkpHWTVsUnV5SXVyUGI0QjJMVE11VXArMG1HQ1F0QjY3VTlr?= =?utf-8?B?c0RwSVkvK25ZLy9mOXh3NGVseTlqUko2VndnSGdVMkRiQTlKMmgzTm1vZExm?= =?utf-8?B?aDhZeDZqK2IzeklPbXBLS3VQdkN4R0N2R0xCd1R2WDJKUVA4UGlJUlhHdzIx?= =?utf-8?B?WTdQT2FScWFYSzkxMUp1NXlzZWNYM25YMmxpTjRxNmZ0S3IwZ2cxU0ZYQm5x?= =?utf-8?B?N1gvZFd6Y0lrc084dHljLzdOaTNUdStWbkdnZ0t0RXVkbDhTRUxKRzBkaHdU?= =?utf-8?B?ZTgveHRqeWxaR1FIdjJHaWMrWWMwbndRa05hTm1jTTFWSmIra3lkaGcxdVBI?= =?utf-8?B?VkgrRWxsUGZEaGFReXVueFlmNUo0NkpVdm16NVBLd0hJNlNRYXZUVEFOazdY?= =?utf-8?B?TmdiK3AxQmNxL1dMaXRPK1cyTndMZGxEeGl1ZXJvcFhBbUJKb0xkdlVVbWRo?= =?utf-8?B?SkJkYTYvS3IyeU5WdXJWc0ZFNDk3UGhFSFNEMDhCZmJHMEpGTFVsSXdoYzAr?= =?utf-8?B?czVnSUlHczE0WVk3K0JLS3NUUTZZVkRBWnhXODZSOUF6WjJOL2NhSUJLemdI?= =?utf-8?B?SHpDZ2taazdRWlI0WVJjb21xL1haaVNMUzIwSjFxaE5raU1RR2E0akRQc3Fz?= =?utf-8?B?ak82RlVrRU5HVXNSbFNLWjNhYTJYZjNPUm81WTJZVEgyRWRFMFBlaVd3T0tE?= =?utf-8?B?OW9DS0JCeVhCWnQ5aWFma2ZKcEJqdUZRMnNidVBlUlZaamNQMkRLdTVldm9G?= =?utf-8?B?RjRPT005N0I0QXJTYUluazJldkpra0tZd1UrbEJrQ0dpSXYvRzcrNGRUd09v?= =?utf-8?B?QkQ5ZEdyL3U5L3oySW9qWFppOG5ONDlYRk9mSkt3U0VuL1hyNW9zM0NKdklp?= =?utf-8?B?R0xscnorZktLSmlwQ3pTenFCSUoybHhmazBMOEZaMnNqblNCVmt2ZlVIcUZU?= =?utf-8?B?UThvZnpLd01QK1lZc1FBekFJaXZqUUp3cjl2MENTeDNTNDBUWmlHV1lodHJR?= =?utf-8?B?SUQyTWYzK1hOWHhxQmw1MUo1bFRVZll5bDMzVzRzNERWRXcweDJNVG9RRXBv?= =?utf-8?B?clJBRi9HWTFTYWlNaWxMbHhRdzdZZ3FZRjFvOTRabFI5RW1CYzZhTTFTc2Y4?= =?utf-8?B?cWswaGZWS3hxU3hVL0RzRmpGQ25DdlUxcVhibGNUeUYzT0hXR2Frdm9SYlkw?= =?utf-8?B?QXc9PQ==?= X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-Network-Message-Id: fe29b7f4-2e73-4530-91e1-08db717e05d5 X-MS-Exchange-CrossTenant-AuthSource: BY3PR13MB4804.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jun 2023 11:03:48.2316 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 4WcYsgiHlLJb18QJVlicle7/bSW+GDZsyy/GxaIMEhCEUB2FLhX4g7HrDE2/WwBE2vOpurdQRY3L325XdvCkg5HhqlyI1DH4oFv7hKNfTkY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR13MB3818 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Connor and Ferruh, On 2023-06-19 09:57:17 +0100, Ferruh Yigit wrote: > On 6/16/2023 1:00 PM, humin (Q) wrote: > > Hi, > > > > 在 2023/6/16 15:20, Chaoyong He 写道: > >> From: Zerun Fu > >> > >> After the mainline Linux kernel commit > >> "fe205d984e7730f4d21f6f8ebc60f0698404ac31" (ACPI: Remove side effect > >> of partly creating a node in acpi_map_pxm_to_online_node) by > >> Jonathan Cameron. When the system does not support NUMA architecture, > >> the "socket_id" is expected to be -1. The valid "socket_id" in > >> BOND PMD is greater than or equal to zero. So it will cause an error > >> when DPDK checks the validity of the "socket_id" when starting the > >> bond. This commit can fix this bug. > >> > >> Fixes: f294e04851fd ("net/bonding: fix socket ID check") > >> Cc: stable@dpdk.org > >> > >> Signed-off-by: Zerun Fu > >> Reviewed-by: Peng Zhang > >> Reviewed-by: Chaoyong He > >> Reviewed-by: Long Wu > > > > No need add your colleagues unless they "reviwed-by" through email-list. > > > > Hi Connor, > > This is done time to time, if code is already internally reviewed, send > review/ack tags within the patch, to reduce noise in the mail list. This is the reason why patches from us usually have 1 or 2 R-b tags when we post to the list. We have an internal review and CI pipeline we run patches thru to reduce the noise at the list and to not waste upstream review resources. We follow the DPDK workflow internally before we submit patches to the public mailing list. I hope we can continue to do so and add R-b tags, as they represent real effort by the developers. > > It looks like there were additional reviewers of code, which is good, > but it requires maintainers' (you and Chas) ack to get accepted. > -- Kind Regards, Niklas Söderlund