From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2573142D23; Fri, 23 Jun 2023 09:54:37 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9EE5240E09; Fri, 23 Jun 2023 09:54:36 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id D4198400EF for ; Fri, 23 Jun 2023 09:54:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1687506875; x=1719042875; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=+HlZUllp5/jK667mlY3KxEIjW4lP9QxowM7//nKx31E=; b=HJylT7Nwc6j1knRHwASJ6Zf8MAETqmgHciM/45gX0nNZnM4UQZy6OYcD R9ZJNuHpAwSVdSxNRRDY9vbRBAN9qrV3nx6rezaTNRdJ8v/9MkqOltP5E 4Qvx8RsMkFDD1orUgZVKoyB7tjvjfhk1wZRDdzppMuz1vLAftpA767tMI W8L4MtzRf6OsjV/Z0CcEpL4VfT5wgSobGT94CHCVFo45yaI01Kn6TXMBq oQLT0FHNd9hlkpaRTmq1jpWmtuhTI4Twdel1Ge5WyQxQjs03vig0EUjrz IyMgS9HFgNDiUDBv+ku1v43ErdWqTb8qeWnHkRb4wW+rJHBnmHkAIvyuf A==; X-IronPort-AV: E=McAfee;i="6600,9927,10749"; a="341047797" X-IronPort-AV: E=Sophos;i="6.01,151,1684825200"; d="scan'208";a="341047797" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jun 2023 00:54:33 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10749"; a="692590240" X-IronPort-AV: E=Sophos;i="6.01,151,1684825200"; d="scan'208";a="692590240" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga006.jf.intel.com with ESMTP; 23 Jun 2023 00:54:33 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Fri, 23 Jun 2023 00:54:32 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Fri, 23 Jun 2023 00:54:32 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.174) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Fri, 23 Jun 2023 00:54:32 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UIwbc+YPi1NBXbto0Ck0+2ygMZ2VV/kOEdhaaJ4E6Dr7teEeeQxQo0X01+1tP4WlzaXRQbwJDBUWW3DzfZHNFPEVA+exktErQQWVyTD1Djop0eVBHHlk6Ci3u9qQEBUQLpnF5VhtW38RG18hK+GIQUBE5TUsInbCFo8hCG6182/wjwWTx8MmDZ4MeVW/ndZwuvbrEB8heySZefrdd2b+B5r2jS4GCYSvLyFAET9UPjqxjStcGkkCZEHak18SNS3Wg2qY9d3aaeIIiUMoMWvFqeae15KUetMiXyyjndbF9FIOkpvolXfqtsy7nKJHYyg6xZvM1k++/+/i1sonjudN6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FMzTW2+y/D8NBYbJCErUUZytGgP0sZ9asrQc9IsBPuo=; b=Uqky8+jnus/KfdMHsXsWhd+OlSzpi9EWURMspYiAW4LrM8HE0MJiYxFL5A7VYvJEk5HmBIyEokHAjDVRVKzHJo54dGX82HHKTMufgzbMxhVDWBPWK59zw3n7juAwx8ph/wQfdAu8mKOS5QuGTbIoaCvLc721ev4bOZ5ispJb3dpPqXYkbazzAf3rvUw7CHc/iDye3y2mo5PixpvJgjQwu6O+X0wg5t2d4ooJECy7/u/Um4ERa4ugh7V2TsnZwlxP5O3vN1U/sJdt7wRlIoDG7y6H35PPKSJ2CHAxG5APitxDiebVnbPjYC4yR4oULOzSq/UsfNIvO4jmpPjsmSbyZg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by PH7PR11MB7451.namprd11.prod.outlook.com (2603:10b6:510:27b::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6521.26; Fri, 23 Jun 2023 07:54:23 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::b8f3:958:d2c5:2232]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::b8f3:958:d2c5:2232%3]) with mapi id 15.20.6521.024; Fri, 23 Jun 2023 07:54:23 +0000 Date: Fri, 23 Jun 2023 08:54:17 +0100 From: Bruce Richardson To: Thomas Monjalon CC: , Subject: Re: [PATCH v3] doc: prefer installing using meson rather than ninja Message-ID: References: <20230609105139.76239-1-bruce.richardson@intel.com> <20230609145107.144593-1-bruce.richardson@intel.com> <1986946.PIDvDuAF1L@thomas> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1986946.PIDvDuAF1L@thomas> X-ClientProxiedBy: DUZPR01CA0003.eurprd01.prod.exchangelabs.com (2603:10a6:10:3c3::15) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|PH7PR11MB7451:EE_ X-MS-Office365-Filtering-Correlation-Id: 36267a52-8e18-48eb-4622-08db73bf0f06 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: C1y8H6AKqO9I2wCqe0OcwIR9eAaIOTngX8X5s3IyEpxT0i2X9DnxEGIFDFYna/MHRk4fCSVUOKDEISGht/vWrFveBFRBdo+LocHIA1MPq5ZeHdTQQ7T+LtYQhjekvSHEZ1ydD1vLteGn4RLomb0dFc3rSh5yOs6NQ1LfmfXa7N91yLo45GVXhG6fffuDDl8vibypRBqGI2F+3gR62Dx6+mex7kqeju9cL7HV6r1kQKUOYlB59m1vhGARHFyXnVFmXkndPMQCBEBZj6MMjLtHdGPOJ/D8eykmtsnkf6aQf3hV9Ss5QMwKqIF+LfRpzqjqKXGoXZ/xA1BByEkaT3QaH+p0EvWbxD2ufaRkF3jxOeYfIkKZC8+MQomc4NHG9XbB3U6ZblH12DdNiBjF1M9qdvMpcS0fTXFogYtvX+yuNvimhcscjtJJALDy1nX0+l5tFHkb4Y/OwWUE4FuYyYdwL87rFYvnBDtImX0V14coyBvgsIVDz3gk94Tdv4fZVEC2jgdhRBi0Rs2c/AekG3f363dFt01E/PxJKPbMxzFWl0wdTBMWxDj2CUZc0185o/IZpKV4I9JuPtTtdSlkv+TY3A== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(366004)(346002)(396003)(136003)(376002)(39860400002)(451199021)(44832011)(5660300002)(86362001)(6506007)(82960400001)(316002)(478600001)(2906002)(26005)(186003)(6512007)(6916009)(4326008)(6666004)(66946007)(66556008)(66476007)(8676002)(6486002)(8936002)(41300700001)(966005)(38100700002)(83380400001)(67856001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ZPWF2QUCf+Be5GdfTwg6jWvMt6RcNlKoL9p1bSkLI5bLIQsPDV/RX/Gg4vpN?= =?us-ascii?Q?s0QIcpQBq03JxIG2eQ6RquP7n4BBDlU/z8zhaVF9aw0OIJs0TkR3XbBNg3IU?= =?us-ascii?Q?a+syhy1ZbVMptVg/e1YMsKcIjV0gpiAVDIB0UDtFiObng12jtjNbqNBIOJoT?= =?us-ascii?Q?hET+9y5BbFizrdvyOkVPhtMQUkI+XMmBWyE7SFH632VrvmiQcISnY+Qmd1Ea?= =?us-ascii?Q?UhNDxXwqEm5u1OtOvSkulGzpNDqzElRoMpVStoC3cRCfC6QE42ML72HLgbY3?= =?us-ascii?Q?uxaPVBa4tNcWQwXPWqr1kK9JoFe8U8K+708WXvDqB06FCUc7HfF8r7uFhqb/?= =?us-ascii?Q?Xx75/VoXokJLn1prBzqi/mhWdrCOfutD/W8732QiXzHftIG7byR8I6iWq4Wm?= =?us-ascii?Q?Y/xNr68xRPMk6JSKLeejZXUHJg7q2tQv3tOjqmdBd5920+6hGs0ii5WJVsy+?= =?us-ascii?Q?Y2Blv67XzrpBfw6pz25ett7EFjbWAIvoti9fa3tcgwMyoWKJZ6A5lMP2NmUm?= =?us-ascii?Q?wC3KpzLeQ+sCnm83uEPYlhZuWPCqmitZoFQ1S2Er/JVnH5yDtQuhRybvDneu?= =?us-ascii?Q?Vyk1vxVuGLxu7aciAJETMe94J/ikb+M6mEaEomeFoO5JvY4/SZWmc/Jyikum?= =?us-ascii?Q?7XwVKtyBxzXZCuzcQXW8jq6psrg7oa8sLyUehEpY3YtHb7qp0oyteUu6uWvN?= =?us-ascii?Q?xa0SNj9Hg3Bqhs0CFwCiyLzF4+kf7ZY1Vdyx5JZVs7qQ+x1y7tzbnaCjZoS4?= =?us-ascii?Q?Wc6gzuCKw/EOzn4EkjuwtXPCQe0xN54wgMgIguiI4JZebheRw7zTLPGC778u?= =?us-ascii?Q?+p95EV8XRP7qJ1b5kzPd2xvr2kX3GhPdVvDcdtGnIX12VsU+M2wImbbU4cOZ?= =?us-ascii?Q?7yt++rxu3yekoVstRPdbX+023GtIwYDMsJkhpJZGuL+1mxGcBGYwn/g4xCgY?= =?us-ascii?Q?xRleOlpnbq1hgCxyc8qK2/E7UHUIU4rbh+nyVqtwyHxTa3RbTRE7DC8O01ko?= =?us-ascii?Q?gEcWXnJGQIZxiq1OC/4ECBhFxtlOrDY81p+FRjk/uQAgVDE1ytZ+V6+kgimj?= =?us-ascii?Q?hxLLgRD114dJqxOieHSX/ZKL6v8QorHkoKR4qu4jyb1hplC9PGofp7DJ4pST?= =?us-ascii?Q?8GJYRZ5Gpefu3SO09ct0bwxRNGaZbkfFnWaIVRgLdNowVGUAdce0ujNjZlh8?= =?us-ascii?Q?/lK8VrOOflbYm2+MpdEy2X35CH2zHZzvJwz5fZch0/Gy5sFvVoQ8TBMyn32g?= =?us-ascii?Q?dcfy7jvVpHSnbaz7dtVeYeQeHC/pwuzYYCXyHyIUigfHa+Kv/KfoGM4l07CU?= =?us-ascii?Q?1psXYWVumlSVXpfPXw1YQnM5gc7GUfc80HZrYISLKuG3sQwwuDwTOFyFJp7k?= =?us-ascii?Q?SKqDkjX/7PdlZARb6+TnHXsLGM3jFyjiUPWhGX064sA2qfO6xQ1Di7m3Jws5?= =?us-ascii?Q?Row03sAXoqKbzlbJhmewwBoZe7ZS1WT49VqNt3NlS1l68DNQ0SC4QHdWggG9?= =?us-ascii?Q?w0LIXLgNLWXXCn9TcxtAht6wiBbJdiMpA+U4JnqlfRoFTKBLGXfrhqs3zG0M?= =?us-ascii?Q?ck1qcGlxMFWG65Llq3W21T2X4sZ+st0koL8wGay33BhyMwn+cNY/i0ZH3vKT?= =?us-ascii?Q?rw=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 36267a52-8e18-48eb-4622-08db73bf0f06 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jun 2023 07:54:23.3436 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: v/MWhg7yDbrDyN7ACWxyzxwFkfa69gtmjfty0asm8EwBoOpLSDYDqbwRCnegpLr55Z3dE53DzSyL/A7Jtc4HTsGuZVK1VkGXYNNYoL1YUic= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB7451 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Jun 22, 2023 at 08:35:17PM +0200, Thomas Monjalon wrote: > 09/06/2023 16:51, Bruce Richardson: > > After doing a build, to install DPDK system-wide our documentation > > recommended using the "ninja install" command. However, for anyone > > building as a non-root user and only installing as root, the "meson > > install" command is a better alternative, as it provides for > > automatically dropping or elevating privileges as necessary in more > > recent meson releases [1]. > > > > [1] https://mesonbuild.com/Installing.html#installing-as-the-superuser > > > > Signed-off-by: Bruce Richardson > > > > --- > > V3: > > * correct order of arguments to meson in CI scripts. The "-C" option > > must follow the meson "install" command. [This is consistent with > > other uses e.g. meson compile -C ..., meson test -C ...] > > > > V2: > > * Fix one missed reference to "ninja install" in Linux GSG > > * Changed CI scripts to use "meson install" to ensure step is properly > > tested. > > --- > > .ci/linux-build.sh | 4 ++-- > > doc/guides/contributing/coding_style.rst | 2 +- > > doc/guides/cryptodevs/uadk.rst | 2 +- > > doc/guides/freebsd_gsg/build_dpdk.rst | 2 +- > > doc/guides/freebsd_gsg/build_sample_apps.rst | 2 +- > > doc/guides/linux_gsg/build_dpdk.rst | 4 ++-- > > doc/guides/prog_guide/build-sdk-meson.rst | 4 ++-- > > 7 files changed, 10 insertions(+), 10 deletions(-) > > I see other occurences which could be replaced: > > .ci/linux-build.sh: [ -d install ] || DESTDIR=$(pwd)/install ninja -C build install Yes, this could be replaced, I somehow missed it. > devtools/test-meson-builds.sh: echo "DESTDIR=$2 $ninja_cmd -C $1 install" >&$verbose > devtools/test-meson-builds.sh: DESTDIR=$2 $ninja_cmd -C $1 install >&$veryverbose While these could be replaced, the use of ninja is not a problem here, as the whole script runs with user permissions. I'll consider replacing them in a new version, though. > doc/guides/nics/mlx4.rst: ninja install > doc/guides/platform/mlx5.rst: ninja install I looked at these before when doing the patch. They need to stay as they are. They are part of instructions for installing the mlx driver dependencies, which use cmake, not meson. /Bruce