From: Bruce Richardson <bruce.richardson@intel.com>
To: Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>
Cc: dev@dpdk.org, "Morten Brørup" <mb@smartsharesystems.com>,
pbhagavatula@marvell.com
Subject: Re: [PATCH v4 8/9] build: make fragmentation library optional
Date: Mon, 17 Jul 2023 14:19:01 +0100 [thread overview]
Message-ID: <ZLU/xaOZdzFi+wwx@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <6a58c9ad-baf1-2dde-6c0c-35d058ba1061@yandex.ru>
On Tue, Jun 27, 2023 at 10:32:55AM +0100, Konstantin Ananyev wrote:
> 23/06/2023 16:07, Bruce Richardson пишет:
> > This library is not essential for most DPDK uses, so mark it as optional
> > in the build config.
> >
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> > Acked-by: Morten Brørup <mb@smartsharesystems.com>
> > ---
> > app/test/meson.build | 6 ++++--
> > lib/meson.build | 1 +
> > 2 files changed, 5 insertions(+), 2 deletions(-)
> >
> > diff --git a/app/test/meson.build b/app/test/meson.build
> > index 0a971997a5..2e447e3402 100644
> > --- a/app/test/meson.build
> > +++ b/app/test/meson.build
> > @@ -56,7 +56,6 @@ test_sources = files(
> > 'test_hash_perf.c',
> > 'test_hash_readwrite_lf_perf.c',
> > 'test_interrupts.c',
> > - 'test_ipfrag.c',
> > 'test_ipsec.c',
> > 'test_ipsec_sad.c',
> > 'test_ipsec_perf.c',
> > @@ -173,7 +172,6 @@ fast_tests = [
> > ['func_reentrancy_autotest', false, true],
> > ['hash_autotest', true, true],
> > ['interrupt_autotest', true, true],
> > - ['ipfrag_autotest', false, true],
> > ['lcores_autotest', true, true],
> > ['logs_autotest', true, true],
> > ['lpm_autotest', true, true],
> > @@ -376,6 +374,10 @@ if dpdk_conf.has('RTE_LIB_GRAPH')
> > test_sources += 'test_graph_perf.c'
> > perf_test_names += 'graph_perf_autotest'
> > endif
> > +if dpdk_conf.has('RTE_LIB_IP_FRAG')
> > + test_sources += 'test_ipfrag.c'
> > + fast_tests += [['ipfrag_autotest', false, true]]
>
> AFAIK, there is a new patch in flight to add new ip_frag perf autotest:
> http://patchwork.dpdk.org/project/dpdk/patch/20230602170147.4828-2-pbhagavatula@marvell.com/
> Probably need to be synced with these changes too..
>
Yep, it would.
I'm working on and off in the background to try and improve the way we
manage dependencies for tests, as right now it's a bit of mess, if I'm
honest. It's very condition-based and error prone.
next prev parent reply other threads:[~2023-07-17 13:19 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-22 13:48 [PATCH 0/7] expand list of optional libraries Bruce Richardson
2023-06-22 13:48 ` [PATCH 1/7] build: make most device classes optional Bruce Richardson
2023-06-22 13:48 ` [PATCH 2/7] build: make membership library optional Bruce Richardson
2023-06-22 13:48 ` [PATCH 3/7] build: make bpf " Bruce Richardson
2023-06-22 13:48 ` [PATCH 4/7] build: make efd " Bruce Richardson
2023-06-22 13:48 ` [PATCH 5/7] build: make distributor " Bruce Richardson
2023-06-22 13:48 ` [PATCH 6/7] build: make fragmentation libary optional Bruce Richardson
2023-06-22 13:48 ` [PATCH 7/7] build: make reorder library optional Bruce Richardson
2023-06-22 14:30 ` [PATCH 0/7] expand list of optional libraries Morten Brørup
2023-06-22 15:05 ` [PATCH v2 " Bruce Richardson
2023-06-22 15:05 ` [PATCH v2 1/7] build: make most device classes optional Bruce Richardson
2023-06-22 15:05 ` [PATCH v2 2/7] build: make membership library optional Bruce Richardson
2023-06-22 15:05 ` [PATCH v2 3/7] build: make bpf " Bruce Richardson
2023-06-22 15:05 ` [PATCH v2 4/7] build: make efd " Bruce Richardson
2023-06-22 15:05 ` [PATCH v2 5/7] build: make distributor " Bruce Richardson
2023-06-22 15:05 ` [PATCH v2 6/7] build: make fragmentation " Bruce Richardson
2023-06-22 15:05 ` [PATCH v2 7/7] build: make reorder " Bruce Richardson
2023-06-23 10:25 ` [PATCH v2 0/7] expand list of optional libraries David Marchand
2023-06-23 10:31 ` David Marchand
2023-06-23 11:08 ` Bruce Richardson
2023-06-23 11:15 ` [PATCH v3 0/8] " Bruce Richardson
2023-06-23 11:15 ` [PATCH v3 1/8] examples/l3fwd: make eventdev an optional dependency Bruce Richardson
2023-06-23 13:25 ` Bruce Richardson
2023-06-23 11:15 ` [PATCH v3 2/8] build: make most device classes optional Bruce Richardson
2023-06-23 11:15 ` [PATCH v3 3/8] build: make membership library optional Bruce Richardson
2023-06-23 11:15 ` [PATCH v3 4/8] build: make bpf " Bruce Richardson
2023-06-23 11:15 ` [PATCH v3 5/8] build: make efd " Bruce Richardson
2023-06-23 11:15 ` [PATCH v3 6/8] build: make distributor " Bruce Richardson
2023-06-23 11:15 ` [PATCH v3 7/8] build: make fragmentation " Bruce Richardson
2023-06-23 11:15 ` [PATCH v3 8/8] build: make reorder " Bruce Richardson
2023-06-23 15:06 ` [PATCH v4 0/9] expand list of optional libraries Bruce Richardson
2023-06-23 15:07 ` [PATCH v4 1/9] examples/l3fwd: make eventdev an optional dependency Bruce Richardson
2023-06-23 15:07 ` [PATCH v4 2/9] event/dlb2: skip configuration if no eventdev lib Bruce Richardson
2023-06-28 10:19 ` David Marchand
2023-06-29 9:39 ` David Marchand
2023-07-18 9:09 ` Bruce Richardson
2023-08-01 8:36 ` David Marchand
2023-08-01 9:17 ` Bruce Richardson
2023-06-23 15:07 ` [PATCH v4 3/9] build: make most device classes optional Bruce Richardson
2023-06-23 15:07 ` [PATCH v4 4/9] build: make membership library optional Bruce Richardson
2023-06-23 15:07 ` [PATCH v4 5/9] build: make bpf " Bruce Richardson
2023-06-27 9:26 ` Konstantin Ananyev
2023-06-23 15:07 ` [PATCH v4 6/9] build: make efd " Bruce Richardson
2023-06-23 15:07 ` [PATCH v4 7/9] build: make distributor " Bruce Richardson
2023-06-23 15:07 ` [PATCH v4 8/9] build: make fragmentation " Bruce Richardson
2023-06-27 9:32 ` Konstantin Ananyev
2023-07-17 13:19 ` Bruce Richardson [this message]
2023-06-23 15:07 ` [PATCH v4 9/9] build: make reorder " Bruce Richardson
2023-07-04 1:40 ` [PATCH v4 0/9] expand list of optional libraries fengchengwen
2023-08-14 15:10 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZLU/xaOZdzFi+wwx@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=konstantin.v.ananyev@yandex.ru \
--cc=mb@smartsharesystems.com \
--cc=pbhagavatula@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).