From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A718C42E9D; Mon, 17 Jul 2023 16:10:07 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 373F340A80; Mon, 17 Jul 2023 16:10:07 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id 213A340698 for ; Mon, 17 Jul 2023 16:10:04 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1689603005; x=1721139005; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=v+2KBU4jGWtoyfAYMAHaAwGT2goj0oAxs95GvwuwRCk=; b=DXEbDcZOhwPvaI0CtXj0nxIXu835dWcviHYAahSpv5W3Z901oH7nxNPb rtBGDwFkyIkLpSuclIIRdkaKoLzRnS0K8pU7YMpRJbKpGdgNLUFlicyeL 7Kvz9NtxHMMhX4FO1xVNZqbfxtLFszEpTTW03F8t+jO0DTcTvOtOHCEge GxqnHDPTtHE4ncNRWJH97HxjbEFr4/+ZjQP6EgeUU1hg+QGe9J8Pe1aZC 1frn2MtNTZ1KXg0hDpWsRCwwKxydslOCnPZPi1/Fd7k7Pbam8fKZLeDB5 KaQApnR3lEYQE4ABYzFLXKlp4A/d4/eRZQZzLfbeQ4ISwIjjSo/trZuKE g==; X-IronPort-AV: E=McAfee;i="6600,9927,10774"; a="452313681" X-IronPort-AV: E=Sophos;i="6.01,211,1684825200"; d="scan'208";a="452313681" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Jul 2023 07:10:01 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10774"; a="723228696" X-IronPort-AV: E=Sophos;i="6.01,211,1684825200"; d="scan'208";a="723228696" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga002.jf.intel.com with ESMTP; 17 Jul 2023 07:10:01 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Mon, 17 Jul 2023 07:10:00 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Mon, 17 Jul 2023 07:10:00 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Mon, 17 Jul 2023 07:10:00 -0700 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (104.47.73.43) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Mon, 17 Jul 2023 07:09:59 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CSWkjlAGDadxX/x+9jRVGDHSpN0wZyiT+c79dfosvc5Khwkn9elCCRuMpqWyBcmuTRV+mLn3i7ErMY9zhfbgIB8WSI2oIchtX5Fks5Wj20KDqHP+U4cg1F0jrO10ze9QCHTHBljkVS6kWM7pqomQSHL9Eyu4xhRa96f/heZTRsGfzyRQeXqqV38iqZzyMQ0rBXkZJ4N9LpXCjvjW06+XAzplpXXfzgmu2AM098yzJxz9ea7Iad17Nl1O884sMSIWZM+HSIEmT4TktgWahLPIOelcuQ0ZNWuMGSz2mE5QZgY2+Fj/37/LYBjmLxaEx4EcAQpPLVNtC/4aqSUY3DRkUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TeXCKkylQt++5p/HkqQFNX9/QlO+b3OGqL+5xJdSyZg=; b=NfPzxGmNswjAxDxrmdWuUfBpQt18MYZW5FIRrjT/Egh43JIrD5PlMKZXC12nayMAwIeznuVEbCnZTvURnXkrZvybnXRWqhOgVP8/oLquKvX9dElkINnTtG6aK/kKRqgj7FT73fZqVhokbrQKiJozATP8KGp4R0In2fz5AnIWzfWkXGQbWDaf80Xa73jYtV6VjJfI/K3vdDeOn5IJ7CSK9LdOJeJkBGj41dvEm4VsD83UqPCFZZVK7d55nFFYfHh5Ssz+GXV+UUJ+tEZzdv7zoWDorEDFPgz24oC4SeK3I4zswX9P+V7TIMsSN6UnHpSY1QhabRUCx8fF+a2o6q/v2g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by SJ0PR11MB5215.namprd11.prod.outlook.com (2603:10b6:a03:2d9::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6588.31; Mon, 17 Jul 2023 14:09:57 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::44fc:41c5:90da:642]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::44fc:41c5:90da:642%4]) with mapi id 15.20.6588.031; Mon, 17 Jul 2023 14:09:57 +0000 Date: Mon, 17 Jul 2023 15:09:46 +0100 From: Bruce Richardson To: Thomas Monjalon CC: David Marchand , , "Timothy McDaniel" , Shepard Siegel , Ed Czeck , "John Miller" , Rosen Xu , "Matan Azrad" , Viacheslav Ovsiienko , Ori Kam , Suanming Mou , "Andrew Rybchenko" , Tianfei Zhang , Xiao Wang , Maxime Coquelin , Chenbo Xia , "Anatoly Burakov" , Harman Kalra , Dmitry Kozlyuk , Narcisa Ana Maria Vasile , Dmitry Malloy , Pallavi Kadam , Naga Harish K S V , Jerin Jacob , Ciara Power Subject: Re: [PATCH] set namespace prefix to threads Message-ID: References: <20230703112359.5067-1-thomas@monjalon.net> <12236357.O9o76ZdvQC@thomas> Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <12236357.O9o76ZdvQC@thomas> X-ClientProxiedBy: DU2PR04CA0236.eurprd04.prod.outlook.com (2603:10a6:10:2b1::31) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|SJ0PR11MB5215:EE_ X-MS-Office365-Filtering-Correlation-Id: 61003c1f-181a-4aed-d4d6-08db86cf7fb3 X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Lb3TNlcy3W8sJ9VekZHzGTvjwk01BAKYvaMM4MmfBepNRKG/AMoRNBsTs3HV0ghX2MrKqI+BzPhnF/9Bwz7FmYZTPvYuH3YqOSCweJuN+EEqTjN9I0d1n6OMmNsDG+lsDRwFCtdgN5oPWBTV0JcFDJ+d9eFSrBldLbBJO44p7YP/phF0ueRHOSERdmQgrHKUkDnKkqGp1O7zJPFmUQmKaLGoxO47VhEL/Y3w/bw5R8dTubn7yAubvR5vkpzfbJdNFSmev0C8iGvS1o2PXyX656E8cZDOTkeRAzg8P/yTHrjgJuOMMPu3DAFqTsa/YBeWWZaaMZYii5caAbenOHfaXZB2FZV8S4RTpAkacHx73XIX7gSih3F6YGHVsjzYR9Rd/jqCg0UOjKvk+DVdU12fhoXocyGn22x3DRqUsi0kWSl8PAgB/IQuVuTp5oa6ZYkc7lv3TG0L3QNy44m9gqGRiwK9uohsQ8yMQK+7SNBPAzZL6oX6TjLiKcxVuo3ViiP9EGqtg8Het9WIHA/YDPDTibhK5AVffCtILXSgcsN4L5FxF8RdIPLEO7eY4Xhau0+V X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(396003)(346002)(376002)(366004)(39860400002)(136003)(451199021)(54906003)(82960400001)(6486002)(6666004)(478600001)(5660300002)(8676002)(41300700001)(8936002)(316002)(38100700002)(6916009)(66476007)(66556008)(4326008)(66946007)(186003)(53546011)(83380400001)(6512007)(6506007)(26005)(107886003)(86362001)(7416002)(44832011)(2906002)(66899021); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OGUvVjhFc3pDSDVZRU9nK29GZkduUUNvRG13aWhTZ2xTRE91T2tLcEYyZzlE?= =?utf-8?B?QmZNM3JobS9ncUdEZ0RzTVlJMXByU2dGQzlhcTFvczNsdDZpV05tV3N1ck92?= =?utf-8?B?b2NoTlRNQ0ZLRGdjZG5uREJoaUFMd3F1NHJxY2lxcmEvSU9XLzhyTStmZ0Vw?= =?utf-8?B?T2dUc0EzSEZKQzJOZnBFMUIzSVBuQVE0MlhibFhYWUNBWWFVdEo1SFJzcjNV?= =?utf-8?B?ZktNa3JSbXNCemVUTE9EQ2dXQzlvNkVzRlpaSlEzejU0eGpaaWhVaEkvcVJj?= =?utf-8?B?cXFmTllYQjk5N0RGWE54bXNlS0NwOGpZbUp3Tzg0R2pFY2E1TjBuQnExMklM?= =?utf-8?B?UGpFQ3huSkdvYmJ1dGZNU3Z1UmRzRXZKMGZmb0pPbnFCMVEvanRjWlllWVgz?= =?utf-8?B?K0M4NCtwVDdHV2R6ZENuNWhnajRVWGs2bDN5V0JPS1ZWLzU3TXRLZ1lpd3Z2?= =?utf-8?B?UXFrakxYSzZTWFpURmw5eXdiYzF1OXREZC9jY3pZVnI3ejJKTTh0QUVGbk0y?= =?utf-8?B?R2ZDYVRNaldmdWJiVGVJSWRCcGFyNWhhempDc2wzR1B1aU9FMGNmazVYMm1L?= =?utf-8?B?VFEybEN5Nk9aakZQT3hjeWNZUFo2Rk9QUTBhbFZIQXBtWHlGR3l3Uy9HVWNB?= =?utf-8?B?Tlk4OVc5emU5bzl1K1dzRFpNd2JFdG94cGo0TktkTm01SlpCZ2U2SG11dE9P?= =?utf-8?B?bXNmM2tBcWIwMzVNV3ZCREloSjE2Z0ZuUklhWWV6MTBFci95ZlF3YjdwREx5?= =?utf-8?B?M1BtUlplR29PV2tvU1lRU1ZJSFA5NnE1MWFWWHpsdU5ZaTFSOUl5MmNVemFj?= =?utf-8?B?MzZGQTVkNHh0ZXBQc24zTTZQcXBhdndGdG54UGp4U0RoRjAwRnYxWVh0S2hQ?= =?utf-8?B?SWhYdXduQ1NLWkhqeTBMa3lMTjVGbktvVFhBL2hWNVlYbFJSYnYzdlBSUXdp?= =?utf-8?B?Q3lCeGRWLzdJZktJdEVLQ1R1ZVhvY1JOd3Y5TW5xTlJKdWZaY0ZQTHNZdnI1?= =?utf-8?B?TnNaUGI5bktPV1VTOE1XRU01WjJuZHg1c0tqTW1mTE0yY2lRdXZORUdFNlFO?= =?utf-8?B?YW1JVnp2UktsTm1scmJvSmFIOGZZOFhuSHI1T1M4SFZwdXE1SjhTaTJ0cEIx?= =?utf-8?B?d1VTbFBhc3ZSZmtmeDRSREFOcGhES3duZlM0QzdEK0ZTaWxBNzk1aFJ6M2N0?= =?utf-8?B?VkZuWXc2WGZqSVNsUkFXeHpRQmtReFFXZzlYK3lReDBBc0lhbWdlT243QS92?= =?utf-8?B?ZWx5N1pTVDYrMmZ1T2Joa216T3ZSVWdBUkt4SnlHS0p2VVVCNFh5KzNmT2sw?= =?utf-8?B?ZDJpZ3c2NjB0UytUbDNWVm5zdkZ0NXl0ak1ETit6TGZXUWdkdDFQajBHUi9o?= =?utf-8?B?THdmb1N5QW9TVGVjY2ZYY2RFb1lpaS9mdkMvZFlhRWlJTUo1REFUVFJ4d1hv?= =?utf-8?B?WHNsZGdLTWtnK09OS1JaNFJhT3gvaUNwK25uZ3VsSVJQQVo5QVlkcytQWW5B?= =?utf-8?B?b0Jmb1N3WExNU1JsZHVXVGo0OE80UGxqUFllVFdKd3pVa0dRT2dYRW1qMUQy?= =?utf-8?B?M0xnWGJoQnFEbTNKZ1VPcURDd0luWVFYcFp2azhWWG5JUDdyK0VEa3B3Qmoy?= =?utf-8?B?OHM5Q2NFT3RYZTUydDE0YjNvREgxdE1uZ1diMzIwejAxOWZSL2YvUGdKZGl6?= =?utf-8?B?SXhDQXE4V1BxV0k0YjA4OHVvTEZHZ1lXZ1ErdDhROEg3cmFEUFJEbkx2K2M3?= =?utf-8?B?V0pKU3BpUnpwaWVUd2lMKzVmajl6Sjg0MWxoS1NMTDF2MFN3bEVuSVI3Ry9Z?= =?utf-8?B?RHlVNEoxZ3VkTHFKNm14VTQ0bE1jNHRvOGhWM1ZXdDRPbHdRdzBqQXBzYlpZ?= =?utf-8?B?VVFyMDMxcjNDS0ZLSXUyaW15cW9lekQyUU9DdXJRV0s1UXhmTGorVlNwUE9a?= =?utf-8?B?NHFSa24wOWhORHlEdVFaRTVzOEJQZFFReXI0WkRHcmpnUmlQMXZvYjU5VFJ2?= =?utf-8?B?MkpOV3VoV2p3aks5aVR4dnR1Z2o1d0dQaFFZOExpMWVNK3h0MEtNYWZJRUNt?= =?utf-8?B?RkorT3Q2RTZjUmxXWWl3UkxtcE15RnJLTmdlK0R5M2QzQW9paGpmc3IxNEt2?= =?utf-8?B?SXQ0ajQzZzFYWXdCVjV6Qml5Z3R4NEZNN0Q2THU1VGdZdXZKOXB2djA2Ulcx?= =?utf-8?B?dkE9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 61003c1f-181a-4aed-d4d6-08db86cf7fb3 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jul 2023 14:09:56.6767 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: yGNzkrV2Osli6kf0Hapxjbwp34/R12bISw/K2znbD5MA10tEyD/SySItWMzox4t5XmOghVA12vZSkbcMVwBRulYZWe3JwFWB3/pogGRaFAE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5215 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Jul 03, 2023 at 01:49:55PM +0200, Thomas Monjalon wrote: > 03/07/2023 13:38, David Marchand: > > On Mon, Jul 3, 2023 at 1:24 PM Thomas Monjalon wrote: > > > > > > When looking at threads in a system, it can be confusing > > > to find some unknown threads without a clue it is started by DPDK. > > > > > > Let's start all thread names with "dpdk-" > > > and the driver name if it comes from a driver. > > > > > > One more constraint: the thread names are generally limited > > > to 16 characters, including NUL character. > > > > Yes, and no way to discover this limit. > > > > > > > > > > Signed-off-by: Thomas Monjalon > > > --- > > > Please review carefully, I may have missed things. > > > > > > Note: we should use rte_ctrl_thread_create() as much as possible. > > > > > > > As for this comment, we should advertise rte_thread_create_control() > > instead, as it is thread library agnostic. > > Which leads me to suggest looking at rte_thread_create_control() calls too. > > You're right, I'll do a second pass. > > > > diff --git a/lib/eal/freebsd/eal.c b/lib/eal/freebsd/eal.c > > > index 7008303e11..e201acd1c2 100644 > > > --- a/lib/eal/freebsd/eal.c > > > +++ b/lib/eal/freebsd/eal.c > > > @@ -843,7 +843,7 @@ rte_eal_init(int argc, char **argv) > > > > > > /* Set thread_name for aid in debugging. */ > > > snprintf(thread_name, sizeof(thread_name), > > > - "rte-worker-%d", i); > > > + "dpdk-worker-%d", i); > > > rte_thread_set_name(lcore_config[i].thread_id, thread_name); > > > > > > ret = rte_thread_set_affinity_by_id(lcore_config[i].thread_id, > > > > We changed this not so long ago with 8ae946970ed3 ("eal: fix thread > > name for high order lcores") which offered up to 4 digits for lcores. > > With your proposal, we are back to only 3 digits, which is probably > > enough, but I preferred to raise it. > > In general no need of hyphen before a number. > I will change to dpdk-worker%d. > While I know that "dpdk-" is probably the clearer prefix, "rte-" is also well-know as the standard API prefix for DPDK. Give we have a 16-char limit, I would suggest keeping using the "rte" prefix on the basis of brevity! A third alternative is to just use "dp-" as prefix... /Bruce