From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 55DA342EA6; Tue, 18 Jul 2023 11:10:11 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D3485410D3; Tue, 18 Jul 2023 11:10:10 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id 9596A40A84 for ; Tue, 18 Jul 2023 11:10:09 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1689671409; x=1721207409; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=I/ANRsQBN8ILFk4fxxD3pvnk263uICgJryxh++fkdQU=; b=aotKENQ+BEuebPrHODh0NtJAmqWO2UNcQVhIeyUlVh7IzPeYUKsHCaO/ xr8FpEnOhy+abGqJ64wxGF+X+ZIFPFUZKB6Bnw5AinUgZy8iJC+/4mAft 3cEaj5G//rugO4o9pUIvJlK9RCSvwreXqaGDSrMFIvoNZgn8Vr83hsSDS Ev4CyITMIHchOcORY1Ga0nXJW2tVVmxjAGAPAGAimcdMOSqQmEhF/Tic0 XCqqtUmLGu6B4GzyOlOCZuoqZZFUxJFfIk+VIXsfiOO83FvaV1akA7JpD 3krIZudVb2UguhoSrbIqEIfP0P0OSFc5y69dDj5S07DO3CD77BwDBVtFR Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10774"; a="366197316" X-IronPort-AV: E=Sophos;i="6.01,213,1684825200"; d="scan'208";a="366197316" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jul 2023 02:10:06 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10774"; a="700827185" X-IronPort-AV: E=Sophos;i="6.01,213,1684825200"; d="scan'208";a="700827185" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga006.jf.intel.com with ESMTP; 18 Jul 2023 02:10:06 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Tue, 18 Jul 2023 02:10:05 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Tue, 18 Jul 2023 02:10:05 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.108) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Tue, 18 Jul 2023 02:10:05 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GPaAFvkiFUjzIAKBWMsKY/muZEZ8XuD09bqmYP84fWoKODmNE9Pl67Ln9TdBTNL8WmoKF6lS6h05NGyh3AKMnuV819tSxFgHI5J5435R523g4L/trqBVTJ5fC9dMFcQwhR3XvqgPSPa808ZxAdRFx0MyncIeJzvpKfOAzpJT2VGCM3EsosbOJcnzULL/ICX1UkQp/4L8lSFMVvfHwJF5/HYIN0U3p/kxSSMNfVrHKPBIjND7Xb1U9vzs9BGnFK2XVkNBEElM/WnCMnAFcRu/5IkcY+8ju5+auTw0DCYmPdStVxTUQsFtLbj2cK7Wv6SKZsXTxCQGgE4g8Gin/I4TEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PpNGMR4G3dCO8HCn18dEhYbpOOGH5RVQBDos2oSKnN0=; b=Cto3c7H2BUaMOJTIR2B5VB45pfrI8UbBtxupwtzxPRMDg7adiE7ijyNe8F9240InjdDD9Hxmq5+ZeAhBbyxuFoXUbbnxUBs5BuGcZzLz71fkcJaMlzF5uRe9CQVx5KME4dPVtvATuPFxhFN+ilK9RXcu2TquqXK8wtmRt0cdi+spfzVkdQigT8fskBAKg5bxqSnaToohCyZ2ZUuloMABKjD9/7yIi/RMr6xUd9G3Bu6RY6cwGjTM2eHLG7g+kRaFBx6cjVJm++WUgio+0s1hNErxf3TFR2wQusYbgmpQC+WsRYGhy6yqG6fxndJGfjfE678x5XMwYFHhjrKYEaX5bg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by CO1PR11MB4963.namprd11.prod.outlook.com (2603:10b6:303:91::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6588.32; Tue, 18 Jul 2023 09:10:03 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::44fc:41c5:90da:642]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::44fc:41c5:90da:642%4]) with mapi id 15.20.6588.031; Tue, 18 Jul 2023 09:10:02 +0000 Date: Tue, 18 Jul 2023 10:09:56 +0100 From: Bruce Richardson To: David Marchand CC: , Timothy McDaniel Subject: Re: [PATCH v4 2/9] event/dlb2: skip configuration if no eventdev lib Message-ID: References: <20230622134840.3225975-1-bruce.richardson@intel.com> <20230623150708.2203918-1-bruce.richardson@intel.com> <20230623150708.2203918-3-bruce.richardson@intel.com> Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: DU2P251CA0020.EURP251.PROD.OUTLOOK.COM (2603:10a6:10:230::29) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|CO1PR11MB4963:EE_ X-MS-Office365-Filtering-Correlation-Id: 77c3cb28-ea7c-4153-451c-08db876ec4e7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: SXcRAwINQUuIzJfwvRwuV+E1k0xq3riq1fabMj7+bWt2EBsZCGJM89KxOwdtAgME5biQbWeaFf1rRRclaET8/EAqFcQ7Ld7VuP1TcvT2ch8wwvQ0O718vWQdI59N2kMPiG5Ct7XUaTBXW1+KK1ypVW/ERlvypMvVGu5JiKxbJ8mzgZWv6nsmgTs8FqggB0p7FrHKY0cYcFSfH8NcSo7PboWTA1UtfQ+6jyXrihqk5NZqN6OMydywr2b+XKwLsgrLPAfrgBNqNQZhjmRvMqgcmDGSslHsdafMzVomX+n5DqrsCxrcRddGpWgJLkfWEvTESs23Yjur1yDpO9C73Q4qRAhEKYhWwP/8yNRWtH17a0zsF+tqvdK1yeioiY4qJETKVk18lyek7661PN7KL+3YVdl+l3CRfSuwi+XORX0p5+SniPf+wIft+84nRCCxVtFDjT0/h/IvUcuezDJsIWSy1SXQtJEvk4zlNnpnO2VoSR89lcELN8Q9LfYhf7qZ3paQ9/Ck8CJJcB4zi4frrqzHiD3wBN4QsFbfOLUObQrhXcwaH7HLHbYW3mhVY08KM+QC2hV06fZppJbHk8hXdiTTlLmkWskThCFgk8RF1GVD6Kw= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(39860400002)(396003)(376002)(346002)(136003)(366004)(451199021)(107886003)(82960400001)(6506007)(83380400001)(38100700002)(186003)(26005)(478600001)(53546011)(6666004)(6486002)(66476007)(8676002)(41300700001)(2906002)(8936002)(66556008)(6916009)(66946007)(966005)(316002)(4326008)(5660300002)(6512007)(44832011)(86362001)(67856001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?V29MQVF1eXBLYjhXVitsSHBFdUJvMmx1dTVUZ0srL3ZjL2dJbTU2a3RSOGFr?= =?utf-8?B?dG1JUDk0L2lnd1htL3RHYktMYm41REVjMjgyVjJidTFoSWZsL3ordEdmYUUx?= =?utf-8?B?MGlZSHcxOE1vSExFUWpFcitnSW5ub2wxMzVpM3dSd0pYNDVtbkw2UEpJdGdt?= =?utf-8?B?V1ExQm9zNnE2YVhuVDBFelhLWVQyZ0pydGNteVpzWlFVVGF4SmVIeEk5QWxr?= =?utf-8?B?NW43Z09LQkpGbE5nU2Vqa2laS2krSVl4eU9pYWtYUGVMUHFPeVZvL3M3UlNn?= =?utf-8?B?dHRIZW9DOFBPcW1LK0J0RSt0TGwra1VPejM1aHN3U2RtdWhDanhCRDFtL082?= =?utf-8?B?QllUeUhNanFTOVEra2ZVMlR5SjB1Ly81UmtsbHpaMEN1RDBhYVRXdkxmMGpz?= =?utf-8?B?RDA1c25ETTFIbHFPY1hQVlFpV3ptV2VnUmp1bndBMEorQkdiVlNuVFQ1NDVo?= =?utf-8?B?QzZYWWFVbTV0SWxGUGtKN0EyeU1kRWUvV3JwZWpOc09FRlZERGtTdzhFRmVX?= =?utf-8?B?akh6UG1JaGcvL0Q4YzdTY3lUNENKTTl6VmxuZkJFeHJVUGlIMTdhbjNOUDlS?= =?utf-8?B?N1dRQ2M0Y05QNkRyd1ZWODdOWndnR3hVYjMyNkVhNDM3aE5FYjFObVJjYSt0?= =?utf-8?B?d00wSkgzTGk2cEtzWFpnTTBXc2hWSndtYko0Tk1KUlRySng5K1dLQnQ5SzJE?= =?utf-8?B?cWNNcWxGVFdWRU9EZit3UnR5REVnU3JVaDA4SXVpMEsxSGNlN3dXMkY4KzlG?= =?utf-8?B?cmphWmRPekRhaW9wUzhyVmpvSjRSTU9hTTBSclBQcDdvQ2RtNG1hVWtRZTJn?= =?utf-8?B?TGF3OWxxbTJBRzRLUWJNWlVtU3RsTnhxWE0wYTlwMzIvZGZqOUZYc1ZndnJi?= =?utf-8?B?MUovL0JPcmEvUkNLc2hwdVRwQ2xBSnZSK2QrNlB0a3VMVmlGWDJWMnVUbFhy?= =?utf-8?B?aHdCVUhmYSt4MjlnR2tRU0I1dExyRTV3M3NiU3JXckovMit5QXh3YjdjNkhR?= =?utf-8?B?UngxWlBRbTVOd2U1d2hBZTFzZXFGTTNEa3hsdE5iaFUzYTFjL2g0Qk1kNnk5?= =?utf-8?B?bk5nSVl6YkhEUnB0NkdETnNEMU4vcWxmRjNmYlpFT2xteEMybTZHbk84WVht?= =?utf-8?B?L3FTeEFWVzZIS2xpOTI3NEwxZ3QrSTV0MXpibEFtOExiQjVXWmE5QzJXNGN3?= =?utf-8?B?OGNtYU9Sd1JYa3J0Vk90Zmp1MXZ6MElYTFNwOUgxd2E1QU8yZnZpTEhuaEV0?= =?utf-8?B?NUkxaldsYldmeTZKNElHNFRWVXhlV1pZZU5VajVYWmpnc1lQUlhHSk01SlNG?= =?utf-8?B?ZDYvVVRQU3BDWEUxeUZ5Unptd2FKREdWcitpV0xaNHhFMG5rY01vdHltNVJl?= =?utf-8?B?YTFVbnFUazR6Wmpia1NESjh2ZDZ1S0o4ZjlYczNpbzRvUXZqdE0xNWNaN21D?= =?utf-8?B?cFBkQlBQRmFqMXdWb0EzeFpLL1JBdkw3N3ZMWnJ3ZjV5bUFmVStxK1R6SUg3?= =?utf-8?B?b3dPWHVrU3FFN2dOMm1jS2cwNnNGYVZDUEQyRXAya2JnWHhwRUNXaVBRb0lx?= =?utf-8?B?Yjd5Qk5MOVQyUWIzY0o0alRoRmpRL1FOb2l3K1owSEZ6RDdPekl6RkdLb1Vs?= =?utf-8?B?bEYvVG5oTEZXbVZjeWJrWWcrMEVIZU90RWFtd2tnbTVVY1NoRkFJc3gxSnlH?= =?utf-8?B?RG81YTJxUDRta0pDK0ZCSU9Vd296K25lL0ZzTXFoVldvcWJXdWdPa0JYeHdU?= =?utf-8?B?aDgxMDdXaDg1NGtveDk1Y3FYNGUvTTlPUmhPRmRxUGJ0aFE1UUdEZERmZ2dv?= =?utf-8?B?bndxc2pkdUU2a3RXMHgyTlZpeUZONFZOUDQrNk1VMVNYUkU1NHN1dHc0N3I5?= =?utf-8?B?NExMWktsRTVQV1ZYSDBHV2U5WkpQWktwNGtNMVF1ZXRHZzhaNDFad1JDZDFH?= =?utf-8?B?bEpDbGhMaGVHVHNndTViMXZrUkdPNWllSDlQdXo3bWRNYU9LYzFVanlROVU4?= =?utf-8?B?Tm5KTFZSanEzQ0pxL0R1M2U1ZkhlZ2ljK2pYYTZqYjVEUGs2Kzhtd0gzOTZW?= =?utf-8?B?MldWSlAxeE1xRzBzakFNRnR2K0wzNXd4M3diREJXVmk2eVhST1RBNDNzS0lv?= =?utf-8?B?MXJHMjRBTjRuQ2RwRG5xU2lEZkwvS2hXbXptRGlla3JaNm5yMSt5TkhLNXVW?= =?utf-8?B?U1E9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 77c3cb28-ea7c-4153-451c-08db876ec4e7 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jul 2023 09:10:02.4861 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: xOf0pUAQJamP/DpJWTIwCW/Ee+OyT81WVTK9TYj6zxp5Ou7gXBfEDszJnwrD2GFtFJ3jFgyFeIAb485o/ucm5+po6wpDFuIcFwYXBgIkK/s= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB4963 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Jun 29, 2023 at 11:39:53AM +0200, David Marchand wrote: > On Wed, Jun 28, 2023 at 12:19 PM David Marchand > wrote: > > > > On Fri, Jun 23, 2023 at 5:07 PM Bruce Richardson > > wrote: > > > > > > While the build system will skip building most libs and drivers when a > > > dependency is missing for a component, for DLB2 driver, the > > > "static_rte_eventdev" object is referenced inside the meson.build file > > > itself, which will cause crashes if it doesn't exist i.e. if eventdev is > > > disabled. Prevent this issue by skipping processing the file if no > > > eventdev. [The build system will still report missing dependency, as the > > > dependency is set by default for all eventdev drivers] > > > > > > Signed-off-by: Bruce Richardson > > > > Could we evaluate the class "std_deps" before jumping to each driver > > meson.build? > > Hum, with my suggestion, we lose the opportunity for drivers to > rewrite completely their "deps". > I doubt we have cases where it really matters, but if this revealed to > be necessary, such driver may be directly referenced in > drivers/meson.build like we do for common/cnxk & friends. > > To illustrate the idea, I pushed your series along patches of mine > (target is v23.11) in my github repo. > https://github.com/david-marchand/dpdk/commit/enable_libs~8 > I don't think we should need to worry too much about the case of a driver needing to rewrite deps. The standard deps should really just be the minimal deps for a class. However, for the implementation of that check, I'm not sure I like the approach of checking std_deps in a loop for each driver. Firstly, the logic inside the per-driver block is already pretty complicated, but secondly, I think we can skip that loop entirely if the standard deps for a class are not met. I think instead it would be better to process std_deps value once immediately after the "subdir(class)" line, and if not all deps are present, just loop through all the driver directories for that class immediately and mark them as unbuildable, before just moving on to the next class. WDYT? /Bruce