From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CD29142EB6; Wed, 19 Jul 2023 10:32:47 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BB1D540EF1; Wed, 19 Jul 2023 10:32:47 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id DBE0C40EE3 for ; Wed, 19 Jul 2023 10:32:45 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1689755566; x=1721291566; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=4I7+SCwo+NjoIV49dGhZGZoHM4WIQMYq5WblIcvSI8U=; b=EYd4/NY8PvPfw5zbTmIqOAy/T9Vhpj/YO9adnLLEyQB0gvRtzZaxUYII m96PHyjcMMfPArXaNYnq7DcU50zlvBRoma3/XLc4DKcITCcmjPnnA66LJ GqtyrHucnPC1zNK1dWAHXzDQF7N+qwd2IGunY9bsTvhkPwCp4K0Q3I31M Mh/Mp5/dGjfkTdHwztXqGKJB8kl9CArocN5e8SlC8ZPx7DMLsTT7EvDJF 93Ja7p6Gqad3vA7SZCOfzNn86ykINT8vB3SZuYc5jpcnrJA2jUg0hT6tD 29YZhGvP9p3zgEZoDKb+73RqKkTmPHGtjvhg18uXFDoWqb+5u4WXOUVgD w==; X-IronPort-AV: E=McAfee;i="6600,9927,10775"; a="365284899" X-IronPort-AV: E=Sophos;i="6.01,216,1684825200"; d="scan'208";a="365284899" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jul 2023 01:32:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10775"; a="847990963" X-IronPort-AV: E=Sophos;i="6.01,216,1684825200"; d="scan'208";a="847990963" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga004.jf.intel.com with ESMTP; 19 Jul 2023 01:32:44 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Wed, 19 Jul 2023 01:32:44 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Wed, 19 Jul 2023 01:32:44 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.173) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Wed, 19 Jul 2023 01:32:44 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=apGGlt6bw16iYlj58nexKJdjA7Vh590p7NEvfgBGayaROZYq7S6GS3sgpNivKxNJqJuC4TwA9Pvk2AYFtkNTJiT6mukcP3Mvec91OwO4nT5ExCGh5pvDwaxR8dYITaBcZoaGPGJRMYpFmdOa3BF7u3gfCtEi8J4yx+ztTCFIyOHTG5xcrMSZPFMNnxe6bEdHiXwyQ9OcH1FvZLpPY3TfcgUtTq29hQjW2k4e9tarnF/S55gU3DpUcETdxvloh95WtLvBPHlckUiK0cxIJgofOPwps0f0T0z069Z4tj5dWMPlIokNR/ZhyoSCPZy2dTed7sCI5cZJOzOifMYWZOO3rw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QX4XMNg06KnkvUs+qNecJXwBR/2dNmTdLwJh1KOBdpU=; b=ChD8YGvi3Bq5OKnSOl9HobV9Q2KV1GVojJFzgGaCOSQHo0bRH/fNgPbxgaVuuwGTD6T4x/epqo2ocfRbcK1mYGqV+CGhkM54HIOZp5ENwqt0SSt5o0b3vq7+L5QCv+uHesmqbITBvrGQnj8/QlCCRSgsNiLAd7MLaeA74GVZRZRpBzBTiKdB4bnChGUD1/ONLKL/fTU4f6GDlQyxTypwdiOF+2z54jwNNP1EZJjJkmdQxluDxE9R30zvJVmBsSekfmIBi2qVAlJ2Mv6qOETn8PpngNjclQBqD8rlLr31RPULGymZmJdQGZboQ5nUYBblYLDAQgNfBl+Zn8q0NsCf2Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by DM6PR11MB4545.namprd11.prod.outlook.com (2603:10b6:5:2ae::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6588.33; Wed, 19 Jul 2023 08:32:42 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::44fc:41c5:90da:642]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::44fc:41c5:90da:642%4]) with mapi id 15.20.6588.031; Wed, 19 Jul 2023 08:32:42 +0000 Date: Wed, 19 Jul 2023 09:32:36 +0100 From: Bruce Richardson To: Stephen Hemminger CC: , Subject: Re: [PATCH v3 0/2] Improve docs on getting info on running process Message-ID: References: <20230613143355.77914-1-bruce.richardson@intel.com> <20230718164802.110560-1-bruce.richardson@intel.com> <20230718104020.40c2d646@hermes.local> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20230718104020.40c2d646@hermes.local> X-ClientProxiedBy: DB7PR05CA0046.eurprd05.prod.outlook.com (2603:10a6:10:2e::23) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|DM6PR11MB4545:EE_ X-MS-Office365-Filtering-Correlation-Id: 334a1941-5f94-4e21-a3c5-08db8832b81b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8XeX/jssfZbm5P8yyWlpzDEmitzAUjWL9K4ZE5Ci4Ukbayj+DOPsG6s/CRZzlJrMo3qmddcW+D8sOPHXELh+0Ejm5mPLJZaU+SxepCg8uGICfYGAd1SNMiweyBJVIYlGUAECLXtJA1LTFWoaOYyOYB0e5vQOBsCjsKUyf4hw3Nt5eZmHmZgSH0Cz/yoOKtRjgFSJ7Kr2BuHD5M1YwySKoRDI6XLeLDU/CCTBXChhCf5vA0MhRmp1tAhbLzY1NZvkfHTR/y7NCLhsPxdbyidSroCPYw1lufAjOr5hmUJG3q+JvWEhYcgSG0BWcNS/EpAxG8ATZ4alNcaceevTWDX+82OD8GpsQtikHtVXdtUaPmCRC6Db98JbP8J26QDAbz5pyAnA/1xzyxBrAHvEQI9vArBzkJtuBCKASMXVt+gzQpSKkHjIWYtEit5SiAjbWSr8T1CmathrwiuMpRUs4T3L+rWbwzE77fpHoMZ4QBgq6A2F0/UunpmNO0IrodjlHSD+7XKhLvd4J4huE/J/a1LZ2pREgVCZ9cDdGYh3W462O1YSRAeCRmQTs41hme34Eck4 X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(39860400002)(396003)(366004)(376002)(346002)(136003)(451199021)(478600001)(38100700002)(82960400001)(2906002)(6666004)(86362001)(6486002)(66476007)(66556008)(66946007)(6916009)(4326008)(316002)(6512007)(41300700001)(186003)(6506007)(26005)(8676002)(8936002)(5660300002)(44832011); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?4IwZ//NQJJEerz8776H4sGnPEyt8vEoGrFXC8s1s4vD0guWd/Jf7+wCEUpFy?= =?us-ascii?Q?c1HdlPvtSjUeVODtEx7t46SfZfmCl5OS7tZJS0bJzKYb8RmIP+hC5Roe1QY3?= =?us-ascii?Q?/pjdJKV/RCMmvXNxRxRbVY/zAOdFBagW8rG7Rabd57MzaXS640WsBLz5pwvq?= =?us-ascii?Q?di5a300Od/r+ozbM4W7ragTeP5UdWFf+NvKmbvkOVvLzyxaYmyUn7Yw88rG0?= =?us-ascii?Q?uMjzdL2LFshNaqj76ZkFs2Aim81NgmTAQcS+0Qf3K2JzDY/OAnKDIDEJ21nY?= =?us-ascii?Q?PWV4BmAETy+xrdVG+9AEtzSjctuXocAgPoRT+pn7Vie266GwR6HgIopMa8zT?= =?us-ascii?Q?4RpHvTiuxSLCAITm84wOJ0OlQtfnRvd0pJreQrWfC6q2ixIeVgIAFEGg5mAO?= =?us-ascii?Q?Zv2AGqkzwsXvGLDrDQs55VkoBlEP/vWZLrvC2JtgWyUgch76834OjBkfW6np?= =?us-ascii?Q?rxXR+HMOeaOMdRtWKhSDAXY/1r2jDAp/q0JLb9MLLmMqezU6YL7HVpn1pXF+?= =?us-ascii?Q?1sjApsu91tHxmrHGoh//A6UyfVL16zth1HkbXw9Olgaji+usCW83ACoJcvWJ?= =?us-ascii?Q?4Gcmd7dsYAa+azq0ld8CIc8qamWishc0YQIUSWvomWaRuWe6KshaarSDGWkN?= =?us-ascii?Q?zywxNnHTJ2NNFQAqieHNMi7K0pqN68tmeucwSRNAFMsgKXZ5AjgJhv3gKkqR?= =?us-ascii?Q?8svaxgNaVWt8LkDRGNQ3Yn04sK02/9pAhBTAtEZQJPRfXYEFtNP09Hj1YsOl?= =?us-ascii?Q?suuyEdtj8vuSh2J3PUyMwN86Ue2RXxhs+xHwbYVm0QHOPVhRV+f6kXaO35Z+?= =?us-ascii?Q?mPTdBRaNnonp9hTmTA9Vr9c+GdWvmGWZurSo1kRDho1ONumZzky/6YruQ6Q+?= =?us-ascii?Q?B7v433W/F5XJHH2rAlD5L3XTx2WT8ujMML/BvIFouBGs5tH1uRDEcSq9TbYq?= =?us-ascii?Q?YqBtjJjsCWRZOjb8YuZWKyh39QrOJMcglOtyR/zoAZvWgyPgPy82BNrRRVp1?= =?us-ascii?Q?YPwW2V2TGirvjomAEMt9s/r0+lYzt3hzQuQcqTu6tC2QPhHzf8Akeona/WR1?= =?us-ascii?Q?q0yQeNDEpPq7FaufNXrQZtJ09P/ndyF1EYhUnPyZDoYLknK5YiHYXIxYj7LH?= =?us-ascii?Q?lgW0w3BrpCwiafkPdyhMdmwj53FZWinWVL0/mmSNHzCId4o6Eg77Ygd9bk7k?= =?us-ascii?Q?l+shiZo/YSlB54sGJoukkHDrlPlrNALHscHvjArNs1Xmhv6d3nzxv5oL8YPH?= =?us-ascii?Q?/N6YYOUMnAbDJVKPz6CXvbOE+AGK+1Zvi4g4fOvBerHVHJ6a4tct/Xer0QOW?= =?us-ascii?Q?mCjXvtI488289k1Ax2hHp/65Tc+aqpjfCH1oWQN2shHtNNnNRsVHZbnAC2mD?= =?us-ascii?Q?ZkSC4wYeLgg3WpECKr5C/EWMgwfElkFk2l6kVaohVPiX1tHS2nSipGA/zswg?= =?us-ascii?Q?BB9c0TeeurYpnlpAHetCwSYoiCeavN7yYWc1nIjd98ueSMtHhsImXYPupZNX?= =?us-ascii?Q?ToCXqsaulIr83cGGZVOx8TYqibaNN4y/EFgoEUzrnqBPomMs/7bZeakYUKAn?= =?us-ascii?Q?y8ajCMS1twIiFIbCRxkg20+Hti7ESZKGQ6KcyIsyr/lP+zsdWsH70hg4Ar60?= =?us-ascii?Q?4A=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 334a1941-5f94-4e21-a3c5-08db8832b81b X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jul 2023 08:32:42.3822 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: nMR09cXrzLw7nQZ/uQu0Bv6ZcZS+VXsfaVBG38KTjWGzbRLL+Nospwg+0FORRVJVy26APrLxr66wxyd4PQiLig2zSd2Z43zBLPqNn9QN6x8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4545 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Jul 18, 2023 at 10:40:20AM -0700, Stephen Hemminger wrote: > On Tue, 18 Jul 2023 17:48:00 +0100 > Bruce Richardson wrote: > > > Add details to our documentation on how to register logging for a > > component. Also provide guidelines on when to use logs vs tracing > > vs telemetry. > > > > V3: Moved new doc section on runtime info, and other minor changes flagged > > by David on review. > > > > V2: extended second patch based on the feedback provided. > > Hopefully, we can keep this section short and clear as the > > revisions roll! :-) > > > > Bruce Richardson (2): > > doc/contributing: provide coding details for dynamic logging > > doc/contributing: guidelines for logging, tracing and telemetry > > > > doc/guides/contributing/coding_style.rst | 18 +++++++++ > > doc/guides/contributing/design.rst | 49 ++++++++++++++++++++++++ > > doc/guides/prog_guide/telemetry_lib.rst | 2 + > > doc/guides/prog_guide/trace_lib.rst | 2 + > > lib/cfgfile/rte_cfgfile.c | 2 + > > 5 files changed, 73 insertions(+) > > > > -- > > 2.39.2 > > > > Should we add explicit statements about: > - Static logtypes (especially LOGTYPE_PMD) should not be used. > - New static logtypes must not be added. I would hope that should not be necessary especially since this section talks about dynamic logging only. However, no harm in adding a one-line note about it. I'll see if I can get a few minutes to spin a V4 with an extra note, but if not I think this set is good to go as-is. /Bruce