From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EB5B442FA9; Mon, 31 Jul 2023 18:29:17 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 57C1A43251; Mon, 31 Jul 2023 18:29:17 +0200 (CEST) Received: from mgamail.intel.com (unknown [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id 092994067B; Mon, 31 Jul 2023 18:29:14 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1690820955; x=1722356955; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=b3Pp95vIxEQTeU3ifxXUmt+mPGGiTpo0yXN2DhpEEKg=; b=griboUKNGPdR0dH9x6iTH/pEES/2J7jZ0zgF4kSqND1KMyzVWVLG2XSq rO70ELhl5j2WO8H1GX85ECxDUae0NBeDNSHoO0yAJ46NtaZm/PkKkHXCF 6XT4+I178VeDea+FlCGWvlU1E/K7Z1OK/MUd7YAHKum/c9aZa9DVWTSa7 Bz4mphYmEmPy14ZXgipho728jCt12J0XyLW3hhNNBV6TfRp9oypymEolU pe7m4RN4uqotXjuk76BBSIP4EV+I4K6oyM1sY8L3qpTgxPWRdehT1jDE1 xXyR/okJDBoe/RCUlHO1rcOyW9aJ8L1seJ7SOeWhoIUqWEYMWZIiE/fWX Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10788"; a="353994331" X-IronPort-AV: E=Sophos;i="6.01,244,1684825200"; d="scan'208";a="353994331" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Jul 2023 09:29:13 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10788"; a="974940055" X-IronPort-AV: E=Sophos;i="6.01,244,1684825200"; d="scan'208";a="974940055" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga006.fm.intel.com with ESMTP; 31 Jul 2023 09:29:13 -0700 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Mon, 31 Jul 2023 09:29:12 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Mon, 31 Jul 2023 09:29:12 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.46) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Mon, 31 Jul 2023 09:29:12 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ERpmlHB3NTSdcl2LBe0dtrigJkVegF7orqAW9A3tgJv4I2YD9VUhyqyveS0nyUIkxfmmW+UalaLqPnkgMb91wgvfrQMJDXpJVrnlRwe3eq6AUkpthMM6bf86pIXB4lt6DyTlpovOdUqezpgaSWyQKOgptvYTikqlJKcJ0G5oZEclrPdGrSWzusKfp9WbywsrRbK7p+HbrUQsoLapamuL/PYhyOD2Mw0mEvQahHu749J1DO8Z2uEMj+VkDoGvy4wFqx3PFoZ7fzUFHx0UCwof5fC3ozW8kZGFv072bow+ULc+rbqY8wCV0V450wGk+R7CvJsDt97J5oU8XAoFglGLPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7hgLB9qeAcEUTXS9R3l3fE7/9QTKE+uPKHgSPUZF+GY=; b=V6bWBnlHHUnxGXTAflLPGZtz7vp/AA4/c6LBqLgUfs6w97IjYXuxmQXU3Xg7cm35pM0IHbFr2ikCkEkp86TMlYGzuVj0ZGlBNFAs4EAtM/J8wykrMTaoqDW5DSFnj7nZhK2M6jDbH1irw5phyffJ5ZbFIHMkVgTgF5r2eqckbQdRB14QOfuRFYsUdCeXN4t93l/R7gNOhFiNZu8xxLM4XHQ8nEJIArMdM0BfhiqGPChxTK6rOroR0QB8u+OdQHHHnjtu8V4GIO1gyTGRvUWawsDoVL0/fxXEpCHDdmcQEgDBkp1DsLXMrUdDZh6xXY1h3cs6dVQBhUja+E71EdiW5A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from CY8PR11MB7290.namprd11.prod.outlook.com (2603:10b6:930:9a::6) by MW4PR11MB5823.namprd11.prod.outlook.com (2603:10b6:303:186::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.43; Mon, 31 Jul 2023 16:29:11 +0000 Received: from CY8PR11MB7290.namprd11.prod.outlook.com ([fe80::1bb0:424:8477:dbfb]) by CY8PR11MB7290.namprd11.prod.outlook.com ([fe80::1bb0:424:8477:dbfb%3]) with mapi id 15.20.6631.043; Mon, 31 Jul 2023 16:29:11 +0000 Date: Mon, 31 Jul 2023 17:29:04 +0100 From: Bruce Richardson To: David Marchand CC: , Morten =?iso-8859-1?Q?Br=F8rup?= , Tyler Retzlaff , Subject: Re: [PATCH v7 2/3] log: separate logging functions out of EAL Message-ID: References: <20220829151901.376754-1-bruce.richardson@intel.com> <20230731153902.2350026-1-bruce.richardson@intel.com> <20230731153902.2350026-3-bruce.richardson@intel.com> Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: DB8PR06CA0045.eurprd06.prod.outlook.com (2603:10a6:10:120::19) To CY8PR11MB7290.namprd11.prod.outlook.com (2603:10b6:930:9a::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY8PR11MB7290:EE_|MW4PR11MB5823:EE_ X-MS-Office365-Filtering-Correlation-Id: 9df92811-75e7-425f-3668-08db91e3454d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: x4NzMMqdtPFdnu2lbqwXQvZrbAwYudrjSFxdNHFguS7CmOAT6GghTaLFuDNPsypay4+d9y3mLj87YoXDwUFN3Zp3AELOKP+mpHOjU42RgLbt4m3hQiXu2T6UZEMZseiCMRLzjejUHCzrWZBf/40wUvJBI/8RufqiViG4bJvPBZOGCERst+GgIOD+G6qRGMsUS3TyrnlfR4TDHKD23oK50QMhwxZ8ZFr2qiNdHIfRisrhOHX787nQ3AeaqRM/hc3dgpW2XS9D2/WsaGEkdCr87//IJJF4qLq5vx/JjR3p6tBfL7yB0lEegV/qXNv4LafkfXuiuuHja3rykMxGkSHS/r/C3PF5Xh0YaDmsCqwpO5x5jZ+IaigyYyXWAwsyBVmBzzo3My74qrU3QjfwdN6M75iU+4vwkBhMw4+d0bjm95BxPo2SI9695gC2LlAHapDpZCA9a/WmomubjdEsNeJsrNcpuWFTFnMvH+l/rd8jodLbWw076QtnE/ac1pufDeH29O2jemZq18kcN1+ZNWEr7pfI51V+02ABui9MGsDmQqo= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CY8PR11MB7290.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(39860400002)(136003)(376002)(396003)(346002)(366004)(451199021)(5660300002)(66946007)(66476007)(66556008)(44832011)(41300700001)(6916009)(4326008)(316002)(54906003)(2906002)(45080400002)(478600001)(6666004)(6486002)(8936002)(8676002)(6506007)(53546011)(26005)(186003)(83380400001)(82960400001)(38100700002)(966005)(6512007)(86362001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UkNWQjQzMlo0aktpZVBaTVdvMzBYZXdPcU9mVUxIbW5adUxnOXAyajFtOXBK?= =?utf-8?B?VFRRRDBLOTN6RDBwRzBheHBscUprQzVTbGRVWlRKUHJEMVRvZzZDbHQvbXRt?= =?utf-8?B?L1NGUTFtcVNMZUtIMGU5UVZrTFZndFJSVStBWWFCZzlwazVVOTFHZ09IVHVv?= =?utf-8?B?c3ZTZXQzMlFtUVJRSVg4MUM5akxoUkg5emJRNzgzdHhIaHJpOE1LUFpaODBC?= =?utf-8?B?S3RnTUx5dHd3TWJ6anN4ci8wSjhXQmZ6V1pvd29KK1plcWV6cjNUSC9WV21P?= =?utf-8?B?dlpZZWlxWmpYTzBvRTNyNWg5bXNTc1lVbXFvS0xQblNhbmt0SC9QOHhHeXVP?= =?utf-8?B?UXBLYnhVMnZpQ2xobXpyM1h3cU02Z2xqZ1ZHcE0vanhSdHNTWDlrK3hmaGFi?= =?utf-8?B?d29Gb21jWlZXMWdJMWpzd25jeklsS0YzK0lUUTZrdnl0eXVGczBoQXFnZFJn?= =?utf-8?B?eWxzODV4anJJVGVMOTJDYTdvMDgwaStPVTNiY1BsYm9NQTRzZEEydU1GbHFC?= =?utf-8?B?ZHZlK1ZaVThEOWsxRSswRE5zU2MxUGxrOEhieHhYQ2k0RkZSOVluWGdkeU9W?= =?utf-8?B?SUpRaVN4ZGhtZGo1UlNCbm85elNTc09Yd0xTTTl5VVM5Y1JSL3E1WGIrMTFF?= =?utf-8?B?T0xCNWpkcGppZGVNOWVIbGJ5RXhoaFNCdDB6U3dWN0Y1L3F1NkgrUkJWWmdj?= =?utf-8?B?TmF2QnVlckk5TWE2QjVKK3FtdGtJalg5eVg1Wlp4YVZXa0dCalN4ZXprMlpy?= =?utf-8?B?bFBuSEdVMVp5cDlJN0pEd0ZnODJCaW1EcldoSElYODBhSHhzaG1YTk40elZE?= =?utf-8?B?QjFqc3MzNVIvTEwvM1hsNXhTUXpXNjhwSFpiZ0NUL2xvdHJJT0YwWVRnT2M0?= =?utf-8?B?NUV0ZmFXdUlWUlpkT0ZRVmlJc2V3clZUQWt1OGZ4dTNTWGt6UEpWVE9BSzN5?= =?utf-8?B?bWZ4eER2WEhSdGttYXR0RDRGdU1yRjNDeXlBd2tNV0FES2ZxVXd0aG5JZ1NU?= =?utf-8?B?MkRRcWlJU3dDNUgxZDE0UXN3QXpkUEJFMm04UksvNTNhbFBtUTNwaFdJNWxI?= =?utf-8?B?MXNVOTR3SHU1N0w2eGxaN0lpSHN6TWRvcEJzRWJMUi9WeHU3QktvTWhEZnJD?= =?utf-8?B?N0cwM3pud0dLemt2YmpVbXBPUlZqa284NzJjSzdyeko5dXV5bkF0blZZM0Ns?= =?utf-8?B?WklSK3NiRWoySVhYdVl5dDlrRk1ESjduMld5aTJadHRwcEEzWFNOMk5rNWs0?= =?utf-8?B?dWtDSlVRbngwY3hjSTZGR08xdldaQi9acDNkSVRWY3NsWk1qek9SaGtvY1F6?= =?utf-8?B?UFRTSkRYT3JBUHRnMXhSdE5Pc1BibXhSbGpjUkZRQitWYUlHLytYejV6SWRH?= =?utf-8?B?Z3Voa2o3dytVa3N1a0c2UHRaYURneTNCTy8vSFUvM1NMMVY4b0xQcTA1NERr?= =?utf-8?B?ZUtZZDBlc0l1M2xCbzcybUh4Ty9kM2xTOEVFQ1g3Y2lTU2E5M3hTMEZsZG41?= =?utf-8?B?enIva3BTWHNDTXhlSTVZak52K2V0d0xGeHRNK1F1Tk1NTWdENXhURWtEeFFx?= =?utf-8?B?c3pTVDlxdmtNem5jWlY0M25ER3FpT2JXdVhuSk5kVUcxSjJ0RWdIVnl1VWoy?= =?utf-8?B?NVJyM2g0NDJwbEFrUmtQcWp0Y2pjbEdvcE9yUWtORUhZV3dOK3E5WmZwa1Z5?= =?utf-8?B?WUg4NktzYklpUFoyajhKTTlsemUrNjhuT1ZyWlFBZzlwMFFUU3JrbVNSaXAv?= =?utf-8?B?dCt4UmYrRFZlNTNPRDQ3MjJObkJKTGdCZXNkUHFLZlZVNjViMzV2Y0xzd1Mw?= =?utf-8?B?VWhJNW1qano0SG1sOUhpRzRmR2VEMlM1cE85bG4vMkc3aUlMRWpDNlZjTDdE?= =?utf-8?B?ZTRBRUptR1g5QTJFSGxzWm5EaDFEczRydzVsdlVHUGRrV1RIUzdValFwWFJi?= =?utf-8?B?bCtpUjAyT1JOcTJxNjlybWRBNEY1eW9HaUJjQkVqMkp6THNtamJJV3pIUUdv?= =?utf-8?B?OUg5ZzRGK0NyOTNDa3luQ1Z1UGQ5K3ZOMW9nZGNHOTh6SFRhUWt2RDQ3NU42?= =?utf-8?B?M0I2aFIwMEhBb0Y2dDl4VmtNVURBc2dTZTYvRkgybFg2NWtBV1lMWlBMcUdG?= =?utf-8?B?NTd5TzR5emhYb2orZ05pdWJZWEtZc1RHczZVZnJoZGlQVjlSZ1VkKzRLRFVE?= =?utf-8?B?T3c9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 9df92811-75e7-425f-3668-08db91e3454d X-MS-Exchange-CrossTenant-AuthSource: CY8PR11MB7290.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Jul 2023 16:29:11.1290 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 1z1ghWHqW5PmhcQKTvRNCkvXyegy7AroOkP98PfaUqQRGQsMB3ztz7khOSih6DjrQVkrD1BO5HHLLR6JWAmsEyCRUKU7XNHzj1a2zbxQb+w= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR11MB5823 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Jul 31, 2023 at 06:22:40PM +0200, David Marchand wrote: > On Mon, Jul 31, 2023 at 5:39 PM Bruce Richardson > wrote: > > diff --git a/doc/api/doxy-api.conf.in b/doc/api/doxy-api.conf.in > > index 1a4210b948..40f7dd2877 100644 > > --- a/doc/api/doxy-api.conf.in > > +++ b/doc/api/doxy-api.conf.in > > @@ -52,6 +52,7 @@ INPUT = @TOPDIR@/doc/api/doxy-api-index.md \ > > @TOPDIR@/lib/kni \ > > @TOPDIR@/lib/kvargs \ > > @TOPDIR@/lib/latencystats \ > > + @TOPDIR@/lib/log \ > > @TOPDIR@/lib/lpm \ > > @TOPDIR@/lib/mbuf \ > > @TOPDIR@/lib/member \ > > In case you are wondering about the reason.. the Intel CI reports an > error on building the documentation: > > *Build Failed #1: > OS: UB2204-64 > Target: x86_64-native-linuxapp-doc > FAILED: doc/api/html > /usr/bin/python3 ../doc/api/generate_doxygen.py doc/api/html > /usr/bin/doxygen doc/api/doxy-api.conf > /root/UB2204-64_K5.15.0_GCC11.3.0/x86_64-native-linuxapp-doc/29045/dpdk/doc/api/doxy-api-index.md:230: > error: unable to resolve reference to 'rte_log.h' for \ref command > (warning treated as error, aborting now) > Traceback (most recent call last): > File "/root/UB2204-64_K5.15.0_GCC11.3.0/x86_64-native-linuxapp-doc/29045/dpdk/x86_64-native-linuxapp-doc/../doc/api/generate_doxygen.py", > line 13, in > subprocess.run(doxygen_command, check=True, stdout=out) > File "/usr/lib/python3.10/subprocess.py", line 524, in run > raise CalledProcessError(retcode, process.args, > subprocess.CalledProcessError: Command '['/usr/bin/doxygen', > 'doc/api/doxy-api.conf']' returned non-zero exit status 1. > [2772/2774] Compiling C object app/test/dpdk-test.p/test_ring.c.o > [2773/2774] Generating doc/guides/html_guides with a custom command > ninja: build stopped > > IIRC Intel CI excludes changes on the doc/ directory when applying patches. > http://inbox.dpdk.org/dev/CY5PR11MB618735108D3E9D90C67EEF96F5DA9@CY5PR11MB6187.namprd11.prod.outlook.com/ > > .. which seems to match the failure reported here, as doxygen would > fail to find rte_log.h. > Yes, I was very much wondering about the reason for failure, since I could find no issues with building the docs on my own system! Thanks for the info. /Bruce