From: Bruce Richardson <bruce.richardson@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: <dev@dpdk.org>, Olivier Matz <olivier.matz@6wind.com>
Subject: Re: [PATCH] cmdline: remove cmdline_poll()
Date: Mon, 31 Jul 2023 17:32:03 +0100 [thread overview]
Message-ID: <ZMfiA4fQWyCR7/3R@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <20230731161232.180420-1-stephen@networkplumber.org>
On Mon, Jul 31, 2023 at 09:12:32AM -0700, Stephen Hemminger wrote:
> The API functions cmdline_poll() was unused by any project,
> untested, and it was buggy. Remove it from 23.11 release.
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
> doc/guides/rel_notes/release_23_11.rst | 10 +---
> lib/cmdline/cmdline.c | 34 -------------
> lib/cmdline/cmdline.h | 16 ------
> lib/cmdline/cmdline_os_unix.c | 12 -----
> lib/cmdline/cmdline_os_windows.c | 68 --------------------------
> lib/cmdline/cmdline_private.h | 3 --
> lib/cmdline/version.map | 1 -
> 7 files changed, 1 insertion(+), 143 deletions(-)
>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
with one comment below
> diff --git a/doc/guides/rel_notes/release_23_11.rst b/doc/guides/rel_notes/release_23_11.rst
> index 6b4dd21fd0e1..d4c123e5503b 100644
> --- a/doc/guides/rel_notes/release_23_11.rst
> +++ b/doc/guides/rel_notes/release_23_11.rst
> @@ -59,15 +59,7 @@ New Features
> Removed Items
> -------------
>
> -.. This section should contain removed items in this release. Sample format:
> -
> - * Add a short 1-2 sentence description of the removed item
> - in the past tense.
> -
> - This section is a comment. Do not overwrite or remove it.
> - Also, make sure to start the actual text at the margin.
> - =======================================================
> -
I believe we keep this boilerplate in place until the finalization of the
release. We want to ensure the instructions are read by all who are editing
this file.
next prev parent reply other threads:[~2023-07-31 16:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-31 16:12 Stephen Hemminger
2023-07-31 16:32 ` Bruce Richardson [this message]
2023-08-01 23:48 ` [PATCH v2] " Stephen Hemminger
2023-10-17 19:37 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZMfiA4fQWyCR7/3R@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=olivier.matz@6wind.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).