From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 40FC042FA8; Mon, 31 Jul 2023 18:34:50 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D9BC740A89; Mon, 31 Jul 2023 18:34:49 +0200 (CEST) Received: from mgamail.intel.com (unknown [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id AEEF74067B for ; Mon, 31 Jul 2023 18:34:47 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1690821287; x=1722357287; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=FElmCf4oGUSzcBZSEkK8g1bHn5+hrd4uw/UVSQ3MCwQ=; b=KPk8gGfpDn5qJuoM4ul9TqVH0FjY3/BKlIfDKftDiDtwtM3rNhn/zLkv lt8WjjFDopfiGTuocRjajD6gKgVDTQ+4j+VT4jGuJUW1MNDk9mEH/M+dd SQjiAXqm0eRQaxQsGOIbXC6iSkDOqVUn8gbpy/ZIbQWKG5XcNXp5x1mv3 4MMvkfoICuG9FScVYI7JIegbnUzM6tDbkudZdHWfnE8S4Wy8vG4ZHl/RZ VQmdpRdevhgwAQfWdB7GDJ2LinDH7OzBcqz/lPEjCktAy6Vofhzr/jdB+ ahpPeCBdduzgCzmfJ0zI46on4WlofZt43+3idsFtW1s2o9JRwo419vecQ Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10788"; a="353996849" X-IronPort-AV: E=Sophos;i="6.01,244,1684825200"; d="scan'208";a="353996849" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Jul 2023 09:32:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10788"; a="757986620" X-IronPort-AV: E=Sophos;i="6.01,244,1684825200"; d="scan'208";a="757986620" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga008.jf.intel.com with ESMTP; 31 Jul 2023 09:32:19 -0700 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Mon, 31 Jul 2023 09:32:19 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Mon, 31 Jul 2023 09:32:19 -0700 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (104.47.74.45) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Mon, 31 Jul 2023 09:32:18 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UrMyoQCHE34UfJV/qDA2Mrh/0dVHFfjWImC04i6ztf8U8DPpuueI21bcfElJ4P09wlQQvP/rE/gKGlnIVDqbafwnL76SnWa7y9xzKEha1d7u50wvz3js6qH8zFna+YiLfnAO4XyO6H3QQKA8HcpodtWH8h9LJi3ekbsk+aufJfKOshXELMrte6s0Y3K2e74r6ewNLXQ+AF5V5p+N7Rg/MGk4bc5J2AQibwZoI/UbI06lENjrw17pCeDNkxjExfN9Yg+pWMzl3z+eJMlv4q64DRyTbV3bgFT0ufq0tkpG57hq1tCuJ73IvS35OwS5fcRpokTEqSSCm3DvrWYME3Q1nQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9WKiMbpbz7ZsQiOc2fnWujr3lIBhrCP3NDcQw+lO6go=; b=b6wXMdKEREik8czImI6e4JOBGInNBXPBoYLe92sxCbDpQm+Sx6xhQSPx0xETekoV78f1SPiil+Mf5ZyffaGg4v9ZCpQlh6Du0UVArmxxfYC7QMIr+sf41akS/Zhwl+KT3T2KE802gfD8MBGnHBOG4hReV46FIp6CXil6828mAyhza6n0yMsVQXU3Y9dXMJtBddmYWszjD8JaADvZ4wMXaakSjxHc3b4OjZghA0NhibaL2KYWYnnf2LrLE7ZlxFwiFBT6H3rmgy8M5d4Yrt/NlpnZgH086fNELQxpGTbwSkLy9q2Euwl85V+fWW+fAaVhEG4SacAPhZaLiGh0YpSzFg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from CY8PR11MB7290.namprd11.prod.outlook.com (2603:10b6:930:9a::6) by IA1PR11MB7775.namprd11.prod.outlook.com (2603:10b6:208:3f3::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.29; Mon, 31 Jul 2023 16:32:09 +0000 Received: from CY8PR11MB7290.namprd11.prod.outlook.com ([fe80::1bb0:424:8477:dbfb]) by CY8PR11MB7290.namprd11.prod.outlook.com ([fe80::1bb0:424:8477:dbfb%3]) with mapi id 15.20.6631.043; Mon, 31 Jul 2023 16:32:09 +0000 Date: Mon, 31 Jul 2023 17:32:03 +0100 From: Bruce Richardson To: Stephen Hemminger CC: , Olivier Matz Subject: Re: [PATCH] cmdline: remove cmdline_poll() Message-ID: References: <20230731161232.180420-1-stephen@networkplumber.org> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20230731161232.180420-1-stephen@networkplumber.org> X-ClientProxiedBy: DUZPR01CA0241.eurprd01.prod.exchangelabs.com (2603:10a6:10:4b5::24) To CY8PR11MB7290.namprd11.prod.outlook.com (2603:10b6:930:9a::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY8PR11MB7290:EE_|IA1PR11MB7775:EE_ X-MS-Office365-Filtering-Correlation-Id: c7978d24-7404-446f-b2d4-08db91e3afa4 X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 47i8siLA6SVOW/0bIQiC8Kl/DyTn/HZL1MT1BBX5ZrVhoUG0/Niq2JqtK/FhdFK+Di/ayfFk+jxbRGNwv9tMwaaq1+P2ZJEO8QRztK2fwaYO+gu/ltNgnISmshAaPU1BWWdNyZbZNeF0eSE72U1BfowTtS8dNpd43Tb3yaatPQI0WfjvOIV5RDiiHI4Ee5evD0TWqQb+gj9QVWsKVFtWVYpnoRAckTh/01s1beWyHGYE1ldvqR9vN0Cg6OOOYwTT4Qi4ij2iIv/9F8hHDznKwG5Tw7zXM7KemLKs1IgmmkAj8OPoEVLeHJN5TRSJh6wFI8hkSys7cFXCOvljbiGvYDxW+7Kd1TII0I5LktNYyuYEtla2d1mxQKsJhVh1w9i6OrCe/0ccU606y4Xie75z3dcBRMIz+tHQwSz0ooeIAXrUQETxnL3VCeANut2WHiRTNzwnOPG9P7u8Y4pDS99jsGlC/WzaAvZJ808HevICidBIj58mUIhJOiMlePfQtHAYyp1s8QzvPkqlUKxAibpwdYACF5cZ3/k3hDHcZSLKaXgh6F4GS+BjKGD7FQUDmUR9 X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CY8PR11MB7290.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(136003)(39860400002)(376002)(346002)(396003)(366004)(451199021)(2906002)(316002)(8676002)(8936002)(5660300002)(44832011)(41300700001)(86362001)(6512007)(6666004)(6486002)(478600001)(82960400001)(6506007)(26005)(186003)(83380400001)(66946007)(38100700002)(66556008)(4326008)(6916009)(66476007); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?OLhkn7E0asH7mGuP/vNs07sU/e96ar0Lz5G6cNPgDmCbzbVsdOHDmSbekJG4?= =?us-ascii?Q?t/oS2MVx2AO/Nt+XtBNhvLdKxk1CSrkn6mrny5TzY4Znr3huStnJV4fyQeGD?= =?us-ascii?Q?lrCvDASGpypXRtV4G02ZRvYwg+qRobILXdmJubBJmSZmV5PmQDVF9DnQyJmB?= =?us-ascii?Q?JbeGL5pd3LVWDVNm+WKrgVgSqS1nP34K2Dgy2F0k8cJ+mUJ5vRG86YD8ona6?= =?us-ascii?Q?IGxNSuJQ/QpHWyJxYKxEqyi8lWBe0Z2Rvib46NPRvKJE7kifqBu7AeF+BBLm?= =?us-ascii?Q?ginumMwU53bQVkt+P+2EVfCqgTWE1pjfx0u0Symaw+Yd21c3GmjEJgPf9/Gy?= =?us-ascii?Q?bCm6JzhT5XTFTkOzq7mq9+ny9CDDCpE9JlNKVwI/8NlywjpRLW8h4IKMift5?= =?us-ascii?Q?4VPMjrjE/0RYD3d6ZsZhlCsysEJOi3qcBsP0CgVzzA1O8a8L1QRCGCSgKmzN?= =?us-ascii?Q?p5FmE+B3qqxBz56d33wn41QcX0GSr+xK460nepKr0KlfuDnLGpk52bsYfaKt?= =?us-ascii?Q?Qw6z3tetu3wNmy4JzKOC33M1yJFGBzgON+7qHhJrzQD8wlW0N5HsInuQxoDW?= =?us-ascii?Q?fOCK1QZKZD6wgSq2yI4QEmKVtvX6Vl3m0jvpyKnEwCD1u7KhOC3dYBTKsxXT?= =?us-ascii?Q?7+eJSsJyfwN9RHrtJWKEpbmeRC4JBTjo1OiF/q9Mkq6OfC5s5LsyD8pcZPmg?= =?us-ascii?Q?jC605OP8wkPQaIMULxMI5Oebnl6DCCDlPQd/p+90tBECf8725WfcDDJiBnYr?= =?us-ascii?Q?5wNJ2xjGAt+W0/YCO6awLytApK/5mFXszfTRbCtQCslf50cfHeGwJP/yFutd?= =?us-ascii?Q?05pYHAksJoE5W0cp+vfmVvC9J0GJJ9756SaSwEYH+hwlfgGCiK41cVzgIj4G?= =?us-ascii?Q?2BhT/iSZpYvPQBRBk27abJEp8qnA4U+sINsUuP4YxrmQmfin9Ezvk89Fv5nQ?= =?us-ascii?Q?jJBOG4Uyjf2XA8sKnrQJKk3xCxa9zSMMTL0N8Z+5UqV/mMvJL1y01n5lkszc?= =?us-ascii?Q?bQ10PJiAi3VD2qXaYIS9D8Jvzjvoo+hvG/0biZH5WQHVYotU1WZgU4zY1Zf6?= =?us-ascii?Q?6Hb9Oe3dYVZmX0wjISHX3aQFJJHo/crW8kQYPVVi1mwkPzLLmZHGyqfbeJlS?= =?us-ascii?Q?Y6SJajTJvP7H0Huj67zu04cl5BuTG2FS2+6GdIubSyqg9hXf8ZK721rrzpyA?= =?us-ascii?Q?TSeCJT6UKkND7Zd9tbTcCsvKhOrT+D3t5modFoU0iRmz5/0JYvjYPakG04NO?= =?us-ascii?Q?F/JZ8v4g++u6VM86dRvrs0sCE/6n54qBckCZJHWCzp+3dkJ1pEmEmAjSb+jc?= =?us-ascii?Q?1g4qlP1xKeKrPOZaVoSP50FB4YmtO2wg5Fff9aLPozBK+3Pes+nYePya6jeP?= =?us-ascii?Q?+1eW/8a488amU8ntqh6Up/zpBaUSAol1+mx1RvLVwROxPofhZ5o+nwJ88BAP?= =?us-ascii?Q?Vn3NNARXvgOIyyBoru+yC71pwX/OsScK+Ta2P/0jFdlHgOKQpnGKTAtZnPA5?= =?us-ascii?Q?q3k4qEdetiq+JCfU7rdcD3WQ+C2zJ++a3K3LMk7sOkJwRe/bDRRDhbKw61F4?= =?us-ascii?Q?dGlpWmpNdsux1QmlhZDHYRHMu6OSoAMesKgEHZue2ZLrwQ2oCqn9CDPygZtM?= =?us-ascii?Q?RQ=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: c7978d24-7404-446f-b2d4-08db91e3afa4 X-MS-Exchange-CrossTenant-AuthSource: CY8PR11MB7290.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Jul 2023 16:32:09.5625 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: AAyK+m+CXpxn8WpDtMez86iO2u/IfdPqlenPGAsbr8xV3lbfCemXGqLbZ3WuekSNUpyeM8pXvnWNgup90dbs/S9HR7uYxe8eKaU+H8KTEUA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB7775 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Jul 31, 2023 at 09:12:32AM -0700, Stephen Hemminger wrote: > The API functions cmdline_poll() was unused by any project, > untested, and it was buggy. Remove it from 23.11 release. > > Signed-off-by: Stephen Hemminger > --- > doc/guides/rel_notes/release_23_11.rst | 10 +--- > lib/cmdline/cmdline.c | 34 ------------- > lib/cmdline/cmdline.h | 16 ------ > lib/cmdline/cmdline_os_unix.c | 12 ----- > lib/cmdline/cmdline_os_windows.c | 68 -------------------------- > lib/cmdline/cmdline_private.h | 3 -- > lib/cmdline/version.map | 1 - > 7 files changed, 1 insertion(+), 143 deletions(-) > Acked-by: Bruce Richardson with one comment below > diff --git a/doc/guides/rel_notes/release_23_11.rst b/doc/guides/rel_notes/release_23_11.rst > index 6b4dd21fd0e1..d4c123e5503b 100644 > --- a/doc/guides/rel_notes/release_23_11.rst > +++ b/doc/guides/rel_notes/release_23_11.rst > @@ -59,15 +59,7 @@ New Features > Removed Items > ------------- > > -.. This section should contain removed items in this release. Sample format: > - > - * Add a short 1-2 sentence description of the removed item > - in the past tense. > - > - This section is a comment. Do not overwrite or remove it. > - Also, make sure to start the actual text at the margin. > - ======================================================= > - I believe we keep this boilerplate in place until the finalization of the release. We want to ensure the instructions are read by all who are editing this file.