From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2DDC842FB0; Tue, 1 Aug 2023 11:25:37 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B0AB640A7D; Tue, 1 Aug 2023 11:25:36 +0200 (CEST) Received: from mgamail.intel.com (unknown [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id D5C32400D5 for ; Tue, 1 Aug 2023 11:25:33 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1690881935; x=1722417935; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=YDPuVSJmbtqDfleNbC38F6N+tOu7ylfzV2VYY9sQ3jE=; b=LItztQbRkizG8eGAKhbLeXhHcL4D8w2VldwCtneF37fBcwDgXhf8+TUg 6D9eb7axzRdSr2Rr7xZ8K35CMYkcFBK9LWjACWds/mC3EYOS+XM+3vksW NN8pCIKRpHkW8zENS+jr0f5C549QLziIW5qyAoiUEflTjJfIWE+JfS9cD QK1zdgIha9563tiYL9m5q45VBUKk4Krtfugq/q7QZZAXK+8xxlubyNM44 rzdpM47ljJGa5Fg+/9G1obnqnfPnxao3uc5jTYMMvpoHV9PTi8IWKwatQ /KVmU97IBrd11ZJaLh5Zy0QCKgJh/BTGIVOLptv3SWrOhK2UUOLno/tkp Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10788"; a="433086922" X-IronPort-AV: E=Sophos;i="6.01,246,1684825200"; d="scan'208";a="433086922" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Aug 2023 02:25:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10788"; a="1059325078" X-IronPort-AV: E=Sophos;i="6.01,246,1684825200"; d="scan'208";a="1059325078" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga005.fm.intel.com with ESMTP; 01 Aug 2023 02:25:30 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Tue, 1 Aug 2023 02:25:30 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Tue, 1 Aug 2023 02:25:30 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Tue, 1 Aug 2023 02:25:30 -0700 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.57.46) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Tue, 1 Aug 2023 02:25:29 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=X8R5XWApWRoE5EjrDcajI+e1/ACrCn+nkolfLgNdRxuEFXN5dG3Kv7voQ/h3BvcnllD5P04rGHdwArYXMfypbuZSaPvrCaRmG1rsLXHfb50O5RrPeQlPshz12oqGJmsfo/wRxyFj76jVHgopBxeCqZ9ahnwgmnGGHjpioXUt5aJJaeMkj+RlvxqnVsgpbFmMrmrCqdmFm6wo3H32nhzxFNow7UUlu7jFi6KC6728lQPL4qZ+l2KeSZh0rg3nwjGnqmrqDry+K/wrJsdsRuwbU+xxkbBDGSdnASyp3RlnkIYaSnlUU75o9uktREuAluBiiRID9H97H6rr11mPZQO7Nw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ErQVKIiFL+YmxW0/h48uyYJZLB/sjRgPUg7qB1ahYGY=; b=YLS5F8k39IgP3meExd4UJbGojaq0eZO3s5ieSyV88AQmoj9zU9+rEsYf/fgUpHCdg4QUn8jpVwkHgl/Ral9WVn9rL3CeqaiYB5saSO67MLUs4JJ2oY+xOGXw5sDNKerzXWBjCNkd9YYnqatd/0ziPdCu/KPe2OZL+WgDkFQEwbIRfStejAZ912uxao+HrBUgk9TmuIiCrpDp5rSiKjPJpi4fH+/3XVbGFOkWPoGi/wtspMPr++b6Y1GDvDZuVotUROjVaqhPTf5J2DF/+iWfoMqo0S+DLsN+HAwrKqZ779c4GzmJHamBxzwtqgc2jRU3nWASll0gPIFjWj6UJMpp9w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by CY8PR11MB7827.namprd11.prod.outlook.com (2603:10b6:930:77::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.43; Tue, 1 Aug 2023 09:25:23 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::9802:65f0:c441:780f]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::9802:65f0:c441:780f%7]) with mapi id 15.20.6631.043; Tue, 1 Aug 2023 09:25:23 +0000 Date: Tue, 1 Aug 2023 10:25:16 +0100 From: Bruce Richardson To: David Marchand CC: Subject: Re: [PATCH] build: check drivers class dependencies early Message-ID: References: <20230801085253.2447095-1-david.marchand@redhat.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20230801085253.2447095-1-david.marchand@redhat.com> X-ClientProxiedBy: DB9PR01CA0023.eurprd01.prod.exchangelabs.com (2603:10a6:10:1d8::28) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|CY8PR11MB7827:EE_ X-MS-Office365-Filtering-Correlation-Id: 7ea2fce1-e773-42d7-a892-08db92713b82 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: LMlnbRDZHaVugw4PaHRbO88lBi5/q9umMrk2c1creKqYZjvdF4hsQXHPeMDlM1cNRWUhJeuwRJU6GKb62i9ZGo6T0BtRSI8DM0a+va9+GGgiGOzzj4Db9kgu0kUO/eCIVmhPxgL6oI9bNaqnfNvzNRWgCO1RY8MyuBnwEV/pQ2B+1bB/HDYPS0kiDmFgLdB7oyJS9B/2UFQBIIRwfrKM8xhUAUgnz/OCRxWV3TR+3ZR3Sa3imzS9pyQ0JekOc29g6rVrF3HppAeE2X64PAcqRmVQZSBgjxMfJo8uJcVAYiTWsiTatobX/GAusgnZwGno28vm82EodyWAPfaXl924IJW0om67s2skdaTXiEHYVX/YO0w8CEhtFZXGHHhbvn3HQecaEsB8NzjnbLYw4N9qQ3cTBDPN6FnNud0f3c/7xJBQQYJGRANREl9RvZiIVEJIOedqtkGPgYAWdC/Mjdmy6wBFgGE4e+cJ5/hiPZDRU+KsDiHZdvsgIA14kdstMQjUvwOtKEEHHpBJe60rQ9dulbWfMxbX1DDrDNZnv/Jz/s1XmvCZGu1GFr4TAlgo9fiC X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(136003)(376002)(346002)(39860400002)(366004)(396003)(451199021)(478600001)(38100700002)(82960400001)(86362001)(6512007)(6486002)(6666004)(186003)(26005)(8676002)(8936002)(6506007)(5660300002)(44832011)(4326008)(2906002)(66556008)(6916009)(66946007)(66476007)(41300700001)(316002)(83380400001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?kqzr5UPJFcseJCARpgvz+qVCATIRUalI5IOYLIMHx29u4KCf0idXjrpzimaC?= =?us-ascii?Q?ZHvMu/n1s0khPiPybmABrm1rE+zt9aEB0nTXtZtz6qoYMpUF310NmfYDwH5G?= =?us-ascii?Q?TgBO9sSaMELB1Ub6ECli2LubO/7G6qYno0QSzFwt9Y6h1crY3CK2I0696Mds?= =?us-ascii?Q?P3YG+fj2y/cuvrfo9G02X8iR1z6lemCDA0tqztq1LzuylDLcn/SdGVD5R+h1?= =?us-ascii?Q?TCNHTrAZRpYZcc05MsnJfdLqSSSMxIvpmnPGyGTkx3djh6Zt2QxugjA8ALTY?= =?us-ascii?Q?/75fqJYxTIyS5dY6La5QOgG6MUTIH2LFqugKxxKYMSABasfEhMczJ2MRqDmD?= =?us-ascii?Q?t4Z6ZG25a4blWesEOcdoLsdKWBxgsWTpZkOqL/WI3Npe4YujWZCYl5PZwYf/?= =?us-ascii?Q?4I0gndWuntefDU40jP9fnTktv8+qfcPxmcF2m53UXNQILB6r6IFsNJZ2UVVY?= =?us-ascii?Q?Ustra3DQjLALCtsaz0UV3i35F4GI7cZAMsq9ancvOMprXdNIvBYoEA1hVQV/?= =?us-ascii?Q?sZ3AA+NpeOxtlKu+lx1wAVz7YJzP+hnFR4KgNz2Xo4+Wc7nRJ2dfPh4ScyHN?= =?us-ascii?Q?65xY5Y18GN0M1jzjJ6igLxGCdnuJNAhRlB5Q7uGUZpI0XuTVuSAA4iR/tL8x?= =?us-ascii?Q?41NoBO7055GuCbMR517g94JiZ6DFOiyLjb8QSE7lQFVx4HO5ZQxgfP7Pq56N?= =?us-ascii?Q?nHJoK7BEgEO1gUsGbs/FmT4FSSLlcbPo4DKiXz5VqEeXfd9W3vF+Wbhzpo8Z?= =?us-ascii?Q?LpAGIkmeEPlHVa+tZtXwJMT1sc+Wx8sSX5vAWMhOhp30qpNyaf2/218mJ1Kn?= =?us-ascii?Q?yx7LYWtaD96Qb6i1grxHJRWeRvh7gbWoIgEG3RPkAwyLA95PbWTD2m2eF8xj?= =?us-ascii?Q?kKkE0OOytXjpjPKLc8ps191nQoXQ3pE2jSUfc94IJ0LLrjWJCikaGE9JQKZO?= =?us-ascii?Q?x1vGWma/Ut2fUbeXG6INeOt+86zQY3d8Rfj0V2lfVj01AmchuNss1fYdaBql?= =?us-ascii?Q?2r06MgWSfL7Ugi/QKqAcCjvq/pVBv3MX3P5N3JHnFeYmWl6NLGPCzoiigBrb?= =?us-ascii?Q?7VeOMrKN8Yu/eJeOBqrglBi5/Qej3EQh5uBi5LUi/qYOIDXa3LAm9EB2zezD?= =?us-ascii?Q?nEBbrX4R1aABa9nl4E+onSZiMK34VctJy1+mSfREYf6IAhzoeozbPz/r+NdN?= =?us-ascii?Q?YLjbt3yHtYCTB7JzgLpuCjqzI6YU6XjBc/bL5ApIrc8OG8k2HPU5pRDsFQgm?= =?us-ascii?Q?RkFPaOzM+u15SqxZBGoNF8afo72Tw95lf2gt9TmXwVik3UFYHPAm6rDHe4iQ?= =?us-ascii?Q?HcQ5EEDeR3U4nd0VF19KilqB1qH9ihkIhxfUgSbodCZvOcmjhYrVOPjVk0DP?= =?us-ascii?Q?YyQl1YyO/VBL2pYaCucZvPJiNGPtJQzvZKTPNhtC11MDPJIKewHZDbaM2keT?= =?us-ascii?Q?wCG9n9cIVJr4INdtBesZGu2enD0iZzMlmxQo6Q7WgJMu7ndv0g0dFg+0Vxfc?= =?us-ascii?Q?NNsuWnPh6sE+dSfUQFNYIs+w0RP4SLnQ+nOOJy4lMqwlFEODSG/Zs0WAO4Kx?= =?us-ascii?Q?rUMVQZ/YOS3s/h+AQw9iCOVCf97s4/wfFYBlzT9PTtLSPOWmRTmA/NSU+Qpz?= =?us-ascii?Q?TQ=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 7ea2fce1-e773-42d7-a892-08db92713b82 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Aug 2023 09:25:23.2343 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 30V/8iqdr3Kt2TV+I07uxaWWsSxVRqQ7iVST9g680uy9Z6bizu/lA7cp+2RYsc8cS2S13xmlHQIdu3PcBhEeBeRyefOiQUg6469r3qs3nIg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB7827 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Aug 01, 2023 at 10:52:53AM +0200, David Marchand wrote: > Drivers implementing a class of devices (for example, drivers/event) > depend on the associated abstraction library (lib/eventdev). > This dependency is expressed in the top level meson.build for this class > (drivers/event/meson.build). > > As we are making more libraries optional, custom constructs referencing > the class dependencies in some drivers meson.build (event/dlb2) may break. > > It would be possible to add more checks in those drivers meson.build but > it is more straightforward to not even consider a driver meson.build when > the class dependencies are not met. > > Signed-off-by: David Marchand > --- > drivers/meson.build | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/drivers/meson.build b/drivers/meson.build > index 74ae8cb96b..c375352e77 100644 > --- a/drivers/meson.build > +++ b/drivers/meson.build > @@ -70,6 +70,17 @@ foreach subpath:subdirs > else > class = subpath > subdir(class) > + skip_class = false > + foreach d:std_deps > + if not is_variable('shared_rte_' + d) > + skip_class = true > + message('Disabling all @1@ drivers: missing internal dependency "@0@"' > + .format(d, class)) > + endif > + endforeach > + if skip_class > + continue > + endif > endif > > # save class name on first occurrence I like this approach. However, we do need something in the summary at the end of the build too. Either: * Single message stating all drivers of a given class are skipped * (as now), message for each driver stating that it has been disabled The former is nice as it gives us a shorter summary. The latter is nice because it's consistent with what we have now. Authors choice, which to go for! :-) Thanks. /Bruce