From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5F9D542FB1; Tue, 1 Aug 2023 12:51:10 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4E17D40F16; Tue, 1 Aug 2023 12:51:10 +0200 (CEST) Received: from mgamail.intel.com (unknown [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id 1275940A89 for ; Tue, 1 Aug 2023 12:51:08 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1690887069; x=1722423069; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=+q/znIPpWDz0jfFaqUZJCEMulf8XS6z6j0s7QHKuxVc=; b=fpf2HvIydnrmrGXA8pPpxcANJ0U6JgOQ0NGsY1WCwS6/AbKnGbkBQ+Yt RTLXumXPhLYUDxG72ZCdTpRifPYXbo3B8TIp3RLGj+AgKHx6KgptDYTbw TR1oP2Td6fuTJp3CF9Hs1NEoGZ+f1eNPtbPdMBQcYgjxOEMHjmaLk1VZm Ht65OqxUj2OMT2uDKUwXBJZoqEio6DdLRKnfonUXzETGkjYqhIqdpfVSt 7Do+d28hwj+WKK6fAvQe8QhI6RAie26d9onQXb9SpniShAtUCiCVn4la0 tAQOEITWkR2paIWvqNaD7cVQCaCsG/qNTGaO5R8pLYIJ8n2mDm0CzmKVS w==; X-IronPort-AV: E=McAfee;i="6600,9927,10788"; a="455639238" X-IronPort-AV: E=Sophos;i="6.01,246,1684825200"; d="scan'208";a="455639238" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Aug 2023 03:51:07 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.01,202,1684825200"; d="scan'208";a="872035892" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmsmga001.fm.intel.com with ESMTP; 01 Aug 2023 03:51:09 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Tue, 1 Aug 2023 03:51:06 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Tue, 1 Aug 2023 03:51:06 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Tue, 1 Aug 2023 03:51:06 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.177) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Tue, 1 Aug 2023 03:51:06 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oU9CjG8t/bpa964L3JMmr0LiNY/LlBNvAJ+FxOlN8OKspz2qEUtVTppv8Scil1osXvqzKzeHjq06JiZri4hepJCtKqTBeYglagI03txYg/Y+cuBaHqVCLe2ET1etOFQd7ZhVNnNBIQk80aRiGOEqzwAQkzP+8GjAjwPk09gQRQ2yj3kf3hLN/xcGbc0heUzhB9V8s0xNin1EL8LuM0i+l9mLbxZaHBkNoCHp+3UdXCcSZ4kh9IDQ3E9SWtHOiI/KofUZ7xsIp4VDrd5U3G1OgaZiwE4Byndbil+rn0oxjQpyY+XdeRF4D10cotiaiOs/rCXXy0yFGv+yWn7lepd0/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UukpGP0jZIyQyMbIj7PB8CLDA0q4mWwwJykAptO8kYU=; b=Ef92gFigsM0Lx75RGiyutBSaHa1aUJ2qDAJQSEx5Cgk4Qe4AHlS0alt/GfRZf5ya6ylqMRiLeHs7dYlE8BtNe2ywPNo6t26dx8EOl0aqLS2yytn4H3mQU64gA29AzcGIWI/GRp8sAW4GuvQOAkhunUyWxjI+f9BDTNa01GhigLV2QVPwMeYwgEcdMb+6AmkXqBR90JO1r7/ifMk6ILqSsXoOX3ArWLkCSrnc7LbGd4iHUPDfeOoAqKE4Zx8OaM1XLmKmOXHsVfCHYco0NlfkyyZQmjKBCg0HvHIEr/DUfpMTfjWwcE30QkkrPhp2GMMdoMCdUasYMoj1xdpDCQOO7w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by SJ2PR11MB7519.namprd11.prod.outlook.com (2603:10b6:a03:4c0::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.44; Tue, 1 Aug 2023 10:51:03 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::9802:65f0:c441:780f]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::9802:65f0:c441:780f%7]) with mapi id 15.20.6631.043; Tue, 1 Aug 2023 10:51:03 +0000 Date: Tue, 1 Aug 2023 11:50:56 +0100 From: Bruce Richardson To: David Marchand CC: Patrick Robb , Tyler Retzlaff , , Morten =?iso-8859-1?Q?Br=F8rup?= , Subject: Re: [PATCH v3] build: update DPDK to use C11 standard Message-ID: References: <20230731103858.1491751-1-bruce.richardson@intel.com> <20230731165810.3086571-1-bruce.richardson@intel.com> <20230731170539.GA22098@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: DB7PR02CA0008.eurprd02.prod.outlook.com (2603:10a6:10:52::21) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|SJ2PR11MB7519:EE_ X-MS-Office365-Filtering-Correlation-Id: f0b435b5-c8f4-4b0e-4e08-08db927d334d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: c35hnLzuw/TAOnmnRTDUwcBWZo23An79o92lgSa+XLJZ12mbWUzXzSsaUL1/DYqhNdkSsWj4PP72N1C37fB5WLhqnBDDOh/uooRnj0g7JfHfhDCH2VKEsvHPtQkUmMTYt6Aq5tUiYiNW1MAS/gC7PkWTEBK+3ao4qgQalDnkno6OsUus3C8typIasrK+uu17MyPvZ20cokqD+vIVGXWcJtNDAOmzMLcEQ5vgLMNuaS/cvPi7+fJSo5+bHuHS6codBB1KavyNqla96B3rE54knQ3iKnqYofgafs1iq+6OZSBdIrOA3sZM2RqAT9EUyxQ2m9oxg1ssh8/M2sJNBsEHIDMTWJ1atUh+NJNsZ6benYefPoAAmyXCXwZYlhh+FVbgqylla+ISC8PDNplpPFkj7RuQ7a2Aw1+BHzwZ8+yJIRMuZVDAzt8DrP9IfwB0HEKsM471R/lE92Kmo8SbvlXIW5RtOetzxzV1yHLEI3mF4BsV9zxWkJamJbYpbtjExrr46jBzt8+mlSVA2G0higj9e8jv2eM4Ek/v74RCDFdyvz5WFyb/0Fh74Yf7B1f8ittH X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(396003)(136003)(346002)(39860400002)(366004)(376002)(451199021)(5660300002)(66946007)(66476007)(66556008)(44832011)(316002)(4326008)(41300700001)(54906003)(15650500001)(6916009)(2906002)(478600001)(6666004)(6486002)(8676002)(8936002)(186003)(53546011)(6506007)(26005)(83380400001)(82960400001)(38100700002)(6512007)(86362001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QjJuS3NrdXdYazFROVJESFlibU5ndmkzODB3ZnJ1bWVud0Fuak01R1p6K2p0?= =?utf-8?B?THlZZGxEK0IwVjlTS1ZQTStrYlBkZnpNczcxdklRdU8yaW1UMEwrTTZ6RHo4?= =?utf-8?B?eU1oWVp4clQ5L2l3cWFHdDBQdDI0emFneTFIajhJWXRlU1IwU2dNSDVzTHY1?= =?utf-8?B?MTEwSHJQZmpxTXVISVR0a0RMeHROV3I4YWNNTXREUmpEU21OZmErY2I0ekFD?= =?utf-8?B?ZVhaRS9TRmlTY244dXFqUkVPYXhqZS92eFV5N0ZUWlRNSzV5SVErT0tUdGYw?= =?utf-8?B?VkIzUGtPb2VKMXloVENsTXJKK2NSTWxkbURLOGhjSXJSK0dzOE9wd1ZtUGd0?= =?utf-8?B?SVh0Z2JCWkI0T3RpM2VTM3h1T0Z1ODJGQkVrckRidUJwa0pLaUR1V1AvQ0xP?= =?utf-8?B?b1MrdUp3OWY3ZXVpWmJFQ3dURE00cUlmTi91NE1nVUdzOEk3Q3RHVERmR29w?= =?utf-8?B?Mm8za05VUFI0KzFRenBYWUFCTW5vMWtrMnFwd0dSNEV2L3A0di9UVzVsUnow?= =?utf-8?B?L3g0bERIM21mMWdSY0dpTG82VXdnQ2NOVUZjNGQ1czlPZDBtVXNzejl2Z3NE?= =?utf-8?B?amhUVzZmcmdTRmg2TzhCeE9hQTQ5dVd1Mzd1eW5NczlEc3FYVUE2ZmY0NDJq?= =?utf-8?B?T1lXZU0zWHlSS1MycFgrY0UyRnduamRVMVc0dnk3MEF6ZVVlTVVtcE9XdFFE?= =?utf-8?B?ZDNISFVYK0dUdUxGakpXek1ZdUNMWjBqa29keTZmR2F1VzU4WGlTZXZUWW9s?= =?utf-8?B?TWl5eSs4TVNScWVsYm56SVNzYmRDeno4QndmUHZURmF4NWxhNUVFMjMxNThK?= =?utf-8?B?eDN4M1NOd0N6VGVnMUZvT2hEdFNpdE9uZGlteHkwOXJJelVFNHVPYlZpbmtU?= =?utf-8?B?NW85YzMxcVZHeGFwUDFhZno2aHBrVURVdUlJOEJPRGdQU1R2b0ZTQmZZdW55?= =?utf-8?B?ZDdzL0p4ODRnamVNNS9OdXhCZW1jcG9RdTcxMFArVG53Rm4rT1dnbXJFM1V6?= =?utf-8?B?QVluSmMyYmpUR1gweHFYcHJkWXlEeXEvZ21oWS9MUk9hWnU3R2E3YUVtWm1U?= =?utf-8?B?UjI0c2dxWXVRNzBwblZVUzNBckprOXRjQmpaZ0JiMjZTN3VFN3gwZURSRlRr?= =?utf-8?B?Rk1Cay9uUTNyQVBtVWEveUNvU2dpaTZGZzJ3SjRpNDdaOS9RS01rb1c0bTNw?= =?utf-8?B?ZkhmZFlFYzlVcVI4S0hJUkZqWGhjTFdiYTJxVi9uL3d3OFZObjRORWRMcFpI?= =?utf-8?B?ZUJZTytZWm1zVTlleVRUVmJLNVUrWG13M0JuOGovaGEyNVA3Y003NHoxcHB6?= =?utf-8?B?ZWlwcWw4Kzd6b2FTOVpaV1hoNmtKNFZUdUhJY0tQTEhDM0JCOUdBK0lJdDNG?= =?utf-8?B?RDA0QUlYYnBvOVEyYm5sREtFbXRMdU5JcTZwb21wZVpFTi92Wm5nUUFjYjhF?= =?utf-8?B?K2ViVWJKOFl6a0RnSFMrbFA2RmRqSEowNHlHMHU2c3ZDSWVzQ0lmSm1LckVP?= =?utf-8?B?UGZ4U2w0ekJZVTVsaDNERER6RW84dDlwbkw0OXpDZXRTdmR0aDNSR2NNRXBY?= =?utf-8?B?aE52ZUZxQWFXRWszUGRHZEpsZ09sTkZiRW9sdUZFbWJaaEZJbVpLNGZaamh4?= =?utf-8?B?M3dZOXBmMlRzNnVJT0NlaDdtRGV6RHh2Ny8yaU1PbXZqQVRPOHk5WmdOQ3Bz?= =?utf-8?B?bHBlSnJwU1V2RmtTZkFTUk9OcUNBbGFLQ2RmeS9lbDRIU2dmeEE4MUdld1p0?= =?utf-8?B?UnVLdFhjSnk1N0g1TFplS29mTHk4aC81bWoxaCtqeVM5SkwxMXVyL2EyS0lv?= =?utf-8?B?dkJIaENFNjBwUWdENFdPTTdEbDlQdUUyQmFtekhvTGVOdllTc0RKQUo4cDEv?= =?utf-8?B?a1pnQ0JtejBoWmxqR0N0bnd0bEhYNkhvSjVMeEN0N0Y1dVpsOTY3bzNERTBz?= =?utf-8?B?M0VZU3Fma0h5WlhIK2FUdzdnSzhvckkzVHFLd2hISnJoSDhLVldKeXFIUjNp?= =?utf-8?B?TldhRVQ5cms5TjZUY01BY0poa2JpVzdyTllQaFU1aTV5MWZJQUtYamw3RzZV?= =?utf-8?B?REl4SHdrNldha3lvdm9heEFrWXM4d1FZRTVTU3VxTlJFSVViaDFHUmpjSHh0?= =?utf-8?B?U2xpQ3N6dnBqTW0rY3NRZ1RqaFovdHhON29GYyttL3JHTHl5QkJLNE14RXNw?= =?utf-8?B?K3c9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: f0b435b5-c8f4-4b0e-4e08-08db927d334d X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Aug 2023 10:51:03.4316 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: x0OCAz9r5LuQ7oJK27m9DUZlOICwYcCJkbxpKNVkAJaqBTnLUDE3eoK0FFf9cQA/BviTJU3uSxi8g+xnHubDXeWMVEi6GNBK+LSXOkprHQs= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR11MB7519 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Aug 01, 2023 at 11:39:06AM +0100, Bruce Richardson wrote: > On Tue, Aug 01, 2023 at 12:35:21PM +0200, David Marchand wrote: > > On Tue, Aug 1, 2023 at 12:19 PM Bruce Richardson > > wrote: > > > > > > On Mon, Jul 31, 2023 at 08:39:31PM -0400, Patrick Robb wrote: > > > > Hi Bruce, > > > > I see some failures for this series for our Ubuntu 20.04 containers. > > > > > > > Hi again, > > > > > > I've attempted to reproduce this on my Ubuntu 20.04 VM and failed, > > > everything seems to build ok. > > > > > > Looking through the logs, though, there does appear to be a difference in > > > the configurations in the two cases. I suspect my Ubuntu has an updated > > > verbs package compared to the image you are using. In the log of the failed > > > build, I see: > > > > > > Checking whether type "struct mlx4_wqe_lso_seg" has member "mss_hdr_size" with dependencies libmlx4, libibverbs: NO > > > Configuring mlx4_autoconf.h using configuration > > > > > > While building in my VM, I have: > > > > > > Checking whether type "struct mlx4_wqe_lso_seg" has member "mss_hdr_size" with dependencies libmlx4, libibverbs: YES (cached) > > > Configuring mlx4_autoconf.h using configuration > > > > > > So my verbs mlx4 header has got a different set of definitions to those in > > > the CI machine. My Ubuntu reports as 20.04.6 with libibverbs-dev package > > > version "28.0-1ubuntu1" > > > > > > Can the CI image be updated to latest 20.04 packages? > > > > > > /Bruce > > > > > > > I can reproduce the issue seen at UNH, with a 20.04.6 container and > > the same libibverbs as you: > > ii libibverbs-dev:amd64 28.0-1ubuntu1 > > amd64 Development files for the libibverbs library > > > > So I suspect something is different in container images.. > > > > Pasting the (hopefully) relevant meson logs: > > > > Running compile: > > Working directory: /root/dpdk/build/meson-private/tmp0ovvvd9g > > Command line: ccache cc -I/usr/include/libnl3 > > /root/dpdk/build/meson-private/tmp0ovvvd9g/testfile.c -o > > /root/dpdk/build/meson-private/tmp0ovvvd9g/output.obj -pipe -c > > -D_FILE_OFFSET_BITS=64 -O0 -std=c11 > > > > Code: > > #include > > void bar(void) { > > struct mlx4_wqe_lso_seg foo; > > foo.mss_hdr_size; > > > > }; > > Compiler stdout: > > > > Compiler stderr: > > In file included from /root/dpdk/build/meson-private/tmp0ovvvd9g/testfile.c:1: > > /usr/include/infiniband/mlx4dv.h:176:2: error: unknown type name 'off_t' > > 176 | off_t uar_mmap_offset; > > | ^~~~~ > > > > Checking whether type "struct mlx4_wqe_lso_seg" has member > > "mss_hdr_size" with dependencies libmlx4, libibverbs: NO > > > Thanks. I'll dig some more. I think the meson version may be the culprit here. In my meson log I don't see the -std=c11 flag appended to the test compilation command. Let me downgrade my meson version and see if I can reproduce. /Bruce