From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 956BF42FC4; Thu, 3 Aug 2023 11:53:00 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 803664282D; Thu, 3 Aug 2023 11:53:00 +0200 (CEST) Received: from mgamail.intel.com (unknown [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id 55DED4161A for ; Thu, 3 Aug 2023 11:52:58 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1691056378; x=1722592378; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=YBTOOPETgv4omnWPXT3dEjOB3AgAlzuZhTMJ+0u5uH0=; b=GmSb4vbr7m4iqAEyJtfdT95VRxABOBr15z820JlHyebW1nRP0nF2r9OE DfSTh4LpnP+mSyjWKGUut91DbA41kwnVmdITyZFQfyEQ79OKCHojMV/R7 Vn+MLXSiCaG505CmpDgnXFuTo3dveyVsDVOlbJi4HsfLfQnKQKNvruZ1i KdA5aacX/Ln6pDd1VVMDrV3ceiQ+35GrMgYFLlWs+Sj7sI3O2plclMA7E RMpYrhkYIfcIUcjMxwO4tuT+O8mY6hdpNGjd7EWH8VAEVDnBuOsN8HwqJ GbTAhgxYmBfo93a0ygnoqlPa5KX0COCR9if2s+Im73Q+UQjNrmXL9GWH2 A==; X-IronPort-AV: E=McAfee;i="6600,9927,10790"; a="350121749" X-IronPort-AV: E=Sophos;i="6.01,251,1684825200"; d="scan'208";a="350121749" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Aug 2023 02:52:57 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10790"; a="794937003" X-IronPort-AV: E=Sophos;i="6.01,251,1684825200"; d="scan'208";a="794937003" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga008.fm.intel.com with ESMTP; 03 Aug 2023 02:52:56 -0700 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Thu, 3 Aug 2023 02:52:56 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Thu, 3 Aug 2023 02:52:56 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.41) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Thu, 3 Aug 2023 02:52:56 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lf91qGRjP2IkwRWH3HHOLsyWbWkkfo0/decvrWAGJIkeWLp1wJcsSqRMEBMavgVXXXZWxkCtKJoDvtv5d1jH15tbSOTWo6fs4YENrBfDeWQ3AsbxjTwmIbO9IEcpmtJ/O24IWKAm4KmQuyw3r1F4TzEp4K2ocTnbXhP3wdf63biap42l9TPFFujjoXL7Q2mfbGnd2W/MqHiYmBqdWBejUBob4J+RXsd1L8jU0VbFIRHN1IHlVsHJWpEpYpQZiVNzosb2fp15vYyjH/aLaScR3l2wc4wiJDpf3uZvj3D93ByjrEEukid2G01ou7TCF4t/RdjtPhVSeuyj2WWVyXnq1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cWWQ9iVtHOGZ06//HTv4cf6ecN8OLUqXYmF0FgCZ8FQ=; b=MZAl3tHqiLA96rAubYKq3Zv5n7laYzGbcXUulSVNXJ8+9oNPP1wpoM09zoEf0gKHmQ0vOEPFz4xjO8qeJCIYSINzWnmioqTWB1mHAu2N0LsNnhfYe7LS4OkIGZdoxcMilgmseErBLAsLr91FupUMyTGbtrWPTI7OUioWb/FqodYEAGcPRQkUqhB4h7KG/KEulh/cyrmcrlqNXOtmBalGk8BROJrqw6Jq+M6a9nZCTtOJYx2V4e38o/2ztViEQGmzKqDd9zrtVgMfmnip+sxQzwFJDj/upT9705GpI89Z5YwqQLcevM9xz/P6/m1e/5JJ+MpkrY7SkjSk/5pX21sjCQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by CH3PR11MB8314.namprd11.prod.outlook.com (2603:10b6:610:170::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.47; Thu, 3 Aug 2023 09:52:54 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::9802:65f0:c441:780f]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::9802:65f0:c441:780f%7]) with mapi id 15.20.6631.046; Thu, 3 Aug 2023 09:52:54 +0000 Date: Thu, 3 Aug 2023 10:52:46 +0100 From: Bruce Richardson To: David Marchand CC: , , , , , Anatoly Burakov , Jay Zhou , "Timothy McDaniel" , Julien Aube , Rahul Lakkireddy , Junfeng Guo , Jeroen de Borst , Rushil Gupta , Joshua Washington , Dongdong Liu , Yisen Zhuang , "Maxime Coquelin" , Gaetan Rivet Subject: Re: [PATCH 03/14] bus/pci: find PCI capability Message-ID: References: <20230803075038.307012-1-david.marchand@redhat.com> <20230803075038.307012-4-david.marchand@redhat.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: DB3PR06CA0004.eurprd06.prod.outlook.com (2603:10a6:8:1::17) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|CH3PR11MB8314:EE_ X-MS-Office365-Filtering-Correlation-Id: 1db8f089-db42-4b43-e6c7-08db940768b6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2F4GmgxSAWHqER4pjgMa6C53XzaD7iYMl0pPGEtShgHngBXb/P/nw4Efy8KYDAdlVy/usLRyxapgBv6siGghXFcNHGRdb9o+YHGVYQ17qVCvz0SbMvJiEKZ7TlVpEc46EkPknGlDUaMtql97mUo8R82m09wy0bL7Zu5cWmy5jtQBnhFXlIm1Lo7EGp+UXCkQTRWn0F0y2P1eTeCML4yzfED98mFgi+32rQVJpkS8am+Qv3X+iNhnW6g/xQDhjctKxKOLbB5gyk1lb03dZhEwarQf5B7JAFxbu332zXBMLnKmJB3cDxZ4r+UoRw85fK0inyqbF0iWQYOYOIyBI4+mZ6E0dnU39psccuNX1Z1utRvJ+7Mu4QrxT2XZwWINqSEUFamyfxIgPuL8oGC9hu8dKITdQEDFSApzZNtbzihydJFLOMP7zQ389Pr7c6/Q6ZcUUITE+7yfq4x9ksnfqSJqSEjFGWCkYwEvvp35xL96a+vwim1MTUxLyhdvNmv85vX37U1ckVvYs1Zyj+44xUM/OAajKt7vbON354LZXKpGrZNmiddOpSxcA40Y7t5jL6AY X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(376002)(396003)(366004)(136003)(39860400002)(346002)(451199021)(6506007)(26005)(186003)(41300700001)(4744005)(2906002)(66946007)(4326008)(66476007)(66556008)(5660300002)(6916009)(316002)(44832011)(7416002)(8676002)(8936002)(6666004)(6486002)(6512007)(478600001)(54906003)(38100700002)(82960400001)(86362001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?1E4GvJUzB/Ii6w/Il16RUMXDOrFjE4WXTflJvbsBmCrKzY0sQU9jBhGC3O9q?= =?us-ascii?Q?Cv9oXvOtgJTLHVamOFmjbVhK+fjkj6qo07Iy8CQBUYnUbo+cmR/hsQMrAvKB?= =?us-ascii?Q?7I1UE9qSe9m2RdWg9gn5WmoAtcEFAbhBInkh8AHaMq5UUwXCWSrb/8PDLxL7?= =?us-ascii?Q?Eqn1BYNor+eb6FfP2MsOhh8d3h8nEhoYblg7lwgnwzZ8fXoRD5jTnaDX+lk0?= =?us-ascii?Q?6bLgoPxfkRhD6QN9fbC8DR52a6mkpbb6YQiZ7+GCVsSmdtAv8SkEVR/SC7J+?= =?us-ascii?Q?k1m1ef7cWWP7k+QXoZGfpv1ORJRiOeYDH2Uqp4W7twdJJ5bNcaDoBYO4qNih?= =?us-ascii?Q?x5BYSOSeexZwK2vNQbbtfGSBiG3YimcMhn17f39ELJ0jXYb/H/uBCnJo4XKZ?= =?us-ascii?Q?f/rFANTZvLnFlNHXIJuP/MbeZQHC1zhU6HS0rZ7lG3HR/QJSN3OYgkDBWBrb?= =?us-ascii?Q?AyMyxEF7q6OHPJgCqdyTafqYaS7VrDJaEjGToxIY7gFT0Io+XNdIVJlPe9TX?= =?us-ascii?Q?U79B+bSE65t5SQgC8YTDDhUTLC7QuxXStfPUCqul2M3CW3r8HtSNQ9ef7omk?= =?us-ascii?Q?2w9HW2mQDtHe8M8yMOnTM4+aEeLjgkF1yCRn8XOQRk/Rwjq+xKYdO7Htfv7b?= =?us-ascii?Q?ELrbOQe1i6AFbanjdXgyBwcJuTPk9+oOK646j7sWRdEend1oiBEUezPRimEh?= =?us-ascii?Q?oUIDswjEqAaj+ZwcXXhVBKsDcdW/fN5sMgrum58KKFULmQrnmOEV1I2kvtZa?= =?us-ascii?Q?RdEUwFvDGdKkZvA32svEl+IaktQPkUwCyLQRoeOLcJa9K193jqt5rHwHefaP?= =?us-ascii?Q?YxYjy6va2/k9BvtFDOkgmA16KRwf2MhMHyWEvygNdrwehn9/v69d1+2iH2Mj?= =?us-ascii?Q?f87pBX05I6v7D59bSr+Zyp8U2JHQfjsSX0N90jxixSB88eTp9/sToremP/65?= =?us-ascii?Q?54xQMO0K8ppeYVCrqk2I7zKa+RZjDVxnBBq4kbxPwvR02uWoj+ITycMv4fUL?= =?us-ascii?Q?pbiUA/KvsMkkphwZNjGebRzv5VYNw7JaXDTWUxZMdWUDq/uFPeH1jfVKJFqs?= =?us-ascii?Q?TbN9gLlH59tH74pmVXJG7o4LsuyZXoCwbYwpi+dVa1D+x/5a7w3SiH93n2a4?= =?us-ascii?Q?E8FRZoif5UqpM1y7LChFLjJS9/03HZ+VGR3QXH6qg6iRDIJaz3UHmTSEPRvY?= =?us-ascii?Q?tWlHRKC9G4ZVIcfoxlRwttL1lI8uQom1rXqRg84ohaMamg6aqTeB9zmqoZec?= =?us-ascii?Q?DRICCqIWT4PY3b1xjPbJi5nDUVvtup7XuT1YftyBFQNusqZ4BuRA960YCZvY?= =?us-ascii?Q?8go0eOIIa0e8p5Jvlf69d22LkrsGl6PD7ylNBKw7l2BotOHtxscjgDFkfBSu?= =?us-ascii?Q?P7Wm2W9ZkNUfEhYEVRF5MuFEE841wJi1vAlH1JVOntxsBOKGfBw5ov+FzotW?= =?us-ascii?Q?tmG2K4RTzlvhhARHEdWveGebLoHL4bc2DYM1BIXicfL4l9vNq4X0k5xXuuCK?= =?us-ascii?Q?h2i23oZupWO4NaJeeODmCo0UTkk8N3GBVEAPxXsgJYu1fGPVxzbUC16vg7XI?= =?us-ascii?Q?HyzULF96XhpMHmCkHQcBxdYDXuAOveBvFMPaCz012w/c6kLNy+CPHdUNUwRk?= =?us-ascii?Q?xg=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 1db8f089-db42-4b43-e6c7-08db940768b6 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Aug 2023 09:52:54.7740 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: HU8S0vcf8mENSL39ljYIbA/y/csMgMGjaW5sXRQkUSY7De9ZqmCcUcnVmHSWcIzK7U2/cZrwK6AlEXE1nMFrg+/OJCsYjBSy7TTylB0Rf5U= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB8314 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Aug 03, 2023 at 10:49:54AM +0100, Bruce Richardson wrote: > On Thu, Aug 03, 2023 at 09:50:26AM +0200, David Marchand wrote: > > Introduce two helpers so that drivers stop reinventing the wheel. > > Use it in existing drivers. > > > > Can you give a little more context on the new helpers and the changes in > the patch? A lot of the changes are not that self-explanatory. > Reading through the patch a second time, I get a better idea of what is happening, and it looks fine [though still think a little more detail is needed in the log] Acked-by: Bruce Richardson