From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8054942FC4; Thu, 3 Aug 2023 10:15:59 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 72ADB43254; Thu, 3 Aug 2023 10:15:59 +0200 (CEST) Received: from mgamail.intel.com (unknown [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id C298C43245 for ; Thu, 3 Aug 2023 10:15:56 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1691050557; x=1722586557; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=09p6maqCfSUOYzYYHzaNTkcOFkW3sWbwRR9Rhb7hvtQ=; b=JtSXdgBlykpafU9qvofFNxRj71mRDS+56lJ1sNFzQrYJhzTaAy7Juv2h WCnmu23naD9Y0Lan4eR92u11gefYi0NizUFC+paw2Krea50HcqOzqpH/K 06huh/i9xlgh2Ibc6WJMqysvWOeLguLFV4V57owrNy4Ope3O5D2+p23/O 8pjTEv+lOiIdA58JH8ah1Vs7U4Ntpn3g4VsGLdOfgOVUwOqTxbSCf/jgv RdSfR21/P3GwTe+zG4x9WotD0ietlmBueQ0rFkpxeY62A3CmCImNQNApy HHArZS4+vGLEljk8TIHFPJoxa164wBBsUN21Q9jx1lcL4Vv4X3dLqUzup A==; X-IronPort-AV: E=McAfee;i="6600,9927,10790"; a="354718621" X-IronPort-AV: E=Sophos;i="6.01,251,1684825200"; d="scan'208";a="354718621" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Aug 2023 01:15:39 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10790"; a="732662110" X-IronPort-AV: E=Sophos;i="6.01,251,1684825200"; d="scan'208";a="732662110" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga007.fm.intel.com with ESMTP; 03 Aug 2023 01:15:38 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Thu, 3 Aug 2023 01:15:38 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Thu, 3 Aug 2023 01:15:37 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Thu, 3 Aug 2023 01:15:37 -0700 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (104.47.56.47) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Thu, 3 Aug 2023 01:15:37 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MK8lsa4pxaFN1Oo8c7Sw5vo2SnwwVDBktvXAjCN36qLh5QmxVPyg4ipDqFblMcBH/lOCWgPxyiZwJnXkmefGNpseEtnV+gAjfBRjFG+GP6yifJ20iMPiMQ7aq003xr3B44mh8StqSixN9X7BxSnQ9dwyMVN7qGOue5nl86u/gbi5q+kCRAI27fnnIt6n7fOsUj5IcIze7d33Z5e/wEmaVCkC1w7PWYzcTiG46A3I2zE0OS7hY20eTYJ+uEoDjvDulmFOcY+K8S0aa30PkM0xHm4mxqQkX+2zKAIA9KlxcrkmPW61Sn4flk4MLJIaBo3jbLV1aORhQEN7Ufkn6B6SqA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=i+/HBCeU+ulhsmquNZyzyFxVJxErgYTJZPVdgLp33a4=; b=C2GRPgO5CNC8ls3o4km1dtCw98jmW2A7uPrKX6fhcmIEF/tctFeE3a10YcCr40D2GupdXEk9KvmvfjjhFzCx7wavWpCURae8xVgIUCeKufSmM08YAxLvdHe36HkFPJrBoeUlhd3G6iIqsjCeJHpY3QXmXhtCE/8H4cwsBlV1gumKn0gQZoSq1HkB2Gax9KW/2SbDewGo+RJF3rvwHr/EtfGi3IxIzpp1o+HPUJR318JM7yNR3Is367PIga3PAZ9ScK38+1D4plKeRim25CZ+SsQHhBDQry+saWn8IkTw/7cshz9wPX094jkx6JVbNNpxUXLlTg+3QWXT2GSPu0jfoA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by DM4PR11MB5486.namprd11.prod.outlook.com (2603:10b6:5:39e::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.20; Thu, 3 Aug 2023 08:15:35 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::9802:65f0:c441:780f]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::9802:65f0:c441:780f%7]) with mapi id 15.20.6631.046; Thu, 3 Aug 2023 08:15:35 +0000 Date: Thu, 3 Aug 2023 09:15:29 +0100 From: Bruce Richardson To: Tyler Retzlaff CC: , Ciara Power Subject: Re: [PATCH] telemetry: avoid truncation of strlcpy return before check Message-ID: References: <1691011261-5666-1-git-send-email-roretzla@linux.microsoft.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1691011261-5666-1-git-send-email-roretzla@linux.microsoft.com> X-ClientProxiedBy: DB8PR03CA0017.eurprd03.prod.outlook.com (2603:10a6:10:be::30) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|DM4PR11MB5486:EE_ X-MS-Office365-Filtering-Correlation-Id: 2db5f42a-4111-4721-b870-08db93f9d038 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Y9hDyssRDyCaWqp6F+31V+K7X1GBvwiEbRII6ri19qdutxQ0Gu0pybCMbH1oXluc//WIDqswS15BsfxwQG7VdtWkINi3MVyQ3pDoD5JM6W0X+/dukDj2Ry/Dihcdwaq5hS40HbQeNp3jp5lZwk0BIsjOZQ2ceBsrm805agG2oD3J17g0N5OxFPh6c2YISgy4CWtCyde11cEAdDy4XcFYQ0W7DNYep+3YBuphPWtP7F42pr8xjYd86M0Bdfyw7KqztnEX18r/5Rbd+XaIsXvouQBTL0plIy8T5DOAfdxvUvbcnch8hZq5Pflhvj4PadSrUsAEwBlwE2u+OZczZlQ6hAzBhEh+axSiuRqx3jeM8tfy0VVMao+ReV95eY2lRA5I/G+EgN7zOTp/RpguRb139u6gKeDnIsyzsN2rQm8w3f1JX2KpD9f0PYz077MC3KHEt/gbNOKIlA8eiQG47tdhIDBQjcLMAvXAlXJcIxqZEcsOTUy8YW+SyP6ehEP+COmwIufF68H42RCBtGaJkEAbvHh1y47NxiPnHKww8hkhyGs3aZaK2LzH79tVn87nO9F6KbnBgbDRx4VqPvZaa1Kdh86vtpxyvr60HSRmOsRG1iE= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(136003)(396003)(39860400002)(346002)(376002)(366004)(451199021)(83380400001)(2906002)(44832011)(86362001)(38100700002)(82960400001)(41300700001)(107886003)(6666004)(6486002)(6512007)(66476007)(316002)(4326008)(6916009)(66946007)(66556008)(26005)(6506007)(5660300002)(478600001)(186003)(8676002)(8936002)(67856001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?26OLMmNJ5SjiA6zlxjQS06stkHk0HWjg4i9m+0HVWSWKIpkbxuw0u86pofEw?= =?us-ascii?Q?Q2Q2M9xxAmd+FgX8LbenOwsZ8+ZqcKjw/17DXhR2AvqyLNhdYa0yNzXXguma?= =?us-ascii?Q?M9YZoS8SfwEKyZqTfwTbjegfIh0hubudHRdpQ7fHqVvUGo2tf9Rs1NS0oBv7?= =?us-ascii?Q?VRJdZgd1QVlt6A35lTqL5R7bWmYn4jFX1xit+h2VzE0cXCvXavNC7P4+r3jV?= =?us-ascii?Q?+NdNlWXK5zxj2H4TPtAudegPt0V9c9BDZ53nZshTk5xcBQhz0xMdV6X3xUG4?= =?us-ascii?Q?B1/q3DaZcw37BgGUzpNMG2wo64ss/gnZjXbJ0i6g7KOuiReNTMetXUYHRb1b?= =?us-ascii?Q?E1fSRHlrVT0Cnya5n0S9iq7m+vuI3mdSQkJIpNgBUukQkISLImqc3blRLhe3?= =?us-ascii?Q?MOAsCoqmX13WWyJFNgKROWfH52QtUss5rmcUDHTpTzrpc/hsaADZPj9EzoJz?= =?us-ascii?Q?5Jo8/btI2ABPeb0ge3dT5M6SOdKDT8KG8mnN5k057ihqZQTxYR3hRsOd0Nyv?= =?us-ascii?Q?ckzRMQpBj39wg/4ylh1JsEmvOYf/FVDYrrvnkMAAHtMM2GfkeDFHHKjioGlG?= =?us-ascii?Q?YMPjtP7sDbhRm12rE5zUsDSu+V4fhxgZIGsOYBpAD+zZHDOeZRrZ/JH1XdI7?= =?us-ascii?Q?McEPwaQ1bEU7tyu9Oi8X2T4TI/rRLErNU6TRoCZKUYxBTDdmghMeGIHEtbFS?= =?us-ascii?Q?mcZFxofQwC+XiBndRdIz5+3GI8g9/XkiGZCESKhOEif1zAS0cNq8Ay/rIT86?= =?us-ascii?Q?j0WAHK43Hjd81VNRWyex7JJlk4Psew3NyEG03u2Q2S3BzXqImPLYNiACJx5k?= =?us-ascii?Q?bRJVIGp6l25RXX3UItmRLfpmFREM8pWLvlmwon3FLWqpfJ4DR9wuY9tw/Yx/?= =?us-ascii?Q?vcPV8pJ8TIvoDkN5vCUyCXmZ6fSGL0iX07IKsjZc4q8LjXP68Ek8OznNmqoZ?= =?us-ascii?Q?2zD5VeBgfOTxSkILrViapiHQzkzw349e8WUw7YnhmlC/C06g2JurRHgC+jP3?= =?us-ascii?Q?c4/Xu23QjEmJUIjzrkICKHBjl+vM6VuxRxNSM9C1FK1tr9AnOV/rJF+5VAVK?= =?us-ascii?Q?uNY9Remn1WYuWpukKdI62a4ekHrKkgo7Ri6d82yPj9+k0aubQTl3qsPFH5w2?= =?us-ascii?Q?0uvh4BVbFKhHQqJRCgmS9dTR7LBKzbxOk6ZIa9cOJFHz/vGls0gklR+B01bk?= =?us-ascii?Q?l+gJozAa71B22MEBDfFs8L35zXQIRr5P1IPcNogLLh8s27/pcEmvYjoeNIBR?= =?us-ascii?Q?0smWjtBT5TLzhhYUd0ISOI45wQvp4vDmyv6AQjiloccTOI9CrfnKiBBv5MWa?= =?us-ascii?Q?4KWZgun21YFpEk/eVq+Wp+gXaM319WaAgCkoQ4hmZyIHsZrQ8FqZqh3lDkTK?= =?us-ascii?Q?UFH4+GK5shlaN43S9znIINQ2dcxRlL+qQN42/tAUgRuhPYHmq8oKicU0NCBO?= =?us-ascii?Q?ijYnT+yChkuDaHkiKXrB3iBe8Skly5kQRUt+VoW4LVWNz0tHl+XlLP25ejiR?= =?us-ascii?Q?IxFjKglA3bYDrXyAiECUwOLaVo1TT+UA7ZkKbOTvxRCrV/OUeuV/UIK0tgT3?= =?us-ascii?Q?YSBuA+MqLGL0BtRoOioGZ2g/e52CBwqiLJDdJ70KP1gjwNQ5FvlxDWQ+2ACe?= =?us-ascii?Q?aw=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 2db5f42a-4111-4721-b870-08db93f9d038 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Aug 2023 08:15:35.4883 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: zkr3c4hGIJ8/1NkMaiSviaGEYtIdKewcIGpUtlUBpAygMtl1oGBNG8WKrs3VLDF0tY+jRtpIu4fzv1MevjLUgGR/8rXLvUxQ3QlohsooYrw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5486 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Aug 02, 2023 at 02:21:01PM -0700, Tyler Retzlaff wrote: > strlcpy returns type size_t when directly assigning to > struct rte_tel_data data_len field it may be truncated leading to > compromised length check that follows > > Since the limit in the check is < UINT_MAX the value returned is > safe to be cast to unsigned int (which may be narrower than size_t) > but only after being checked against RTE_TEL_MAX_SINGLE_STRING_LEN > > Signed-off-by: Tyler Retzlaff > --- Acked-by: Bruce Richardson This probably should be marked as a fix for backport. > lib/telemetry/telemetry_data.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/lib/telemetry/telemetry_data.c b/lib/telemetry/telemetry_data.c > index 3b1a240..52307cb 100644 > --- a/lib/telemetry/telemetry_data.c > +++ b/lib/telemetry/telemetry_data.c > @@ -41,12 +41,13 @@ > int > rte_tel_data_string(struct rte_tel_data *d, const char *str) > { > + const size_t len = strlcpy(d->data.str, str, sizeof(d->data.str)); > d->type = TEL_STRING; > - d->data_len = strlcpy(d->data.str, str, sizeof(d->data.str)); > - if (d->data_len >= RTE_TEL_MAX_SINGLE_STRING_LEN) { > + if (len >= RTE_TEL_MAX_SINGLE_STRING_LEN) { > d->data_len = RTE_TEL_MAX_SINGLE_STRING_LEN - 1; > return E2BIG; /* not necessarily and error, just truncation */ > } > + d->data_len = (unsigned int)len; > return 0; > } > > -- > 1.8.3.1 >