From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C461343007; Tue, 8 Aug 2023 10:09:42 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 557C043247; Tue, 8 Aug 2023 10:09:42 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id 4E97040A87 for ; Tue, 8 Aug 2023 10:09:39 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1691482180; x=1723018180; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=UdVJQ36MzKoiAdYgH0sQGMwlC60DhHXB6844bzWAMxY=; b=RI+NMA68OdVJViRkWsnelt1Did/wSEkMN0jMQXjn8vNzpDb8/opBGf/x pPExUPbmxQM0TtXrh4S5Jid1V2ML8Ck/zyfnptX+tbHLJ0a7mH9rTW5qr F4P7bFv8CDfS/zR25PYOAcHlCPOpoBlKg45D4rc4+LSpc2VzuVqf4JTQk Kp68bvJ4CW7RzZe+ZY/Y5xo2X8DRJlYGI2SN7Mj/K/C8KN+DqDFhzQ+tJ GaQhawMG5qPLux2j2YPq5t1eLx1MnmzIa6hqC9shki1gRVaza6ELaIsOd 7R1f07QMExHGhY9oZTbNmlr4U1ggNRYTVQwpPXq4N9btNhkgbtcuALs7D g==; X-IronPort-AV: E=McAfee;i="6600,9927,10795"; a="360845285" X-IronPort-AV: E=Sophos;i="6.01,263,1684825200"; d="scan'208";a="360845285" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Aug 2023 01:07:45 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10795"; a="681157469" X-IronPort-AV: E=Sophos;i="6.01,263,1684825200"; d="scan'208";a="681157469" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga003.jf.intel.com with ESMTP; 08 Aug 2023 01:07:45 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Tue, 8 Aug 2023 01:07:44 -0700 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Tue, 8 Aug 2023 01:07:44 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Tue, 8 Aug 2023 01:07:44 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.109) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Tue, 8 Aug 2023 01:07:44 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=b5sRfYdFtE4h0nyqdhIQGNoUznQ2U5KkRx1crqzcUz9Rzhk2K26Md6FfMA+OCTvBOLDWPh6zgShs2m/53956nBtuyle4Hjw129RfCgikKUA9Ws51gD57ERD0I5e5HCfOCJXR9yaROgLHcsKOKY2fRCRVahAwJhuy4PdACuWTea1OxARb4RAGZliNVJMbE9r6+uypwS1wgwVi34FrYbgRkXTGAB1dvd34KhMRaDlBFbFBH6NgmATSB8LjnMyfCVQJNQGDq0tGc3CkgY2VSjXdgvUuIPMuaa/9jclx2uS5w8TAEaMgOIDMRl6gqAyA9fgKRp+O/p3rYqHkW9B4xE6kxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=R+OGuNF+vMt2UebZmrf57CUepmqx95Azxpe66jjb7zA=; b=HDMyDkrCUgPw4L6CLi1p0q04c+6kSaM8LR/z7bAVJyT8/2+M41zwdA+0BiLYut+L9sce5nbsK5ajM3YeuOnLhXEXdb3KO7M7FhMa1+gden83qxIeyI1l0uRjeyFpvNvnLWGdOqGaFMBhbGojmrdTD6PW3PSJsQgrzbLaNKx/w6rX8x+OxqvQ5lWG8FATRLFg/CKUNtDa+wYiTU3REWtcXkwF/MdUQNnHkNYoCp+FaMCkrau2PAxzkQdSYjzz/2KI6KnmkR1G5pzghVCRoWj39FBRA8JoNYYZSckLomeAVhNZZXqXhJ6JUmvsHkl9VgD+9FRmfXR2p75sEn8OfeXu1Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by DS0PR11MB8666.namprd11.prod.outlook.com (2603:10b6:8:1bd::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.26; Tue, 8 Aug 2023 08:07:37 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::9802:65f0:c441:780f]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::9802:65f0:c441:780f%7]) with mapi id 15.20.6652.026; Tue, 8 Aug 2023 08:07:37 +0000 Date: Tue, 8 Aug 2023 09:07:30 +0100 From: Bruce Richardson To: David Marchand CC: , Morten =?iso-8859-1?Q?Br=F8rup?= , Tyler Retzlaff Subject: Re: [PATCH v2] build: check drivers class dependencies early Message-ID: References: <20230801085253.2447095-1-david.marchand@redhat.com> <20230801134133.2860104-1-david.marchand@redhat.com> Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: DUZPR01CA0198.eurprd01.prod.exchangelabs.com (2603:10a6:10:4b6::29) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|DS0PR11MB8666:EE_ X-MS-Office365-Filtering-Correlation-Id: 158d4425-bf4a-481e-bd9a-08db97e68723 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: XnhZLC4dcXP/aEzriEbn2UDCy3GFZtw2sqWJy5W2L2Cs2H8JzqSZTsTZslPrIbWO5RuLy9RvMZ/beESakHSNou5232+6WsVVBNHrK4Al9OYF7ErlEhQdWUnCzA79QW9cuAfhDNofJrrZJsPegvn9uJxPExOQHl9UiNChy8xFJx1WfFwc3shXhA5q7ENDr9uAcpIV2gbj3Q4X3U60dIMB+30pp+WM3v6RMDTDi9o6E02vzp4/HMBKkdoWvP58oSa7om53S0DokOVnS58mCWGLQ04Gt8hgAkLfB6X6rC9gbr+fsolkpHvXr+IwzU8Uty2u7Pf0QEtZ6ucgSThP17PRl05aKsV0C+xwkgJqei5tAM+naR0h/AttCH3rK5HpzrLSn7iN6i+o0jvFcxb9w/6wyvpxXRwQApj29+onuVwCtueBYGGzlAHpRSM1Vy11Lmho0Jp7u/2jIsDIfgA2Veb3KOw5WxQCbirRBove9hhrZF0wvtE2InHMSeXiu/NDNXC0b2lfjrTibjEsc4i2iMhDpoAq4KZ5FuKq/o+vHt1t8aPUNJGPlsLAxLc6gs1jhThI/NFFmsAOXv91X2mZN/L8phvUGqyXUfFBnLqEyfb9IbaNB1nWWBZYvscYXFIG62KLnqIYXSSHNfC0pFY/04dkbg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(366004)(396003)(376002)(136003)(39860400002)(346002)(90021799007)(451199021)(186006)(1800799003)(90011799007)(6512007)(4326008)(316002)(6916009)(86362001)(6506007)(53546011)(82960400001)(38100700002)(54906003)(66946007)(478600001)(6486002)(66476007)(6666004)(66556008)(41300700001)(26005)(8676002)(8936002)(2906002)(5660300002)(44832011); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Z1FjQnAzMGhhSnB2Y0VITG1PQlI2d2xrSVVFTUo2TmhEbVJUamgyYmZZSkFk?= =?utf-8?B?a1AvRG9TWEhZR29jUFc5TmFYd01pRVdSRDVWOXA4d2tOU3pTUDQyV1BtN0Z2?= =?utf-8?B?UTFmb3IxRnhmbFNMQTFYd29QR1d1UEdQeDI5dUF1WEJ3YXRlczhYWkZFMHNm?= =?utf-8?B?cWhaRjR6ZFR3c2tURVB2QkJwZnV3dkRYNDkrbkdqcWkxWXhuWEptK29rU29Y?= =?utf-8?B?YjdLcGNhaWUrZUR5ZE1qbGJyKzkrV29FSU1VWUdvRXBwU1dMV2dXaHhtVFpV?= =?utf-8?B?OHRZZ0Q1RUZUSDIrKzJPeEZkalBUWWVRWkZQVUNPYWM3TUpVSUZNYlowVmJt?= =?utf-8?B?SlNCN1hIZFIvRUdoZE5WdDNEV243QjJaNEt3REtWME84UXE0U3lnVkFrQzBC?= =?utf-8?B?dGtUUWVjZlNoOENPc1Rrcmt2R3luSG1kWjlEVkxsOWhjN1RwSFlMeENjcEVN?= =?utf-8?B?L25LSC9ubVFrWjVyaks4R09jR000TnlOYXhOb1BGeTRiV0VrNXdJeDc3aHZr?= =?utf-8?B?SGJqNlJ6S0VCMERNcjEvYXNoQUpvaHhOVWp2NHd6bUVaT0dOSVBqWkpudnJ3?= =?utf-8?B?TW5XeGFObXhnOE45OTZJbHdBSGJ5RG53L1J2R3pTM2VreUNjcDl1MjEwam1z?= =?utf-8?B?MUlwbXhjNnRNQ21lbEVka08zd1I2bmxBR25tajBPdlRjcHpCajR4ekp0Q0oz?= =?utf-8?B?WURtR1FrZkdBVnVHbVVWTnMySFlDY3YyTndJeWkrcmNBaHozcUorSWtwRlRx?= =?utf-8?B?V01RcHJuaXloa2FBTEozNVdpNWFGeC82UnhKbStGb25nc1JGYklmUnRKZUNY?= =?utf-8?B?dW8wMUZNTEpIN3ZJVU9UNHE4a0ZHUjRzSFpQQ0VxK1ZrdUtVUUM0SzhmNm1R?= =?utf-8?B?b2dUMndKMllpSnlkbWF4dkNKWEhCOVVKTklFWjBGb2ZkR1JiK3Axc2NLNHl2?= =?utf-8?B?c004d3BuRkFtZWVOVEc5aGxzeDZkd1kzczZoVHY5TVZoR2ZNSGZmZ2phaXNq?= =?utf-8?B?Z1FUaTQ3OWRrb2xpV0JabVFndXRTODlhQnZmTjNTZ1diT2ZVNTl3a2w5REhx?= =?utf-8?B?eFhUeDZaa0hQS1cwYjFFaE1aeXlZclZCbEs4MVRZWFlObjNJL01YTzlzQXZo?= =?utf-8?B?LzZBVkFuNHF2MjFaVGNyYUJJczYwLzVtTmg4T0VSYVBrSEJVU1pCeDZCRll5?= =?utf-8?B?czRCRGdOblZCQ0ZDS0Yzb1VXUnI0MkJRK1JSd1Y5NXVYc240QjdwNHZYeDZ3?= =?utf-8?B?Z0ZjTFVKTVFiY3IyaWdCdzYyeWN3WEIxVlBkeDJ6ZVhBYXNXRS93WHBDanJV?= =?utf-8?B?SDY5dzJJekVTMDF6NHExSVo4RVljSVkxUUhmMnh3eDNSQ0hQNWpvTlliYWVH?= =?utf-8?B?QVlQWmdxelY4aTlVVHVvckNyL0g2VW1OTjYzOUkrQ09OVXZoNEV2V1BGOFpm?= =?utf-8?B?RnJpanExWDBlc3VPSERRcGx6Y21BdHVta043ZERTOGtHVUs1U3BXVmphY3JW?= =?utf-8?B?LzRQcUhwcWhJY2Y5QStqNVRRcERZTkFoMXZyUFExYjhpL0g5QnFDaUpiWmJ1?= =?utf-8?B?dmN6ZnAxRHgyK0g4UCtkUlE4eWZmZlNHTjVDQWVzcDJ4a09sVTJLNjRMT0lT?= =?utf-8?B?Mng5QVRqWDBhbE1BK0xMYmRtS2lwKzZ5VTdtWnZpQXI1RmxVby9YVnV6YW5G?= =?utf-8?B?TFNZVTJaUnJySjlaYmJtempXMXc3dzlNMDZOMFo0djRrY0dNV0lmbzU5Lzk3?= =?utf-8?B?ZDFPd0hTVktzeUlzOHdCTzI3WUY2czczV3pVUjBSTGlYcGJISnhUdE1DVTEz?= =?utf-8?B?cU1sUjNZV1dva3k5NnBqcUpRMWdZSExldTJUWEl5ZnJVZW5yZXVSbFFCZ2Fp?= =?utf-8?B?MGhHWG1SbHQweXhCZktKRHhUWjlFOUhjaXlFbWNETjc4WFJ6NkZzUExGWDFF?= =?utf-8?B?VXM0dGRZM2JmSnozZlV5RWtQclBSd3JrMWNCZ0dmaTVUS2thbFAwNVZ0UUhr?= =?utf-8?B?SWNXVjVZK1c5eEN2RzJyaW1hWGhWU01SNnVORzN1YXhlcWdRNFlsdFN1R3Na?= =?utf-8?B?d2RtVnhVQ0V6akZUaVJSL2s1UGxFSWdXTEh1UW5CRm1qS3czVnBLNUVxWE5p?= =?utf-8?B?T2lOL1lOamh1alFPZkFjUTZmS1hJYVRhM3YvdlU1MFFXZC9ib0l3ZFRoN1du?= =?utf-8?B?SFE9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 158d4425-bf4a-481e-bd9a-08db97e68723 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Aug 2023 08:07:37.2961 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: cQtLf9IrQbYDK1gcA0Gz/w3ALr/B8ANIfOSTqNs38tHILAIMcYcem5xZgMYikBOrFiwumEHZNGhpgXZZ34yuk6s0Rp+dNy1i6KqFxASqzSc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB8666 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Aug 08, 2023 at 09:43:25AM +0200, David Marchand wrote: > On Tue, Aug 1, 2023 at 3:41 PM David Marchand wrote: > > > > Drivers implementing a class of devices (for example, drivers/event) > > depend on the associated abstraction library (lib/eventdev). > > This dependency is expressed in the top level meson.build for this class > > (drivers/event/meson.build). > > > > As we are making more libraries optional, custom constructs referencing > > the class dependencies in some drivers meson.build (event/dlb2) may break. > > > > It would be possible to add more checks in those drivers meson.build but > > it is more straightforward to not even consider a driver meson.build when > > the class dependencies are not met. > > > > Signed-off-by: David Marchand > > Acked-by: Morten Brørup > Acked-by: Bruce Richardson > Acked-by: Tyler Retzlaff > > Applied, thanks. > > Bruce, could you rebase your series marking more libraries optional? > There is some conflicts after removal of kni/flow_classify, and adding > a unit test (perf reasm). > Yes, I plan to do so. However, I think I'd rather defer that set until after the set reworking the build of the tests completely. It makes everything a lot simpler in that regard. In fact, I may merge the two sets into one. /Bruce