From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 34E224300F; Tue, 8 Aug 2023 20:35:40 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BCE8742B71; Tue, 8 Aug 2023 20:35:39 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id EBFE941148 for ; Tue, 8 Aug 2023 20:35:37 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1691519738; x=1723055738; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=d5qfPCcUZYJ58r3h5YgZbpgwYecNX0myfU5Ev1Q51yY=; b=aY5b0SutyTqhLil9U/pg1tscu2SVObPC3Ytu1EID9JI+35iESErU/RAU daJcn16wmxmE1plN6aPfJqiw3IANDRYYQMyHT/GHZtg3PPH1xf/TE0LBH J+ZInTvAs5prGfzoi9PEHCITevoxpNU1tiNxt5S+2RlTVnJflV1dcYyo8 WxKGVWNj8zcuJouHf2fM2fEocVz2FKmQggtD1LRqYCZTd8yT0VtmPKXV+ N3ql/yn5AiPAdcreTPy8J23AYBrjQJLA+1TBou4dnf1GVh6F0uIKDgEOk 8Y0CSAP3RW3Hp6Pfroq8UV/Wzamt93ryDxG+cgb5GoFecA745dPvBL0cF w==; X-IronPort-AV: E=McAfee;i="6600,9927,10795"; a="370910457" X-IronPort-AV: E=Sophos;i="6.01,157,1684825200"; d="scan'208";a="370910457" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Aug 2023 11:35:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10795"; a="734673989" X-IronPort-AV: E=Sophos;i="6.01,157,1684825200"; d="scan'208";a="734673989" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga007.fm.intel.com with ESMTP; 08 Aug 2023 11:35:36 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Tue, 8 Aug 2023 11:35:36 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Tue, 8 Aug 2023 11:35:35 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Tue, 8 Aug 2023 11:35:35 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.104) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Tue, 8 Aug 2023 11:35:35 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mla6DXJ35PiEMpImzaBTEWFjZBf8XDARAmysSqZQasv0/4LFJ5eUy8ejx7AnO6+bQbJ95dLCmz4HFVrwwnb6vqdMONCXUnAJPskoz4x3jjMd5WvuQmp9CwJIDE+oC/GNUtGGFOF4DBAj84A2HHDZCSAHn2TUeL54+xNCjCcYvojVBNymWddHxQqFAmaTHXduUqu59zV/dXOfWIfelMYzQtHO1c/ozHGOSHNhfOwkPGRTlYFlVaEeSnYYgypVZ+tQFj0mznbET5wCH09H1+aD583182nJAqfmmdIZUHJ7YYPoykjrHkavIewnOkLuRSWV8qcGosnmLq6ZgRScbE9Gjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GFqRkPFg2G0+pp7cul1RtXecRx1cngTdqJHv9/JIVSA=; b=TMp/HWasGgodjf9OgpERsi6DXvbxA0NawPVSNCIK2p1I6Q3qhdJ4qHojbf0CyS4UK9Fo0vkzaMKuiC4Swz1lVxz40zrYY5lxyebF+9+kABymemymCs+57R8fwmiM+Xo9vwZH+ofLcTqhF7ABauTd6VXo90K9uzB4o/18g6TxUGQ3bSxB9EoMn6/ne8g/WSOPbyrmy/fsJfpi1TQ/fCwB6pUblwQ5mtMP2M20fbarvEfNh3XCf7F56O66K9yOOxCWeTMGEl9WnatDx2k3W7EjlITdPr/b2quKfdvuEaDRpTUDy1li95cFBLyF3QzEDWk8+w1n53AFZXLzyCS6Fq/bWw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by DM4PR11MB5567.namprd11.prod.outlook.com (2603:10b6:5:39a::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.27; Tue, 8 Aug 2023 18:35:34 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::9802:65f0:c441:780f]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::9802:65f0:c441:780f%7]) with mapi id 15.20.6652.026; Tue, 8 Aug 2023 18:35:34 +0000 Date: Tue, 8 Aug 2023 19:35:28 +0100 From: Bruce Richardson To: Tyler Retzlaff CC: "lihuisong (C)" , , Ciara Power Subject: Re: [PATCH] telemetry: avoid truncation of strlcpy return before check Message-ID: References: <1691011261-5666-1-git-send-email-roretzla@linux.microsoft.com> <35199239-fac5-f7f2-6f80-5070b016d7d6@huawei.com> <20230808175937.GA13736@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230808175937.GA13736@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> X-ClientProxiedBy: DB3PR08CA0023.eurprd08.prod.outlook.com (2603:10a6:8::36) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|DM4PR11MB5567:EE_ X-MS-Office365-Filtering-Correlation-Id: 40031652-1394-4a54-074c-08db983e40bc X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: y7X/t7921dP6qEwQxgOy5SENDmBsZ51WfZmzmQxiYqDjd5fusAvrj0UPB9z7iskzy3I2XEqd0XZrC/xxfZqz1/e3CPTvYVgom/D/I7vXU1HcIQZB87W+4i36bZ2eIco2l1/4hdmnHdy0ZyuvFqMq+rY8cCdmF/q2B1SdaBZOhw30NJcYvg6gy3y+fPgQ2sYHEZrROGz0j3LzHOBJJYtViezIN1vWMtXUQPwoML0zSD9Sytj/0y8pXK9XFTOav3gM2FTAJZ2wK2LRvC9jjphIG0+G/4YoEjpFU03QFRpCZlb4RzwlH6UD0mSbVeTswbpoTv88wvrmuwLd/pwB2auHwRybQlwKXJhkxRCqeVQgU60uJiur68wYTZ45s6luzxk5b0+1a4uYmFZaCJX9wfjVp2f+xxq+j88y6kqf0CgmDP76kIxgFXygJarpLRKmTdw59bIshVpnSWN5z16MICR8a3MVQWOXCJnoLatTEG6LiFMiXye1TSC1hc/91/AyzQNS0QNV7uWjnmE7JcoWwUMNQvuQsZjgvYC7EbyCXpWhYIk2voltjPvfHTYEj5Yl9GNpY6jS5e36R6LFUqO5im5iMRgZ9v4mxq+3FWK99Ea4qRo= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(39860400002)(366004)(136003)(396003)(346002)(376002)(1800799003)(186006)(451199021)(26005)(107886003)(6506007)(6512007)(6486002)(6666004)(478600001)(38100700002)(82960400001)(54906003)(66476007)(66556008)(66946007)(6916009)(4326008)(41300700001)(316002)(8936002)(8676002)(5660300002)(44832011)(2906002)(83380400001)(86362001)(67856001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N3JkUTNBdzdQOHFJamFMNjEyNm1iNUF6N2F4TjlETi9HSnMrRWdkMTFCU3M1?= =?utf-8?B?akU5R0FGV0NJL0NVUGh2aTBxbVl2M2FhU1B4aTdpVjhVdFFWUkc1YWlKeGZH?= =?utf-8?B?c2RFaTBWM1Buc2xVMlRwQ3JvVnpXK0dlbXJSN3VlbHJhV3A4bEIvcUh4ZFVE?= =?utf-8?B?K1daOU9KYnlxZmppRXVKWHVrU2NIVjQ1Rm1hNnZGMnFGUE1aaXc5RVh4Nkhm?= =?utf-8?B?RjF5YWczQU8wbXdHaFdLKzJURXIreHVzRDZJd2x6WE1PTy9hNC9zTDUxLzRM?= =?utf-8?B?T20wYzdzV0tqZUNRMG9OVXE4OFNRa0VxQzR2NU5pZUhNb0FGYStqb2tNK0ov?= =?utf-8?B?VzI4T2MxWnRQbnRNd28rSW4vR1VpYUZkdjFmTGZhSVBxaVRiWjBVUmtweUtV?= =?utf-8?B?bjFxazFXL2NkVUpSVlR2OTkrRGxDNnBJZ1U5NHRZN2htblRLL2xJV2pqRm5K?= =?utf-8?B?L1U3OVNLaDV0enJqU2E1UUJkaS9FeVJQQjRaN2xHWXRNVGRIekcvL1BVSmVi?= =?utf-8?B?WkJGS1BTWmd3TkIrVXZ3STA5Yk9JMGpSd2ZxcFFidHJBU1VXQTBLQXJRWVBO?= =?utf-8?B?SGlGbkZWbG9FUVF2VlYyWHVyUE1sNlZNN0JUamFQMWhEK3BocHRhTFZ1TEQw?= =?utf-8?B?dkYzaUhJT1Ivd3k4VlZaZFZyVk1CV3BTWDN5UXhDK25GV2pQUGtFY0kxZE1F?= =?utf-8?B?L3FVS3QrbUhsWU4vMFFqSmR5VGJKSG5LcFhpcFZaMEQ0RW9iWURrTG9EUGZj?= =?utf-8?B?NE42bTYra0lZZysxUGoyMERNREY1Z01wei9lR2lETGJqWVdkU2NEZFY5cnZa?= =?utf-8?B?R3RvY0tPdWVhZWpOLzJYQkszbjNBWWQ3V0FVODBrSFVLaHRiSGhoSHJWS0d1?= =?utf-8?B?V0dIYnQzV2RTcTY3a2JYUHdKaGpJSnl6dHdNVXk5L2xUSW9RQVZIWThWd2lh?= =?utf-8?B?ZEJwU29URXNDVE9reE1obEFsZVZkaHV0VG8vOXBqWWYvQVhsQ2JUejhVRG9k?= =?utf-8?B?UkJGZ3F5OStKSWtUWnBuVml6ZDhwc1l2VG93eVRpdzFUU0ZxMnl5QjE3ekVZ?= =?utf-8?B?eW8yZkNWZ2JZVjZUaVBianlPbzZJTll0dTFuc1VIRWxDWGw5b0FIOHhmeXJU?= =?utf-8?B?TUcrU01UWGQ1MmlWNlc4Rk5vZ1NhSEhsNk04VXhFTXZaakhxdUMvczFJd25W?= =?utf-8?B?RTZkMm9kU21sekc1Y29PVWVKeHhBUXUyNGlxb0cyWE96MFpiaE9FUy8rRjIz?= =?utf-8?B?Vzd6S1FEV3pvdmlGS1c4UEdxdTk3MFVMdkNZU2JzdWk0VFNlVU5mQW02bmZY?= =?utf-8?B?OTdvV1QrNmFHdG14NTlJeVJCNGNKSWNsWEl2dnBlZllTdmVwcTMzM3Axb2Uv?= =?utf-8?B?dytUWVp5aVJsWVZOaStHcTY3ckNkUnhSdTJvYy9Td0VrYVEvY1Rod0o4UXp3?= =?utf-8?B?VUowOXRuWHJHdHhMdU9GQ1YzSm1RckZpTlc1YWNkNzhxMVRCMmdiSm42Z2Z3?= =?utf-8?B?c1p2MUNXallKMEtJUkVFNTVjSUVmNkhLNDlrQ1gwcDBzM09NdkNsUVpUSVVX?= =?utf-8?B?RVVMRjhiSDR3WVpZSE12ZUNPaGsvQUhUcUgvNFM2TWl1eHFBRUQ1VytQYjgv?= =?utf-8?B?Q01DQi9rNUhVa0JHeXEzT1dPMjZhMG9BeVJaOURlUVBtZTBEMHl5OFM5VW5D?= =?utf-8?B?NndBaG5MYmxCcmlVYjloY0FuQzdnbVR1a05VMDJJNzFDdDlrSVJGVDh6OWxQ?= =?utf-8?B?akVWSzNSbVNqWlFlQW5Eb2ZsOEIzWFlCVVF1NTVnTDNDMzhKNHR3bnFaNWN6?= =?utf-8?B?cEg5K1VJdFo3bjF0OXBFRERnN0hyM3VKeWlWUW5xK21tUkZzSExFSDVFcDVw?= =?utf-8?B?Rm1IeXEvMkJhR25WVU13UzFlU2UrczN3OEp4VjkxSHJSY2hnSmVPKzAzSGtS?= =?utf-8?B?cFNnV2FqaithTVkrUmpCbnFJNm9aaWgzWk4xaEVFQ25jQnZtVFFLRVZJMUg2?= =?utf-8?B?NlBIY2s4ekl5cG5pZnRmZW94bzhoa3hFZk56VWFQdVhGL3VtSVErTDE1SU5K?= =?utf-8?B?WS9OT0NuN2IyKzAvVmRZRjRjc3JKc2ZJMkt1YnpzdW1WZUZiWHA5UVZ3d21T?= =?utf-8?B?T2ZHV0tudmxEdHFEaGlMcytlYUp4Z0gyNFN1b05sVHlYWTNZN2pDVDNpUHZk?= =?utf-8?B?Ymc9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 40031652-1394-4a54-074c-08db983e40bc X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Aug 2023 18:35:34.6856 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: BmlfiZqVEch9N5+pejhCTdDefGKry8wVcwreH0wRdMQ3xVO4jHDajfhTONgDO0VVjdPyBAGBXNQY2ZjFNFT8zEpJDh7ToVQ0cf118UkFa/U= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5567 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Aug 08, 2023 at 10:59:37AM -0700, Tyler Retzlaff wrote: > On Tue, Aug 08, 2023 at 10:24:41AM +0800, lihuisong (C) wrote: > > > > 在 2023/8/3 5:21, Tyler Retzlaff 写道: > > >strlcpy returns type size_t when directly assigning to > > >struct rte_tel_data data_len field it may be truncated leading to > > >compromised length check that follows > > > > > >Since the limit in the check is < UINT_MAX the value returned is > > >safe to be cast to unsigned int (which may be narrower than size_t) > > >but only after being checked against RTE_TEL_MAX_SINGLE_STRING_LEN > > > > > >Signed-off-by: Tyler Retzlaff > > >--- > > > lib/telemetry/telemetry_data.c | 5 +++-- > > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > > >diff --git a/lib/telemetry/telemetry_data.c b/lib/telemetry/telemetry_data.c > > >index 3b1a240..52307cb 100644 > > >--- a/lib/telemetry/telemetry_data.c > > >+++ b/lib/telemetry/telemetry_data.c > > >@@ -41,12 +41,13 @@ > > > int > > > rte_tel_data_string(struct rte_tel_data *d, const char *str) > > > { > > >+ const size_t len = strlcpy(d->data.str, str, sizeof(d->data.str)); > > sizeof(d->data.str) is equal to RTE_TEL_MAX_SINGLE_STRING_LEN(8192). > > So It seems that this truncation probably will not happen. > > agreed, regardless the data type choices permit a size that exceeds the > range of the narrower type and the assignment results in a warning being > generated on some targets. that's why the truncating cast is safe to > add. > > none of this would be necessary if data_len had been appropriately typed > as size_t. Bruce should we be changing the type instead since we are in > 23.11 merge window...? > I'm fine either way, to be honest.