From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C93954302C; Thu, 10 Aug 2023 18:40:22 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 63ABC42D12; Thu, 10 Aug 2023 18:40:22 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id 4157940691 for ; Thu, 10 Aug 2023 18:40:20 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1691685620; x=1723221620; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=lUBXcvR79/S1liX5r9JXT+964aNUCmEffNJyV768BTA=; b=HFFT93sHEpZJkY/FGLW3d1ZHzngGp3IwgIo0FGaZtlYPtK1DflO+Q8Jj aKplVSFljO1yIl3qZR1B4206YgZRavu4oAFIbM89lOnk6sD5xyVXu/1nn uc7cdtqlLqDQht9DU3VQrp2RoWSDzuCAO4C32xK4Dn7IQYIAEEzqQBwQ4 JGR4t1e58aESClHzPjnHOrFZxBV6VgEZilkXPZgVdOP2pBvAOee/3pHNp QtREZoYEKfv450LxH89MkxdNvVp0iYhlh1Cp3+R/yHjfxVdQjwoZXyVVO VGprvap0vF8G9+M+lSA1Qfk/9jkpbRRLFRWFH1XNmHd6GM6Yh3A2tITlG Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10798"; a="457828267" X-IronPort-AV: E=Sophos;i="6.01,162,1684825200"; d="scan'208";a="457828267" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Aug 2023 09:35:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10798"; a="735480714" X-IronPort-AV: E=Sophos;i="6.01,162,1684825200"; d="scan'208";a="735480714" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga007.fm.intel.com with ESMTP; 10 Aug 2023 09:35:58 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Thu, 10 Aug 2023 09:35:57 -0700 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Thu, 10 Aug 2023 09:35:57 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Thu, 10 Aug 2023 09:35:57 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.175) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Thu, 10 Aug 2023 09:35:57 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=etNNnolNHACgUZzUPsZHwdNk/vp99bbNHkF9VozG0IlryThsH3JNcCVquSGa8tgd+fJyfHdgotCEt0qN+a2sszIqeTWmNX+nv0Rrc3PyBbP2izg1fVzNec4ACEAINTxP2kUDeHNrjjmRDqPwRqes2oTPFFXLeKaBpGw9nCWqeXCmKppPPxszNZA3yI4sUzuB6alsAj/moSiPFTsFpeV/rqWmuGtI92PDbvA9PZS5mSwd/JKq2A3zt0UpfsJ3HyJ6v5S0Um7713PGHRVXbQFU/B9LH+AkSkI6PsLdZDT1ZLxG1gurNV0IU3KJbMc7Z3UnXWM1rkrfBSUMoSLsjtwB2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=idrHjO0k43n13CJosbpDkvRtoomZcDDba83IebzNyc4=; b=W7NPvxPOo8FiKc7J8BksV98teE48hxNe7PvC/yRfXfD2kBjpGFbAc8EG3i+4mTOFNLYVuwJ8F9hn5QohOH/h9zuhBDXKSCmAcF0riJBLxq6iDz5D8IeIlrhcR/4A8ejn7iBqPoT7CSoJ5p5+wsoHK7/HP0xrgro1Y1Zu4YEG9YHf0GLdUyWu5/oUs1UEmksoMH0LB8uGpht2RPO7K0OVNSt+5cCfwuBD4rJFBOPEt7I4gkTrQYcAHMhFV7TuD2w9RwepwsXv3KOd/mRLDTAPiPcWdT0xwGRc3W8iifiF86S2erxx3+C4OaKCEaq8EjioupkI8C+RvagOnuEfv0V5QQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by CY5PR11MB6260.namprd11.prod.outlook.com (2603:10b6:930:23::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.30; Thu, 10 Aug 2023 16:35:55 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::9802:65f0:c441:780f]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::9802:65f0:c441:780f%7]) with mapi id 15.20.6652.029; Thu, 10 Aug 2023 16:35:55 +0000 Date: Thu, 10 Aug 2023 17:35:49 +0100 From: Bruce Richardson To: Stephen Hemminger CC: Thomas Monjalon , David Marchand , , Morten =?iso-8859-1?Q?Br=F8rup?= , Tyler Retzlaff , Ali Alnubani , Subject: Re: [PATCH v5] build: update DPDK to use C11 standard Message-ID: References: <20230731103858.1491751-1-bruce.richardson@intel.com> <20230802123134.370199-1-bruce.richardson@intel.com> <10316692.qUNvkh4Gvn@thomas> <20230810074839.446f655d@hermes.local> Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230810074839.446f655d@hermes.local> X-ClientProxiedBy: DUZPR01CA0049.eurprd01.prod.exchangelabs.com (2603:10a6:10:469::9) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|CY5PR11MB6260:EE_ X-MS-Office365-Filtering-Correlation-Id: 65453db4-fb4b-4ea4-0b09-08db99bfde6e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: PmcQIRUfA53HiSR5x4LkBP13bfqTPB3ro40SXDnyApV2YI1V/RXg8ivoeURr8RevnBRBohOuket21bcamWQcezREwP/gIdbKLSqAWo6Q458du47h+Jz09d8kN3gWhRqq6aOSJNA76rqDZBL9jfsQXIZEBC9/xK7r1q4xmRc7vtRmjkoT2bS4ffdND1gAARmRt5sCvJYHkoQUPI1Qr1WPI5k0+2UmibES62KeQMrW65Y3tIHcIsOlIquoDYJxKGa6XDY0gbFfhj+zEToNdc0jKDgpGDgu1p6qMRID68iditT1oAtsRLdPRGIkm8m7untKSx/OsuDwV9eWDKE6PvW+XauhMG66UW2zxd+gGdt1fbxlMVMfvvUN7ed8cEYAKdohgYtZiHWD54VK/7nUJTON3T0AJkBQKvWgkqOnAD96pSam1JBuapORNmYhLbLSp/hHrqkskV6SKxobG4V6bnPgcFjtRrdKl+KLKPBqADj4MD+ezEnciwW1KpqmYqlQctPmT2/xeWn1XMYrgv6zjOgEBxgdWTTc33OJCSW4/ELO7+RxJ/Xqt0Qkoa3Yqbs8v2NE X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(396003)(366004)(346002)(136003)(376002)(39860400002)(451199021)(1800799006)(186006)(478600001)(44832011)(86362001)(66574015)(83380400001)(6512007)(6666004)(15650500001)(2906002)(6486002)(53546011)(26005)(6506007)(38100700002)(41300700001)(316002)(82960400001)(66946007)(6916009)(66556008)(66476007)(4326008)(5660300002)(54906003)(8676002)(8936002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SmJvbWJmS3Zqb1k0UFUyeUdoQ3h3a0RTTU5QTVNzYWZmUTAxcEdSdjBHQmhk?= =?utf-8?B?clVnUG81SVhKNWtsZGdlQzVoUkVhSE1nVkpBamVadENKMHpRNnhZR05sMFF1?= =?utf-8?B?VHRkR043MUJSK21JeFhoUXY0RWx4M0tiR3NxNXlHQ0U3ZmZBRE9jVjA2OFZm?= =?utf-8?B?YmRlS2lYQkFMbzdLS0RFK0M0c2RRL2RZNW1CNWNBNkIrUFpGRWEweHNlbHZC?= =?utf-8?B?K2Y3Z05BdWdxNTBLeE1HYnRRcDV2dXI4R0RkSmRneENpRk5WaGEvWW9lTHlR?= =?utf-8?B?VkM4QlU5cHJzd3MzOGhXWDhDdWIwM3R5QWlMaGJuYjdKbVRic29EbWNZSmJi?= =?utf-8?B?WmRDcUhYLzRMRUt4b3R6QUd0MmZpcEY2LytkTlA2MTZUeTZ3Ym91WkQ4R205?= =?utf-8?B?a3FEb0FXcjFzT1NDWkxNeElrb1B2SlNKZlFRKzRqYXFTZ01YYWhlalZPUmNJ?= =?utf-8?B?Vk0xamNMMVdjdUNHblJPamxBNDU1aUFDaGwzSkx4Yk1MMWlZZHNtaWVoTGdR?= =?utf-8?B?dXZkMFNlVFcvd3UwaUZFNHVrOFp0OXorTC8rd1VibXhJSmxLQ1JiblhnQUhY?= =?utf-8?B?M2tKNUhtOW5WT3hpcUZ0MGRoaVFCeEpuNGpMdm5KUlZWdktEWnZrL284YVor?= =?utf-8?B?bEZHbEhJNDNFK0dsOVZsUldUSWNBRVgvSk1KY0VDLzBac1VVd1NWWlA1QVlm?= =?utf-8?B?dUJJakh3QUFlcm00VlQ4NkdaZ3RzVmV6VGxCUThGejIzM0ExMEw3OUkyMUNX?= =?utf-8?B?ZTRISjkwYjVnT1ZiZGpUOUV6Z2txd1doV2p3QVRkSXhYeDFFM0NVK0tHMjI3?= =?utf-8?B?NmY3YmVnMGZVUE1BNFkva2hNNGxTWGI0OEoyanFyVzdndWZtSkhDdEIrRzVD?= =?utf-8?B?QUMreEh0L0tQbUQ4NHRVYjdXODQxVzFBK2MwR2xFeUlLakRrVDFTM0VzeWJw?= =?utf-8?B?cDNoZTR3dnNBVWJhaEpXQUh4TnIzalI3emhuZ0VvdlliRkJpVnk0MjBDcjFv?= =?utf-8?B?VTFIMFBucHh5Nk9COTJqVk9EYnl5VTdmeUc5YmdEck5zNmtvSGZiWEJ2bDNU?= =?utf-8?B?SG9wZ1FmYkE2bjJqejdkVzA1N0lTeWJycEJjNnBneTNUUDUxb2RaZ2E5S3F1?= =?utf-8?B?K0hmRVNXNVJ6eG1BWTdKSUJNTDJOYkVzRWZwcXBNQ2xCNnAwREVBaExTMC9z?= =?utf-8?B?S05KbGZUOWJvVDhaaytNalp1N1NBcUZUZGhiY1Bpc1pEVGxLcS8waTFKSXFQ?= =?utf-8?B?a05sTFUwTEl0VW9QYkcyVWQ3Z3F0K1MvZDJUZ3Nkd3pIYjZvUGV3WFVDS2xG?= =?utf-8?B?aUZMUU9hVG81NXYvSTV0WGZJdEQydVpSMGxmNVBGd1ZTblByNkxiTnJmdVlR?= =?utf-8?B?OE43aXV4RkovRVlpRG5qY1pvUjRiSFUrWU5PWlJvc21MR0xCTzc2Uk9iMHF0?= =?utf-8?B?cFR5UGd0ZUkvYy9hdGlXcVFJTGJlVlpNcG1QSjBoeVRibk8xcFo5TEY0ZUJo?= =?utf-8?B?MDVlN3NiNFFqVGNhM1dPN0J6WitpTnQ1QkdoTm9IYVpyR0N0WGhaaDdjUTFN?= =?utf-8?B?QnRzZWNyN3o3NUxGenRMdE9NdUxGdFhXSHU1YWk0S1hMTWlPSS83dEF1aWFy?= =?utf-8?B?ZlF6Wlh5WWZEdHdCMW9jVU9zRStDcituempVSVl6TXovWlhHc2lXQUJ0ME1v?= =?utf-8?B?OUxzMWtEUkd4SnFHUGkzbC9oY2FoeFowcmxZVTlSSlRyeVc0c2h2bDh6N2dY?= =?utf-8?B?RHJXTFZQcEdnTThmMEdSWm5CZTdFdmVZRW81b2NUemdMNjZlQjhKYWJ3bThr?= =?utf-8?B?Q0V1U1E3T09zTU9kYkVJOXRVMUo0Sk9wMGhSbUNXVlAwNFZXOWMwa2J6Lytx?= =?utf-8?B?Z0pDbDFndy9zVTY0RituWUFtblNnK0MwS0kyY1VZRXF5SGtQeHQ5MVBmZ0Ex?= =?utf-8?B?aGZQaGJKZXhkcVpmVFlYTG5RcTZjQlBQamt0bTcwUEpwVUdROHFUbnorWXlP?= =?utf-8?B?NzJCVGh4a0ZjejlwUlNUMDRNTkVWY3A2S3g5cmw4NzhDYXVZbVVQNWdpREFn?= =?utf-8?B?TENoV0lpR1BDMVFna1JSdDFLd0VFNTNsMGNoOVhFa002RTZjdytDY25iNkp3?= =?utf-8?B?UnFKZHNrR2dnOXVkY2UyeEJ6aG9lMUlTVHFoVW1jU01Xbkdzd0dSeU43aGc0?= =?utf-8?B?UVE9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 65453db4-fb4b-4ea4-0b09-08db99bfde6e X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Aug 2023 16:35:55.4147 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +qwctb3c2eKKYs5wW37mjbSgLTBYF2OjmH3iOcfguWXPrUTNdRL4r6LNZ7ORb8lJwNDm/w5UdSmIWqYCfCkuML85VgphLTZPThgEMaQs1s0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR11MB6260 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Aug 10, 2023 at 07:48:39AM -0700, Stephen Hemminger wrote: > On Thu, 10 Aug 2023 15:34:43 +0200 > Thomas Monjalon wrote: > > > 03/08/2023 15:36, David Marchand: > > > On Wed, Aug 2, 2023 at 2:32 PM Bruce Richardson > > > wrote: > > > > > > > > As previously announced, DPDK 23.11 will require a C11 supporting > > > > compiler and will use the C11 standard in all builds. > > > > > > > > Forcing use of the C standard, rather than the standard with > > > > GNU extensions, means that some posix definitions which are not in > > > > the C standard are unavailable by default. We fix this by ensuring > > > > the correct defines or cflags are passed to the components that > > > > need them. > > > > > > > > Signed-off-by: Bruce Richardson > > > > Acked-by: Morten Brørup > > > > Acked-by: Tyler Retzlaff > > > Tested-by: Ali Alnubani > > > > > > The CI results look good. > > > > > > Applied, thanks! > > > > The compiler support is updated, that's fine. > > Should we go further and document some major Linux distributions? > > One concern is to make clear RHEL 7 is not supported anymore. > > Should it be a release note? > > Well, DPDK currently is still building fine on Centos 7 for me, so let's hold off on claiming anything until it's definitely broken. > > > > Should be addressed in linux/sys_reqs.rst as well as deprecation notice. > Also, is it possible to add automated check in build for compiler version? I'd be a little careful about what we claim, and I think current docs are accurate vs our original plans. What we didn't plan to support was the GCC and Clang compiler versions in RHEL 7, but if one installs an updated GCC, for example, the build should be fine on RHEL 7. Now, though, we are having to re-evaluate our use of stdatomics, which means we may not actually break RHEL 7 compatibility after all. We'll have to "watch this space" as the saying goes! Overall, I think the approach of build-time checks is the best, but not for specific versions, but instead for capabilities. If/when we add support for stdatomics to DPDK builds on Linux/BSD, at that point we put in the initial compiler checks a suitable check for them being present and output a suitable error if not found. /Bruce