From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 20E984305E; Mon, 14 Aug 2023 10:27:15 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EA30C40A7F; Mon, 14 Aug 2023 10:27:14 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id E531C4021F for ; Mon, 14 Aug 2023 10:27:13 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1692001634; x=1723537634; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=4T2t4xYcqQh+YUX8JL9e416/7CyC8FT0u1AyFdmsnIw=; b=RqaTo9dvl8zImf2qDxgTVYzER0D3o8Y0SdFusmd2QPwLZ/jyzVYl/+6R d7B7BGbtSHHj3SSkywnux6LwnWXBzlyqHHRu6zIw59Rv79xuPJH0pHoFz nR2vWTC7DY3hZGwu8y1t2LSv7V7HBC4EbwVg7qFYBHLrSaWsQpDVriA9/ y8tmHFwoF0iRw7kbBiJ84Zp5wkBz9Xu+NcOfyTtjVze8U5JeCYIHY/8zb Jw4JqyYjUhTUTnu3TyN9Tz9hbJJJD/GOJaEcllV+Re0pHyYQU/40UQPBZ tZ3tDM7y2MYRPid1ZhD2y3hZGV+Ckv1WfKp83+OcGW3pIytX8B32DddsC g==; X-IronPort-AV: E=McAfee;i="6600,9927,10801"; a="371991773" X-IronPort-AV: E=Sophos;i="6.01,172,1684825200"; d="scan'208";a="371991773" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Aug 2023 01:27:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10801"; a="726941832" X-IronPort-AV: E=Sophos;i="6.01,172,1684825200"; d="scan'208";a="726941832" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga007.jf.intel.com with ESMTP; 14 Aug 2023 01:27:12 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Mon, 14 Aug 2023 01:27:12 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Mon, 14 Aug 2023 01:27:11 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Mon, 14 Aug 2023 01:27:11 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.44) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Mon, 14 Aug 2023 01:27:11 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=X76hh4jAxkXwsJZ8q/N60nnwi9vM7aAB74R1m0xyrkcgWOy0RhBQ/97CJSTnMthqsviwCXYNWfwlz9+KnhGCmXwFkA7MJw1TaiPwrpVXhG56rSwNI0OeeQmWtGkgjHsqalHUw4tZEo3B38MVnbVzuJCXOMOmPAjSc0p499p7C1wMqnJcT32UOppa2lTuF0EOyvwBOJH2oYgZ8P03rMB9dupXgsyss5iss9lez/eLpacebuArz4ffJUG47m1rBOrsr0qD9tghR9ojrVwP59LnTVUNni/R4w6QKapcP5icBXVuDT7yxIjEjQ2mqPJ4+Ib/7gWV20pbhE/ajjpW1IRpNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1kp6Ui+lLywhfaZLOIujo/TBEDg49GGbHIM8UC9CTBA=; b=kUipafGAggWrj+XudDT3sh8DC8Z0hXlY8hz3OA8YkByMtEm0JYWIvBEVvQGYUX8IEt43jwfkAU5Eh/X3i5hBRxhLXURlwKNyh5QtUQ8wbnbR4Ossm4kK9S8U+Jvn1EaCYsuwdD2I3vx7x36N9Kk1MxSyb0vdB6wh1KvWj9YX/etgh5cTH7rikWkaDMWMlHrURhHDIfNDhyXC5Xc7Vs8raFiAIlDTp5sznoTnheGu5CjPX8I6350Hyeeedx19/9rUNfE4ya+VAZ4eS32DYFXRcXn+oA1Pn61KRBXIXfZdMZO/KZuHa6Yha8+JICOuT/De00dYzvbV8Oj8yfSqPmqK0g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by MW3PR11MB4714.namprd11.prod.outlook.com (2603:10b6:303:5d::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6678.24; Mon, 14 Aug 2023 08:27:10 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::9802:65f0:c441:780f]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::9802:65f0:c441:780f%7]) with mapi id 15.20.6678.022; Mon, 14 Aug 2023 08:27:09 +0000 Date: Mon, 14 Aug 2023 09:27:03 +0100 From: Bruce Richardson To: Tyler Retzlaff CC: , Konstantin Ananyev , , Subject: Re: [PATCH v4 1/4] build: unblock the use of the MSVC compiler Message-ID: References: <1674674707-3094-1-git-send-email-roretzla@linux.microsoft.com> <1691778287-15746-1-git-send-email-roretzla@linux.microsoft.com> <1691778287-15746-2-git-send-email-roretzla@linux.microsoft.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1691778287-15746-2-git-send-email-roretzla@linux.microsoft.com> X-ClientProxiedBy: DUZPR01CA0184.eurprd01.prod.exchangelabs.com (2603:10a6:10:4b3::7) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|MW3PR11MB4714:EE_ X-MS-Office365-Filtering-Correlation-Id: 27978718-a76e-48f1-8df9-08db9ca04029 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: XnMMRSQCHYHdnOVx16IOPLYrTKNQnJ2g1qfNJXbyO25R5PXH1V1EiGLpYbSfowtJgEyf/8OM6at0Hd1dBUdhh54dCF+KrtFK7KtKGXHgJ+/NDR5CzAJ3Tn+oXqA4+vHMz7Mg9fJwo+01+fh8hgWRrHT0MPobu4ivTgLMJ5wsmgqEmzWwmpPcYu+IOethupNxgCPwAAKVaaKGkSKaoiABTEc+E7mHZH+/24+vXaoTJpbwH08e/EmiswgyoGMlN6LAMyxqE0PVxgm7EmG0af41QTQD4CKOUc+GST9taKmqmoTAn+TDBSb+Rs/LW5IvLxh4sqIoB4gaquRM0K6UiVLPJ2QT5rSW3flgIfUiLm4pj6x4ImOhlNK8MT6IHZIlLNP715VB6XloZZirpHtaE0MVzi4DhpGkabRAn2OFyrlmpXRsJFGjt6PIbA4gXF0YYoAo24SitFOBTOQaBfPJXys5bIQtWX3iQ7bFHUO5A+w4p8GLBDMDqH3j0UhHztod1g2/Iwz3csKWGs2jR/n95u7UPMgj7Q3kMUOKa//LR8jp9pI12Ct7pme5rdCCJZo7JDB5 X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(376002)(396003)(366004)(346002)(39860400002)(136003)(186006)(1800799006)(451199021)(66899021)(2906002)(44832011)(86362001)(5660300002)(38100700002)(8936002)(82960400001)(4326008)(8676002)(41300700001)(6916009)(316002)(66476007)(66556008)(83380400001)(66946007)(6666004)(26005)(6486002)(6512007)(478600001)(6506007); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?otY3N6H8uVeOFNYsrjuNmkyLkNr/TOeMYUwq0Z9XLbqJwv8VQtZ7tj5KFpWW?= =?us-ascii?Q?QjMSNg59v1xNnLZOWQwYqW8W+QGId29mNXjlYBmdus7M+ZkSJYNdTSZs+//v?= =?us-ascii?Q?NH9S/rcMeGfO7AgHJM0zWu+snbQETmd5jGTzLP4H0qNmu2p+8UjbtQMUxsOs?= =?us-ascii?Q?clEZj2HcXSao1G8DafXI2JN7LU+yfipqFiP2eZR0stUONyxB0Q2bAC1EL+0n?= =?us-ascii?Q?Et+Svrhodosl6mFSeJUsS5WaKiihffHhM/r/KNNWuWcJBJ2aGdW+S4KShI2n?= =?us-ascii?Q?6PS652jVEOQj1K3FhdfOoWZSwXdInUGdJUt4XXrkP1aAQMQvu7Q8JCBiFo0M?= =?us-ascii?Q?hVXDWCGji3+/McmA9F3TD1zjJKPRRyWH6vwA01PglQxhey80uFGwl+qwGFaN?= =?us-ascii?Q?OrgdpytNkLkM3kLYAUKQ+GKuZEJ96fUM6ShEEM0B1rLh6WSiW9UubmUbTgdS?= =?us-ascii?Q?wk/GC03r5ip42mGea7o4kYpxNCqg3isc9LCXpiSWAiqtOwXiy+aKSvPEJuDN?= =?us-ascii?Q?9RDL3x59ClXZ0h4Fyv54qjxKAcZkd7X9YvpssHNMWTl983q/XHXorSln42My?= =?us-ascii?Q?2jffC/ihSELdCBgOb965LmbZhiCtPxOWpHWYdJoGY5kLGYxR99oD4UG+Kf1t?= =?us-ascii?Q?JmKEKPqG0atXWT3LEUQuEE3PBCZIh62iUOz0FjSbgLMwh9SdZtVfbxUclBVw?= =?us-ascii?Q?bhn/5I730dcSABPP23oh6iplQOcP9QO4Lvn9oQlrGhBHDoIMFTnEq75cL8lG?= =?us-ascii?Q?BAuWlaAMxmUxQpfMdLQtGQyWRAuX0LPGTZ/zqy6z92JOMxDcMOe7705VgnlJ?= =?us-ascii?Q?ru0a+TyTXF2BTDzwlBGgZj8HcIsBBXt+YyqMyB8sS5UbfQnGQ4G3WWskrK1p?= =?us-ascii?Q?okbAlOoFN65KzyiuoyPlGuhOx+PE+isrIfL2FYcovM1HYjDpulKvJE8KlTrW?= =?us-ascii?Q?Fl9OItCbQ3xDbPt0Zep9n+lSySMeNAd7KLdE3W78PN5mTAP5tRIQPoZMqa3u?= =?us-ascii?Q?OQvOJSMDB3maY7DFTvNg+Dn4B063A2g92AvknoBBvSZi3cczfxWRT7yivVsg?= =?us-ascii?Q?f7JTPk3q1mfxsFE8SZBE5CdDA+csCeP3hkPKJ9eoUUmijfE5z/pUpVDXjoHV?= =?us-ascii?Q?cRudKBqEdNrUyG0ME6Ui1U+QDmzXLBW3pfWObauSXz/OBs1fK1W/dkzWsTQ9?= =?us-ascii?Q?RTigw0jLqsruwJjZYO4UN2lRtBZVKNYm1tLQR0J62uyJfMqfTlRMYNz40Kdv?= =?us-ascii?Q?hSgh6j7NTiLR0sycxZa9Xgzmibsl04WaeCCoAUOSzQZb+bttvSB4wqtYOqa/?= =?us-ascii?Q?N5rCbZKUb1gqI09vupKFOO//DTukb1xzre89mVTALyRBjKUM773p8ZSgtU8k?= =?us-ascii?Q?d8gpkT+XJQoZqobxpqaW8r2YQfAG0uOdsgDllw+mZFWZNanIzIqwCZ95Kv3M?= =?us-ascii?Q?W5koo4TN/tHqb14SE7/lPsMhSHwCOvKhOc1qHPPbiN9QtH66QSm/17PCvyOV?= =?us-ascii?Q?nno5TR+djw4Rx9P9aQ3nkxnILlDZf9ujWV1Wdx3Xl6ZFNILZ3OEsEncowapW?= =?us-ascii?Q?aKkMCvrRaM6TBWdVhenEw/GxWiAWGwYkyrHEg8xQV48fadQ6y8Ez/v2ASEKW?= =?us-ascii?Q?Bg=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 27978718-a76e-48f1-8df9-08db9ca04029 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Aug 2023 08:27:09.0325 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ApAmfxrC0zfWuF2KkkEWwEvV3TqbWOfYM1vDpe/a9s5OgZytOVgSL0M4grEchwEQckHx0aJYIjH2gHhbLs44BIUe2dcqrjkFF9rNABTASZ0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4714 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Aug 11, 2023 at 11:24:44AM -0700, Tyler Retzlaff wrote: > Detect when MSVC toolset is available and tweak toolchain arguments > where the meson build system offers no abstraction. > > Signed-off-by: Tyler Retzlaff > Acked-by: Bruce Richardson > --- > config/meson.build | 23 +++++++++++++++-------- > config/x86/meson.build | 10 ++++++---- > lib/meson.build | 13 ++++++++++--- > 3 files changed, 31 insertions(+), 15 deletions(-) > > diff --git a/config/meson.build b/config/meson.build > index d822371..b6c7d48 100644 > --- a/config/meson.build > +++ b/config/meson.build > @@ -16,7 +16,8 @@ endforeach > > # MS linker requires special treatment. > # TODO: use cc.get_linker_id() with Meson >= 0.54 > -is_ms_linker = is_windows and (cc.get_id() == 'clang') > +is_ms_compiler = is_windows and (cc.get_id() == 'msvc') > +is_ms_linker = is_windows and (cc.get_id() == 'clang' or is_ms_compiler) Question out of interest, what other linker option do we have on windows? When is the second part of this conditional false? /Bruce