From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C3C4B4305E; Mon, 14 Aug 2023 10:30:35 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5A3D240A7F; Mon, 14 Aug 2023 10:30:35 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id C7E524021F for ; Mon, 14 Aug 2023 10:30:33 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1692001834; x=1723537834; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=Ym2Acp5p3lup6AaD8UVp5GVW13YhJgeqHEQDN+9vHNs=; b=DXO/nECdEAGnJ8LTmvuglbGr6BjrKToyj7Z3OFCxNzDQ18EKuLuAtZGk tFZmyVI7K5zOEVkjP8ZXjznEuHx+uG+Qk+Fw3/nNakxDjho/xNa76OwkS bEip+CCQfsGpF78Q/E6dOWAMjXsj6pe6Tq/HRpPn/qD52vI4YwibUm8Rd oGn0T3yJ2zxUginmqIPLN2NLJoU5crMeqU5A8W8DHLSZdEevdaqdHJF7v RGx/+dxC63Vh5UxlfkU/X60oHooHQjbJUMRdfjhv8wB90Hu16TB07kvI/ TokTAbdh6XyeOSqld2QmUWaYj+wikInMMvCBBYARWAUWnnfSdj8lt0/b9 w==; X-IronPort-AV: E=McAfee;i="6600,9927,10801"; a="402976548" X-IronPort-AV: E=Sophos;i="6.01,172,1684825200"; d="scan'208";a="402976548" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Aug 2023 01:30:32 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10801"; a="710246743" X-IronPort-AV: E=Sophos;i="6.01,172,1684825200"; d="scan'208";a="710246743" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga006.jf.intel.com with ESMTP; 14 Aug 2023 01:30:32 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Mon, 14 Aug 2023 01:30:32 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Mon, 14 Aug 2023 01:30:27 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Mon, 14 Aug 2023 01:30:27 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.45) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Mon, 14 Aug 2023 01:30:27 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=i/itGWFCi11HMxvnDWfQiBxpi+3+WickBgDlfYaGTZXLKRZTLz6bnpvT9HyTkK79JCUBM15fWKld8GOlo3++2v7snTRUL9DT5covfQqlfajeI09zu2IHoz/j+mObTtoC20nxtzzM5eZoU4g7CkkeeqCSGEJY4A8jVFnBiMGrVBTIYS2xSLoC8Lo2bMZXR1z0/3c5SErp2+B4MO9X62aobWHH/6ApTH/N+mOzM4fGMlXpZQ9qKivxCcazEniboIM1pQqx6yRIcWiSn8OkBJS+hexPmNQWyGYq/07Hwm9SZMPhDX+Isz0fKtwgbefvF2XQ5/F7GxqjXr7p1BMuVBoaUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=07hkVeNFFtyZAHtf8gHK3M8NBTpNdjUXlexQ1D4/T3U=; b=R6A8aXr4Ps1qaqOTVf7R7Wckny21pHl1DyxUH/qdrD9tzz32AnKEDdijvu1oyWpCFyruGaWdDl5CHeVEanruFbCOVucyA4m1sct2iqRocL/k6o6Evw03xa4QVWC2JZqPTalhOyxg8lh4xSTXQJDL4I3VABqoKidxAa9VqBEwxQ7pms04/H/ETakxVkPwW0ZyBj239w9sDCvyhW/gFtrGXG37kQz1dthDZ3ZVlMH/r1KbljNaQPE2PGsJb6U/HT4lFLa7nJmwG6BIyy6w/IYSTE9mWZc7VlYDiJEDiFjd6zlt/Rgg4kHaKrFxQGTTkPXj467ZFdzzZF2EL8PICNlhBg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) by MW3PR11MB4714.namprd11.prod.outlook.com (2603:10b6:303:5d::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6678.24; Mon, 14 Aug 2023 08:30:26 +0000 Received: from DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::9802:65f0:c441:780f]) by DS0PR11MB7309.namprd11.prod.outlook.com ([fe80::9802:65f0:c441:780f%7]) with mapi id 15.20.6678.022; Mon, 14 Aug 2023 08:30:26 +0000 Date: Mon, 14 Aug 2023 09:30:20 +0100 From: Bruce Richardson To: Tyler Retzlaff CC: , Konstantin Ananyev , , Subject: Re: [PATCH v4 4/4] build: enable MSVC specific compiler options Message-ID: References: <1674674707-3094-1-git-send-email-roretzla@linux.microsoft.com> <1691778287-15746-1-git-send-email-roretzla@linux.microsoft.com> <1691778287-15746-5-git-send-email-roretzla@linux.microsoft.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1691778287-15746-5-git-send-email-roretzla@linux.microsoft.com> X-ClientProxiedBy: DB8PR06CA0003.eurprd06.prod.outlook.com (2603:10a6:10:100::16) To DS0PR11MB7309.namprd11.prod.outlook.com (2603:10b6:8:13e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7309:EE_|MW3PR11MB4714:EE_ X-MS-Office365-Filtering-Correlation-Id: d4fbab4b-f653-4c7e-6edd-08db9ca0b59b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8qTATQsEeMEpWeSHTCQuO4GqOIO0Oht8otpVvZLhabaHR7W8PxJNE1WCO+MgXHcViwf+XdVYWhLlDb8O/AeQ9Jn/vtBa7lsj8wiLQkALmy4eRsJdbQ7WAMZbCcLRPYhAm0CYGkh37p9On7guq7gl7bJwSxwie7EKgNwO0SCuogij195YSYOGH5PMYxC6A8QXrLc+D7tCohtL1Lg7hUP/rPl8tJjL12m1N1+qRIKxr6qcbyNXgldSnyBKuTq+hRbPPdb6BYnfzHg0IpmtnObikkSeZ7gwTR/xaGIOysh/NcY9HryWINuObD4I9D8sjhOMGF0r50s5Jsqu3ds2DRDVQFDYkwPyuADoZ7Hl8LYpFmdttEk7YheN+AnVXC9ee3bFMIRgHYCVZBxBOepMwWq/pr3kQbD4Qy2Io/0C1osPFN7w+89RpUhswVATvoG3+Sq3RB4AYmUNFQ3THRFA4EhhoUQfhut/BYNS8/YG8KCjxCUGy3sC3wgmQ+N3caAkdza4C3XgCxlXdK/BeArsBaAjwYJkAhE07EgY/X2yxc4RQEtti5YIQxhM1DKP+y+ICKLG X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7309.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(346002)(136003)(39860400002)(366004)(396003)(376002)(186006)(1800799006)(451199021)(2906002)(316002)(66556008)(83380400001)(66946007)(6916009)(66476007)(41300700001)(6666004)(6506007)(478600001)(26005)(6512007)(6486002)(44832011)(86362001)(5660300002)(82960400001)(8676002)(4326008)(8936002)(38100700002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?8qT84SjZ9eIgfvZWx/wCeTbBAuhcrfONLmqLa8NV837GsRnvzj8EjtEKG2+0?= =?us-ascii?Q?dKUU8VUd56yMLLt/0R1MXyaMEqCskBOWlnyIk1zpyuslb9PuWrSXffaGnL4Q?= =?us-ascii?Q?6bz0ZEoPsmwUheYFTQRfPY66t6IJr1j7SHAKMxbHLNm+OZeZnCnw5XK6++ae?= =?us-ascii?Q?E5bzCWiFNWQc832RuuCN3pyGz3UNnrCufk+495B4UEfwerAhpykSyACAv9+C?= =?us-ascii?Q?JRE+LSgDu38Y+h+pwNXk9c4m48JVawlhTxZqoaddGyLdS15nCS2b15BGePOp?= =?us-ascii?Q?XpwWsiIGklJgscRQAJrjHTtBd6krbSwljneUTV75LZ8eOCa7i/KzUZT5f0Bg?= =?us-ascii?Q?bcUCbn7tC2+mH6OY4n+EI2Vxe4Wk0ipe9b1AiZCZa8PzCYpLlbgN5U2cPpBY?= =?us-ascii?Q?yR7htUNJeNM1fSrdNnTEYRsMNfooymiSv8HNJlFlxtM3yThy8gu1w1RZT13P?= =?us-ascii?Q?x9stwGr3f03IkmdoGMx5wNIuRfi8jGMGUzcMcVfH2n1qAzOIuBa+sm+ETdjV?= =?us-ascii?Q?dUH308TCzk3OI0dtcAyKYKtUEOQQjlwE8l3J/ap0Hhnm6OfqnSZn2Xf0Cx2L?= =?us-ascii?Q?y9RWyS3F4LiWel1s/VxKpNvl5Lgu9CK/DLGrNnGKxq9k6KvZenYGOExqvSI7?= =?us-ascii?Q?qltkS9hnTJqwgHZ2tlT4b5c0raSD191MSuapiqweSvknxzNM3W2yVik4Cx29?= =?us-ascii?Q?8WarKB1sh6aKiXoyOUMNbXAyxvDZe5hBRgit5gLRHJHnl+BWFomK64wIfRBu?= =?us-ascii?Q?BgQnU7p+l9ewz6cpRpWzLeLU2k6fMETMRM9lZLrCYpV/FGKlibRfrKpfNGMv?= =?us-ascii?Q?ztUe9h5qhQYDoMp/c4DvAx2UCUlHDm3AjXTUJdUDO4ylXcYLF5dJZnD2AMSY?= =?us-ascii?Q?Lq8AW4Mi+mHhsMg5v8OSZ3PZNiSrclxbv0RXoNLld+aOJkIgOBs7zCi+TdFB?= =?us-ascii?Q?cMoOx+Rz3gj4zyqwBDMNeduU8d+vQ/a4Y78AcquOhBWNd/HcCMh/42uvYesD?= =?us-ascii?Q?ea3pix4dYKBMvAPOQaI+xMs/E6+nOlBAscEoheJk8z5Y/A6eDQ99busA1rXb?= =?us-ascii?Q?p83CIo9oL5Wwt7iU4i3ToBfygnOjEHCylE6/Cj7XWdGHGniPCsu5z1/65CWj?= =?us-ascii?Q?CWkJgogI0G1Ar4hIOPjM1yVVVmtHXypZuyuJoFLcztwuUM1KupPQuFwy9STj?= =?us-ascii?Q?xZfQPfz7qKKV5+rpoQL0JD46SkmHgEb9jr14TOXRigdOiRWkygfX1kvgTN9i?= =?us-ascii?Q?ERA9AbWKegKsDi5IFj4gr4uTFsqrxgpGPLhxW+Slou+GyCPNhCPEtl2NALUm?= =?us-ascii?Q?hz1YL2+AwG1bzTgiyYQWbLC1ft+BdqOaWQOLddCTOoHLqP37Zi8nafMFjcA7?= =?us-ascii?Q?2ezPdAvt0pEXA2P5uOz9O6w0H6+UgnF4ftgNavN0ddKvYwFla5zUczHvAjh7?= =?us-ascii?Q?Lq68QRotH+6cy7lRIhLf3opJ4Xj7V5h4cxxrkmEMAijgboCUdCOohFAcnAO7?= =?us-ascii?Q?z1VroeXlbda8ZdzB4YxEjVrOoldjdUeat2+cXRaFyqVuFjpqcksFs9bNQNux?= =?us-ascii?Q?hdsuYY2Pn2W5JQUn21rdfSljwlnkogznMWh6jlUF7NFcVkQRzvkzwIR0Nvub?= =?us-ascii?Q?Wg=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: d4fbab4b-f653-4c7e-6edd-08db9ca0b59b X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7309.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Aug 2023 08:30:26.0980 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: WFlK7ss1kFEF/KPg2MQ63MRZyJKTP0ww7I2f6C5JmvzXrBPfa5WVFPzi6mBl9b1G/yk1489mvlStvi20rpNuuYEtZ442YBdXly0w9nX+im0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4714 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Aug 11, 2023 at 11:24:47AM -0700, Tyler Retzlaff wrote: > * Enable optional use of C11 atomics support. > * Enable use of C23 typeof operator. > * Explicitly force intrinsics when building with MSVC. > * Disable MSVC C runtime checks. > > Signed-off-by: Tyler Retzlaff Acked-by: Bruce Richardson If there is going to be a lot of this type of special handling for MSVC, we could look to add a separate config/msvc (and config/gcc-like) directory with separate meson.build files for the different toolchains. Might help centralize all such definitions in one place rather than having conditionals everywhere. /Bruce > --- > config/meson.build | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/config/meson.build b/config/meson.build > index 821a1c3..839057a 100644 > --- a/config/meson.build > +++ b/config/meson.build > @@ -27,6 +27,14 @@ dpdk_conf.set('RTE_EXEC_ENV_' + exec_env.to_upper(), 1) > is_ms_compiler = is_windows and (cc.get_id() == 'msvc') > is_ms_linker = is_windows and (cc.get_id() == 'clang' or is_ms_compiler) > > +# MS compiler (except x86) does not support inline assembly > +if is_ms_compiler > + dpdk_conf.set('_CRT_SECURE_NO_WARNINGS', 1) > + dpdk_conf.set('RTE_FORCE_INTRINSICS', 1) > + add_project_arguments('/experimental:c11atomics', language: 'c') > + add_project_arguments('/d1experimental:typeof', language: 'c') > +endif > + > # set the major version, which might be used by drivers and libraries > # depending on the configuration options > pver = meson.project_version().split('.') > -- > 1.8.3.1 >